203678 2019-10-31 07:18:24 -0700 [EWS] Limit API tests failures to display in the status-bubble tooltip and buildbot summary 2020-07-08 09:02:23 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214085 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1585890 0 aakash_jain 2019-10-31 07:18:24 -0700 Sometimes a patch can break hundreds of API tests. In those cases, the status-bubble tries to display all those hundreds of failures, and becomes unreadable. Similarly buildbot build page display all the failing test names in the summary string, and becomes pretty unreadable. For e.g.: https://ews-build.webkit.org/#/builders/3/builds/11258 has 788 API test failures and the build page is unreadable. We should limit the number of failures to display in the status-bubble and summary strings. Complete list of failing tests can still be seen in the logs of the test-run and the json output. 1585900 1 382458 aakash_jain 2019-10-31 07:50:40 -0700 Created attachment 382458 Patch 1585906 2 aakash_jain 2019-10-31 07:53:05 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/4/builds/61 1585915 3 jbedard 2019-10-31 08:18:21 -0700 (In reply to Aakash Jain from comment #2) > Sample run: https://ews-build.webkit-uat.org/#/builders/4/builds/61 What does this look like in tooltips? 1585916 4 aakash_jain 2019-10-31 08:19:21 -0700 > What does this look like in tooltips? https://ews.webkit-uat.org/status-bubble/381964/ 1585927 5 382458 commit-queue 2019-10-31 08:42:56 -0700 Comment on attachment 382458 Patch Clearing flags on attachment: 382458 Committed r251849: <https://trac.webkit.org/changeset/251849> 1585928 6 commit-queue 2019-10-31 08:42:58 -0700 All reviewed patches have been landed. Closing bug. 1585929 7 webkit-bug-importer 2019-10-31 08:43:18 -0700 <rdar://problem/56782288> 1588295 8 aakash_jain 2019-11-07 10:54:38 -0800 Recent examples where this change was helpful in keeping the UI readable: https://ews-build.webkit.org/#/builders/9/builds/11552 https://ews-build.webkit.org/#/builders/3/builds/11613 Corresponding Status bubble in: https://bugs.webkit.org/show_bug.cgi?id=203880 382458 2019-10-31 07:50:40 -0700 2019-10-31 08:42:56 -0700 Patch bug-203678-20191031105039.patch text/plain 2756 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTg0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTEwLTMxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbRVdTXSBMaW1pdCBBUEkgdGVzdHMgZmFpbHVyZXMgdG8gZGlzcGxheSBp biB0aGUgc3RhdHVzLWJ1YmJsZSB0b29sdGlwIGFuZCBidWlsZGJvdCBzdW1tYXJ5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM2NzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBw b3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKEFuYWx5emVBUElUZXN0c1Jlc3VsdHMp OiBEZWZpbmUgTlVNX0FQSV9GQUlMVVJFU19UT19ESVNQTEFZIGFzIDEwLgorICAgICAgICAoQW5h bHl6ZUFQSVRlc3RzUmVzdWx0cy5hbmFseXplUmVzdWx0cyk6IFRydW5jYXRlIHRoZSBmYWlsdXJl IHN0cmluZyB0byBjb250YWluIDEwIHRlc3QgZmFpbHVyZXMuCisKIDIwMTktMTAtMzAgIFBlbmcg TGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KIAogICAgICAgICBbUGljdHVyZS1pbi1QaWN0dXJl IFdlYiBBUEldIEVuYWJsZSB0aGUgc3VwcG9ydCBmb3IgaU9TCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNTE4NDIpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAg LTE0NTEsNiArMTQ1MSw3IEBAIGNsYXNzIEFuYWx5emVBUElUZXN0c1Jlc3VsdHMoYnVpbGRzdGVw LkIKICAgICBuYW1lID0gJ2FuYWx5emUtYXBpLXRlc3RzLXJlc3VsdHMnCiAgICAgZGVzY3JpcHRp b24gPSBbJ2FuYWx5emUtYXBpLXRlc3QtcmVzdWx0cyddCiAgICAgZGVzY3JpcHRpb25Eb25lID0g WydhbmFseXplLWFwaS10ZXN0cy1yZXN1bHRzJ10KKyAgICBOVU1fQVBJX0ZBSUxVUkVTX1RPX0RJ U1BMQVkgPSAxMAogCiAgICAgZGVmIHN0YXJ0KHNlbGYpOgogICAgICAgICBzZWxmLnJlc3VsdHMg PSB7fQpAQCAtMTQ5Miw3ICsxNDkzLDggQEAgY2xhc3MgQW5hbHl6ZUFQSVRlc3RzUmVzdWx0cyhi dWlsZHN0ZXAuQgogICAgICAgICBmbGFreV9mYWlsdXJlcyA9IGZpcnN0X3J1bl9mYWlsdXJlcy51 bmlvbihzZWNvbmRfcnVuX2ZhaWx1cmVzKSAtIGZpcnN0X3J1bl9mYWlsdXJlcy5pbnRlcnNlY3Rp b24oc2Vjb25kX3J1bl9mYWlsdXJlcykKICAgICAgICAgZmxha3lfZmFpbHVyZXNfc3RyaW5nID0g JywgJy5qb2luKFtmYWlsdXJlX25hbWUucmVwbGFjZSgnVGVzdFdlYktpdEFQSS4nLCAnJykgZm9y IGZhaWx1cmVfbmFtZSBpbiBmbGFreV9mYWlsdXJlc10pCiAgICAgICAgIG5ld19mYWlsdXJlcyA9 IGZhaWx1cmVzX3dpdGhfcGF0Y2ggLSBjbGVhbl90cmVlX2ZhaWx1cmVzCi0gICAgICAgIG5ld19m YWlsdXJlc19zdHJpbmcgPSAnLCAnLmpvaW4oW2ZhaWx1cmVfbmFtZS5yZXBsYWNlKCdUZXN0V2Vi S2l0QVBJLicsICcnKSBmb3IgZmFpbHVyZV9uYW1lIGluIG5ld19mYWlsdXJlc10pCisgICAgICAg IG5ld19mYWlsdXJlc190b19kaXNwbGF5ID0gbGlzdChuZXdfZmFpbHVyZXMpWzpzZWxmLk5VTV9B UElfRkFJTFVSRVNfVE9fRElTUExBWV0KKyAgICAgICAgbmV3X2ZhaWx1cmVzX3N0cmluZyA9ICcs ICcuam9pbihbZmFpbHVyZV9uYW1lLnJlcGxhY2UoJ1Rlc3RXZWJLaXRBUEkuJywgJycpIGZvciBm YWlsdXJlX25hbWUgaW4gbmV3X2ZhaWx1cmVzX3RvX2Rpc3BsYXldKQogCiAgICAgICAgIHNlbGYu X2FkZFRvTG9nKCdzdGRlcnInLCAnXG5GYWlsdXJlcyBpbiBBUEkgVGVzdCBmaXJzdCBydW46IHt9 Jy5mb3JtYXQoZmlyc3RfcnVuX2ZhaWx1cmVzKSkKICAgICAgICAgc2VsZi5fYWRkVG9Mb2coJ3N0 ZGVycicsICdcbkZhaWx1cmVzIGluIEFQSSBUZXN0IHNlY29uZCBydW46IHt9Jy5mb3JtYXQoc2Vj b25kX3J1bl9mYWlsdXJlcykpCkBAIC0xNTA1LDYgKzE1MDcsOCBAQCBjbGFzcyBBbmFseXplQVBJ VGVzdHNSZXN1bHRzKGJ1aWxkc3RlcC5CCiAgICAgICAgICAgICBzZWxmLmJ1aWxkLnJlc3VsdHMg PSBGQUlMVVJFCiAgICAgICAgICAgICBwbHVyYWxTdWZmaXggPSAncycgaWYgbGVuKG5ld19mYWls dXJlcykgPiAxIGVsc2UgJycKICAgICAgICAgICAgIG1lc3NhZ2UgPSAnRm91bmQge30gbmV3IEFQ SSB0ZXN0IGZhaWx1cmV7fToge30nLmZvcm1hdChsZW4obmV3X2ZhaWx1cmVzKSwgcGx1cmFsU3Vm Zml4LCBuZXdfZmFpbHVyZXNfc3RyaW5nKQorICAgICAgICAgICAgaWYgbGVuKG5ld19mYWlsdXJl cykgPiBzZWxmLk5VTV9BUElfRkFJTFVSRVNfVE9fRElTUExBWToKKyAgICAgICAgICAgICAgICBt ZXNzYWdlICs9ICcgLi4uJwogICAgICAgICAgICAgc2VsZi5kZXNjcmlwdGlvbkRvbmUgPSBtZXNz YWdlCiAgICAgICAgICAgICBzZWxmLmJ1aWxkLmJ1aWxkRmluaXNoZWQoW21lc3NhZ2VdLCBGQUlM VVJFKQogICAgICAgICBlbHNlOgo=