203668 2019-10-31 01:07:56 -0700 Web Inspector: REGRESSION(r251038): Elements: Computed: variables are shown in the Properties section instead of in the Variables section 2019-10-31 15:02:40 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 200554 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1585822 0 hi 2019-10-31 01:07:56 -0700 . 1585823 1 382439 hi 2019-10-31 01:12:15 -0700 Created attachment 382439 Patch 1586012 2 382439 mattbaker 2019-10-31 12:29:26 -0700 Comment on attachment 382439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112 > + set propertyVisibilityMode(propertyVisibilityMode) This is kind of wordy. I think the context is clear, how about just naming the parameter `mode`? 1586073 3 382439 hi 2019-10-31 14:15:58 -0700 Comment on attachment 382439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review >> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112 >> + set propertyVisibilityMode(propertyVisibilityMode) > > This is kind of wordy. I think the context is clear, how about just naming the parameter `mode`? This is just putting back what was removed in r251038. Also, `WI.SpreadsheetCSSStyleDeclarationSection` has a similarly named concept. 1586077 4 382439 mattbaker 2019-10-31 14:30:19 -0700 Comment on attachment 382439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review >>> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112 >>> + set propertyVisibilityMode(propertyVisibilityMode) >> >> This is kind of wordy. I think the context is clear, how about just naming the parameter `mode`? > > This is just putting back what was removed in r251038. Also, `WI.SpreadsheetCSSStyleDeclarationSection` has a similarly named concept. Okie dokie! 1586090 5 382439 commit-queue 2019-10-31 15:00:29 -0700 Comment on attachment 382439 Patch Clearing flags on attachment: 382439 Committed r251883: <https://trac.webkit.org/changeset/251883> 1586091 6 commit-queue 2019-10-31 15:00:30 -0700 All reviewed patches have been landed. Closing bug. 1586092 7 webkit-bug-importer 2019-10-31 15:02:40 -0700 <rdar://problem/56796756> 382439 2019-10-31 01:12:15 -0700 2019-10-31 15:00:29 -0700 Patch 203668.diff text/plain 6804 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUxY2FhZjc2NWJjLi4yNGFjNzc0MmI1ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTktMTAtMzEgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJF R1JFU1NJT04ocjI1MTAzOCk6IEVsZW1lbnRzOiBDb21wdXRlZDogdmFyaWFibGVzIGFyZSBzaG93 biBpbiB0aGUgUHJvcGVydGllcyBzZWN0aW9uIGluc3RlYWQgb2YgaW4gdGhlIFZhcmlhYmxlcyBz ZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDM2NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRTdHlsZURldGFpbHNQYW5lbC5qczoKKyAgICAg ICAgKFdJLkNvbXB1dGVkU3R5bGVEZXRhaWxzUGFuZWwucHJvdG90eXBlLmluaXRpYWxMYXlvdXQp OgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRTdHlsZVNlY3Rpb24uanM6 CisgICAgICAgIChXSS5Db21wdXRlZFN0eWxlU2VjdGlvbik6CisgICAgICAgIChXSS5Db21wdXRl ZFN0eWxlU2VjdGlvbi5wcm90b3R5cGUuc2V0IHByb3BlcnR5VmlzaWJpbGl0eU1vZGUpOiBBZGRl ZC4KKyAgICAgICAgKFdJLkNvbXB1dGVkU3R5bGVTZWN0aW9uLnByb3RvdHlwZS5nZXQgcHJvcGVy dGllc1RvUmVuZGVyKToKKyAgICAgICAgUmVpbnRyb2R1Y2UgdGhlIGBwcm9wZXJ0eVZpc2liaWxp dHlNb2RlYCBjb25jZXB0IHRvIGBXSS5Db21wdXRlZFN0eWxlU2VjdGlvbmAgc28gdGhhdCB0aGUK KyAgICAgICAgQ29tcHV0ZWQgZGV0YWlscyBwYW5lbCBjYW4gcHJldmVudCBDU1MgdmFyaWFibGVz IGZyb20gYmVpbmcgc2hvd24gaW4gdGhlIFByb3Blcml0ZXMgc2VjdGlvbi4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlv bi5qczoKKyAgICAgICAgKFdJLlNwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24u cHJvdG90eXBlLmdldCBwcm9wZXJ0aWVzVG9SZW5kZXIpOgorICAgICAgICBSZXBsYWNlIGB2YXJp YWJsZWAgZ2V0dGVyIHdpdGggYGlzVmFyaWFibGVgIHRvIG1hdGNoIHIyNTEwMzguCisKIDIwMTkt MTAtMzAgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogdHJhY2sgV0kuU2NyaXB0IHVuaXF1ZSBkaXNwbGF5IG5hbWUgbnVtYmVy cyBwZXIgUGFnZSB0YXJnZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvbXB1dGVkU3R5bGVEZXRhaWxzUGFuZWwuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db21wdXRlZFN0eWxlRGV0YWlsc1BhbmVs LmpzCmluZGV4IGY1NGI1ZGJkNzQ3Li40MWRkY2YzNThjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRTdHlsZURldGFpbHNQYW5l bC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db21w dXRlZFN0eWxlRGV0YWlsc1BhbmVsLmpzCkBAIC0xMDQsNiArMTA0LDcgQEAgV0kuQ29tcHV0ZWRT dHlsZURldGFpbHNQYW5lbCA9IGNsYXNzIENvbXB1dGVkU3R5bGVEZXRhaWxzUGFuZWwgZXh0ZW5k cyBXSS5TdHlsZUQKICAgICAgICAgdGhpcy5fY29tcHV0ZWRTdHlsZVNlY3Rpb24gPSBuZXcgV0ku Q29tcHV0ZWRTdHlsZVNlY3Rpb24odGhpcyk7CiAgICAgICAgIHRoaXMuX2NvbXB1dGVkU3R5bGVT ZWN0aW9uLmFkZEV2ZW50TGlzdGVuZXIoV0kuQ29tcHV0ZWRTdHlsZVNlY3Rpb24uRXZlbnQuRmls dGVyQXBwbGllZCwgdGhpcy5faGFuZGxlRWRpdG9yRmlsdGVyQXBwbGllZCwgdGhpcyk7CiAgICAg ICAgIHRoaXMuX2NvbXB1dGVkU3R5bGVTZWN0aW9uLnNob3dzSW1wbGljaXRQcm9wZXJ0aWVzID0g dGhpcy5fY29tcHV0ZWRTdHlsZVNob3dBbGxTZXR0aW5nLnZhbHVlOworICAgICAgICB0aGlzLl9j b21wdXRlZFN0eWxlU2VjdGlvbi5wcm9wZXJ0eVZpc2liaWxpdHlNb2RlID0gV0kuQ29tcHV0ZWRT dHlsZVNlY3Rpb24uUHJvcGVydHlWaXNpYmlsaXR5TW9kZS5IaWRlVmFyaWFibGVzOwogICAgICAg ICB0aGlzLl9jb21wdXRlZFN0eWxlU2VjdGlvbi5zaG93c1Nob3J0aGFuZHNJbnN0ZWFkT2ZMb25n aGFuZHMgPSB0aGlzLl9jb21wdXRlZFN0eWxlUHJlZmVyU2hvcnRoYW5kc1NldHRpbmcudmFsdWU7 CiAgICAgICAgIHRoaXMuX2NvbXB1dGVkU3R5bGVTZWN0aW9uLmFsd2F5c1Nob3dQcm9wZXJ0eU5h bWVzID0gWyJkaXNwbGF5IiwgIndpZHRoIiwgImhlaWdodCJdOwogICAgICAgICB0aGlzLl9jb21w dXRlZFN0eWxlU2VjdGlvbi5oaWRlRmlsdGVyTm9uTWF0Y2hpbmdQcm9wZXJ0aWVzID0gdHJ1ZTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nv bXB1dGVkU3R5bGVTZWN0aW9uLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQ29tcHV0ZWRTdHlsZVNlY3Rpb24uanMKaW5kZXggZWNlOGQ2MmU0ODUuLjU0ODVi OTk0ZjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Db21wdXRlZFN0eWxlU2VjdGlvbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Db21wdXRlZFN0eWxlU2VjdGlvbi5qcwpAQCAtNDAsNiArNDAs NyBAQCBXSS5Db21wdXRlZFN0eWxlU2VjdGlvbiA9IGNsYXNzIENvbXB1dGVkU3R5bGVTZWN0aW9u IGV4dGVuZHMgV0kuVmlldwogICAgICAgICB0aGlzLl9zaG93c0ltcGxpY2l0UHJvcGVydGllcyA9 IGZhbHNlOwogICAgICAgICB0aGlzLl9zaG93c1Nob3J0aGFuZHNJbnN0ZWFkT2ZMb25naGFuZHMg PSBmYWxzZTsKICAgICAgICAgdGhpcy5fYWx3YXlzU2hvd1Byb3BlcnR5TmFtZXMgPSBuZXcgU2V0 OworICAgICAgICB0aGlzLl9wcm9wZXJ0eVZpc2liaWxpdHlNb2RlID0gV0kuQ29tcHV0ZWRTdHls ZVNlY3Rpb24uUHJvcGVydHlWaXNpYmlsaXR5TW9kZS5TaG93QWxsOwogICAgICAgICB0aGlzLl9o aWRlRmlsdGVyTm9uTWF0Y2hpbmdQcm9wZXJ0aWVzID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX2Zp bHRlclRleHQgPSBudWxsOwogICAgIH0KQEAgLTEwOCw2ICsxMDksMTYgQEAgV0kuQ29tcHV0ZWRT dHlsZVNlY3Rpb24gPSBjbGFzcyBDb21wdXRlZFN0eWxlU2VjdGlvbiBleHRlbmRzIFdJLlZpZXcK ICAgICAgICAgdGhpcy5uZWVkc0xheW91dCgpOwogICAgIH0KIAorICAgIHNldCBwcm9wZXJ0eVZp c2liaWxpdHlNb2RlKHByb3BlcnR5VmlzaWJpbGl0eU1vZGUpCisgICAgeworICAgICAgICBpZiAo dGhpcy5fcHJvcGVydHlWaXNpYmlsaXR5TW9kZSA9PT0gcHJvcGVydHlWaXNpYmlsaXR5TW9kZSkK KyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB0aGlzLl9wcm9wZXJ0eVZpc2liaWxpdHlN b2RlID0gcHJvcGVydHlWaXNpYmlsaXR5TW9kZTsKKworICAgICAgICB0aGlzLm5lZWRzTGF5b3V0 KCk7CisgICAgfQorCiAgICAgc2V0IGhpZGVGaWx0ZXJOb25NYXRjaGluZ1Byb3BlcnRpZXModmFs dWUpCiAgICAgewogICAgICAgICBpZiAodmFsdWUgPT09IHRoaXMuX2hpZGVGaWx0ZXJOb25NYXRj aGluZ1Byb3BlcnRpZXMpCkBAIC0xMzEsNiArMTQyLDkgQEAgV0kuQ29tcHV0ZWRTdHlsZVNlY3Rp b24gPSBjbGFzcyBDb21wdXRlZFN0eWxlU2VjdGlvbiBleHRlbmRzIFdJLlZpZXcKIAogICAgICAg ICBwcm9wZXJ0aWVzLnNvcnQoKGEsIGIpID0+IGEubmFtZS5leHRlbmRlZExvY2FsZUNvbXBhcmUo Yi5uYW1lKSk7CiAKKyAgICAgICAgbGV0IGhpZGVWYXJpYWJsZXMgPSB0aGlzLl9wcm9wZXJ0eVZp c2liaWxpdHlNb2RlID09PSBDb21wdXRlZFN0eWxlU2VjdGlvbi5Qcm9wZXJ0eVZpc2liaWxpdHlN b2RlLkhpZGVWYXJpYWJsZXM7CisgICAgICAgIGxldCBoaWRlTm9uVmFyaWFibGVzID0gdGhpcy5f cHJvcGVydHlWaXNpYmlsaXR5TW9kZSA9PT0gQ29tcHV0ZWRTdHlsZVNlY3Rpb24uUHJvcGVydHlW aXNpYmlsaXR5TW9kZS5IaWRlTm9uVmFyaWFibGVzOworCiAgICAgICAgIHJldHVybiBwcm9wZXJ0 aWVzLmZpbHRlcigocHJvcGVydHkpID0+IHsKICAgICAgICAgICAgIGlmICh0aGlzLl9hbHdheXNT aG93UHJvcGVydHlOYW1lcy5oYXMocHJvcGVydHkuY2Fub25pY2FsTmFtZSkpCiAgICAgICAgICAg ICAgICAgcmV0dXJuIHRydWU7CkBAIC0xNDQsNiArMTU4LDEyIEBAIFdJLkNvbXB1dGVkU3R5bGVT ZWN0aW9uID0gY2xhc3MgQ29tcHV0ZWRTdHlsZVNlY3Rpb24gZXh0ZW5kcyBXSS5WaWV3CiAgICAg ICAgICAgICB9IGVsc2UgaWYgKHByb3BlcnR5LmlzU2hvcnRoYW5kKQogICAgICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKIAorICAgICAgICAgICAgaWYgKHByb3BlcnR5LmlzVmFyaWFibGUgJiYg aGlkZVZhcmlhYmxlcykKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAg ICAgIGlmICghcHJvcGVydHkuaXNWYXJpYWJsZSAmJiBoaWRlTm9uVmFyaWFibGVzKQorICAgICAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAg ICAgIH0pOwogICAgIH0KQEAgLTI3MSwzICsyOTEsOSBAQCBXSS5Db21wdXRlZFN0eWxlU2VjdGlv bi5FdmVudCA9IHsKIH07CiAKIFdJLkNvbXB1dGVkU3R5bGVTZWN0aW9uLlN0eWxlQ2xhc3NOYW1l ID0gImNvbXB1dGVkLXN0eWxlLXNlY3Rpb24iOworCitXSS5Db21wdXRlZFN0eWxlU2VjdGlvbi5Q cm9wZXJ0eVZpc2liaWxpdHlNb2RlID0geworICAgIFNob3dBbGw6IFN5bWJvbCgidmFyaWFibGUt dmlzaWJpbGl0eS1zaG93LWFsbCIpLAorICAgIEhpZGVWYXJpYWJsZXM6IFN5bWJvbCgidmFyaWFi bGUtdmlzaWJpbGl0eS1oaWRlLXZhcmlhYmxlcyIpLAorICAgIEhpZGVOb25WYXJpYWJsZXM6IFN5 bWJvbCgidmFyaWFibGUtdmlzaWJpbGl0eS1oaWRlLW5vbi12YXJpYWJsZXMiKSwKK307CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRz aGVldENTU1N0eWxlRGVjbGFyYXRpb25FZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25FZGl0b3Iu anMKaW5kZXggYWYwMGFiMWIyN2QuLmNlMTdkYjNjMWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFy YXRpb25FZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uRWRpdG9yLmpzCkBAIC0yMzMsMTEg KzIzMywxNCBAQCBXSS5TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25FZGl0b3IgPSBjbGFz cyBTcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25FZAogICAgICAgICBpZiAodGhpcy5fc29y dFByb3BlcnRpZXNCeU5hbWUpCiAgICAgICAgICAgICBwcm9wZXJ0aWVzLnNvcnQoKGEsIGIpID0+ IGEubmFtZS5leHRlbmRlZExvY2FsZUNvbXBhcmUoYi5uYW1lKSk7CiAKKyAgICAgICAgbGV0IGhp ZGVWYXJpYWJsZXMgPSB0aGlzLl9wcm9wZXJ0eVZpc2liaWxpdHlNb2RlID09PSBTcHJlYWRzaGVl dENTU1N0eWxlRGVjbGFyYXRpb25FZGl0b3IuUHJvcGVydHlWaXNpYmlsaXR5TW9kZS5IaWRlVmFy aWFibGVzOworICAgICAgICBsZXQgaGlkZU5vblZhcmlhYmxlcyA9IHRoaXMuX3Byb3BlcnR5Vmlz aWJpbGl0eU1vZGUgPT09IFNwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvbkVkaXRvci5Qcm9w ZXJ0eVZpc2liaWxpdHlNb2RlLkhpZGVOb25WYXJpYWJsZXM7CisKICAgICAgICAgcmV0dXJuIHBy b3BlcnRpZXMuZmlsdGVyKChwcm9wZXJ0eSkgPT4gewotICAgICAgICAgICAgaWYgKCFwcm9wZXJ0 eS52YXJpYWJsZSAmJiB0aGlzLl9wcm9wZXJ0eVZpc2liaWxpdHlNb2RlID09PSBXSS5TcHJlYWRz aGVldENTU1N0eWxlRGVjbGFyYXRpb25FZGl0b3IuUHJvcGVydHlWaXNpYmlsaXR5TW9kZS5IaWRl Tm9uVmFyaWFibGVzKQorICAgICAgICAgICAgaWYgKCFwcm9wZXJ0eS5pc1ZhcmlhYmxlICYmIGhp ZGVOb25WYXJpYWJsZXMpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAg ICAgICBpZiAocHJvcGVydHkudmFyaWFibGUgJiYgdGhpcy5fcHJvcGVydHlWaXNpYmlsaXR5TW9k ZSA9PT0gV0kuU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uRWRpdG9yLlByb3BlcnR5Vmlz aWJpbGl0eU1vZGUuSGlkZVZhcmlhYmxlcykKKyAgICAgICAgICAgIGlmIChwcm9wZXJ0eS5pc1Zh cmlhYmxlICYmIGhpZGVWYXJpYWJsZXMpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwog CiAgICAgICAgICAgICByZXR1cm4gIXByb3BlcnR5LmltcGxpY2l0IHx8IHRoaXMuX3Nob3dzSW1w bGljaXRQcm9wZXJ0aWVzIHx8IHRoaXMuX2Fsd2F5c1Nob3dQcm9wZXJ0eU5hbWVzLmhhcyhwcm9w ZXJ0eS5jYW5vbmljYWxOYW1lKTsK