203650 2019-10-30 18:16:56 -0700 Unbounded memory growth due to WebGL buffers not being freed 2024-01-17 01:50:36 -0800 1 1 1 Unclassified WebKit WebGL Safari 12 Mac macOS 10.14 RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 arindam.bose webkit-unassigned dino justin_fan kkinnunen simon.fraser webkit-bug-importer oldest_to_newest 1585698 0 382401 arindam.bose 2019-10-30 18:16:56 -0700 Created attachment 382401 GL delete buffer memory growth example. This is coming through from a bug report on Mapbox GL-JS https://github.com/mapbox/mapbox-gl-js/issues/8771 Safari is seeing unbounded memory growth in interactions wherein the user is constantly loading and unloading tiles by panning or zooming the interactive map. We were able to run use the Xcode instruments allocation tracker on a debug build of WebKit, and found that calls to `WebGLRenderingContext.deleteBuffer` was not freeing up memory. We were able to confirm this by creating an isolated example page that repeatedly creates->uploads and then deletes a vertex buffer every frame, the example page is attached. The process for the tab grows upto 6gb of memory consumption in 30s. 1585804 1 webkit-bug-importer 2019-10-30 23:29:57 -0700 <rdar://problem/56772525> 2005554 2 kkinnunen 2024-01-17 01:50:36 -0800 Thank you for the report. This is fixed now. 382401 2019-10-30 18:16:56 -0700 2019-10-30 18:16:56 -0700 GL delete buffer memory growth example. index.html text/html 1508 arindam.bose PGh0bWw+CiAgICA8aGVhZD4KICAgICAgICA8dGl0bGU+IFNhZmFyaSBXZWJHTCBidWZmZXIgbGVh azwvdGl0bGU+CiAgICA8L2hlYWQ+CiAgICA8Ym9keT4KICAgICAgICA8Y2FudmFzIHdpZHRoPTgw MCBoZWlnaHQ9ODAwIGlkPSd0ZXN0Jz48L2NhbnZhcz4KICAgICAgICA8c2NyaXB0PgogICAgICAg ICAgICBjb25zdCBjYW52YXMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpOwogICAg ICAgICAgICBjb25zdCBnbCA9IGNhbnZhcy5nZXRDb250ZXh0KCd3ZWJnbCcpOwogICAgICAgICAg ICBsZXQgdmVydEJ1ZmZlciA9IG51bGw7CiAgICAgICAgICAgIGxldCBpbmRleEJ1ZmZlciA9IG51 bGw7CgogICAgICAgICAgICBjb25zdCBzaXplID0gMWU2ICogMzsKICAgICAgICAgICAgY29uc3Qg dmVydGV4QXJyYXkgPSBuZXcgRmxvYXQzMkFycmF5KHNpemUpOwogICAgICAgICAgICBjb25zdCBp bmRleEFycmF5ID0gbmV3IFVpbnQxNkFycmF5KHNpemUpOwogICAgICAgICAgICBmdW5jdGlvbiBj cmVhdGVHbEJ1ZmZlcnMoKXsKICAgICAgICAgICAgICAgIHZlcnRCdWZmZXIgPSBnbC5jcmVhdGVC dWZmZXIoKTsKICAgICAgICAgICAgICAgIGdsLmJpbmRCdWZmZXIoZ2wuQVJSQVlfQlVGRkVSLCB2 ZXJ0QnVmZmVyKTsKICAgICAgICAgICAgICAgIGdsLmJ1ZmZlckRhdGEoZ2wuQVJSQVlfQlVGRkVS LCB2ZXJ0ZXhBcnJheSwgZ2wuU1RBVElDX0RSQVcpOwogICAgICAgICAgICAgICAgaW5kZXhCdWZm ZXIgPSBnbC5jcmVhdGVCdWZmZXIoKTsKICAgICAgICAgICAgICAgIGdsLmJpbmRCdWZmZXIoZ2wu RUxFTUVOVF9BUlJBWV9CVUZGRVIsIGluZGV4QnVmZmVyKTsKICAgICAgICAgICAgICAgIGdsLmJ1 ZmZlckRhdGEoZ2wuRUxFTUVOVF9BUlJBWV9CVUZGRVIsIGluZGV4QXJyYXksIGdsLlNUQVRJQ19E UkFXKTsKICAgICAgICAgICAgfQoKICAgICAgICAgICAgZnVuY3Rpb24gZGVsZXRlR2xCdWZmZXIo KXsKICAgICAgICAgICAgICAgIGlmKHZlcnRCdWZmZXIpewogICAgICAgICAgICAgICAgICAgIGds LmRlbGV0ZUJ1ZmZlcih2ZXJ0QnVmZmVyKTsKICAgICAgICAgICAgICAgICAgICBkZWxldGUgdmVy dEJ1ZmZlcjsKICAgICAgICAgICAgICAgIH0KCiAgICAgICAgICAgICAgICBpZihpbmRleEJ1ZmZl cil7CiAgICAgICAgICAgICAgICAgICAgZ2wuZGVsZXRlQnVmZmVyKGluZGV4QnVmZmVyKTsKICAg ICAgICAgICAgICAgICAgICBkZWxldGUgaW5kZXhCdWZmZXI7CiAgICAgICAgICAgICAgICB9CiAg ICAgICAgICAgIH0KCgogICAgICAgICAgICBmdW5jdGlvbiBldmVyeUZyYW1lKCl7CiAgICAgICAg ICAgICAgICBkZWxldGVHbEJ1ZmZlcigpOwogICAgICAgICAgICAgICAgY3JlYXRlR2xCdWZmZXJz KCk7CiAgICAgICAgICAgICAgICB3aW5kb3cucmVxdWVzdEFuaW1hdGlvbkZyYW1lKGV2ZXJ5RnJh bWUpOwogICAgICAgICAgICB9CiAgICAgICAgICAgIGV2ZXJ5RnJhbWUoKTsKCiAgICAgICAgPC9z Y3JpcHQ+CiAgICA8L2JvZHk+CjwvaHRtbD4=