203630 2019-10-30 14:54:27 -0700 Add telemetry to test a potential cause of crashes under -[WKContentView _interpretKeyEvent:isCharEvent:] 2019-10-31 08:23:20 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue ddkilzer simon.fraser thorton webkit-bug-importer oldest_to_newest 1585534 0 wenson_hsieh 2019-10-30 14:54:27 -0700 <rdar://problem/54132630> 1585740 1 wenson_hsieh 2019-10-30 20:34:07 -0700 <rdar://problem/56769229> 1585741 2 382414 wenson_hsieh 2019-10-30 20:34:55 -0700 Created attachment 382414 Patch 1585919 3 382414 commit-queue 2019-10-31 08:23:18 -0700 Comment on attachment 382414 Patch Clearing flags on attachment: 382414 Committed r251847: <https://trac.webkit.org/changeset/251847> 1585920 4 commit-queue 2019-10-31 08:23:20 -0700 All reviewed patches have been landed. Closing bug. 382414 2019-10-30 20:34:55 -0700 2019-10-31 08:23:18 -0700 Patch bug-203630-20191030203455.patch text/plain 2732 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY2OTJhY2U1M2I4OGE4YmQ0 MDQ0OWU4ZmI4OGZlMjFhNTM4ZGVhMzMuLjMzZmYxNWFmZWNkNzU4MjFkYWQyMTVhNjkwNTRlMmQ0 ZWQ3OGI5N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTktMTAtMzAgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHRlbGVtZXRyeSB0 byB0ZXN0IGEgcG90ZW50aWFsIGNhdXNlIG9mIGNyYXNoZXMgdW5kZXIgLVtXS0NvbnRlbnRWaWV3 IF9pbnRlcnByZXRLZXlFdmVudDppc0NoYXJFdmVudDpdCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM2MzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzU2NzY5MjI5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgaU9TLXNwZWNpZmljIGNyYXNoIG9jY3VycyB1bmRlciBgLV9pbnRlcnByZXRLZXlF dmVudDppc0NoYXJFdmVudDpgLCB3aGVuIHdlIGZpcnN0IHRyeSB0byBhY2Nlc3MgV2ViRXZlbnQn cworICAgICAgICBwcm9wZXJ0aWVzIHdpdGggYGV2ZW50LmtleWJvYXJkRmxhZ3NgLiBUaGlzIHN1 Z2dlc3RzIHRoYXQgYmV0d2VlbiBzdG9yaW5nIHRoZSBXZWJFdmVudCBpbiBXZWJQYWdlUHJveHkn cworICAgICAgICBtX2tleUV2ZW50UXVldWUsIGFuZCBsYXRlciByZWNlaXZpbmcgYW4gSW50ZXJw cmV0S2V5RXZlbnQgc3luYyBJUEMgbWVzc2FnZSBpbiB0aGUgVUkgcHJvY2Vzcywgc29tZXRoaW5n IGVuZHMgdXAKKyAgICAgICAgb3ZlcnJlbGVhc2luZyAob3Igb3RoZXJ3aXNlIHdyaXRpbmcgb3Zl ciBvciBjb3JydXB0aW5nKSB0aGUgV2ViRXZlbnQuCisKKyAgICAgICAgSG93ZXZlciwgZnJvbSBj b2RlIGluc3BlY3Rpb24sIG5vdGhpbmcgYXBwZWFycyB0byBvdmVycmVsZWFzZSB0aGUgV2ViRXZl bnQ7IGFuIGFsdGVybmF0ZSBwb3NzaWJpbGl0eSBpcyB0aGF0IHRoZQorICAgICAgICBBUEkgaXMg c29tZWhvdyBiZWluZyBpbnZva2VkIGZyb20gYSBiYWNrZ3JvdW5kIHRocmVhZCwgd2hpY2ggd291 bGQgZXhwbGFpbiB3aHkgdGhlIFdlYkV2ZW50IG1heSBzb21ldGltZXMgZ2V0CisgICAgICAgIGRl c3Ryb3llZCB0b28gZWFybHkuCisKKyAgICAgICAgVG8gdHJ5IGFuZCBkZXRlY3QgdGhpcyBzY2Vu YXJpbyAoYW5kIGF2b2lkIGtlZXBpbmcgYW55IHN0cm9uZyByZWZlcmVuY2VzIHRvIFdlYkV2ZW50 IGF0IGFsbCksIGFkZCBhbgorICAgICAgICBgb3NfbG9nX2ZhdWx0YCBpbiBjYXNlIHRoZSBBUEkg aXMgYmVpbmcgY2FsbGVkIG9uIGEgYmFja2dyb3VuZCB0aHJlYWQsIGFuZCBiYWlsIGltbWVkaWF0 ZWx5LgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgaGFuZGxlS2V5V2ViRXZlbnQ6d2l0aENvbXBs ZXRpb25IYW5kbGVyOl0pOgorCiAyMDE5LTEwLTI5ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNp ZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNTE2OTMpOiBbaU9TXSBVbmFi bGUgdG8gY2hhbmdlIHNlbGVjdGlvbiBpbiBhIGZvY3VzZWQgZWxlbWVudCBpZiB0aGUgZWxlbWVu dCdzIGJvdW5kcyBjaGFuZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGU5Mzg5NWZhYmRmZTY3Y2UxY2I3 YjVlNDM1OGJhMGQ3ZDU0MWY5ZDUuLjUxNzU4NDg1Y2ZiZDZkZWQ1OWU3Y2U4NWY2YzFmZTUxZjZl NjM4MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNDk0Nyw2ICs0OTQ3LDEyIEBAIC0gKHZvaWQpaGFu ZGxlS2V5V2ViRXZlbnQ6KDo6V2ViRXZlbnQgKil0aGVFdmVudAogCiAtICh2b2lkKWhhbmRsZUtl eVdlYkV2ZW50Oig6OldlYkV2ZW50ICopdGhlRXZlbnQgd2l0aENvbXBsZXRpb25IYW5kbGVyOih2 b2lkICheKSg6OldlYkV2ZW50ICp0aGVFdmVudCwgQk9PTCB3YXNIYW5kbGVkKSljb21wbGV0aW9u SGFuZGxlcgogeworICAgIGlmICghaXNVSVRocmVhZCgpKSB7CisgICAgICAgIFJFTEVBU0VfTE9H X0ZBVUxUKEtleUhhbmRsaW5nLCAiJXMgd2FzIGludm9rZWQgb24gYSBiYWNrZ3JvdW5kIHRocmVh ZC4iLCBfX1BSRVRUWV9GVU5DVElPTl9fKTsKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIodGhl RXZlbnQsIE5PKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIFtzZWxmIF9oYW5kbGVE T01QYXN0ZVJlcXVlc3RXaXRoUmVzdWx0OldlYkNvcmU6OkRPTVBhc3RlQWNjZXNzUmVzcG9uc2U6 OkRlbmllZEZvckdlc3R1cmVdOwogCiAgICAgdXNpbmcgSGFuZGxlZEJ5SW5wdXRNZXRob2QgPSBX ZWJLaXQ6Ok5hdGl2ZVdlYktleWJvYXJkRXZlbnQ6OkhhbmRsZWRCeUlucHV0TWV0aG9kOwo=