203628 2019-10-30 14:14:45 -0700 tryCachePutToScopeGlobal should hold lock to update metadata.m_getPutInfo 2019-10-30 15:19:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1585504 0 tzagallo 2019-10-30 14:14:45 -0700 <rdar://problem/56705353> 1585510 1 382355 tzagallo 2019-10-30 14:24:58 -0700 Created attachment 382355 Patch 1585512 2 382355 ysuzuki 2019-10-30 14:25:42 -0700 Comment on attachment 382355 Patch r=me 1585566 3 382355 commit-queue 2019-10-30 15:19:41 -0700 Comment on attachment 382355 Patch Clearing flags on attachment: 382355 Committed r251812: <https://trac.webkit.org/changeset/251812> 1585567 4 commit-queue 2019-10-30 15:19:42 -0700 All reviewed patches have been landed. Closing bug. 382355 2019-10-30 14:24:58 -0700 2019-10-30 15:19:41 -0700 Patch bug-203628-20191030142457.patch text/plain 3815 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NzQxZGM5NGMwODk2MDZjYjIwMDhiZmNlNjIwZjgxN2ExNjQwN2Q2Li5kMmRhZTg2NWVmZWY4MTBh ZmQyMTgyNjM0NzEyMGZiNTI0MGJhYWMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0xMC0zMCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICB0cnlDYWNoZVB1dFRvU2NvcGVHbG9iYWwgc2hvdWxkIGhvbGQgdGhlIGxv Y2sgdG8gdXBkYXRlIG1ldGFkYXRhLm1fZ2V0UHV0SW5mbworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNjI4CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81NjcwNTM1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXZSBob2xkIHRoZSBsb2NrIHRvIHVwZGF0ZSBtX3dhdGNocG9pbnRTZXQgYW5kIG1fb3Bl cmFuZCwgYnV0IGF0IHRoYXQgcG9pbnQgd2UgaGF2ZSBhbHJlYWR5CisgICAgICAgIHVwZGF0ZWQg bV9nZXRQdXRJbmZvLiBUaGlzIGNhbiBsZWFkIHRvIGluY29uc2lzdGVudCBzdGF0ZSBvYnNlcnZh YmxlIGZyb20gdGhlIGNvbXBpbGVyIHRocmVhZAorICAgICAgICB3aGVyZSB0aGUgZ2V0UHV0SW5m byBkb2VzIG5vdCBtYXRjaCB0aGUgd2F0Y2hwb2ludFNldC4KKworICAgICAgICAqIHJ1bnRpbWUv Q29tbW9uU2xvd1BhdGhzLmg6CisgICAgICAgIChKU0M6OkNvbW1vblNsb3dQYXRoczo6dHJ5Q2Fj aGVQdXRUb1Njb3BlR2xvYmFsKToKKwogMjAxOS0xMC0yOSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdh bGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQXNzZW1ibHldIENyZWF0ZSBhIFdhc20gaW50 ZXJwcmV0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbW1v blNsb3dQYXRocy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1Bh dGhzLmgKaW5kZXggYTJkODUwYTFlYTQ0NWZlODViOGFkZjM0ZGVmMTNhMTIyMDRlZTZjNi4uNTkz ODU5NGJjMDE0MWE5MDc5OWE2ZjYwODQxYTFmYjE1OGMzMWM4ZiAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmgKQEAgLTE0MywxMCArMTQzLDEw IEBAIGlubGluZSB2b2lkIHRyeUNhY2hlUHV0VG9TY29wZUdsb2JhbCgKICAgICAgICAgaWYgKHNj b3BlLT5pc0dsb2JhbExleGljYWxFbnZpcm9ubWVudCgpKSB7CiAgICAgICAgICAgICBKU0dsb2Jh bExleGljYWxFbnZpcm9ubWVudCogZ2xvYmFsTGV4aWNhbEVudmlyb25tZW50ID0ganNDYXN0PEpT R2xvYmFsTGV4aWNhbEVudmlyb25tZW50Kj4oc2NvcGUpOwogICAgICAgICAgICAgUmVzb2x2ZVR5 cGUgbmV3UmVzb2x2ZVR5cGUgPSBuZWVkc1ZhckluamVjdGlvbkNoZWNrcyhyZXNvbHZlVHlwZSkg PyBHbG9iYWxMZXhpY2FsVmFyV2l0aFZhckluamVjdGlvbkNoZWNrcyA6IEdsb2JhbExleGljYWxW YXI7Ci0gICAgICAgICAgICBtZXRhZGF0YS5tX2dldFB1dEluZm8gPSBHZXRQdXRJbmZvKG1ldGFk YXRhLm1fZ2V0UHV0SW5mby5yZXNvbHZlTW9kZSgpLCBuZXdSZXNvbHZlVHlwZSwgbWV0YWRhdGEu bV9nZXRQdXRJbmZvLmluaXRpYWxpemF0aW9uTW9kZSgpKTsKICAgICAgICAgICAgIFN5bWJvbFRh YmxlRW50cnkgZW50cnkgPSBnbG9iYWxMZXhpY2FsRW52aXJvbm1lbnQtPnN5bWJvbFRhYmxlKCkt PmdldChpZGVudC5pbXBsKCkpOwogICAgICAgICAgICAgQVNTRVJUKCFlbnRyeS5pc051bGwoKSk7 CiAgICAgICAgICAgICBDb25jdXJyZW50SlNMb2NrZXIgbG9ja2VyKGNvZGVCbG9jay0+bV9sb2Nr KTsKKyAgICAgICAgICAgIG1ldGFkYXRhLm1fZ2V0UHV0SW5mbyA9IEdldFB1dEluZm8obWV0YWRh dGEubV9nZXRQdXRJbmZvLnJlc29sdmVNb2RlKCksIG5ld1Jlc29sdmVUeXBlLCBtZXRhZGF0YS5t X2dldFB1dEluZm8uaW5pdGlhbGl6YXRpb25Nb2RlKCkpOwogICAgICAgICAgICAgbWV0YWRhdGEu bV93YXRjaHBvaW50U2V0ID0gZW50cnkud2F0Y2hwb2ludFNldCgpOwogICAgICAgICAgICAgbWV0 YWRhdGEubV9vcGVyYW5kID0gcmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KGdsb2JhbExleGlj YWxFbnZpcm9ubWVudC0+dmFyaWFibGVBdChlbnRyeS5zY29wZU9mZnNldCgpKS5zbG90KCkpOwog ICAgICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rl c3RzL0NoYW5nZUxvZwppbmRleCA2YWNkNGEyNjdlOGE0NGJkYjhkYmNkYzY5MmNmOWNkMDQ0NWY3 ZGNlLi5lMTdiNmVhMGRjMjlmZTMyNTdlM2NiYjM3MjBjNDMzN2M4Y2Y0ZGI2IDEwMDY0NAotLS0g YS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTEwLTMwICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9AYXBwbGUuY29tPgorCisg ICAgICAgIHRyeUNhY2hlUHV0VG9TY29wZUdsb2JhbCBzaG91bGQgaG9sZCB0aGUgbG9jayB0byB1 cGRhdGUgbWV0YWRhdGEubV9nZXRQdXRJbmZvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM2MjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU2NzA1 MzUzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog c3RyZXNzL3Byb3BlcnR5LW1vdmUtZnJvbS1nbG9iYWwtb2JqZWN0LXRvLWdsb2JhbC1sZXhpY2Fs LWVudmlyb25tZW50LmpzOiBBZGRlZC4KKyAgICAgICAgKGZvbyk6CisKIDIwMTktMTAtMjggIFl1 c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBPcHRpbWl6 ZSBQcm9taXNlIHJ1bnRpbWUgZnVuY3Rpb25zCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9w cm9wZXJ0eS1tb3ZlLWZyb20tZ2xvYmFsLW9iamVjdC10by1nbG9iYWwtbGV4aWNhbC1lbnZpcm9u bWVudC5qcyBiL0pTVGVzdHMvc3RyZXNzL3Byb3BlcnR5LW1vdmUtZnJvbS1nbG9iYWwtb2JqZWN0 LXRvLWdsb2JhbC1sZXhpY2FsLWVudmlyb25tZW50LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY2ODFlNjI2NGZl MTVmZWRhZjQ3MDZkZDMwZTE1YjdlNWFmODc5OWQKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3Rz L3N0cmVzcy9wcm9wZXJ0eS1tb3ZlLWZyb20tZ2xvYmFsLW9iamVjdC10by1nbG9iYWwtbGV4aWNh bC1lbnZpcm9ubWVudC5qcwpAQCAtMCwwICsxLDE1IEBACitmdW5jdGlvbiBmb28oKSB7CisgICAg ICBiYXIgPSA0OworfQorZnVuY3Rpb24gZ2V0KCkgeworICAgICAgcmV0dXJuIGJhcjsKK30KK2Zv ciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwMDsgKytpKQorICAgICAgZm9vKCk7Citmb3IgKHZhciBp ID0gMDsgaSA8IDEwMDAwMDA7ICsraSkKKyAgICAgIGdldCgpOworJC5ldmFsU2NyaXB0KCdsZXQg YmFyID0gMzsnKTsKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwMDsgKytpKQorICAgICAgZ2V0 KCk7Citmb3IgKHZhciBpID0gMDsgaSA8IDEwMDAwMDA7ICsraSkKKyAgICAgIGZvbygpOwo=