20360 2008-08-12 09:08:18 -0700 MIME type parameters break <video> and <audio> elements 2008-08-13 16:51:16 -0700 1 1 1 Unclassified WebKit New Bugs 525.x (Safari 3.1) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 0 eric.carlson webkit-unassigned oldest_to_newest 88313 0 eric.carlson 2008-08-12 09:08:18 -0700 A MIME type can have various parameters after the type which add extra meaning, but WebKit doesn't deal with them. Open http://hsivonen.iki.fi/test/moz/video-selection/source-mp4-ogg-params.html, which contains: <video controls autoplay> <source src='html5-test.mp4' type='video/mp4; codecs="avc1.42E01E, mp4a.40.2"'> <source src='html5-test.ogg' type='application/ogg; codecs="theora, vorbis"'> FAIL: This is fallback text. </video> In Safari, WebKit should display 'html5-test.mp4', but it does not because the MIME type registry doesn't match 'video/mp4; codecs="avc1.42E01E, mp4a.40.2"'. 88315 1 22749 eric.carlson 2008-08-12 09:14:20 -0700 Created attachment 22749 Patch to strip parameters from the MIME type before checking with the type registry 88316 2 eric.carlson 2008-08-12 09:19:45 -0700 <rdar://6137931> 88317 3 22749 adele 2008-08-12 09:19:52 -0700 Comment on attachment 22749 Patch to strip parameters from the MIME type before checking with the type registry You've got some tabs in the patch- you should replace those with spaces. You also want to generate and checkin results for the test, and make a ChangeLog entry for the LayoutTests directory. 88319 4 22751 eric.carlson 2008-08-12 09:59:57 -0700 Created attachment 22751 Revised patch 88445 5 adele 2008-08-13 16:51:16 -0700 Committed revision 35729. 22749 2008-08-12 09:14:20 -0700 2008-08-12 09:59:57 -0700 Patch to strip parameters from the MIME type before checking with the type registry eric.carlson_mime_parameter_patch.txt text/plain 2278 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTY4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMDgtMTIgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIGFsbCBwYXJhbWV0ZXJzIGZyb20gdGhlIE1JTUUgdHlwZSBiZWZvcmUgY2hlY2tp bmcgd2l0aCB0aGUgTUlNRSB0eXBlIHJlZ2lzdHJ5CisKKyAgICAgICAgVGVzdHM6IG1lZGlhL3Zp ZGVvLXNvdXJjZS10eXBlLXBhcmFtcy5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6cGlja01lZGlh KTogb25seSBwYXNzIHRoZSBwb3J0aW9uIGJlZm9yZSB0aGUgZmlyc3QgJzsnIAorICAgICAgICB0 byBpc1N1cHBvcnRlZE1lZGlhTUlNRVR5cGUoKQorCiAyMDA4LTA4LTEyICBBZGFtIFJvYmVuICA8 YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZpeApJbmRleDogV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gMzU2ODIpCisrKyBXZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxOSw3ICs4MTksMTMgQEAg U3RyaW5nIEhUTUxNZWRpYUVsZW1lbnQ6OnBpY2tNZWRpYSgpCiAgICAgICAgICAgICAgICAgICAg ICAgICBjb250aW51ZTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgaWYgKHNv dXJjZS0+aGFzQXR0cmlidXRlKHR5cGVBdHRyKSkgewotICAgICAgICAgICAgICAgICAgICBTdHJp bmcgdHlwZSA9IHNvdXJjZS0+dHlwZSgpOworICAgICAgICAgICAgICAgICAgICBTdHJpbmcgdHlw ZSA9IHNvdXJjZS0+dHlwZSgpLnN0cmlwV2hpdGVTcGFjZSgpOworCisgICAgICAgICAgICAgICAg ICAgIC8vICJ0eXBlIiBjYW4gaGF2ZSBwYXJhbWV0ZXJzIGFmdGVyIGEgc2VtaS1jb2xvbiwgc3Ry aXAgdGhlbSBiZWZvcmUgY2hlY2tpbmcgd2l0aCB0aGUgdHlwZSByZWdpc3RyeQorICAgICAgICAg ICAgICAgICAgICBpbnQgc2VtaSA9IHR5cGUuZmluZCgnOycpOworICAgICAgICAgICAgICAgICAg ICBpZiAoLTEgIT0gc2VtaSkKKwkJCQkJCXR5cGUgPSB0eXBlLmxlZnQoc2VtaSkuc3RyaXBXaGl0 ZVNwYWNlKCk7CisKICAgICAgICAgICAgICAgICAgICAgaWYgKCFNSU1FVHlwZVJlZ2lzdHJ5Ojpp c1N1cHBvcnRlZE1lZGlhTUlNRVR5cGUodHlwZSkpCiAgICAgICAgICAgICAgICAgICAgICAgICBj b250aW51ZTsKICAgICAgICAgICAgICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS92aWRl by1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRp YS92aWRlby1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL21lZGlhL3ZpZGVvLXNvdXJjZS10eXBlLXBhcmFtcy5odG1sCShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDExIEBACis8Ym9keT4KKzxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+ Cis8dmlkZW8gY29udHJvbHM+CisgICAgPHNvdXJjZSBzcmM9Y29udGVudC9ib2d1cy5tcGVnIHR5 cGU9InZpZGVvL2JsYWhibGFoIj4KKyAgICA8c291cmNlIHNyYz1jb250ZW50L3Rlc3QubXA0IHR5 cGU9InZpZGVvL21wZWc7IGNvZGVjcz0mcXVvdDthdmMxLjRENDAwQyZxdW90OyI+CisgICAgPHNv dXJjZSBzcmM9Y29udGVudC9lcnJvcjIubXBlZyB0eXBlPXZpZGVvL21wZWc+Cis8L3ZpZGVvPgor PHNjcmlwdD4KK3ZpZGVvID0gbWVkaWEgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgn dmlkZW8nKVswXTsKK3dhaXRGb3JFdmVudFRlc3RBbmRFbmQoJ2JlZ2luJywgInJlbGF0aXZlVVJM KHZpZGVvLmN1cnJlbnRTcmMpID09ICdjb250ZW50L3Rlc3QubXA0JyIpOworPC9zY3JpcHQ+Cg== 22751 2008-08-12 09:59:57 -0700 2008-08-12 19:20:48 -0700 Revised patch eric.carlson_mime_parameter_patch.txt text/plain 3371 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTY4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMDgtMTIgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzYwCisgICAgICAg IFJlbW92ZSBhbGwgcGFyYW1ldGVycyBmcm9tIHRoZSBNSU1FIHR5cGUgYmVmb3JlIGNoZWNraW5n IHdpdGggdGhlIE1JTUUgdHlwZSByZWdpc3RyeQorCisgICAgICAgIFRlc3RzOiBtZWRpYS92aWRl by1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnBpY2tNZWRpYSk6 IG9ubHkgcGFzcyB0aGUgcG9ydGlvbiBiZWZvcmUgdGhlIGZpcnN0ICc7JyAKKyAgICAgICAgdG8g aXNTdXBwb3J0ZWRNZWRpYU1JTUVUeXBlKCkKKwogMjAwOC0wOC0xMiAgQWRhbSBSb2JlbiAgPGFy b2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXgKSW5kZXg6IFdlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9uIDM1NjgyKQorKysgV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MTksNyArODE5LDEzIEBAIFN0 cmluZyBIVE1MTWVkaWFFbGVtZW50OjpwaWNrTWVkaWEoKQogICAgICAgICAgICAgICAgICAgICAg ICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGlmIChzb3Vy Y2UtPmhhc0F0dHJpYnV0ZSh0eXBlQXR0cikpIHsKLSAgICAgICAgICAgICAgICAgICAgU3RyaW5n IHR5cGUgPSBzb3VyY2UtPnR5cGUoKTsKKyAgICAgICAgICAgICAgICAgICAgU3RyaW5nIHR5cGUg PSBzb3VyY2UtPnR5cGUoKS5zdHJpcFdoaXRlU3BhY2UoKTsKKworICAgICAgICAgICAgICAgICAg ICAvLyAidHlwZSIgY2FuIGhhdmUgcGFyYW1ldGVycyBhZnRlciBhIHNlbWktY29sb24sIHN0cmlw IHRoZW0gYmVmb3JlIGNoZWNraW5nIHdpdGggdGhlIHR5cGUgcmVnaXN0cnkKKyAgICAgICAgICAg ICAgICAgICAgaW50IHNlbWkgPSB0eXBlLmZpbmQoJzsnKTsKKyAgICAgICAgICAgICAgICAgICAg aWYgKC0xICE9IHNlbWkpCisgICAgICAgICAgICAgICAgICAgICAgICB0eXBlID0gdHlwZS5sZWZ0 KHNlbWkpLnN0cmlwV2hpdGVTcGFjZSgpOworCiAgICAgICAgICAgICAgICAgICAgIGlmICghTUlN RVR5cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWRNZWRpYU1JTUVUeXBlKHR5cGUpKQogICAgICAgICAg ICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgfQpJbmRleDogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2 aXNpb24gMzU2ODQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxMyBAQAorMjAwOC0wOC0xMiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNjAKKyAgICAgICAg QWRkIHRlc3QgY2FzZSBmb3IgcGFyYW1ldGVycyBvbiBhIDxzb3VyY2U+IGVsZW1lbnQgJ3R5cGUn IGF0dHJpYnV0ZS4KKworICAgICAgICAqIG1lZGlhL3ZpZGVvLXNvdXJjZS10eXBlLXBhcmFtcy1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL3ZpZGVvLXNvdXJjZS10eXBlLXBh cmFtcy5odG1sOiBBZGRlZC4KKwogMjAwOC0wOC0xMiAgTmlrb2xhcyBaaW1tZXJtYW5uICA8emlt bWVybWFubkBrZGUub3JnPgogCiAgICAgICAgIFJ1YmJlciBzdGFtcGVkIGJ5IEFuZGVycy4KSW5k ZXg6IExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNvdXJjZS10eXBlLXBhcmFtcy1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLXR5cGUtcGFy YW1zLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL3ZpZGVv LXNvdXJjZS10eXBlLXBhcmFtcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MyBAQAorRVZFTlQoYmVnaW4pIFRFU1QocmVsYXRpdmVVUkwodmlkZW8uY3VycmVudFNyYykgPT0g J2NvbnRlbnQvdGVzdC5tcDQnKSBPSworRU5EIE9GIFRFU1QKKwpJbmRleDogTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tc291cmNlLXR5cGUtcGFyYW1zLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvbWVkaWEvdmlkZW8tc291cmNlLXR5cGUtcGFyYW1zLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zb3VyY2UtdHlwZS1wYXJhbXMuaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwxMSBAQAorPGJvZHk+Cis8c2NyaXB0IHNyYz12aWRlby10ZXN0Lmpz Pjwvc2NyaXB0PgorPHZpZGVvIGNvbnRyb2xzPgorICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvYm9n dXMubXBlZyB0eXBlPSJ2aWRlby9ibGFoYmxhaCI+CisgICAgPHNvdXJjZSBzcmM9Y29udGVudC90 ZXN0Lm1wNCB0eXBlPSJ2aWRlby9tcGVnOyBjb2RlY3M9JnF1b3Q7YXZjMS40RDQwMEMmcXVvdDsi PgorICAgIDxzb3VyY2Ugc3JjPWNvbnRlbnQvZXJyb3IyLm1wZWcgdHlwZT12aWRlby9tcGVnPgor PC92aWRlbz4KKzxzY3JpcHQ+Cit2aWRlbyA9IG1lZGlhID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNC eVRhZ05hbWUoJ3ZpZGVvJylbMF07Cit3YWl0Rm9yRXZlbnRUZXN0QW5kRW5kKCdiZWdpbicsICJy ZWxhdGl2ZVVSTCh2aWRlby5jdXJyZW50U3JjKSA9PSAnY29udGVudC90ZXN0Lm1wNCciKTsKKzwv c2NyaXB0Pgo=