203588 2019-10-29 14:38:30 -0700 [ Mac Debug ] (r251706) webanimations/empty-keyframes-crash.html is crashing 2019-10-30 16:25:48 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203561 InRadar P2 Normal --- 1 tsavell graouts dino graouts jlewis3 repstein webkit-bug-importer oldest_to_newest 1585105 0 tsavell 2019-10-29 14:38:30 -0700 The changes in https://trac.webkit.org/changeset/251706/webkit broke webanimations/empty-keyframes-crash.html casting it to crash on Mac debug. History: https://results.webkit.org/?suite=layout-tests&test=webanimations%2Fempty-keyframes-crash.html Log: Application Specific Information: CRASHING TEST: webanimations/empty-keyframes-crash.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x00000002eb1b4810 WTFCrash + 16 (Assertions.cpp:305) 1 com.apple.WebCore 0x00000002d8006c6b WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebCore 0x00000002d9d78ff8 WebCore::KeyframeEffect::setAnimatedPropertiesInStyle(WebCore::RenderStyle&, double) + 168 (KeyframeEffect.cpp:1070) 3 com.apple.WebCore 0x00000002d9d78ce3 WebCore::KeyframeEffect::apply(WebCore::RenderStyle&) + 195 (KeyframeEffect.cpp:1029) https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r251715%20(10173)/webanimations/empty-keyframes-crash-crash-log.txt 1585106 1 webkit-bug-importer 2019-10-29 14:39:52 -0700 <rdar://problem/56721908> 1585107 2 webkit-bug-importer 2019-10-29 14:40:06 -0700 <rdar://problem/56721919> 1585310 3 382293 graouts 2019-10-30 03:26:46 -0700 Created attachment 382293 Patch 1585447 4 graouts 2019-10-30 11:46:10 -0700 Landed in r251789. 1585647 5 jlewis3 2019-10-30 16:23:39 -0700 *** Bug 203641 has been marked as a duplicate of this bug. *** 382293 2019-10-30 03:26:46 -0700 2019-10-30 11:42:07 -0700 Patch bug-203588-20191030112644.patch text/plain 3265 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk2ZWQxMGM0YTJlNDNh N2FhNGM1ODU0YjIyYTUzOTU2YWEyNGMyNC4uNzkxOTE0YjgxMzBiNzUxMTlkODRmMGQxNzlkM2Q0 YjM5ZWQ3MTg1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEwLTMwICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgWyBNYWMgRGVidWcgXSAo cjI1MTcwNikgd2ViYW5pbWF0aW9ucy9lbXB0eS1rZXlmcmFtZXMtY3Jhc2guaHRtbCBpcyBjcmFz aGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAz NTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IEtleWZyYW1lRWZmZWN0IGZvciB3aGljaCB0aGUgYmxlbmRpbmcga2V5ZnJhbWVzIHdlcmUgZ2Vu ZXJhdGVkIGZvciBhIENTUyBUcmFuc2l0aW9uIGNvdWxkIGJlIGFwcGxpZWQgdG8gYSBkaWZmZXJl bnQgYW5pbWF0aW9uLAorICAgICAgICB3aGljaCBpcyBub3QgYSBDU1NUcmFuc2l0aW9uLCB3aGlj aCBkb2VzIG5vdCBjaGFuZ2UgdGhlIGZhY3QgdGhhdCB3ZSBjYW4gYmxlbmQgdGhlIHNpbmdsZSBD U1MgcHJvcGVydHkgd2l0aCB0d28gZnVsbHktcXVhbGlmaWVkCisgICAgICAgIGtleWZyYW1lcyBk aXJlY3RseS4gU28gd2UgY2FuIHJlbW92ZSB0aGF0IGFzc2VydGlvbiBhbmQgc2ltcGx5IGNoZWNr IHRoYXQgd2UgaGF2ZSBhIHNpbmdsZSBDU1MgcHJvcGVydHkgaW5zdGVhZCBhbmQgYWNjZXNzIHRo ZQorICAgICAgICBzaW5nbGUgQ1NTIHByb3BlcnR5IGluIHRoZSBLZXlmcmFtZUxpc3QuCisKKyAg ICAgICAgKiBhbmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 S2V5ZnJhbWVFZmZlY3Q6OnNldEFuaW1hdGVkUHJvcGVydGllc0luU3R5bGUpOgorCiAyMDE5LTEw LTI5ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYiBB bmltYXRpb25zXSBPcHRpbWl6ZSBibGVuZGluZyBmb3IgQ1NTIFRyYW5zaXRpb25zCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuY3BwIGIvU291cmNl L1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0LmNwcAppbmRleCA0ZjFkNjJjY2Y4Njkx MGE1MWFkODc4ZGNmZTY3ZmM2Y2IzY2UzN2ZlLi40NDhlYTA1MWI0ZjBiYjQyMzdiYTIwOWQ1NmRh MDUzOTg1NmRmZjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJh bWVFZmZlY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVj dC5jcHAKQEAgLTEwNjMsMTIgKzEwNjMsMTQgQEAgdm9pZCBLZXlmcmFtZUVmZmVjdDo6Z2V0QW5p bWF0ZWRTdHlsZShzdGQ6OnVuaXF1ZV9wdHI8UmVuZGVyU3R5bGU+JiBhbmltYXRlZFN0eWwKIAog dm9pZCBLZXlmcmFtZUVmZmVjdDo6c2V0QW5pbWF0ZWRQcm9wZXJ0aWVzSW5TdHlsZShSZW5kZXJT dHlsZSYgdGFyZ2V0U3R5bGUsIGRvdWJsZSBpdGVyYXRpb25Qcm9ncmVzcykKIHsKKyAgICBhdXRv JiBwcm9wZXJ0aWVzID0gbV9ibGVuZGluZ0tleWZyYW1lcy5wcm9wZXJ0aWVzKCk7CisKICAgICAv LyBJbiB0aGUgY2FzZSBvZiBDU1MgVHJhbnNpdGlvbnMgd2UgYWxyZWFkeSBrbm93IHRoYXQgdGhl cmUgYXJlIG9ubHkgdHdvIGtleWZyYW1lcywgb25lIHdoZXJlIG9mZnNldD0wIGFuZCBvbmUgd2hl cmUgb2Zmc2V0PTEsCiAgICAgLy8gYW5kIG9ubHkgYSBzaW5nbGUgQ1NTIHByb3BlcnR5IHNvIHdl IGNhbiBzaW1wbHkgYmxlbmQgYmFzZWQgb24gdGhlIHN0eWxlIGF2YWlsYWJsZSBvbiB0aG9zZSBr ZXlmcmFtZXMgd2l0aCB0aGUgcHJvdmlkZWQgaXRlcmF0aW9uCiAgICAgLy8gcHJvZ3Jlc3Mgd2hp Y2ggYWxyZWFkeSBhY2NvdW50cyBmb3IgdGhlIHRyYW5zaXRpb24ncyB0aW1pbmcgZnVuY3Rpb24u CiAgICAgaWYgKG1fYmxlbmRpbmdLZXlmcmFtZXNTb3VyY2UgPT0gQmxlbmRpbmdLZXlmcmFtZXNT b3VyY2U6OkNTU1RyYW5zaXRpb24pIHsKLSAgICAgICAgQVNTRVJUKGlzPENTU1RyYW5zaXRpb24+ KGFuaW1hdGlvbigpKSk7Ci0gICAgICAgIENTU1Byb3BlcnR5QW5pbWF0aW9uOjpibGVuZFByb3Bl cnRpZXModGhpcywgZG93bmNhc3Q8Q1NTVHJhbnNpdGlvbj4oYW5pbWF0aW9uKCkpLT5wcm9wZXJ0 eSgpLCAmdGFyZ2V0U3R5bGUsIG1fYmxlbmRpbmdLZXlmcmFtZXNbMF0uc3R5bGUoKSwgbV9ibGVu ZGluZ0tleWZyYW1lc1sxXS5zdHlsZSgpLCBpdGVyYXRpb25Qcm9ncmVzcyk7CisgICAgICAgIEFT U0VSVChwcm9wZXJ0aWVzLnNpemUoKSA9PSAxKTsKKyAgICAgICAgQ1NTUHJvcGVydHlBbmltYXRp b246OmJsZW5kUHJvcGVydGllcyh0aGlzLCAqcHJvcGVydGllcy5iZWdpbigpLCAmdGFyZ2V0U3R5 bGUsIG1fYmxlbmRpbmdLZXlmcmFtZXNbMF0uc3R5bGUoKSwgbV9ibGVuZGluZ0tleWZyYW1lc1sx XS5zdHlsZSgpLCBpdGVyYXRpb25Qcm9ncmVzcyk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAK QEAgLTEwODIsNyArMTA4NCw3IEBAIHZvaWQgS2V5ZnJhbWVFZmZlY3Q6OnNldEFuaW1hdGVkUHJv cGVydGllc0luU3R5bGUoUmVuZGVyU3R5bGUmIHRhcmdldFN0eWxlLCBkb3ViCiAgICAgaWYgKG1f YmxlbmRpbmdLZXlmcmFtZXMuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBmb3Ig KGF1dG8gY3NzUHJvcGVydHlJZCA6IG1fYmxlbmRpbmdLZXlmcmFtZXMucHJvcGVydGllcygpKSB7 CisgICAgZm9yIChhdXRvIGNzc1Byb3BlcnR5SWQgOiBwcm9wZXJ0aWVzKSB7CiAgICAgICAgIC8v IDEuIElmIGl0ZXJhdGlvbiBwcm9ncmVzcyBpcyB1bnJlc29sdmVkIGFib3J0IHRoaXMgcHJvY2Vk dXJlLgogICAgICAgICAvLyAyLiBMZXQgdGFyZ2V0IHByb3BlcnR5IGJlIHRoZSBsb25naGFuZCBw cm9wZXJ0eSBmb3Igd2hpY2ggdGhlIGVmZmVjdCB2YWx1ZSBpcyB0byBiZSBjYWxjdWxhdGVkLgog ICAgICAgICAvLyAzLiBJZiBhbmltYXRpb24gdHlwZSBvZiB0aGUgdGFyZ2V0IHByb3BlcnR5IGlz IG5vdCBhbmltYXRhYmxlIGFib3J0IHRoaXMgcHJvY2VkdXJlIHNpbmNlIHRoZSBlZmZlY3QgY2Fu bm90IGJlIGFwcGxpZWQuCg==