203556 2019-10-29 01:51:00 -0700 [GTK][WPE] Fix non-unified build after r251691 2019-10-29 07:37:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen cgarcia clopez commit-queue webkit-bug-importer youennf zan oldest_to_newest 1584860 0 aperez 2019-10-29 01:51:00 -0700 Commit r251691 introduced the following build failure: ../Source/WebCore/bindings/js/ScriptModuleLoader.cpp:218:23: error: use of undeclared identifier 'JSInternalPromise'; did you mean 'JSC::JSInternalPromise'? auto* jsPromise = JSInternalPromise::create(globalObject.vm(), globalObject.internalPromiseStructure()); ^~~~~~~~~~~~~~~~~ JSC::JSInternalPromise DerivedSources/ForwardingHeaders/JavaScriptCore/JSInternalPromise.h:42:7: note: 'JSC::JSInternalPromise' declared here class JSInternalPromise final : public JSPromise { ^ 1 error generated. 1584861 1 382168 aperez 2019-10-29 02:02:00 -0700 Created attachment 382168 Patch 1584903 2 382168 commit-queue 2019-10-29 07:36:39 -0700 Comment on attachment 382168 Patch Clearing flags on attachment: 382168 Committed r251698: <https://trac.webkit.org/changeset/251698> 1584904 3 commit-queue 2019-10-29 07:36:40 -0700 All reviewed patches have been landed. Closing bug. 1584905 4 webkit-bug-importer 2019-10-29 07:37:17 -0700 <rdar://problem/56705931> 382168 2019-10-29 02:02:00 -0700 2019-10-29 07:36:39 -0700 Patch bug-203556-20191029110159.patch text/plain 1675 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWJhM2ExZDdiMWQyZTFk MzFlODJmZTAyMTYzZjYyNDAwZWNmZGM2NS4uZTA3Mzc0NjEwZmQ1NTIxNmU3YzRkMTRjODg4ZjMx NGRjYjY1ZTFiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEwLTI5ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b V1BFXSBGaXggbm9uLXVuaWZpZWQgYnVpbGQgYWZ0ZXIgcjI1MTY5MQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNTU2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKwor ICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdE1vZHVsZUxvYWRlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpyZWplY3RQcm9taXNlKTogQWRkIG1pc3NpbmcgbmFtZXNwYWNlIGluIGNhbGwgdG8g SlNDOjpKU0ludGVybmFsUHJvbWlzZTo6Y3JlYXRlKCkuCisKIDIwMTktMTAtMjggIFl1c3VrZSBT dXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBSZW1vdmUgSlNQcm9t aXNlRGVmZXJyZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1Njcmlw dE1vZHVsZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRNb2R1 bGVMb2FkZXIuY3BwCmluZGV4IGIzZjA2YWM1NmY3ZjViZDI3ZjE4MDRkNjFhZjU0YjVlZTc4OWU1 MDAuLjY0MTdmNGFmY2ZkM2Q0MTBiN2FjMTIzNmE1ODc2YmFiZDYxMzQ5YWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdE1vZHVsZUxvYWRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0TW9kdWxlTG9hZGVyLmNwcApAQCAtMjE1 LDcgKzIxNSw3IEBAIEpTQzo6SlNWYWx1ZSBTY3JpcHRNb2R1bGVMb2FkZXI6OmV2YWx1YXRlKEpT Qzo6SlNHbG9iYWxPYmplY3QqIGpzR2xvYmFsT2JqZWN0LCBKCiAKIHN0YXRpYyBKU0M6OkpTSW50 ZXJuYWxQcm9taXNlKiByZWplY3RQcm9taXNlKEpTRE9NR2xvYmFsT2JqZWN0JiBnbG9iYWxPYmpl Y3QsIEV4Y2VwdGlvbkNvZGUgZWMsIEFTQ0lJTGl0ZXJhbCBtZXNzYWdlKQogewotICAgIGF1dG8q IGpzUHJvbWlzZSA9IEpTSW50ZXJuYWxQcm9taXNlOjpjcmVhdGUoZ2xvYmFsT2JqZWN0LnZtKCks IGdsb2JhbE9iamVjdC5pbnRlcm5hbFByb21pc2VTdHJ1Y3R1cmUoKSk7CisgICAgYXV0byoganNQ cm9taXNlID0gSlNDOjpKU0ludGVybmFsUHJvbWlzZTo6Y3JlYXRlKGdsb2JhbE9iamVjdC52bSgp LCBnbG9iYWxPYmplY3QuaW50ZXJuYWxQcm9taXNlU3RydWN0dXJlKCkpOwogICAgIFJFTEVBU0Vf QVNTRVJUKGpzUHJvbWlzZSk7CiAgICAgYXV0byBkZWZlcnJlZCA9IERlZmVycmVkUHJvbWlzZTo6 Y3JlYXRlKGdsb2JhbE9iamVjdCwgKmpzUHJvbWlzZSk7CiAgICAgZGVmZXJyZWQtPnJlamVjdChl YywgV1RGTW92ZShtZXNzYWdlKSk7Cg==