20355 2008-08-11 19:08:25 -0700 Back list isn't properly updated for fragment changes after a redirect 2009-09-22 13:04:56 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED HasReduction, InRadar P2 Normal --- 1 mathewsb beidson adele agrieve beidson grahamperrin rostislav.hristov oldest_to_newest 88268 0 mathewsb 2008-08-11 19:08:25 -0700 After a redirect by window.location.replace(), changes to the URI fragment don't insert new history entries. The problem continues until you change to a new page. For instance suppose you have these two files: a.html: <script>window.location.replace('b.html');</script> b.html: <a href="#asdf">Click this link to demonstrate the problem.</a> If you load a.html, you will be redirected to b.html. If you click on the link, then the location bar is updated, but no history entry is added. However, if you load b.html directly, then clicking on the link *does* insert a history entry. This happens for me on Safari 3.1.2, and on the WebKit nightly r35666. 88269 1 mathewsb 2008-08-11 19:12:37 -0700 By the way, this bug may seem trivial, but it causes issues for our JS history management library on Facebook. I would guess that it causes problems for other history management libraries, too. 88286 2 mrowe 2008-08-11 21:55:46 -0700 <rdar://problem/6142803> 91497 3 mathewsb 2008-09-17 10:38:26 -0700 A real-world description of how this affects end users: 1. User gets an email that says "X tagged a photo of you on Facebook." Has a link that looks like this: http://www.facebook.com/n/?photo.php&pid=XXXXXXXX&op=1&view=all&subj=XXXXXXX&id=XXXX 2. User clicks on the link, is taken to the photo. 3. User clicks on the photo to go to the next photo. 4. At this point, the back button doesn't work. (Normally, on other browsers, it would take you back to the first photo. In Safari, it might not do anything, or it might take you back to what you were viewing before you clicked on the Facebook link.) 101315 4 rostislav.hristov 2008-12-04 04:18:17 -0800 The problem applies also to meta redirects like: <meta http-equiv="refresh" content="0;url=b.html" /> Check how the following sample behaves in Safari and the other browsers: http://www.asual.com/swfaddress/samples/ajax/history/ 135636 5 agrieve 2009-07-29 11:24:26 -0700 This bug is also affecting gmail on the iphone/android in some cases. 149103 6 beidson 2009-09-22 10:36:06 -0700 In: void FrameLoader::continueFragmentScrollAfterNavigationPolicy(const ResourceRequest& request, bool shouldContinue) ...we check the FrameLoadType to see if we should change the back/forward list or not. The FrameLoadType is set in the various forms of loads that go through a new DocumentLoader, but is never set in the synchronous anchor scroll case. So the old FrameLoadType from the a.html -> b.html redirect is still sticking around, preventing the back/forward entry from being made. 149152 7 39938 beidson 2009-09-22 12:39:33 -0700 Created attachment 39938 Patch v1 149158 8 beidson 2009-09-22 13:04:56 -0700 Sending LayoutTests/ChangeLog Adding LayoutTests/fast/loader/fragment-after-redirect-gets-back-entry-expected.txt Adding LayoutTests/fast/loader/fragment-after-redirect-gets-back-entry.html Adding LayoutTests/fast/loader/resources/click-fragment-link.html Sending LayoutTests/http/tests/navigation/relativeanchor-frames-expected.txt Sending WebCore/ChangeLog Sending WebCore/loader/FrameLoader.cpp Transmitting file data ....... Committed revision 48644. 39938 2009-09-22 12:39:33 -0700 2009-09-22 12:53:35 -0700 Patch v1 patch.txt text/plain 5790 beidson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODY0MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDktMjIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJh Y2sgbGlzdCBpc24ndCBwcm9wZXJseSB1cGRhdGVkIGZvciBmcmFnbWVudCBjaGFuZ2VzIGFmdGVy IGEgcmVkaXJlY3QuCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTQyODAzPiBhbmQgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzU1CisKKyAgICAgICAgVGVzdDog ZmFzdC9sb2FkZXIvZnJhZ21lbnQtYWZ0ZXItcmVkaXJlY3QtZ2V0cy1iYWNrLWVudHJ5Lmh0bWwK KworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG cmFtZUxvYWRlcjo6bG9hZFVSTCk6IFByb3Blcmx5IHJlc2V0IHRoZSBwb2xpY3kgRnJhbWVMb2Fk VHlwZSBiZWZvcmUKKyAgICAgICAgICBjb25zdWx0aW5nIHRoZSBwb2xpY3kgZGVsZWdhdGUgZm9y IGZyYWdtZW50IHNjcm9sbGluZy4KKwogMjAwOS0wOS0yMiAgRGFyaW4gRmlzaGVyICA8ZGFyaW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5k ZXg6IFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDQ4NjA5KQorKysgV2ViQ29yZS9sb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzMzLDYgKzIzMzMsNyBAQCB2 b2lkIEZyYW1lTG9hZGVyOjpsb2FkVVJMKGNvbnN0IEtVUkwmIG5lCiAgICAgaWYgKHNob3VsZFNj cm9sbFRvQW5jaG9yKGlzRm9ybVN1Ym1pc3Npb24sIG5ld0xvYWRUeXBlLCBuZXdVUkwpKSB7CiAg ICAgICAgIG9sZERvY3VtZW50TG9hZGVyLT5zZXRUcmlnZ2VyaW5nQWN0aW9uKGFjdGlvbik7CiAg ICAgICAgIHN0b3BQb2xpY3lDaGVjaygpOworICAgICAgICBtX3BvbGljeUxvYWRUeXBlID0gbmV3 TG9hZFR5cGU7CiAgICAgICAgIGNoZWNrTmF2aWdhdGlvblBvbGljeShyZXF1ZXN0LCBvbGREb2N1 bWVudExvYWRlci5nZXQoKSwgZm9ybVN0YXRlLnJlbGVhc2UoKSwKICAgICAgICAgICAgIGNhbGxD b250aW51ZUZyYWdtZW50U2Nyb2xsQWZ0ZXJOYXZpZ2F0aW9uUG9saWN5LCB0aGlzKTsKICAgICB9 IGVsc2UgewpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDg2NDMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOS0yMiAgQnJhZHkgRWlk c29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQmFjayBsaXN0IGlzbid0IHByb3Blcmx5IHVwZGF0ZWQgZm9yIGZy YWdtZW50IGNoYW5nZXMgYWZ0ZXIgYSByZWRpcmVjdC4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzYxNDI4MDM+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAz NTUKKworICAgICAgICAqIGZhc3QvbG9hZGVyL2ZyYWdtZW50LWFmdGVyLXJlZGlyZWN0LWdldHMt YmFjay1lbnRyeS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbG9hZGVyL2Zy YWdtZW50LWFmdGVyLXJlZGlyZWN0LWdldHMtYmFjay1lbnRyeS5odG1sOiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2xvYWRlci9yZXNvdXJjZXMvY2xpY2stZnJhZ21lbnQtbGluay5odG1sOiBBZGRl ZC4KKworICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZWxhdGl2ZWFuY2hvci1mcmFt ZXMtZXhwZWN0ZWQudHh0OiBVcGRhdGVkIHJlc3VsdHMgKGEgcHJvZ3Jlc3Npb24hKQorCiAyMDA5 LTA5LTIyICBWaWN0b3IgV2FuZyAgPHZpY3RvcndAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbG9hZGVy L2ZyYWdtZW50LWFmdGVyLXJlZGlyZWN0LWdldHMtYmFjay1lbnRyeS1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvZnJhZ21lbnQtYWZ0ZXItcmVkaXJl Y3QtZ2V0cy1iYWNrLWVudHJ5LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3QvbG9hZGVyL2ZyYWdtZW50LWFmdGVyLXJlZGlyZWN0LWdldHMtYmFjay1lbnRyeS1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNiBAQAorQ2xpY2sgdGhpcyBsaW5r LCBhbmQgdGhlcmUgc2hvdWxkIGJlIGEgYmFjay1saXN0IGVudHJ5IGZvciB0aGUgcGFnZSB3aXRo b3V0IHRoZSBmcmFnbWVudCBJRC4KKworPT09PT09PT09PT09PT0gQmFjayBGb3J3YXJkIExpc3Qg PT09PT09PT09PT09PT0KKyAgICAgICAgKGZpbGUgdGVzdCk6ZmFzdC9sb2FkZXIvcmVzb3VyY2Vz L2NsaWNrLWZyYWdtZW50LWxpbmsuaHRtbCAgKipuYXYgdGFyZ2V0KioKK2N1cnItPiAgKGZpbGUg dGVzdCk6ZmFzdC9sb2FkZXIvcmVzb3VyY2VzL2NsaWNrLWZyYWdtZW50LWxpbmsuaHRtbCN0ZXN0 ZnJhZ21lbnQgICoqbmF2IHRhcmdldCoqCis9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvZnJhZ21lbnQt YWZ0ZXItcmVkaXJlY3QtZ2V0cy1iYWNrLWVudHJ5Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9sb2FkZXIvZnJhZ21lbnQtYWZ0ZXItcmVkaXJlY3QtZ2V0cy1iYWNrLWVudHJ5 Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9mcmFnbWVudC1h ZnRlci1yZWRpcmVjdC1nZXRzLWJhY2stZW50cnkuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwxMSBAQAorPHNjcmlwdD4KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewor CWxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKwlsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQmFja0ZvcndhcmRMaXN0KCk7CisJbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGls RG9uZSgpOworfQorCit3aW5kb3cubG9jYXRpb24ucmVwbGFjZSgncmVzb3VyY2VzL2NsaWNrLWZy YWdtZW50LWxpbmsuaHRtbCcpOworCis8L3NjcmlwdD4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv bG9hZGVyL3Jlc291cmNlcy9jbGljay1mcmFnbWVudC1saW5rLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvcmVzb3VyY2VzL2NsaWNrLWZyYWdtZW50LWxpbmsuaHRt bAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3Jlc291cmNlcy9jbGlj ay1mcmFnbWVudC1saW5rLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjIgQEAKKzxzY3Jp cHQ+CisKK2Z1bmN0aW9uIGxvYWRlZCgpIHsKKwlpZiAod2luZG93LmxheW91dFRlc3RDb250cm9s bGVyKSB7CisJCXZhciBlbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImZyYWdtZW50 bGluayIpOworCSAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhlbGVtZW50Lm9mZnNldExlZnQg KyAoZWxlbWVudC5vZmZzZXRXaWR0aCAvIDIpLCBlbGVtZW50Lm9mZnNldFRvcCArIChlbGVtZW50 Lm9mZnNldEhlaWdodCAvIDIpKTsKKwkgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisJICAg IGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKwl9Cit9CisKK2Z1bmN0aW9uIGhhc2hDaGFuZ2VkKCkK K3sKKwlpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorCQlsYXlvdXRUZXN0Q29udHJv bGxlci5ub3RpZnlEb25lKCk7Cit9CisKKzwvc2NyaXB0PgorPGJvZHkgb25oYXNoY2hhbmdlPSJo YXNoQ2hhbmdlZCgpOyIgb25sb2FkPSJsb2FkZWQoKTsiPgorPGEgaWQ9ImZyYWdtZW50bGluayIg aHJlZj0iI3Rlc3RmcmFnbWVudCI+Q2xpY2sgdGhpcyBsaW5rLCBhbmQgdGhlcmUgc2hvdWxkIGJl IGEgYmFjay1saXN0IGVudHJ5IGZvciB0aGUgcGFnZSB3aXRob3V0IHRoZSBmcmFnbWVudCBJRC48 L2E+Cis8L2JvZHk+Cis8aHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdh dGlvbi9yZWxhdGl2ZWFuY2hvci1mcmFtZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZWxhdGl2ZWFuY2hvci1mcmFtZXMtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiA0ODYwOSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2 aWdhdGlvbi9yZWxhdGl2ZWFuY2hvci1mcmFtZXMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkp CkBAIC0yLDcgKzIsMTAgQEAKIAogPT09PT09PT09PT09PT0gQmFjayBGb3J3YXJkIExpc3QgPT09 PT09PT09PT09PT0KICAgICAgICAgaHR0cDovLzEyNy4wLjAuMTo4MDAwL25hdmlnYXRpb24vcmVs YXRpdmVhbmNob3ItZnJhbWVzLmh0bWwgICoqbmF2IHRhcmdldCoqCi1jdXJyLT4gIGh0dHA6Ly8x MjcuMC4wLjE6ODAwMC9uYXZpZ2F0aW9uL3Jlc291cmNlcy9mcmFtZXNldC5wbD9mcmFtZVVSTD1z dWNjZXNzMjAwLmh0bWwgICoqbmF2IHRhcmdldCoqCisgICAgICAgIGh0dHA6Ly8xMjcuMC4wLjE6 ODAwMC9uYXZpZ2F0aW9uL3Jlc291cmNlcy9mcmFtZXNldC5wbD9mcmFtZVVSTD1zdWNjZXNzMjAw Lmh0bWwgICoqbmF2IHRhcmdldCoqCiAgICAgICAgICAgICBodHRwOi8vMTI3LjAuMC4xOjgwMDAv bmF2aWdhdGlvbi9yZXNvdXJjZXMvb3RoZXJwYWdlLmh0bWwgKGluIGZyYW1lICJmb290ZXIiKQog ICAgICAgICAgICAgaHR0cDovLzEyNy4wLjAuMTo4MDAwL25hdmlnYXRpb24vcmVzb3VyY2VzL3N1 Y2Nlc3MyMDAuaHRtbCAoaW4gZnJhbWUgIm1haW4iKQorY3Vyci0+ICBodHRwOi8vMTI3LjAuMC4x OjgwMDAvbmF2aWdhdGlvbi9yZXNvdXJjZXMvZnJhbWVzZXQucGw/ZnJhbWVVUkw9c3VjY2VzczIw MC5odG1sCisgICAgICAgICAgICBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdhdGlvbi9yZXNv dXJjZXMvb3RoZXJwYWdlLmh0bWwgKGluIGZyYW1lICJmb290ZXIiKQorICAgICAgICAgICAgaHR0 cDovLzEyNy4wLjAuMTo4MDAwL25hdmlnYXRpb24vcmVzb3VyY2VzL3N1Y2Nlc3MyMDAuaHRtbCNh bmNob3IxIChpbiBmcmFtZSAibWFpbiIpICAqKm5hdiB0YXJnZXQqKgogPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K