203549 2019-10-28 20:56:24 -0700 REGRESSION (r251413): Nightly build crashes on launch due to -[WKPreferences _setShouldAllowDesignSystemUIFonts:]: unrecognized selector 2019-10-29 16:41:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203129 InRadar P2 Normal --- 1 mitz mmaxfield commit-queue dino jonlee mitz mmaxfield simon.fraser thorton webkit-bug-importer oldest_to_newest 1584820 0 mitz 2019-10-28 20:56:24 -0700 r251413, the change made for bug 203129, removed a method used by the current version of Safari (version 13.0.2 (13608.2.40.1.3)), causing nightly builds to crash on launch: 2019-10-28 20:50:07.640 SafariForWebKitDevelopment[67089:31260958] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[WKPreferences _setShouldAllowDesignSystemUIFonts:]: unrecognized selector sent to instance 0x7fb3b7649220' *** First throw call stack: ( 0 CoreFoundation 0x00007fff4dc76e0b __exceptionPreprocess + 171 1 libobjc.A.dylib 0x00007fff753b0c76 objc_exception_throw + 48 2 CoreFoundation 0x00007fff4dd0f964 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132 3 CoreFoundation 0x00007fff4dbec6f0 ___forwarding___ + 1456 4 CoreFoundation 0x00007fff4dbec0b8 _CF_forwarding_prep_0 + 120 5 Safari 0x000000010c10ea15 -[WebKitPreferencesManager _initializeReaderPageGroupPreferencesManager] + 69 6 Safari 0x000000010c10c424 -[WebKitPreferencesManager _initWithPreferencesType:] + 291 7 Safari 0x000000010c10bb0a __61+[WebKitPreferencesManager readerPageGroupPreferencesManager]_block_invoke + 46 8 libdispatch.dylib 0x00007fff75f90db8 _dispatch_client_callout + 8 9 libdispatch.dylib 0x00007fff75f90d6b dispatch_once_f + 41 10 Safari 0x000000010c10bad9 +[WebKitPreferencesManager readerPageGroupPreferencesManager] + 45 11 Safari 0x000000010c26cae4 ___ZN6Safari16ReaderController15readerPageGroupEv_block_invoke + 48 1584824 1 mitz 2019-10-28 21:08:43 -0700 <rdar://problem/56696055> 1584946 2 mmaxfield 2019-10-29 09:43:28 -0700 *** Bug 203570 has been marked as a duplicate of this bug. *** 1584947 3 382189 mmaxfield 2019-10-29 09:44:11 -0700 Created attachment 382189 Patch 1584948 4 382189 mitz 2019-10-29 09:49:46 -0700 Comment on attachment 382189 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382189&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:129 > +@property (nonatomic, setter=_setShouldAllowDesignSystemUIFonts:) BOOL _shouldAllowDesignSystemUIFonts WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); This declaration isn’t necessary. 1585079 5 382189 commit-queue 2019-10-29 13:58:53 -0700 Comment on attachment 382189 Patch Clearing flags on attachment: 382189 Committed r251732: <https://trac.webkit.org/changeset/251732> 1585080 6 commit-queue 2019-10-29 13:58:55 -0700 All reviewed patches have been landed. Closing bug. 382189 2019-10-29 09:44:11 -0700 2019-10-29 13:58:53 -0700 Patch bug-203549-20191029094411.patch text/plain 3118 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdiZWVhNDhmODliMzI4YTM2 MDljNzhhNzYyZDYwM2MwZGE5YmI3YzIuLmMxMmZlNDQxMTY1NDZlYTU1MGVhNjY2MzNlN2YyMjVi Yjc0NjJlZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMTAtMjkgIE15bGVzIEMu IE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MjUxNDEzKTogTmlnaHRseSBidWlsZCBjcmFzaGVzIG9uIGxhdW5jaCBkdWUgdG8gLVtXS1ByZWZl cmVuY2VzIF9zZXRTaG91bGRBbGxvd0Rlc2lnblN5c3RlbVVJRm9udHM6XTogdW5yZWNvZ25pemVk IHNlbGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDM1NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICByMjUxNDEzIGRlbGV0ZWQgYW4gU1BJIHRoYXQgbmV3IFNhZmFyaSBzdG9wcGVkIGNhbGxpbmcu IEhvd2V2ZXIsCisgICAgICAgIG9sZCBTYWZhcmkgY29udGludWVzIHRvIGNhbGwgaXQuIFRoZSBz b2x1dGlvbiBpcyBqdXN0IHRvIGFkZCBzdHViCisgICAgICAgIGltcGxlbWVudGF0aW9ucyBzbyBv bGQgU2FmYXJpIGRvZXNuJ3QgZmFpbCB0byBsaW5rIGF0IHJ1bnRpbWUuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW06CisgICAgICAgICgtW1dLUHJlZmVy ZW5jZXMgX3Nob3VsZEFsbG93RGVzaWduU3lzdGVtVUlGb250c10pOgorICAgICAgICAoLVtXS1By ZWZlcmVuY2VzIF9zZXRTaG91bGRBbGxvd0Rlc2lnblN5c3RlbVVJRm9udHM6XSk6CisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oOgorCiAyMDE5LTEw LTI5ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNXUEUuY21ha2UgYW5kIE5FV1MgZm9yIHRoZSAy LjI3LjIgcmVsZWFzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLUHJlZmVyZW5jZXMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlcy5tbQppbmRleCBlYTEwNzNiMzRjNjQ1YmI1MjlkY2I5MzY2NmFiNmM3M2Nh YzJhMzkzLi4wMGM3YjcxYmVjZjRlOGJiZjViMDgyYjUyOTJiNWY4NDc5Yjk5MTZmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQpA QCAtNzEzLDYgKzcxMywxNyBAQCAtICh2b2lkKV9zZXRTaG91bGRBbGxvd1VzZXJJbnN0YWxsZWRG b250czooQk9PTClfc2hvdWxkQWxsb3dVc2VySW5zdGFsbGVkRm9udHMKICAgICBfcHJlZmVyZW5j ZXMtPnNldFNob3VsZEFsbG93VXNlckluc3RhbGxlZEZvbnRzKF9zaG91bGRBbGxvd1VzZXJJbnN0 YWxsZWRGb250cyk7CiB9CiAKKy0gKEJPT0wpX3Nob3VsZEFsbG93RGVzaWduU3lzdGVtVUlGb250 cworeworICAgIC8vIFRoZXNlIGZvbnRzIGFyZSBhbHdheXMgZW5hYmxlZC4gVGhpcyBmdW5jdGlv biBvbmx5IGV4aXN0cyBmb3IgYmluYXJ5IGNvbXBhdGliaWxpdHkuCisgICAgcmV0dXJuIFlFUzsK K30KKworLSAodm9pZClfc2V0U2hvdWxkQWxsb3dEZXNpZ25TeXN0ZW1VSUZvbnRzOihCT09MKV9z aG91bGRBbGxvd0Rlc2lnblN5c3RlbVVJRm9udHMKK3sKKyAgICAvLyBUaGVzZSBmb250cyBhcmUg YWx3YXlzIGVuYWJsZWQuIFRoaXMgZnVuY3Rpb24gb25seSBleGlzdHMgZm9yIGJpbmFyeSBjb21w YXRpYmlsaXR5LgorfQorCiBzdGF0aWMgX1dLRWRpdGFibGVMaW5rQmVoYXZpb3IgdG9BUEkoV2Vi Q29yZTo6RWRpdGFibGVMaW5rQmVoYXZpb3IgYmVoYXZpb3IpCiB7CiAgICAgc3dpdGNoIChiZWhh dmlvcikgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dL UHJlZmVyZW5jZXNQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlc1ByaXZhdGUuaAppbmRleCA1NjdmYzM1YmQxMTY1OTk1MmE0NzNmM2I1NmE2 MDgwY2YzMTdhY2VmLi4yNmZjYTdmMzA5NzhhOTM5ZjIxMDFjYzhjZTFkOTExYmYyODljZmZjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNl c1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVm ZXJlbmNlc1ByaXZhdGUuaApAQCAtMTI2LDYgKzEyNiw3IEBAIHR5cGVkZWYgTlNfRU5VTShOU0lu dGVnZXIsIF9XS0VkaXRhYmxlTGlua0JlaGF2aW9yKSB7CiBAcHJvcGVydHkgKG5vbmF0b21pYywg c2V0dGVyPV9zZXRET01QYXN0ZUFsbG93ZWQ6KSBCT09MIF9kb21QYXN0ZUFsbG93ZWQgV0tfQVBJ X0FWQUlMQUJMRShtYWNvcygxMC4xMyksIGlvcygxMS4wKSk7CiAKIEBwcm9wZXJ0eSAobm9uYXRv bWljLCBzZXR0ZXI9X3NldFNob3VsZEFsbG93VXNlckluc3RhbGxlZEZvbnRzOikgQk9PTCBfc2hv dWxkQWxsb3dVc2VySW5zdGFsbGVkRm9udHMgV0tfQVBJX0FWQUlMQUJMRShtYWNvcygxMC4xMy40 KSwgaW9zKDExLjMpKTsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldFNob3VsZEFs bG93RGVzaWduU3lzdGVtVUlGb250czopIEJPT0wgX3Nob3VsZEFsbG93RGVzaWduU3lzdGVtVUlG b250cyBXS19BUElfQVZBSUxBQkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkp OwogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRFZGl0YWJsZUxpbmtCZWhhdmlv cjopIF9XS0VkaXRhYmxlTGlua0JlaGF2aW9yIF9lZGl0YWJsZUxpbmtCZWhhdmlvciBXS19BUElf QVZBSUxBQkxFKG1hY29zKDEwLjEzLjQpLCBpb3MoMTEuMykpOwogCg==