203542 2019-10-28 16:27:31 -0700 Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-database.html is a flaky failure 2019-10-29 12:29:41 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney commit-queue ews-feeder tsavell webkit-bug-importer wilander oldest_to_newest 1584726 0 katherine_cheney 2019-10-28 16:27:31 -0700 http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-database.html is failing almost every other run. flakiness dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fwebsite-data-removal-for-site-navigated-to-with-link-decoration-database.html Currently unable to reproduce locally. Likely cause: scheduleStatisticsProcessingRequestIfNecessary() is messing with the callback in website-data-removal-for-site-navigated-to-with-link-decoration-database.html The test calls processStatisticsAndDataRecords() manually when it is finished making changes. 1584727 1 webkit-bug-importer 2019-10-28 16:28:09 -0700 <rdar://problem/56689764> 1584756 2 382140 katherine_cheney 2019-10-28 17:07:58 -0700 Created attachment 382140 Patch 1584758 3 382140 wilander 2019-10-28 17:11:16 -0700 Comment on attachment 382140 Patch LGTM 1584785 4 382140 ews-feeder 2019-10-28 18:12:20 -0700 Comment on attachment 382140 Patch Rejecting attachment 382140 from commit-queue. Katherine_cheney@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1584786 5 katherine_cheney 2019-10-28 18:14:02 -0700 Guess I'm still too early... 1584810 6 382140 ews-feeder 2019-10-28 19:59:31 -0700 Comment on attachment 382140 Patch Rejecting attachment 382140 from commit-queue. Katherine_cheney@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1584985 7 382140 ews-feeder 2019-10-29 11:16:43 -0700 Comment on attachment 382140 Patch Rejecting attachment 382140 from commit-queue. Katherine_cheney@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1584998 8 tsavell 2019-10-29 11:24:21 -0700 *** Bug 203576 has been marked as a duplicate of this bug. *** 1585027 9 382140 commit-queue 2019-10-29 12:29:40 -0700 Comment on attachment 382140 Patch Clearing flags on attachment: 382140 Committed r251719: <https://trac.webkit.org/changeset/251719> 1585028 10 commit-queue 2019-10-29 12:29:41 -0700 All reviewed patches have been landed. Closing bug. 382140 2019-10-28 17:07:58 -0700 2019-10-29 12:29:40 -0700 Patch bug-203542-20191028170758.patch text/plain 2050 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3OWYzMTkwNTJhMGQ5ZTgy NDIwZmE1OTJjNzcyZDM2NzUyMGZkMTEuLjQzZGJjNGQ4OWEwNGYxNmIzMGZmNmFjZmY1MmMwOGIz ZTJhODA0N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMTAtMjggIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3Qg aHR0cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL3dlYnNpdGUtZGF0YS1yZW1vdmFsLWZv ci1zaXRlLW5hdmlnYXRlZC10by13aXRoLWxpbmstZGVjb3JhdGlvbi1kYXRhYmFzZS5odG1sIGlz IGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAzNTQyI2FkZF9jb21tZW50CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjY4 OTc2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHRlc3Qgd2FzIGEgZmxha3kgZmFpbHVyZSBkdWUgdG8gaXRzIGNhbGxpbmcKKyAgICAgICAg c2NoZWR1bGVTdGF0aXN0aWNzUHJvY2Vzc2luZ1JlcXVlc3RJZk5lY2Vzc2FyeSgpIGFmdGVyIGxv Z2dpbmcgYSBjcm9zcworICAgICAgICBzaXRlIGxvYWQgd2l0aCBsaW5rIGRlY29yYXRpb24uIFRo aXMgY2FsbCBpcyBjdXJyZW50bHkgdW5lY2Vzc2FyeQorICAgICAgICBiZWNhdXNlIHRoaXMgZnVu Y3Rpb24gaXMgbm90IHlldCB1c2VkIHRvIGNsYXNzaWZ5IHJlc291cmNlcywgYW5kIGlzCisgICAg ICAgIGNhdXNpbmcgdGhlIHRlc3QgdG8gZXhlY3V0ZSBhIGNhbGxiYWNrIGJlZm9yZSBpdCBpcyBy ZWFkeS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2Fk U3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwOgorCiAyMDE5LTEwLTI4ICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBf V0tQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24gU1BJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNl U3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291 cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlLmNwcAppbmRleCA0YTAxYWMwOTExYzJmYzAy YzM5MmRiOGFhMTZjMGFjYTgzZmI4N2E1Li40MzI2ZjQzMzg5M2ZhZTJkN2ExMzNiNjMwZDVhYjJl ZmRiZDVkZGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNz aWZpZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNz RGF0YWJhc2VTdG9yZS5jcHAKQEAgLTE0MDIsOCArMTQwMiw2IEBAIHZvaWQgUmVzb3VyY2VMb2Fk U3RhdGlzdGljc0RhdGFiYXNlU3RvcmU6OmxvZ0Nyb3NzU2l0ZUxvYWRXaXRoTGlua0RlY29yYXRp b24oY29uCiAgICAgCiAgICAgaWYgKGlzUHJldmFsZW50UmVzb3VyY2UoZnJvbURvbWFpbikpCiAg ICAgICAgIHNldElzU2NoZWR1bGVkRm9yQWxsQnV0Q29va2llRGF0YVJlbW92YWwodG9Eb21haW4s IHRydWUpOwotICAgIAotICAgIHNjaGVkdWxlU3RhdGlzdGljc1Byb2Nlc3NpbmdSZXF1ZXN0SWZO ZWNlc3NhcnkoKTsKIH0KIAogdm9pZCBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9y ZTo6c2V0VXNlckludGVyYWN0aW9uKGNvbnN0IFJlZ2lzdHJhYmxlRG9tYWluJiBkb21haW4sIGJv b2wgaGFkVXNlckludGVyYWN0aW9uLCBXYWxsVGltZSBtb3N0UmVjZW50SW50ZXJhY3Rpb24pCg==