203521 2019-10-28 14:26:03 -0700 Fix a bug that cannot unhide a platform. 2022-02-09 10:14:13 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 dewei_zhu dewei_zhu dewei_zhu rniwa webkit-bug-importer oldest_to_newest 1584621 0 dewei_zhu 2019-10-28 14:26:03 -0700 Fix a bug that cannot unhide a platform. 1584624 1 382107 dewei_zhu 2019-10-28 14:28:24 -0700 Created attachment 382107 Patch 1584626 2 dewei_zhu 2019-10-28 14:30:02 -0700 <rdar://problem/43784654> 1584637 3 382107 rniwa 2019-10-28 14:35:36 -0700 Comment on attachment 382107 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382107&action=review > Websites/perf.webkit.org/public/admin/platforms.php:62 > - || update_field('platforms', 'platform', 'hidden')) > + || update_field('platforms', 'platform', 'hidden', Database::to_database_boolean(array_get($_POST, 'hidden')))) Can we add a helper function like update_boolean_field and do this work there? It's kind of silly to specify the updated field name twice. 382107 2019-10-28 14:28:24 -0700 2019-10-28 14:35:36 -0700 Patch bug-203521-20191028142823.patch text/plain 1689 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNjcxCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA3MTg2OGU4YjY2MWQzM2ZhMTA5ZTBlM2FlZmM4M2Y5ZDQ1Mzk3YTQ1Li42NmI1NWJmZWE3 NTZjNjY5Mzc5Nzg0YjhhNmMyODgzZWNjYzJlODUyIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0xMC0yOCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYSBidWcgdGhhdCBjYW5ub3QgdW5oaWRlIGEgcGxh dGZvcm0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDM1MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBC ZWZvcmUgdGhpcyBjaGFuZ2UsIHRoZSB0aGVyZSBpcyBubyB2YWx1ZSBpbiBQT1NUIHdoZW4gJ2hp ZGRlbicgY2hlY2tib3ggaXMgdW5jaGVja2VkLgorICAgICAgICBUaGVuIHRoZSB1cGRhdGUgd2ls bCBmYWlsIGJlY2F1c2UgcGxhdGZvcm1faGlkZGVuIGNhbm5vdCBiZSBOVUxMLgorCisgICAgICAg ICogcHVibGljL2FkbWluL3BsYXRmb3Jtcy5waHA6IFByb3ZpZGUgbmV3IHZhbHVlIHdoZW4gaGlk ZS91bmhpZGUgYSBwbGF0Zm9ybS4KKwogMjAxOS0xMC0yNSAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgU1NMIHN1cHBvcnQgZm9yIHBlZm9ybWFuY2UgZGFz aGJvYXJkIGRhdGFiYXNlIGNvbm5lY3Rpb24uCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvcHVibGljL2FkbWluL3BsYXRmb3Jtcy5waHAgYi9XZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvcHVibGljL2FkbWluL3BsYXRmb3Jtcy5waHAKaW5kZXggNWMwYjliZmFhMDNiZjk0YmRm YWRiN2VhNTcxNTViOTRhNmJmMWI3Ni4uZDQyODRiZDBlMjRhZTc5MjZmMDViYTIyMWZmYzMxNzVm NTViYmU2NCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9hZG1p bi9wbGF0Zm9ybXMucGhwCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvYWRt aW4vcGxhdGZvcm1zLnBocApAQCAtNTksNyArNTksNyBAQCBmdW5jdGlvbiBtZXJnZV9wbGF0Zm9y bXMoJHBsYXRmb3JtX3RvX21lcmdlLCAkZGVzdGluYXRpb25fcGxhdGZvcm0pIHsKIGlmICgkZGIp IHsKICAgICBpZiAoJGFjdGlvbiA9PSAndXBkYXRlJykgewogICAgICAgICBpZiAodXBkYXRlX2Zp ZWxkKCdwbGF0Zm9ybXMnLCAncGxhdGZvcm0nLCAnbmFtZScpCi0gICAgICAgICAgICB8fCB1cGRh dGVfZmllbGQoJ3BsYXRmb3JtcycsICdwbGF0Zm9ybScsICdoaWRkZW4nKSkKKyAgICAgICAgICAg IHx8IHVwZGF0ZV9maWVsZCgncGxhdGZvcm1zJywgJ3BsYXRmb3JtJywgJ2hpZGRlbicsIERhdGFi YXNlOjp0b19kYXRhYmFzZV9ib29sZWFuKGFycmF5X2dldCgkX1BPU1QsICdoaWRkZW4nKSkpKQog ICAgICAgICAgICAgcmVnZW5lcmF0ZV9tYW5pZmVzdCgpOwogICAgICAgICBlbHNlCiAgICAgICAg ICAgICBub3RpY2UoJ0ludmFsaWQgcGFyYW1ldGVycy4nKTsK