203519 2019-10-28 14:19:09 -0700 Move tracking and computation of timer heap current insertion order to ThreadTimers 2019-10-30 15:16:29 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 203586 1 dbates dbates aestes jer.noble webkit-bug-importer oldest_to_newest 1584613 0 dbates 2019-10-28 14:19:09 -0700 We track the heap insertion count (a simple counter, which may overflow, each time an entry is inserted) as a means to ensure that timers with the same firing time are ordered by insertion in the heap. Currently this count is a process-wide (i.e. globally unique across all threads). But it doesn't need to be and it increases the rate at which the count can overflow (since multiple threads can increment it). Architecturally it makes more sense for this count to move to per-thread storage. 1584629 1 382109 dbates 2019-10-28 14:32:00 -0700 Created attachment 382109 Patch 1585556 2 382109 dbates 2019-10-30 15:15:50 -0700 Comment on attachment 382109 Patch Clearing flags on attachment: 382109 Committed r251810: <https://trac.webkit.org/changeset/251810> 1585557 3 dbates 2019-10-30 15:15:51 -0700 All reviewed patches have been landed. Closing bug. 1585560 4 webkit-bug-importer 2019-10-30 15:16:29 -0700 <rdar://problem/56760431> 382109 2019-10-28 14:32:00 -0700 2019-10-30 15:15:50 -0700 Patch bug-203519-20191028143159.patch text/plain 3759 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGU4MGM4ZTU1MDUzODBk NTE2NjlhNzgyZGY2NzkzYzdiYjk4MmY4Yi4uZjQ2ZGU5MWIxYTFlODQ3Yzg2MzYwOTQyZGZhOWFk Nzg2ZjJiOTVjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDE5LTEwLTI4ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIHRyYWNraW5nIGFu ZCBjb21wdXRhdGlvbiBvZiB0aW1lciBoZWFwIGN1cnJlbnQgaW5zZXJ0aW9uIG9yZGVyIHRvIFRo cmVhZFRpbWVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAzNTE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRWFjaCB0aHJlYWQgbWFpbnRhaW5zIGl0cyBvd24gaGVhcCBvZiB0aW1lcnMuIFNvLCB0aGV5 IHNob3VsZCBhbHNvIG1haW50YWluIHRoZSBydW5uaW5nIGluc2VydGlvbiBjb3VudC4KKyAgICAg ICAgVGhlIHJ1bm5pbmcgaW5zZXJ0aW9uIGNvdW50IGlzIHVzZWQgdG8gZW5zdXJlIHRpbWVycyB3 aXRoIHRoZSBzYW1lIGZpcmluZyB0aW1lIGFyZSBvcmRlcmVkIGJ5IHdoZW4KKyAgICAgICAgdGhl eSB3ZXJlIGluc2VydGVkIGludG8gdGhlIGhlYXAuIFRoaXMgaXMgaW1wb3J0YW50IHRvIGVuc3Vy ZSB0aGF0IGNvZGUgbGlrZToKKworICAgICAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KGEs IDApCisgICAgICAgICAgICAgICAgd2luZG93LnNldFRpbWVvdXQoYiwgMCkKKworICAgICAgICBz Y2hlZHVsZSBhKCkgdG8gYmUgY2FsbGVkIGJlZm9yZSBiKCkgZXZlbiB0aG91Z2ggYm90aCBoYXMg dGhlIHNhbWUgZmlyaW5nIHRpbWUuCisKKyAgICAgICAgQ3VycmVudGx5IHRoZSBpbnNlcnRpb24g Y291bnQgaXMgcHJvY2Vzcy13aWRlLiBUaGF0IGlzLCBpdCBpcyBnbG9iYWxseSB1bmlxdWUgYWNy b3NzIGFsbCB0aHJlYWRzLiBUaGUKKyAgICAgICAgY3VycmVudCB3aWR0aCBvZiB0aGUgY291bnQg aXMgc2l6ZW9mKHVuc2lnbmVkKSBhbmQgc28gdGhlIG1vcmUgdGhyZWFkcyB0aGF0IGluY3JlbWVu dCBpdCB0aGUgZmFzdGVyIGl0CisgICAgICAgIGFwcHJvYWNoZXMgdGhlIHBvaW50IG9mIHdyYXBw aW5nIGFyb3VuZC4gVGhlIGN1cnJlbnQgY29kZSBjYW4gb25seSBlbnN1cmUgY29ycmVjdCB0aW1l ciBvcmRlcmluZyBpbiBhCisgICAgICAgIHdpbmRvdyBvZiBzaXplb2YodW5zaWduZWQpIC8gMiB0 aW1lcnMgKHNlZSBUaW1lckhlYXBMZXNzVGhhbkZ1bmN0aW9uOjpjb21wYXJlKE1vbm90b25pY1Rp bWUsIHVuc2lnbmVkLCBNb25vdG9uaWNUaW1lLCB1bnNpZ25lZCkpLgorICAgICAgICBXZSBjb3Vs ZCBzaW1wbHkgbGVhdmUgaXQgcHJvY2Vzcy13aWRlIGFuZCBpbmNyZWFzZXMgdGhlIHdpZHRoIHRv IDY0LWJpdHMsIGJ1dCBJIGZlbHQgaXQgbWFkZSBtb3JlCisgICAgICAgIHNlbnNlIGNvbmNlcHR1 YWxseSB0byBtb3ZlIHRoZSBjb3VudCB0byB0aGUgdGhyZWFkIGxvY2FsIHN0b3JhZ2UgYW5kIGJl IHdpdGggdGhlIHRpbWVyIGhlYXAgaXRzZWxmCisgICAgICAgIGRlc3BpdGUgdGhlIGV4dHJhIDQg Ynl0ZXMgcGVyIHRocmVhZCB0aGF0IGl0IGFkZHMuCisKKyAgICAgICAgKiBkb20vQWN0aXZlRE9N T2JqZWN0Lmg6CisgICAgICAgICogcGxhdGZvcm0vVGhyZWFkVGltZXJzLmg6CisgICAgICAgIChX ZWJDb3JlOjpUaHJlYWRUaW1lcnM6Om5leHRIZWFwSW5zZXJ0aW9uQ291bnQpOiBBZGRlZC4KKyAg ICAgICAgKiBwbGF0Zm9ybS9UaW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaW1lckJhc2U6 OnNldE5leHRGaXJlVGltZSk6CisKIDIwMTktMDktMTMgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNA YXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQgYnVpbGRpbmcgV2ViS2l0IGZvciBNYWMgQ2F0 YWx5c3QgZnJvbSBYY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVGhy ZWFkVGltZXJzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9UaHJlYWRUaW1lcnMuaAppbmRl eCA3YTExMTM4NjVhOGMzOTgwYzY2NGEzNTcxZTZkMzc1YTVlZDI3NDAwLi4yYzM0MmZhZGQ5OWE3 OTI2ODYyYzY0YzMyNmE4ODllOWMxZjcyNWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9UaHJlYWRUaW1lcnMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9UaHJl YWRUaW1lcnMuaApAQCAtNTYsNiArNTYsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCB1cGRhdGVTaGFy ZWRUaW1lcigpOwogICAgIHZvaWQgZmlyZVRpbWVyc0luTmVzdGVkRXZlbnRMb29wKCk7CiAKKyAg ICB1bnNpZ25lZCBuZXh0SGVhcEluc2VydGlvbkNvdW50KCkgeyByZXR1cm4gbV9jdXJyZW50SGVh cEluc2VydGlvbk9yZGVyKys7IH0KKwogcHJpdmF0ZToKICAgICB2b2lkIHNoYXJlZFRpbWVyRmly ZWRJbnRlcm5hbCgpOwogICAgIHZvaWQgZmlyZVRpbWVyc0luTmVzdGVkRXZlbnRMb29wSW50ZXJu YWwoKTsKQEAgLTYzLDYgKzY1LDcgQEAgcHJpdmF0ZToKICAgICBUaHJlYWRUaW1lckhlYXAgbV90 aW1lckhlYXA7CiAgICAgU2hhcmVkVGltZXIqIG1fc2hhcmVkVGltZXIgeyBudWxscHRyIH07IC8v IEV4dGVybmFsIG9iamVjdCwgY2FuIGJlIGEgcnVuIGxvb3Agb24gYSB3b3JrZXIgdGhyZWFkLiBO b3JtYWxseSBzZXQvcmVzZXQgYnkgd29ya2VyIHRocmVhZC4KICAgICBib29sIG1fZmlyaW5nVGlt ZXJzIHsgZmFsc2UgfTsgLy8gUmVlbnRyYW5jeSBndWFyZC4KKyAgICB1bnNpZ25lZCBtX2N1cnJl bnRIZWFwSW5zZXJ0aW9uT3JkZXIgeyAwIH07CiAgICAgTW9ub3RvbmljVGltZSBtX3BlbmRpbmdT aGFyZWRUaW1lckZpcmVUaW1lOwogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vVGltZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVGltZXIuY3BwCmluZGV4 IDJiNDYzNTE3OGQ5ZjEzNjZkYmVhMzUzNzViMjkyOGQ1N2I0MDRkNjguLjIwYWJiZDk1YWNlOWNj NGM5ZjliMTMzNzU5ODkwYjNjMzM4NDAwZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL1RpbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9UaW1lci5jcHAK QEAgLTQ4MSw5ICs0ODEsNyBAQCB2b2lkIFRpbWVyQmFzZTo6c2V0TmV4dEZpcmVUaW1lKE1vbm90 b25pY1RpbWUgbmV3VGltZSkKICAgICB9CiAKICAgICBpZiAob2xkVGltZSAhPSBuZXdUaW1lKSB7 Ci0gICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBwYXJ0IG9mIFRocmVhZFRpbWVycywg b3IgYW5vdGhlciBwZXItdGhyZWFkIHN0cnVjdHVyZS4KLSAgICAgICAgc3RhdGljIHN0ZDo6YXRv bWljPHVuc2lnbmVkPiBjdXJyZW50SGVhcEluc2VydGlvbk9yZGVyOwotICAgICAgICBhdXRvIG5l d09yZGVyID0gY3VycmVudEhlYXBJbnNlcnRpb25PcmRlcisrOworICAgICAgICBhdXRvIG5ld09y ZGVyID0gdGhyZWFkR2xvYmFsRGF0YSgpLnRocmVhZFRpbWVycygpLm5leHRIZWFwSW5zZXJ0aW9u Q291bnQoKTsKIAogICAgICAgICBpZiAoIW1faGVhcEl0ZW0pCiAgICAgICAgICAgICBtX2hlYXBJ dGVtID0gVGhyZWFkVGltZXJIZWFwSXRlbTo6Y3JlYXRlKCp0aGlzLCBuZXdUaW1lLCAwKTsK