203487 2019-10-28 07:11:43 -0700 [ews] Improve summary for CompileWebKit and CompileJSC build step 2019-10-28 07:58:14 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1584437 0 aakash_jain 2019-10-28 07:11:43 -0700 Improve summary for CompileWebKit step to make it more readable. Currently in case of failure it says: "Compiled WebKit (failure)". It should say something like: "Failed to compile WebKit". Similarly in case of failure, CompileJSC step currently says: "Compiled JSC (failure)". It should say something like: "Failed to compile JSC". 1584438 1 382068 aakash_jain 2019-10-28 07:13:37 -0700 Created attachment 382068 Patch 1584440 2 aakash_jain 2019-10-28 07:18:58 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/3/builds/132 1584443 3 aakash_jain 2019-10-28 07:58:00 -0700 Committed r251653: <https://trac.webkit.org/changeset/251653> 1584445 4 webkit-bug-importer 2019-10-28 07:58:14 -0700 <rdar://problem/56669358> 382068 2019-10-28 07:13:37 -0700 2019-10-28 07:41:28 -0700 Patch bug-203487-20191028101335.patch text/plain 3538 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTY1MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTEwLTI4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBJbXByb3ZlIHN1bW1hcnkgZm9yIENvbXBpbGVXZWJLaXQgYW5k IENvbXBpbGVKU0MgYnVpbGQgc3RlcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjAzNDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6Cisg ICAgICAgIChDb21waWxlV2ViS2l0LmdldFJlc3VsdFN1bW1hcnkpOiBNZXRob2QgdG8gZ2VuZXJh dGUgY3VzdG9tIHN0YXR1cyBtZXNzYWdlLgorICAgICAgICAoQ29tcGlsZUpTQy5nZXRSZXN1bHRT dW1tYXJ5KTogRGl0dG8uCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0 ZXBzX3VuaXR0ZXN0LnB5OiBVcGRhdGVkIHVuaXQtdGVzdHMuCisKIDIwMTktMTAtMjEgIEppZXdl biBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQXV0aG5dIFdhcm4g dXNlcnMgd2hlbiBtdWx0aXBsZSBORkMgdGFncyBwcmVzZW50CkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNTE2NTIpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAg LTgyOCw2ICs4MjgsMTEgQEAgY2xhc3MgQ29tcGlsZVdlYktpdChzaGVsbC5Db21waWxlKToKIAog ICAgICAgICByZXR1cm4gc3VwZXIoQ29tcGlsZVdlYktpdCwgc2VsZikuZXZhbHVhdGVDb21tYW5k KGNtZCkKIAorICAgIGRlZiBnZXRSZXN1bHRTdW1tYXJ5KHNlbGYpOgorICAgICAgICBpZiBzZWxm LnJlc3VsdHMgPT0gRkFJTFVSRToKKyAgICAgICAgICAgIHJldHVybiB7dSdzdGVwJzogdSdGYWls ZWQgdG8gY29tcGlsZSBXZWJLaXQnfQorICAgICAgICByZXR1cm4gc2hlbGwuQ29tcGlsZS5nZXRS ZXN1bHRTdW1tYXJ5KHNlbGYpCisKIAogY2xhc3MgQ29tcGlsZVdlYktpdFRvVChDb21waWxlV2Vi S2l0KToKICAgICBuYW1lID0gJ2NvbXBpbGUtd2Via2l0LXRvdCcKQEAgLTg4NCw2ICs4ODksMTEg QEAgY2xhc3MgQ29tcGlsZUpTQyhDb21waWxlV2ViS2l0KToKICAgICAgICAgc2VsZi5zZXRQcm9w ZXJ0eSgnZ3JvdXAnLCAnanNjJykKICAgICAgICAgcmV0dXJuIENvbXBpbGVXZWJLaXQuc3RhcnQo c2VsZikKIAorICAgIGRlZiBnZXRSZXN1bHRTdW1tYXJ5KHNlbGYpOgorICAgICAgICBpZiBzZWxm LnJlc3VsdHMgPT0gRkFJTFVSRToKKyAgICAgICAgICAgIHJldHVybiB7dSdzdGVwJzogdSdGYWls ZWQgdG8gY29tcGlsZSBKU0MnfQorICAgICAgICByZXR1cm4gc2hlbGwuQ29tcGlsZS5nZXRSZXN1 bHRTdW1tYXJ5KHNlbGYpCisKIAogY2xhc3MgQ29tcGlsZUpTQ1RvVChDb21waWxlSlNDKToKICAg ICBuYW1lID0gJ2NvbXBpbGUtanNjLXRvdCcKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI1MTY1MikK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQko d29ya2luZyBjb3B5KQpAQCAtODMxLDcgKzgzMSw3IEBAIGNsYXNzIFRlc3RDb21waWxlV2ViS2l0 KEJ1aWxkU3RlcE1peGluQWQKICAgICAgICAgICAgICsgRXhwZWN0U2hlbGwubG9nKCdzdGRpbycs IHN0ZG91dD0nMSBlcnJvciBnZW5lcmF0ZWQuJykKICAgICAgICAgICAgICsgMiwKICAgICAgICAg KQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmlu Zz0nQ29tcGlsZWQgV2ViS2l0IChmYWlsdXJlKScpCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29t ZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5nPSdGYWlsZWQgdG8gY29tcGlsZSBXZWJLaXQn KQogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAogCkBAIC04NzEsNyArODcxLDcgQEAg Y2xhc3MgVGVzdENvbXBpbGVXZWJLaXRUb1QoQnVpbGRTdGVwTWl4aQogICAgICAgICAgICAgKyBF eHBlY3RTaGVsbC5sb2coJ3N0ZGlvJywgc3Rkb3V0PScxIGVycm9yIGdlbmVyYXRlZC4nKQogICAg ICAgICAgICAgKyAyLAogICAgICAgICApCi0gICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1 bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5nPSdDb21waWxlZCBXZWJLaXQgKGZhaWx1cmUpJykKKyAg ICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J0Zh aWxlZCB0byBjb21waWxlIFdlYktpdCcpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQog CiAgICAgZGVmIHRlc3Rfc2tpcChzZWxmKToKQEAgLTk0NCw3ICs5NDQsNyBAQCBjbGFzcyBUZXN0 Q29tcGlsZUpTQyhCdWlsZFN0ZXBNaXhpbkFkZGl0CiAgICAgICAgICAgICArIEV4cGVjdFNoZWxs LmxvZygnc3RkaW8nLCBzdGRvdXQ9JzEgZXJyb3IgZ2VuZXJhdGVkLicpCiAgICAgICAgICAgICAr IDIsCiAgICAgICAgICkKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJF LCBzdGF0ZV9zdHJpbmc9J0NvbXBpbGVkIEpTQyAoZmFpbHVyZSknKQorICAgICAgICBzZWxmLmV4 cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nRmFpbGVkIHRvIGNvbXBp bGUgSlNDJykKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKIApAQCAtOTgzLDcgKzk4 Myw3IEBAIGNsYXNzIFRlc3RDb21waWxlSlNDVG9UKEJ1aWxkU3RlcE1peGluQWQKICAgICAgICAg ICAgICsgRXhwZWN0U2hlbGwubG9nKCdzdGRpbycsIHN0ZG91dD0nMSBlcnJvciBnZW5lcmF0ZWQu JykKICAgICAgICAgICAgICsgMiwKICAgICAgICAgKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNv bWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nQ29tcGlsZWQgSlNDIChmYWlsdXJlKScp CisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5n PSdGYWlsZWQgdG8gY29tcGlsZSBKU0MnKQogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkK IAogCg==