203486 2019-10-28 06:53:40 -0700 dumpSpeculation in SpeculatedType.cpp prints to the wrong stream and has wrong capitalization for NaN 2019-10-28 13:28:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Trivial --- 1 tuomas.webkit webkit-unassigned commit-queue ews-watchlist keith_miller koivisto mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1584434 0 tuomas.webkit 2019-10-28 06:53:40 -0700 in void dumpSpeculation(PrintStream& outStream, SpeculatedType value) in SpeculatedType.cpp, "DoubleImpureNan" is printed to out when it should be printed to strOut. also DoubleImpureNan and DoublePureNan should both end with a capital N. 1584435 1 382067 tuomas.webkit 2019-10-28 06:58:05 -0700 Created attachment 382067 proposed patch 1584573 2 382067 commit-queue 2019-10-28 13:21:55 -0700 Comment on attachment 382067 proposed patch Clearing flags on attachment: 382067 Committed r251667: <https://trac.webkit.org/changeset/251667> 1584574 3 commit-queue 2019-10-28 13:21:56 -0700 All reviewed patches have been landed. Closing bug. 1584580 4 webkit-bug-importer 2019-10-28 13:28:52 -0700 <rdar://problem/56682260> 382067 2019-10-28 06:58:05 -0700 2019-10-28 13:21:55 -0700 proposed patch webkit_203486.patch text/plain 1409 tuomas.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNmNDU4ZTQzMzY0Li4xMTdjZjAwZDU5ZCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMTAtMjggIFR1b21h cyBLYXJra2FpbmVuICA8dHVvbWFzLndlYmtpdEBhcHBsZS5jb20+CisKKyAgICAgICAgZHVtcFNw ZWN1bGF0aW9uIGluIFNwZWN1bGF0ZWRUeXBlLmNwcCBwcmludHMgdG8gdGhlIHdyb25nIHN0cmVh bSBhbmQgaGFzIHdyb25nIGNhcGl0YWxpemF0aW9uIGZvciBOYU4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzQ4NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYnl0ZWNvZGUvU3BlY3VsYXRlZFR5cGUu Y3BwOgorICAgICAgICAoSlNDOjpkdW1wU3BlY3VsYXRpb24pOgorCiAyMDE5LTEwLTI2ICBDaHJp cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBQdXQgT2Zmc2NyZWVuQ2FudmFz IGJlaGluZCBhIGJ1aWxkIGZsYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29kZS9TcGVjdWxhdGVkVHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvU3BlY3VsYXRlZFR5cGUuY3BwCmluZGV4IGEzMjViMmM4MWJjLi44NDQzOGUzOTM1ZSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1NwZWN1bGF0ZWRUeXBlLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3BlY3VsYXRlZFR5cGUuY3Bw CkBAIC0yNjgsMTMgKzI2OCwxMyBAQCB2b2lkIGR1bXBTcGVjdWxhdGlvbihQcmludFN0cmVhbSYg b3V0U3RyZWFtLCBTcGVjdWxhdGVkVHlwZSB2YWx1ZSkKICAgICAgICAgICAgIGlzVG9wID0gZmFs c2U7CiAgICAgICAgIAogICAgICAgICBpZiAodmFsdWUgJiBTcGVjRG91YmxlUHVyZU5hTikKLSAg ICAgICAgICAgIHN0ck91dC5wcmludCgiRG91YmxlUHVyZU5hbiIpOworICAgICAgICAgICAgc3Ry T3V0LnByaW50KCJEb3VibGVQdXJlTmFOIik7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGlz VG9wID0gZmFsc2U7CiAgICAgfQogICAgIAogICAgIGlmICh2YWx1ZSAmIFNwZWNEb3VibGVJbXB1 cmVOYU4pCi0gICAgICAgIG91dC5wcmludCgiRG91YmxlSW1wdXJlTmFuIik7CisgICAgICAgIHN0 ck91dC5wcmludCgiRG91YmxlSW1wdXJlTmFOIik7CiAgICAgCiAgICAgaWYgKHZhbHVlICYgU3Bl Y0Jvb2xlYW4pCiAgICAgICAgIHN0ck91dC5wcmludCgiQm9vbCIpOwo=