203461 2019-10-26 10:14:35 -0700 REGRESSION(2.27.2): [GTK] Overview item remove button broken 2019-10-30 00:57:10 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned aperez berto bugs-noreply cgarcia ews-watchlist gustavo oldest_to_newest 1584250 0 mcatanzaro 2019-10-26 10:14:35 -0700 Since upgrading Tech Preview from 2.26.1 -> 2.27.2, the remove button for about:overview overview items is broken. We see a broken image placeholder instead of the proper remove icon. Normally I'd check the web inspector for hints, but the web inspector is itself still broken (bug #202321, pending new shared-mime-info release), so no hints. 1584883 1 cgarcia 2019-10-29 04:07:11 -0700 This is a regression of the switch to new custom protocols implementation. Epiphany is passing NULL as content type of ephy-resource requests, in which case we should try to guess the mime type, but we are not doing it. 1584885 2 382175 cgarcia 2019-10-29 04:09:02 -0700 Created attachment 382175 Patch 1584886 3 ews-watchlist 2019-10-29 04:09:38 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1585296 4 cgarcia 2019-10-30 00:57:10 -0700 Committed r251769: <https://trac.webkit.org/changeset/251769> 382175 2019-10-29 04:09:02 -0700 2019-10-29 06:17:08 -0700 Patch wk2-custom-protocol-no-mime.diff text/plain 2152 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNjkyYzE5YzUxZmYuLjFhYWRhNTBlMTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDE5LTEwLTI5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKDIuMjcuMik6IFtHVEtdIE92ZXJ2aWV3IGl0ZW0g cmVtb3ZlIGJ1dHRvbiBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwMzQ2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgaXMgYSByZWdyZXNzaW9uIG9mIHRoZSBzd2l0Y2ggdG8gbmV3IGN1 c3RvbSBwcm90b2NvbHMgaW1wbGVtZW50YXRpb24uIEVwaXBoYW55IGlzIHBhc3NpbmcgTlVMTCBh cyBjb250ZW50CisgICAgICAgIHR5cGUgb2YgZXBoeS1yZXNvdXJjZSByZXF1ZXN0cywgaW4gd2hp Y2ggY2FzZSB3ZSBzaG91bGQgdHJ5IHRvIGd1ZXNzIHRoZSBtaW1lIHR5cGUsIGJ1dCB3ZSBhcmUg bm90IGRvaW5nIGl0LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVSSVNj aGVtZVJlcXVlc3QuY3BwOgorICAgICAgICAod2Via2l0VVJJU2NoZW1lUmVxdWVzdFJlYWRDYWxs YmFjayk6IFVzZSBNSU1FVHlwZVJlZ2lzdHJ5IHRvIGd1ZXNzIHRoZSBtaW1lIHR5cGUgd2hlbiBj b250ZW50IHR5cGUgaXMgbnVsbHB0ciwKKyAgICAgICAgbGlrZSBOZXR3b3JrRGF0YVRhc2sgZG9l cy4KKwogMjAxOS0xMC0yOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXBsYWNlIEludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLm5vZGVB dFBvc2l0aW9uSXNGb2N1c2VkRWxlbWVudCB3aXRoIGFuIGVsZW1lbnQgY29udGV4dApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0VVJJU2NoZW1lUmVx dWVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVUklTY2hl bWVSZXF1ZXN0LmNwcAppbmRleCBkODA4NmRiMzcwYi4uNGYxMTg1NDQ1MDUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVSSVNjaGVtZVJlcXVlc3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVSSVNjaGVt ZVJlcXVlc3QuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSAiV2ViUGFnZVByb3h5Lmgi CiAjaW5jbHVkZSA8V2ViQ29yZS9HVW5pcXVlUHRyU291cC5oPgogI2luY2x1ZGUgPFdlYkNvcmUv SFRUUFBhcnNlcnMuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL01JTUVUeXBlUmVnaXN0cnkuaD4KICNp bmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlRXJyb3IuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1VSTFNv dXAuaD4KICNpbmNsdWRlIDxsaWJzb3VwL3NvdXAuaD4KQEAgLTE4MSw2ICsxODIsOCBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRVUklTY2hlbWVSZXF1ZXN0UmVhZENhbGxiYWNrKEdJbnB1dFN0cmVhbSog aW5wdXRTdHJlYW0sIEdBc3luYwogICAgIGlmICghcHJpdi0+Ynl0ZXNSZWFkKSB7CiAgICAgICAg IFJlc291cmNlUmVzcG9uc2UgcmVzcG9uc2UocHJpdi0+dGFzay0+cmVxdWVzdCgpLnVybCgpLCBl eHRyYWN0TUlNRVR5cGVGcm9tTWVkaWFUeXBlKHByaXYtPmNvbnRlbnRUeXBlLmRhdGEoKSksIHBy aXYtPnN0cmVhbUxlbmd0aCwgZW1wdHlTdHJpbmcoKSk7CiAgICAgICAgIHJlc3BvbnNlLnNldFRl eHRFbmNvZGluZ05hbWUoZXh0cmFjdENoYXJzZXRGcm9tTWVkaWFUeXBlKHByaXYtPmNvbnRlbnRU eXBlLmRhdGEoKSkpOworICAgICAgICBpZiAocmVzcG9uc2UubWltZVR5cGUoKS5pc0VtcHR5KCkp CisgICAgICAgICAgICByZXNwb25zZS5zZXRNaW1lVHlwZShNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRN SU1FVHlwZUZvclBhdGgocmVzcG9uc2UudXJsKCkucGF0aCgpKSk7CiAgICAgICAgIHByaXYtPnRh c2stPmRpZFJlY2VpdmVSZXNwb25zZShyZXNwb25zZSk7CiAgICAgfQogCg==