20345 2008-08-11 08:16:11 -0700 Error bubbles are clobbered when syntax highlighting JavaScript resources 2008-08-11 18:39:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P1 Major --- 1 timothy timothy oldest_to_newest 88218 0 timothy 2008-08-11 08:16:11 -0700 If a JavaScript resource has an error bubble the bubble text will be syntax highlighted too, and the bubble will be clobbered. 88219 1 22728 timothy 2008-08-11 08:21:30 -0700 Created attachment 22728 Proposed patch 88222 2 22728 aroben 2008-08-11 08:47:20 -0700 Comment on attachment 22728 Proposed patch r=me Yay for tests! 88223 3 timothy 2008-08-11 09:54:51 -0700 Landed in r35664. 88249 4 mrowe 2008-08-11 17:05:56 -0700 Should this be closed now? 22728 2008-08-11 08:21:30 -0700 2008-08-11 08:47:20 -0700 Proposed patch 0001-Fixes-a-bug-where-error-bubbles-in-JavaScrip.patch text/plain 5344 timothy RnJvbSBkOTBlMzY1MjAzYThmOTNlNzFjYzJkMDBiZjI3OGQ1MGRkNWU2MDM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBNb24sIDExIEF1ZyAyMDA4IDA4OjIwOjI4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBGaXhlcyBhIGJ1ZyB3aGVyZSBlcnJvciBidWJibGVzIGluIEphdmFTY3JpcHQgcmVzb3Vy Y2VzIHdvdWxkCiAgICAgICAgIGJlIGNsb2JiZXJlZCBieSB0aGUgc3ludGF4IGhpZ2hsaWdodGVy LgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNDUK CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogbWFudWFsLXRl c3RzL2luc3BlY3Rvci9yZXNvdXJjZXMvc2NyaXB0LWVycm9yLmpzOiBBZGRlZC4KICAgICAgICAq IG1hbnVhbC10ZXN0cy9pbnNwZWN0b3Ivc3R5bGVkLWVycm9yLWJ1YmJsZXMtaW4tc2NyaXB0cy5o dG1sOiBBZGRlZC4KICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL1NvdXJjZUZyYW1lLmpzOgogICAg ICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlLl9hZGRNZXNzYWdlVG9Tb3Vy Y2UpOgogICAgICAgIENoZWNrIHRoZSBub2RlVHlwZSBhbmQgbm90IHRoZSBub2RlTmFtZSwgdGhp cyBpcyBsZXNzIGZyYWdpbGUuCiAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90 b3R5cGUuX3N5bnRheEhpZ2hsaWdodEphdmFzY3JpcHRMaW5lKToKICAgICAgICBDaGVjayBpZiB0 aGUgbGFzdENoaWxkIGlzIGFuIGVycm9yIGJ1YmJsZSwgaWYgc28gcmVtb3ZlIGl0IGJlZm9yZQog ICAgICAgIGdldHRpbmcgdGhlIGxpbmUncyB0ZXh0Q29udGVudC4gQWRkIHRoZSBlcnJvciBidWJi bGUgYmFjayBhdCB0aGUgZW5kLgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxOCArKysrKysrKysrKysrKysrKysKIC4uLi9pbnNwZWN0 b3IvcmVzb3VyY2VzL3NjcmlwdC1lcnJvci5qcyAgICAgICAgICAgIHwgICAgNiArKysrKysKIC4u Li9pbnNwZWN0b3Ivc3R5bGVkLWVycm9yLWJ1YmJsZXMtaW4tc2NyaXB0cy5odG1sIHwgICAgNiAr KysrKysKIFdlYkNvcmUvcGFnZS9pbnNwZWN0b3IvU291cmNlRnJhbWUuanMgICAgICAgICAgICAg IHwgICAxNSArKysrKysrKysrKysrLS0KIDQgZmlsZXMgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBXZWJDb3JlL21hbnVhbC10ZXN0 cy9pbnNwZWN0b3IvcmVzb3VyY2VzL3NjcmlwdC1lcnJvci5qcwogY3JlYXRlIG1vZGUgMTAwNjQ0 IFdlYkNvcmUvbWFudWFsLXRlc3RzL2luc3BlY3Rvci9zdHlsZWQtZXJyb3ItYnViYmxlcy1pbi1z Y3JpcHRzLmh0bWwKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDNjYWFmMjkuLjVmOWY4Y2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMDgtMTEg IFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIEZpeGVzIGEg YnVnIHdoZXJlIGVycm9yIGJ1YmJsZXMgaW4gSmF2YVNjcmlwdCByZXNvdXJjZXMgd291bGQKKyAg ICAgICAgYmUgY2xvYmJlcmVkIGJ5IHRoZSBzeW50YXggaGlnaGxpZ2h0ZXIuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzQ1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvaW5z cGVjdG9yL3Jlc291cmNlcy9zY3JpcHQtZXJyb3IuanM6IEFkZGVkLgorICAgICAgICAqIG1hbnVh bC10ZXN0cy9pbnNwZWN0b3Ivc3R5bGVkLWVycm9yLWJ1YmJsZXMtaW4tc2NyaXB0cy5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9Tb3VyY2VGcmFtZS5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuX2FkZE1lc3NhZ2VUb1NvdXJjZSk6 CisgICAgICAgIENoZWNrIHRoZSBub2RlVHlwZSBhbmQgbm90IHRoZSBub2RlTmFtZSwgdGhpcyBp cyBsZXNzIGZyYWdpbGUuCisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90 eXBlLl9zeW50YXhIaWdobGlnaHRKYXZhc2NyaXB0TGluZSk6CisgICAgICAgIENoZWNrIGlmIHRo ZSBsYXN0Q2hpbGQgaXMgYW4gZXJyb3IgYnViYmxlLCBpZiBzbyByZW1vdmUgaXQgYmVmb3JlCisg ICAgICAgIGdldHRpbmcgdGhlIGxpbmUncyB0ZXh0Q29udGVudC4gQWRkIHRoZSBlcnJvciBidWJi bGUgYmFjayBhdCB0aGUgZW5kLgorCiAyMDA4LTA4LTA4ICBCZXRoIERha2luICA8YmRha2luQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvbWFudWFsLXRlc3RzL2luc3BlY3Rvci9yZXNvdXJjZXMvc2NyaXB0LWVycm9yLmpzIGIvV2Vi Q29yZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlcy9zY3JpcHQtZXJyb3IuanMKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYmMxYzI3MAotLS0gL2Rldi9udWxsCisr KyBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL2luc3BlY3Rvci9yZXNvdXJjZXMvc2NyaXB0LWVycm9y LmpzCkBAIC0wLDAgKzEsNiBAQAordmFyIHRlc3QgPSBkb2N1bWVudC5ib2R5OwordGhpcy53aWxs LmJlLmFuLmVycm9yID0gMTsKKworZnVuY3Rpb24gdGVzdCgpIHsKKwlyZXR1cm4gNDI7Cit9CmRp ZmYgLS1naXQgYS9XZWJDb3JlL21hbnVhbC10ZXN0cy9pbnNwZWN0b3Ivc3R5bGVkLWVycm9yLWJ1 YmJsZXMtaW4tc2NyaXB0cy5odG1sIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL3N0 eWxlZC1lcnJvci1idWJibGVzLWluLXNjcmlwdHMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi4wMDQ5Y2VmCi0tLSAvZGV2L251bGwKKysrIGIvV2ViQ29yZS9tYW51YWwt dGVzdHMvaW5zcGVjdG9yL3N0eWxlZC1lcnJvci1idWJibGVzLWluLXNjcmlwdHMuaHRtbApAQCAt MCwwICsxLDYgQEAKKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvc2NyaXB0LWVycm9yLmpzIj48L3Nj cmlwdD4KKzxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDM0NSI+QnVnIDE5MDY1OgorRXJyb3IgYnViYmxlcyBhcmUgY2xvYmJlcmVk IHdoZW4gc3ludGF4IGhpZ2hsaWdodGluZyBKYXZhU2NyaXB0IHJlc291cmNlczwvYT4uPC9wPgor PHA+VG8gdGVzdCwgb3BlbiB0aGUgSW5zcGVjdG9yLiBUaGVyZSBzaG91bGQgYmUgYSByZWQgYnVi YmxlIHdpdGggdGhlIG51bWJlciAiMSIKK2luIGl0IG5leHQgdG8gdGhlIHRoZSBvbmx5IHNjcmlw dCByZXNvdXJjZSBpbiB0aGUgUmVzb3VyY2VzIHBhbmVsLiBDbGlja2luZyB0aGUKK3Jlc291cmNl IHNob3VsZCBzaG93IHN5bnRheCBoaWdobGlnaHRlZCBKYXZhU2NyaXB0IHdpdGggYSByZWQgZXJy b3IgYnViYmxlLjwvcD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvU291cmNl RnJhbWUuanMgYi9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL1NvdXJjZUZyYW1lLmpzCmluZGV4IDMy ODIwMjkuLmU4MWE0MGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvU291cmNl RnJhbWUuanMKKysrIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9Tb3VyY2VGcmFtZS5qcwpAQCAt MzMzLDcgKzMzMyw3IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAg ICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgdmFyIGVycm9yRGl2ID0gY2VsbC5sYXN0Q2hp bGQ7Ci0gICAgICAgIGlmICghZXJyb3JEaXYgfHwgZXJyb3JEaXYubm9kZU5hbWUudG9Mb3dlckNh c2UoKSAhPT0gImRpdiIgfHwgIWVycm9yRGl2Lmhhc1N0eWxlQ2xhc3MoIndlYmtpdC1odG1sLW1l c3NhZ2UtYnViYmxlIikpIHsKKyAgICAgICAgaWYgKCFlcnJvckRpdiB8fCBlcnJvckRpdi5ub2Rl VHlwZSAhPT0gTm9kZS5FTEVNRU5UX05PREUgfHwgIWVycm9yRGl2Lmhhc1N0eWxlQ2xhc3MoIndl YmtpdC1odG1sLW1lc3NhZ2UtYnViYmxlIikpIHsKICAgICAgICAgICAgIGVycm9yRGl2ID0gdGhp cy5lbGVtZW50LmNvbnRlbnREb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAgICAg ICAgIGVycm9yRGl2LmNsYXNzTmFtZSA9ICJ3ZWJraXQtaHRtbC1tZXNzYWdlLWJ1YmJsZSI7CiAg ICAgICAgICAgICBjZWxsLmFwcGVuZENoaWxkKGVycm9yRGl2KTsKQEAgLTQ3Miw4ICs0NzIsMTYg QEAgV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZSA9IHsKICAgICBfc3ludGF4SGln aGxpZ2h0SmF2YXNjcmlwdExpbmU6IGZ1bmN0aW9uKGxpbmUsIHByZXZMaW5lKQogICAgIHsKICAg ICAgICAgdmFyIHByZXZpb3VzTWF0Y2hMZW5ndGggPSAwOworCisgICAgICAgIHZhciBtZXNzYWdl QnViYmxlID0gbGluZS5sYXN0Q2hpbGQ7CisgICAgICAgIGlmIChtZXNzYWdlQnViYmxlICYmIG1l c3NhZ2VCdWJibGUubm9kZVR5cGUgPT09IE5vZGUuRUxFTUVOVF9OT0RFICYmIG1lc3NhZ2VCdWJi bGUuaGFzU3R5bGVDbGFzcygid2Via2l0LWh0bWwtbWVzc2FnZS1idWJibGUiKSkKKyAgICAgICAg ICAgIGxpbmUucmVtb3ZlQ2hpbGQobWVzc2FnZUJ1YmJsZSk7CisgICAgICAgIGVsc2UKKyAgICAg ICAgICAgIG1lc3NhZ2VCdWJibGUgPSBudWxsOworCiAgICAgICAgIHZhciBjb2RlID0gbGluZS50 ZXh0Q29udGVudDsKLSAgICAgICAgd2hpbGUgKGxpbmUuaGFzQ2hpbGROb2RlcygpKQorCisgICAg ICAgIHdoaWxlIChsaW5lLmZpcnN0Q2hpbGQpCiAgICAgICAgICAgICBsaW5lLnJlbW92ZUNoaWxk KGxpbmUuZmlyc3RDaGlsZCk7CiAKICAgICAgICAgZnVuY3Rpb24gY3JlYXRlU3Bhbihjb250ZW50 LCBjbGFzc05hbWUpCkBAIC01OTMsNiArNjAxLDkgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1l LnByb3RvdHlwZSA9IHsKIAogICAgICAgICBpZiAodG1wIDwgY29kZS5sZW5ndGgpCiAgICAgICAg ICAgICBsaW5lLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKGNvZGUuc3Vic3Ry aW5nKHRtcCwgaSkpKTsKKworICAgICAgICBpZiAobWVzc2FnZUJ1YmJsZSkKKyAgICAgICAgICAg IGxpbmUuYXBwZW5kQ2hpbGQobWVzc2FnZUJ1YmJsZSk7CiAgICAgfSwKIAogICAgIHN5bnRheEhp Z2hsaWdodEphdmFzY3JpcHQ6IGZ1bmN0aW9uKCkKLS0gCjEuNS40LjQKCg==