203434 2019-10-25 14:26:05 -0700 Web Inspector: Right-clicking in color picker should not select color 2019-10-28 16:25:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1584010 0 nvasilyev 2019-10-25 14:26:05 -0700 It should show a context menu. This is NOT a regression. It's been like this for years. 1584012 1 381967 nvasilyev 2019-10-25 14:30:29 -0700 Created attachment 381967 Patch 1584015 2 381967 hi 2019-10-25 14:36:10 -0700 Comment on attachment 381967 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381967&action=review rs=me > Source/WebInspectorUI/UserInterface/Views/ColorSquare.js:152 > + if (event.button !== 0 || event.ctrlKey) Does this work for non-macOS systems too? Should it only check for `event.ctrlKey` if `WI.Platform.name === "mac"`? 1584023 3 nvasilyev 2019-10-25 14:50:24 -0700 (In reply to Devin Rousso from comment #2) > Comment on attachment 381967 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381967&action=review > > rs=me > > > Source/WebInspectorUI/UserInterface/Views/ColorSquare.js:152 > > + if (event.button !== 0 || event.ctrlKey) > > Does this work for non-macOS systems too? Should it only check for > `event.ctrlKey` if `WI.Platform.name === "mac"`? Hm, I'm not sure. However, we use `if (event.button !== 0 || event.ctrlKey)` everywhere in Web Inspector (in 13 other places). 1584675 4 381967 nvasilyev 2019-10-28 15:27:42 -0700 Comment on attachment 381967 Patch I'll land this. If we decide to change Control-click behavior on non-Mac platforms, it should be a separate patch that modifies all `event.button !== 0 || event.ctrlKey` conditions, not just in the color picker. 1584716 5 commit-queue 2019-10-28 16:24:05 -0700 The commit-queue encountered the following flaky tests while processing attachment 381967: webaudio/stereo2mono-down-mixing.html bug 203538 (authors: ap@webkit.org, crogers@google.com, haraken@chromium.org, mark.lam@apple.com, and sam@webkit.org) The commit-queue is continuing to process your patch. 1584718 6 381967 commit-queue 2019-10-28 16:24:54 -0700 Comment on attachment 381967 Patch Clearing flags on attachment: 381967 Committed r251682: <https://trac.webkit.org/changeset/251682> 1584719 7 commit-queue 2019-10-28 16:24:56 -0700 All reviewed patches have been landed. Closing bug. 1584720 8 webkit-bug-importer 2019-10-28 16:25:16 -0700 <rdar://problem/56689660> 381967 2019-10-25 14:30:29 -0700 2019-10-28 16:24:54 -0700 Patch patch.txt text/plain 1293 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDJiNTA5NDY1NmZiLi4zNmIxYjMyNTBkOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMTAtMjUgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogUmlnaHQtY2xpY2tpbmcgaW4gY29sb3IgcGlja2VyIHNob3VsZCBub3Qgc2VsZWN0IGNvbG9y CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDM0MzQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvQ29sb3JTcXVhcmUuanM6CisgICAgICAgIChXSS5Db2xvclNxdWFyZS5w cm90b3R5cGUuX2hhbmRsZU1vdXNlZG93bik6CisKIDIwMTktMTAtMjMgIE5pa2l0YSBWYXNpbHll diAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVwbGFj ZSBjb2xvciB3aGVlbCB3aXRoIHNxdWFyZSBIU0IgY29sb3IgcGlja2VyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2xvclNxdWFyZS5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbG9yU3F1YXJlLmpz CmluZGV4IDljZWY0NWFhMjFmLi43MGIwNDYyNTVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29sb3JTcXVhcmUuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29sb3JTcXVhcmUuanMKQEAgLTE0 OSw2ICsxNDksOSBAQCBXSS5Db2xvclNxdWFyZSA9IGNsYXNzIENvbG9yU3F1YXJlCiAKICAgICBf aGFuZGxlTW91c2Vkb3duKGV2ZW50KQogICAgIHsKKyAgICAgICAgaWYgKGV2ZW50LmJ1dHRvbiAh PT0gMCB8fCBldmVudC5jdHJsS2V5KQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIHdp bmRvdy5hZGRFdmVudExpc3RlbmVyKCJtb3VzZW1vdmUiLCB0aGlzLCB0cnVlKTsKICAgICAgICAg d2luZG93LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNldXAiLCB0aGlzLCB0cnVlKTsKICAgICAgICAg dGhpcy5fdXBkYXRlQ29sb3JGb3JNb3VzZUV2ZW50KGV2ZW50KTsK