203425 2019-10-25 11:14:24 -0700 [LFC][IFC] Remove redundant LineLayout::LineInput c'tor 2019-10-25 17:46:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1583915 0 zalan 2019-10-25 11:14:24 -0700 ssia 1583917 1 webkit-bug-importer 2019-10-25 11:14:58 -0700 <rdar://problem/56624666> 1583927 2 381947 zalan 2019-10-25 11:25:45 -0700 Created attachment 381947 Patch 1584109 3 381947 commit-queue 2019-10-25 17:46:14 -0700 Comment on attachment 381947 Patch Clearing flags on attachment: 381947 Committed r251617: <https://trac.webkit.org/changeset/251617> 1584110 4 commit-queue 2019-10-25 17:46:16 -0700 All reviewed patches have been landed. Closing bug. 381947 2019-10-25 11:25:45 -0700 2019-10-25 17:46:14 -0700 Patch bug-203425-20191025112544.patch text/plain 6536 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGM2Njg0ZjcwZGNjZDA5 M2RmZDNiYjRiNThjNzA3YWQ5YTZjNjgzZC4uZjZlNTZiZDQ5OGQ2OWEyMzk2YTgyNjI3ZTc5YmJm Yzk4NTc5OWY5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTEwLTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBSZW1vdmUg cmVkdW5kYW50IExpbmVMYXlvdXQ6OkxpbmVJbnB1dCBjJ3RvcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNDI1CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81NjYyNDY2Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNb3ZlIHRoZSBTa2lwQWxpZ21lbnQgcGFyYW1lbnRlciB0byB0aGUgTGluZUxheW91 dCBmcm9tIExpbmVMYXlvdXQ6OkxpbmVJbnB1dCwgYmVjYXVzZSBpdCdzIHRoZSBwcm9wZXJ0eSBv ZiB0aGUgbGF5b3V0IGFuZCBub3QgYW4gaW5wdXQgdG8gdGhlIGFjdHVhbCBsaW5lLgorCisgICAg ICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6bGlu ZUxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdDb250 ZXh0Ojpjb21wdXRlZEludHJpbnNpY1dpZHRoRm9yQ29uc3RyYWludCBjb25zdCk6CisgICAgICAg ICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUxheW91dC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVMYXlvdXQ6OkxpbmVJbnB1dDo6TGluZUlucHV0KToKKyAg ICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUxheW91dDo6TGluZUxheW91dCk6CisgICAgICAg ICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUxheW91dC5oOgorCiAyMDE5LTEw LTI1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZD XSBBZGQgc3VwcG9ydCBmb3Igbm8td3JhcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQu Y3BwCmluZGV4IDQwYjY5N2Y0ZWZhYjllNGJlZTAyZDMxY2VkNTBkMGU2MjU5M2MzMDQuLjNhMDc4 NzAzNjEwNGI5YTcyNzNhNzdkNGNjMzg1MjU4OWJkOGY1ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3Jt YXR0aW5nQ29udGV4dC5jcHAKQEAgLTEwMSw3ICsxMDEsNyBAQCB2b2lkIElubGluZUZvcm1hdHRp bmdDb250ZXh0OjpsaW5lTGF5b3V0KFVzZWRIb3Jpem9udGFsVmFsdWVzIHVzZWRIb3Jpem9udGFs VmFsdQogICAgICAgICBhdXRvIGxpbmVDb25zdHJhaW50cyA9IGluaXRpYWxDb25zdHJhaW50c0Zv ckxpbmUodXNlZEhvcml6b250YWxWYWx1ZXMsIGxpbmVMb2dpY2FsVG9wKTsKIAogICAgICAgICBh dXRvIGxpbmVJbnB1dCA9IExpbmVMYXlvdXQ6OkxpbmVJbnB1dCB7IGxpbmVDb25zdHJhaW50cywg cm9vdCgpLnN0eWxlKCkudGV4dEFsaWduKCksIGlubGluZUl0ZW1zLCBsZWFkaW5nSW5saW5lSXRl bUluZGV4LCBsZWFkaW5nUGFydGlhbENvbnRlbnQgfTsKLSAgICAgICAgYXV0byBsaW5lTGF5b3V0 ID0gTGluZUxheW91dCB7ICp0aGlzLCBsaW5lSW5wdXQgfTsKKyAgICAgICAgYXV0byBsaW5lTGF5 b3V0ID0gTGluZUxheW91dCB7ICp0aGlzLCBMaW5lOjpTa2lwQWxpZ25tZW50OjpObywgbGluZUlu cHV0IH07CiAKICAgICAgICAgYXV0byBsaW5lQ29udGVudCA9IGxpbmVMYXlvdXQubGF5b3V0KCk7 CiAgICAgICAgIHNldERpc3BsYXlCb3hlc0ZvckxpbmUobGluZUNvbnRlbnQsIHVzZWRIb3Jpem9u dGFsVmFsdWVzKTsKQEAgLTIzOSw5ICsyMzksOSBAQCBMYXlvdXRVbml0IElubGluZUZvcm1hdHRp bmdDb250ZXh0Ojpjb21wdXRlZEludHJpbnNpY1dpZHRoRm9yQ29uc3RyYWludChVc2VkSG9yaQog ICAgIHdoaWxlIChsZWFkaW5nSW5saW5lSXRlbUluZGV4IDwgaW5saW5lSXRlbXMuc2l6ZSgpKSB7 CiAgICAgICAgIC8vIE9ubHkgdGhlIGhvcml6dG9uYWwgYXZhaWxhYmxlIHdpZHRoIGlzIGNvbnN0 cmFpbmVkIHdoZW4gY29tcHV0aW5nIGludHJpbnNpYyB3aWR0aC4KICAgICAgICAgYXV0byBpbml0 aWFsTGluZUNvbnN0cmFpbnRzID0gTGluZTo6SW5pdGlhbENvbnN0cmFpbnRzIHsgeyB9LCB1c2Vk SG9yaXpvbnRhbFZhbHVlcy5jb25zdHJhaW50cy53aWR0aCwgZmFsc2UsIHsgfSB9OwotICAgICAg ICBhdXRvIGxpbmVJbnB1dCA9IExpbmVMYXlvdXQ6OkxpbmVJbnB1dCB7IGluaXRpYWxMaW5lQ29u c3RyYWludHMsIGlubGluZUl0ZW1zLCBsZWFkaW5nSW5saW5lSXRlbUluZGV4IH07CisgICAgICAg IGF1dG8gbGluZUlucHV0ID0gTGluZUxheW91dDo6TGluZUlucHV0IHsgaW5pdGlhbExpbmVDb25z dHJhaW50cywgcm9vdCgpLnN0eWxlKCkudGV4dEFsaWduKCksIGlubGluZUl0ZW1zLCBsZWFkaW5n SW5saW5lSXRlbUluZGV4LCB7IH0gfTsKIAotICAgICAgICBhdXRvIGxpbmVDb250ZW50ID0gTGlu ZUxheW91dCgqdGhpcywgbGluZUlucHV0KS5sYXlvdXQoKTsKKyAgICAgICAgYXV0byBsaW5lQ29u dGVudCA9IExpbmVMYXlvdXQoKnRoaXMsIExpbmU6OlNraXBBbGlnbm1lbnQ6OlllcywgbGluZUlu cHV0KS5sYXlvdXQoKTsKIAogICAgICAgICBsZWFkaW5nSW5saW5lSXRlbUluZGV4ID0gKmxpbmVD b250ZW50LnRyYWlsaW5nSW5saW5lSXRlbUluZGV4ICsgMTsKICAgICAgICAgTGF5b3V0VW5pdCBm bG9hdHNXaWR0aDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3Jt YXR0aW5nL0lubGluZUxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lTGluZUxheW91dC5jcHAKaW5kZXggMjhmM2JjZmZiYTU2MTllMTMw MGZhMWRiNDM5NmQ0NzBkMWYxYzE2OS4uYmIzNWM3OWMwNDY1NTQ3NDhhY2U5MzUyMjg0ZWEwYzJj MzkwYzliZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRp bmcvSW5saW5lTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lTGluZUxheW91dC5jcHAKQEAgLTc0LDE0ICs3NCw2IEBAIExpbmVM YXlvdXQ6OkxpbmVJbnB1dDo6TGluZUlucHV0KGNvbnN0IExpbmU6OkluaXRpYWxDb25zdHJhaW50 cyYgaW5pdGlhbExpbmVDb25zCiB7CiB9CiAKLUxpbmVMYXlvdXQ6OkxpbmVJbnB1dDo6TGluZUlu cHV0KGNvbnN0IExpbmU6OkluaXRpYWxDb25zdHJhaW50cyYgaW5pdGlhbExpbmVDb25zdHJhaW50 cywgY29uc3QgSW5saW5lSXRlbXMmIGlubGluZUl0ZW1zLCB1bnNpZ25lZCBsZWFkaW5nSW5saW5l SXRlbUluZGV4KQotICAgIDogaW5pdGlhbENvbnN0cmFpbnRzKGluaXRpYWxMaW5lQ29uc3RyYWlu dHMpCi0gICAgLCBza2lwQWxpZ25tZW50KExpbmU6OlNraXBBbGlnbm1lbnQ6OlllcykKLSAgICAs IGlubGluZUl0ZW1zKGlubGluZUl0ZW1zKQotICAgICwgbGVhZGluZ0lubGluZUl0ZW1JbmRleChs ZWFkaW5nSW5saW5lSXRlbUluZGV4KQotewotfQotCiB2b2lkIExpbmVMYXlvdXQ6OlVuY29tbWl0 dGVkQ29udGVudDo6YWRkKGNvbnN0IElubGluZUl0ZW0mIGlubGluZUl0ZW0sIExheW91dFVuaXQg bG9naWNhbFdpZHRoKQogewogICAgIG1fdW5jb21taXR0ZWRSdW5zLmFwcGVuZCh7IGlubGluZUl0 ZW0sIGxvZ2ljYWxXaWR0aCB9KTsKQEAgLTk0LDEwICs4NiwxMCBAQCB2b2lkIExpbmVMYXlvdXQ6 OlVuY29tbWl0dGVkQ29udGVudDo6cmVzZXQoKQogICAgIG1fd2lkdGggPSAwOwogfQogCi1MaW5l TGF5b3V0OjpMaW5lTGF5b3V0KGNvbnN0IElubGluZUZvcm1hdHRpbmdDb250ZXh0JiBpbmxpbmVG b3JtYXR0aW5nQ29udGV4dCwgY29uc3QgTGluZUlucHV0JiBsaW5lSW5wdXQpCitMaW5lTGF5b3V0 OjpMaW5lTGF5b3V0KGNvbnN0IElubGluZUZvcm1hdHRpbmdDb250ZXh0JiBpbmxpbmVGb3JtYXR0 aW5nQ29udGV4dCwgTGluZTo6U2tpcEFsaWdubWVudCBza2lwQWxpZ25tZW50LCBjb25zdCBMaW5l SW5wdXQmIGxpbmVJbnB1dCkKICAgICA6IG1faW5saW5lRm9ybWF0dGluZ0NvbnRleHQoaW5saW5l Rm9ybWF0dGluZ0NvbnRleHQpCiAgICAgLCBtX2xpbmVJbnB1dChsaW5lSW5wdXQpCi0gICAgLCBt X2xpbmUoaW5saW5lRm9ybWF0dGluZ0NvbnRleHQsIGxpbmVJbnB1dC5pbml0aWFsQ29uc3RyYWlu dHMsIGxpbmVJbnB1dC5ob3Jpem9udGFsQWxpZ25tZW50LCBsaW5lSW5wdXQuc2tpcEFsaWdubWVu dCkKKyAgICAsIG1fbGluZShpbmxpbmVGb3JtYXR0aW5nQ29udGV4dCwgbGluZUlucHV0LmluaXRp YWxDb25zdHJhaW50cywgbGluZUlucHV0Lmhvcml6b250YWxBbGlnbm1lbnQsIHNraXBBbGlnbm1l bnQpCiAgICAgLCBtX2xpbmVIYXNJbnRydXNpdmVGbG9hdChsaW5lSW5wdXQuaW5pdGlhbENvbnN0 cmFpbnRzLmxpbmVJc0NvbnN0cmFpbmVkQnlGbG9hdCkKIHsKIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVMYXlvdXQuaCBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVMYXlvdXQuaApp bmRleCAxZjY0OWJhMzVhNWJiOGMxMWNiMmE0Mjg5Mzc3MDMwNGJjZmUyNGY3Li5hZjg1ZmNhZjZh ZDk5YTE3MmI5MjkzZjdmZjg0NDM3NDRmYTMyNGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lTGF5b3V0LmgKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUxheW91dC5oCkBAIC0z Niw3ICszNiw3IEBAIG5hbWVzcGFjZSBMYXlvdXQgewogY2xhc3MgTGluZUxheW91dCB7CiBwdWJs aWM6CiAgICAgc3RydWN0IExpbmVJbnB1dDsKLSAgICBMaW5lTGF5b3V0KGNvbnN0IElubGluZUZv cm1hdHRpbmdDb250ZXh0JiwgY29uc3QgTGluZUlucHV0Jik7CisgICAgTGluZUxheW91dChjb25z dCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dCYsIExpbmU6OlNraXBBbGlnbm1lbnQsIGNvbnN0IExp bmVJbnB1dCYpOwogCiAgICAgc3RydWN0IExpbmVDb250ZW50OwogICAgIExpbmVDb250ZW50IGxh eW91dCgpOwpAQCAtNDYsMTMgKzQ2LDEwIEBAIHB1YmxpYzoKICAgICAgICAgdW5zaWduZWQgbGVu Z3RoOwogICAgIH07CiAgICAgc3RydWN0IExpbmVJbnB1dCB7Ci0gICAgICAgIExpbmVJbnB1dChj b25zdCBMaW5lOjpJbml0aWFsQ29uc3RyYWludHMmLCBUZXh0QWxpZ25Nb2RlLCBjb25zdCBJbmxp bmVJdGVtcyYsIHVuc2lnbmVkIGxlYWRpbmdJbmxpbmVJdGVtSW5kZXgsIE9wdGlvbmFsPFBhcnRp YWxDb250ZW50PiBsZWFkaW5nUGFydGlhbENvbnRlbnQpOwotICAgICAgICBMaW5lSW5wdXQoY29u c3QgTGluZTo6SW5pdGlhbENvbnN0cmFpbnRzJiwgY29uc3QgSW5saW5lSXRlbXMmLCB1bnNpZ25l ZCBsZWFkaW5nSW5saW5lSXRlbUluZGV4KTsKKyAgICAgICAgTGluZUlucHV0KGNvbnN0IExpbmU6 OkluaXRpYWxDb25zdHJhaW50cyYsIFRleHRBbGlnbk1vZGUgaG9yaXpvbnRhbEFsaWdubWVudCwg Y29uc3QgSW5saW5lSXRlbXMmLCB1bnNpZ25lZCBsZWFkaW5nSW5saW5lSXRlbUluZGV4LCBPcHRp b25hbDxQYXJ0aWFsQ29udGVudD4gbGVhZGluZ1BhcnRpYWxDb250ZW50KTsKIAogICAgICAgICBM aW5lOjpJbml0aWFsQ29uc3RyYWludHMgaW5pdGlhbENvbnN0cmFpbnRzOwogICAgICAgICBUZXh0 QWxpZ25Nb2RlIGhvcml6b250YWxBbGlnbm1lbnQ7Ci0gICAgICAgIC8vIEZJWE1FIEFsdGVybmF0 aXZlbHkgd2UgY291bGQganVzdCBoYXZlIGEgc2Vjb25kIHBhc3Mgd2l0aCB2ZXJ0aWNhbCBwb3Np dGlvbmluZyAocHJlZmVycmVkIHdpZHRoIGNvbXB1dGF0aW9uIG9wdHMgb3V0KSAKLSAgICAgICAg TGluZTo6U2tpcEFsaWdubWVudCBza2lwQWxpZ25tZW50IHsgTGluZTo6U2tpcEFsaWdubWVudDo6 Tm8gfTsKICAgICAgICAgY29uc3QgSW5saW5lSXRlbXMmIGlubGluZUl0ZW1zOwogICAgICAgICB1 bnNpZ25lZCBsZWFkaW5nSW5saW5lSXRlbUluZGV4IHsgMCB9OwogICAgICAgICBPcHRpb25hbDxQ YXJ0aWFsQ29udGVudD4gbGVhZGluZ1BhcnRpYWxDb250ZW50Owo=