203424 2019-10-25 11:02:16 -0700 [LFC][IFC] Add support for no-wrap 2019-10-25 16:16:37 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1583908 0 zalan 2019-10-25 11:02:16 -0700 ssia 1583909 1 webkit-bug-importer 2019-10-25 11:02:36 -0700 <rdar://problem/56624136> 1583914 2 381944 zalan 2019-10-25 11:11:17 -0700 Created attachment 381944 Patch 1583929 3 381944 koivisto 2019-10-25 11:29:18 -0700 Comment on attachment 381944 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381944&action=review > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:83 > - LayoutUnit runsWidth = 0; > + LayoutUnit runsWidth; Or auto runsWidth = 0_lu; 1584073 4 381944 commit-queue 2019-10-25 16:16:35 -0700 Comment on attachment 381944 Patch Clearing flags on attachment: 381944 Committed r251610: <https://trac.webkit.org/changeset/251610> 1584074 5 commit-queue 2019-10-25 16:16:37 -0700 All reviewed patches have been landed. Closing bug. 381944 2019-10-25 11:11:17 -0700 2019-10-25 16:16:35 -0700 Patch bug-203424-20191025111116.patch text/plain 7361 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWVmMjE4Zjg2NGJiOTQ3 MDc3YTkxMTdjZWU1ZGU3NjU5NDg3NmJmMi4uZGM2Njg0ZjcwZGNjZDA5M2RmZDNiYjRiNThjNzA3 YWQ5YTZjNjgzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTEwLTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBBZGQgc3Vw cG9ydCBmb3Igbm8td3JhcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAzNDI0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NjYyNDEzNj4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb25zdWx0IHRoZSB3 aGl0ZS1zcGFjZSBzdHlsZSBwcm9wZXJ0eSBhYm91dCBsaW5lIHdyYXBwaW5nIHdoZW4gdGhlIGNv bnRlbnQgb3ZlcmZsb3dzIGFuZCBjYW4ndCBiZSBzcGxpdC4KKworICAgICAgICAqIGxheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCcmVha2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkxheW91dDo6aXNDb250ZW50V3JhcHBpbmdBbGxvd2VkKToKKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dDo6TGluZUJyZWFrZXI6OmJyZWFraW5nQ29udGV4dEZvcklubGluZUNvbnRlbnQpOgorICAg ICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnJlYWtlcjo6d29yZEJyZWFraW5nQmVoYXZpb3Ig Y29uc3QpOgorICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCcmVh a2VyLmg6CisKIDIwMTktMTAtMjUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTEZDXVtJRkNdIEFkZCBzdXBwb3J0IGZvciBwcmVzZXJ2ZWQgbmV3IGxpbmUgKHBy ZSwgcHJlLXdyYXAsIGJyZWFrLXNwYWNlcywgcHJlLWxpbmUpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnJlYWtlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnJlYWtlci5j cHAKaW5kZXggNzRiMDY3MzYzZWM4MzVhNDhkMmYyMmJhNDllOTNkZTA5NjU3MWE2Zi4uYTYyMzMz NzY2OTFiNzFiMzdkOTc3NjIzZTUwOTE2ODBlNTdkYzJhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJyZWFrZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCcmVha2Vy LmNwcApAQCAtMzUsNiArMzUsMTEgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIG5hbWVzcGFjZSBM YXlvdXQgewogCitzdGF0aWMgaW5saW5lIGJvb2wgaXNDb250ZW50V3JhcHBpbmdBbGxvd2VkKGNv bnN0IFJlbmRlclN0eWxlJiBzdHlsZSkKK3sKKyAgICByZXR1cm4gc3R5bGUud2hpdGVTcGFjZSgp ICE9IFdoaXRlU3BhY2U6OlByZSAmJiBzdHlsZS53aGl0ZVNwYWNlKCkgIT0gV2hpdGVTcGFjZTo6 Tm9XcmFwOworfQorCiBMaW5lQnJlYWtlcjo6QnJlYWtpbmdDb250ZXh0IExpbmVCcmVha2VyOjpi cmVha2luZ0NvbnRleHRGb3JJbmxpbmVDb250ZW50KGNvbnN0IFZlY3RvcjxMaW5lTGF5b3V0OjpS dW4+JiBydW5zLCBMYXlvdXRVbml0IGxvZ2ljYWxXaWR0aCwgTGF5b3V0VW5pdCBhdmFpbGFibGVX aWR0aCwgYm9vbCBsaW5lSXNFbXB0eSkKIHsKICAgICBpZiAobG9naWNhbFdpZHRoIDw9IGF2YWls YWJsZVdpZHRoKQpAQCAtNTEsOCArNTYsMTYgQEAgTGluZUJyZWFrZXI6OkJyZWFraW5nQ29udGV4 dCBMaW5lQnJlYWtlcjo6YnJlYWtpbmdDb250ZXh0Rm9ySW5saW5lQ29udGVudChjb25zdAogICAg ICAgICB9CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9OwotICAgIGlmIChpc1RleHRDb250 ZW50KHJ1bnMpKQotICAgICAgICByZXR1cm4gd29yZEJyZWFraW5nQmVoYXZpb3IocnVucywgYXZh aWxhYmxlV2lkdGgsIGxpbmVJc0VtcHR5KTsKKyAgICBpZiAoaXNUZXh0Q29udGVudChydW5zKSkg eworICAgICAgICBpZiAoYXV0byB0cmFpbGluZ1BhcnRpYWxDb250ZW50ID0gd29yZEJyZWFraW5n QmVoYXZpb3IocnVucywgYXZhaWxhYmxlV2lkdGgpKQorICAgICAgICAgICAgcmV0dXJuIHsgQnJl YWtpbmdDb250ZXh0OjpDb250ZW50QnJlYWs6OlNwbGl0LCB0cmFpbGluZ1BhcnRpYWxDb250ZW50 IH07CisgICAgICAgIC8vIElmIHdlIGRpZCBub3QgbWFuYWdlIHRvIGJyZWFrIHRoaXMgY29udGVu dCwgd2Ugc3RpbGwgbmVlZCB0byBkZWNpZGUgd2hldGhlciBrZWVwIGl0IG9yIHdyYXAgaXQgdG8g dGhlIG5leHQgbGluZS4KKyAgICAgICAgLy8gRklYTUU6IEtlZXAgdHJhY2tpbmcgdGhlIGxhc3Qg YnJlYWtpbmcgb3Bwb3J0dW5pdHkgd2hlcmUgd2UgY2FuIHdyYXAgdGhlIGNvbnRlbnQ6CisgICAg ICAgIC8vIDxzcGFuIHN0eWxlPSJ3aGl0ZS1zcGFjZTogcHJlOyI+dGhpcyBmaXRzPC9zcGFuPiA8 c3BhbiBzdHlsZT0id2hpdGUtc3BhY2U6IHByZTsiPnRoaXMgZG9lcyBub3QgZml0IGJ1dCBkb2Vz IG5vdCB3cmFwIGVpdGhlcjwvc3Bhbj4KKyAgICAgICAgLy8gXl4gY291bGQgd3JhcCBhdCB0aGUg d2hpdGVzcGFjZSBwb3NpdGlvbiBiZXR3ZWVuIHRoZSAyIGlubGluZSBjb250YWluZXJzLgorICAg ICAgICBhdXRvIGNvbnRlbnRTaG91bGRXcmFwID0gIWxpbmVJc0VtcHR5ICYmIGlzQ29udGVudFdy YXBwaW5nQWxsb3dlZChydW5zWzBdLmlubGluZUl0ZW0uc3R5bGUoKSk7CisgICAgICAgIHJldHVy biB7IGNvbnRlbnRTaG91bGRXcmFwID8gQnJlYWtpbmdDb250ZXh0OjpDb250ZW50QnJlYWs6Oldy YXAgOiBCcmVha2luZ0NvbnRleHQ6OkNvbnRlbnRCcmVhazo6S2VlcCwgeyB9IH07CisgICAgfQog CiAgICAgLy8gRmlyc3Qgbm9uLXRleHQgaW5saW5lIGNvbnRlbnQgYWx3YXlzIHN0YXlzIG9uIGxp bmUuCiAgICAgcmV0dXJuIHsgbGluZUlzRW1wdHkgPyBCcmVha2luZ0NvbnRleHQ6OkNvbnRlbnRC cmVhazo6S2VlcCA6IEJyZWFraW5nQ29udGV4dDo6Q29udGVudEJyZWFrOjpXcmFwLCB7IH0gfTsK QEAgLTYzLDE1ICs3NiwxNyBAQCBib29sIExpbmVCcmVha2VyOjpzaG91bGRXcmFwRmxvYXRCb3go TGF5b3V0VW5pdCBmbG9hdExvZ2ljYWxXaWR0aCwgTGF5b3V0VW5pdCBhdgogICAgIHJldHVybiAh bGluZUlzRW1wdHkgJiYgZmxvYXRMb2dpY2FsV2lkdGggPiBhdmFpbGFibGVXaWR0aDsKIH0KIAot TGluZUJyZWFrZXI6OkJyZWFraW5nQ29udGV4dCBMaW5lQnJlYWtlcjo6d29yZEJyZWFraW5nQmVo YXZpb3IoY29uc3QgVmVjdG9yPExpbmVMYXlvdXQ6OlJ1bj4mIHJ1bnMsIExheW91dFVuaXQgYXZh aWxhYmxlV2lkdGgsIGJvb2wgbGluZUlzRW1wdHkpIGNvbnN0CitPcHRpb25hbDxMaW5lQnJlYWtl cjo6QnJlYWtpbmdDb250ZXh0OjpUcmFpbGluZ1BhcnRpYWxDb250ZW50PiBMaW5lQnJlYWtlcjo6 d29yZEJyZWFraW5nQmVoYXZpb3IoY29uc3QgVmVjdG9yPExpbmVMYXlvdXQ6OlJ1bj4mIHJ1bnMs IExheW91dFVuaXQgYXZhaWxhYmxlV2lkdGgpIGNvbnN0CiB7CiAgICAgLy8gQ2hlY2sgd2hlcmUg dGhlIG92ZXJmbG93IG9jY3VycyBhbmQgdXNlIHRoZSBjb3JyZXNwb25kaW5nIHN0eWxlIHRvIGZp Z3VyZSBvdXQgdGhlIGJyZWFraW5nIGJlaGF2aW91ci4KICAgICAvLyA8c3BhbiBzdHlsZT0id29y ZC1icmVhazogbm9ybWFsIj5maXJzdDwvc3Bhbj48c3BhbiBzdHlsZT0id29yZC1icmVhazogYnJl YWstYWxsIj5zZWNvbmQ8L3NwYW4+PHNwYW4gc3R5bGU9IndvcmQtYnJlYWs6IG5vcm1hbCI+dGhp cmQ8L3NwYW4+Ci0gICAgTGF5b3V0VW5pdCBydW5zV2lkdGggPSAwOworICAgIExheW91dFVuaXQg cnVuc1dpZHRoOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBydW5zLnNpemUoKTsgKytp KSB7CiAgICAgICAgIGF1dG8mIHJ1biA9IHJ1bnNbaV07CiAgICAgICAgIEFTU0VSVChydW4uaW5s aW5lSXRlbS5pc1RleHQoKSB8fCBydW4uaW5saW5lSXRlbS5pc0NvbnRhaW5lclN0YXJ0KCkgfHwg cnVuLmlubGluZUl0ZW0uaXNDb250YWluZXJFbmQoKSk7CiAgICAgICAgIHJ1bnNXaWR0aCArPSBy dW4ubG9naWNhbFdpZHRoOworICAgICAgICAvLyBGSVhNRTogSW4gY2FzZSBvZiBtdWx0aXBsZSBp bmxpbmUgaXRlbXMsIHdlIG1pZ2h0IG5vdCBiZSBhYmxlIHRvIHNwbGl0IHRoZSBjb250ZW50IHdo ZXJlIGl0IG92ZXJmbG93cyAoPHNwYW4gc3R5bGU9IndoaXRlLXNwYWNlOiBub3JtYWwiPnRoaXMg c3RpbGwgZml0cyB0aGUgbGluZTwvc3BhbjxzcGFuIHN0eWxlPSJ3aGl0ZS1zcGFjZTogcHJlIj50 aGlzIGlzIG5vdCBhbnltb3JlLCBidXQgY2FuJ3Qgc3BsaXQ8L3NwYW4pCisgICAgICAgIC8vIHNv IHdlIG5lZWQgdG8gbG9vayBmb3Igc3BsaXQgcG9zaXRpb25zIGV2ZW4gcnVuc1dpZHRoIDw9IGF2 YWlsYWJsZVdpZHRoLgogICAgICAgICBpZiAocnVuc1dpZHRoIDw9IGF2YWlsYWJsZVdpZHRoKQog ICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIC8vIExldCdzIGZpbmQgdGhlIGZpcnN0IGJy ZWFraW5nIG9wcG9ydHVuaXR5IHN0YXJ0aW5nIGZyb20gdGhpcyBvdmVyZmxvd24gaW5saW5lIGl0 ZW0uCkBAIC04MCwxOSArOTUsMTggQEAgTGluZUJyZWFrZXI6OkJyZWFraW5nQ29udGV4dCBMaW5l QnJlYWtlcjo6d29yZEJyZWFraW5nQmVoYXZpb3IoY29uc3QgVmVjdG9yPExpbmUKICAgICAgICAg ICAgIC8vIHdlIG5lZWQgdG8gY2hlY2sgaWYgdGhlcmUncyBhbm90aGVyIGlubGluZSBpdGVtIGJl eW9uZCB0aGUgW2NvbnRhaW5lciBlbmRdIHRvIHNwbGl0LgogICAgICAgICAgICAgY29udGludWU7 CiAgICAgICAgIH0KLSAgICAgICAgLy8gRG8gbm90IGV2ZW4gdHJ5IHRvIHdyYXAgJ3ByZScgYW5k ICduby13cmFwJyBjb250ZW50LgotICAgICAgICBhdXRvIHdoaXRlc3BhY2UgPSBydW4uaW5saW5l SXRlbS5zdHlsZSgpLndoaXRlU3BhY2UoKTsKLSAgICAgICAgaWYgKHdoaXRlc3BhY2UgPT0gV2hp dGVTcGFjZTo6UHJlIHx8IHdoaXRlc3BhY2UgPT0gV2hpdGVTcGFjZTo6Tm9XcmFwKQorICAgICAg ICAvLyBEbyBub3QgdHJ5IHRvIHNwbGl0ICdwcmUnIGFuZCAnbm8td3JhcCcgY29udGVudC4KKyAg ICAgICAgaWYgKCFpc0NvbnRlbnRXcmFwcGluZ0FsbG93ZWQocnVuLmlubGluZUl0ZW0uc3R5bGUo KSkpCiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgLy8gQXQgdGhpcyBwb2ludCB0aGUg YXZhaWxhYmxlIHdpZHRoIGNhbiB2ZXJ5IHdlbGwgYmUgbmVnYXRpdmUgZS5nLiB3aGVuIHNvbWUg cGFydCBvZiB0aGUgY29udGludW91cyB0ZXh0IGNvbnRlbnQgY2FuIG5vdCBiZSBicm9rZW4gaW50 byBwYXJ0cyAtPgogICAgICAgICAvLyA8c3BhbiBzdHlsZT0id29yZC1icmVhazoga2VlcC1hbGwi PnRleHRjb250ZW50d2l0aG5vYnJlYWs8L3NwYW4+PHNwYW4+dGV4dGNvbnRlbnR3aXRoeWVzYnJl YWs8L3NwYW4+CiAgICAgICAgIC8vIFdoZW4gdGhlIGZpcnN0IHNwYW4gY29tcHV0ZXMgbG9uZ2Vy IHRoYW4gdGhlIGF2YWlsYWJsZSBzcGFjZSwgYnkgdGhlIHRpbWUgd2UgZ2V0IHRvIHRoZSBzZWNv bmQgc3BhbiwgdGhlIGFkanVzdGVkIGF2YWlsYWJsZSBzcGFjZSBiZWNvbWVzIG5lZ2F0aXZlLgog ICAgICAgICBhdXRvIGFkanVzdGVkQXZhaWxhYmxlV2lkdGggPSBzdGQ6Om1heChMYXlvdXRVbml0 IHsgfSwgYXZhaWxhYmxlV2lkdGggLSBydW5zV2lkdGggKyBydW4ubG9naWNhbFdpZHRoKTsKICAg ICAgICAgaWYgKGF1dG8gc3BsaXRMZW5ndGhBbmRXaWR0aCA9IHRyeUJyZWFraW5nVGV4dFJ1bihy dW4sIGFkanVzdGVkQXZhaWxhYmxlV2lkdGgpKQotICAgICAgICAgICAgcmV0dXJuIHsgQnJlYWtp bmdDb250ZXh0OjpDb250ZW50QnJlYWs6OlNwbGl0LCBCcmVha2luZ0NvbnRleHQ6OlRyYWlsaW5n UGFydGlhbENvbnRlbnQgeyBpLCBzcGxpdExlbmd0aEFuZFdpZHRoLT5sZW5ndGgsIHNwbGl0TGVu Z3RoQW5kV2lkdGgtPmxlZnRMb2dpY2FsV2lkdGggfSB9OworICAgICAgICAgICAgcmV0dXJuIEJy ZWFraW5nQ29udGV4dDo6VHJhaWxpbmdQYXJ0aWFsQ29udGVudCB7IGksIHNwbGl0TGVuZ3RoQW5k V2lkdGgtPmxlbmd0aCwgc3BsaXRMZW5ndGhBbmRXaWR0aC0+bGVmdExvZ2ljYWxXaWR0aCB9Owog ICAgIH0KICAgICAvLyBXZSBkaWQgbm90IG1hbmFnZSB0byBicmVhayBpbiB0aGlzIHNlcXVlbmNl IG9mIHJ1bnMuCi0gICAgcmV0dXJuIHsgbGluZUlzRW1wdHkgPyBCcmVha2luZ0NvbnRleHQ6OkNv bnRlbnRCcmVhazo6S2VlcCA6IEJyZWFraW5nQ29udGV4dDo6Q29udGVudEJyZWFrOjpXcmFwLCB7 IH0gfTsKKyAgICByZXR1cm4geyB9OwogfQogCiBPcHRpb25hbDxMaW5lQnJlYWtlcjo6U3BsaXRM ZW5ndGhBbmRXaWR0aD4gTGluZUJyZWFrZXI6OnRyeUJyZWFraW5nVGV4dFJ1bihjb25zdCBMaW5l TGF5b3V0OjpSdW4gb3ZlcmZsb3dSdW4sIExheW91dFVuaXQgYXZhaWxhYmxlV2lkdGgpIGNvbnN0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9Jbmxp bmVMaW5lQnJlYWtlci5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv SW5saW5lTGluZUJyZWFrZXIuaAppbmRleCAwNDQyNjg2YTYwMDRjZDgzZmY0MjczOGFkOWIzZmQ3 MmY5OGJjYjZkLi45ZThkN2FkNTA1YzcyOGRjYzk4ZWFmNjFlNTJiNTEwNGRiMThkNjVmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5l QnJlYWtlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUxpbmVCcmVha2VyLmgKQEAgLTUzLDcgKzUzLDcgQEAgcHVibGljOgogCiBwcml2YXRlOgog Ci0gICAgTGluZUJyZWFrZXI6OkJyZWFraW5nQ29udGV4dCB3b3JkQnJlYWtpbmdCZWhhdmlvcihj b25zdCBWZWN0b3I8TGluZUxheW91dDo6UnVuPiYsIExheW91dFVuaXQgYXZhaWxhYmxlV2lkdGgs IGJvb2wgbGluZUlzRW1wdHkpIGNvbnN0OworICAgIE9wdGlvbmFsPEJyZWFraW5nQ29udGV4dDo6 VHJhaWxpbmdQYXJ0aWFsQ29udGVudD4gd29yZEJyZWFraW5nQmVoYXZpb3IoY29uc3QgVmVjdG9y PExpbmVMYXlvdXQ6OlJ1bj4mLCBMYXlvdXRVbml0IGF2YWlsYWJsZVdpZHRoKSBjb25zdDsKIAog ICAgIHN0cnVjdCBTcGxpdExlbmd0aEFuZFdpZHRoIHsKICAgICAgICAgdW5zaWduZWQgbGVuZ3Ro IHsgMCB9Owo=