203417 2019-10-25 08:48:46 -0700 Python 3: Add support in webkitpy.xcode 2019-10-25 16:01:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=184986 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue dewei_zhu ews-watchlist glenn slewis webkit-bug-importer oldest_to_newest 1583834 0 jbedard 2019-10-25 08:48:46 -0700 We need to add Python 3 support in webkitpy.xcode, which mostly manages simulators. 1583841 1 381928 jbedard 2019-10-25 09:02:33 -0700 Created attachment 381928 Patch 1583901 2 dewei_zhu 2019-10-25 10:55:39 -0700 r=me 1584055 3 381928 commit-queue 2019-10-25 16:00:46 -0700 Comment on attachment 381928 Patch Clearing flags on attachment: 381928 Committed r251608: <https://trac.webkit.org/changeset/251608> 1584056 4 commit-queue 2019-10-25 16:00:48 -0700 All reviewed patches have been landed. Closing bug. 1584060 5 webkit-bug-importer 2019-10-25 16:01:16 -0700 <rdar://problem/56635897> 381928 2019-10-25 09:02:33 -0700 2019-10-25 16:00:46 -0700 Patch bug-203417-20191025090233.patch text/plain 6684 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTU5MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE5LTEwLTI1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBQeXRob24gMzogQWRkIHN1cHBvcnQgaW4gd2Via2l0cHkueGNvZGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzQxNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy90 ZXN0LXdlYmtpdHB5LXB5dGhvbjM6IEFkZCB3ZWJraXRweS54Y29kZS4KKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbV9tb2NrLnB5OgorICAgICAgICAo UmVhZGFibGVCaW5hcnlGaWxlT2JqZWN0LnNlZWspOiBBZGQgc2VlayBmdW5jdGlvbiB0byBtaXJy b3IgYWN0dWFsIGJpbmFyeSBmaWxlCisgICAgICAgIGJlaGF2aW9yIGFuZCBzdXBwb3J0IHBsaXN0 bGliLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5w eToKKyAgICAgICAgKFNpbXVsYXRlZERldmljZU1hbmFnZXIuX2Rpc2FtYmlndWF0ZV9kZXZpY2Vf dHlwZSk6IFVzZSB2YWx1ZXMgaW5zdGVhZCBvZiBpdGVydmFsdWVzLgorICAgICAgICAoU2ltdWxh dGVkRGV2aWNlTWFuYWdlci5fZ2V0X2RldmljZV9pZGVudGlmaWVyX2Zvcl90eXBlKTogVXNlIGl0 ZW1zIGluc3RlYWQgb2YgaXRlcml0ZW1zLgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdl ci5kZXZpY2VfY291bnRfZm9yX3R5cGUpOiBVc2UgdmFsdWVzIGluc3RlYWQgb2YgaXRlcnZhbHVl cy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2VfdW5p dHRlc3QucHk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VUZXN0Lm1vY2tfaG9zdF9mb3Jfc2lt Y3RsKTogVXNlIGl0ZW1zIGluc3RlYWQgb2YgaXRlcml0ZW1zLgorICAgICAgICAoY2hhbmdlX3N0 YXRlX3RvKTogRXhwbGljaXRseSB1c2UgYnl0ZXMgdG8gZWRpdCBhIGJpbmFyeSBmaWxlLgorCiAy MDE5LTEwLTI1ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAg ICAgICB0ZXN0MjYyLXJ1bm5lciBzaG91bGQgYmUgYWJsZSB0byBwYXNzIEpTQyBhIGZlYXR1cmUg ZmxhZwpJbmRleDogVG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtpdHB5LXB5dGhvbjMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtpdHB5LXB5dGhvbjMJKHJldmlzaW9uIDI1MTU4 OSkKKysrIFRvb2xzL1NjcmlwdHMvdGVzdC13ZWJraXRweS1weXRob24zCSh3b3JraW5nIGNvcHkp CkBAIC00MSw2ICs0MSw3IEBAIFBZVEhPTjNfQ09NUEFUSUJMRV9ESVJFQ1RPUklFUyA9IFsKICAg J3dlYmtpdHB5LmNvbW1vbi5uZXQnLAogICAnd2Via2l0cHkuY29tbW9uLndhdGNobGlzdCcsCiAg ICd3ZWJraXRweS5yZXN1bHRzJywKKyAgJ3dlYmtpdHB5Lnhjb2RlJywKIF0KIFNMT1dfVEVTVFMg PSBbCiAgICAgU0NNVGVzdCwKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9maWxlc3lzdGVtX21vY2sucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW1fbW9jay5weQkocmV2aXNpb24gMjUxNTg5KQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW1fbW9jay5w eQkod29ya2luZyBjb3B5KQpAQCAtNDg2LDYgKzQ4Niw5IEBAIGNsYXNzIFJlYWRhYmxlQmluYXJ5 RmlsZU9iamVjdChvYmplY3QpOgogICAgICAgICBzZWxmLm9mZnNldCArPSBieXRlcwogICAgICAg ICByZXR1cm4gc2VsZi5kYXRhW3N0YXJ0OnNlbGYub2Zmc2V0XQogCisgICAgZGVmIHNlZWsoc2Vs Ziwgb2Zmc2V0KToKKyAgICAgICAgc2VsZi5vZmZzZXQgPSBvZmZzZXQKKwogCiBjbGFzcyBSZWFk YWJsZVRleHRGaWxlT2JqZWN0KFJlYWRhYmxlQmluYXJ5RmlsZU9iamVjdCk6CiAgICAgZGVmIF9f aW5pdF9fKHNlbGYsIGZzLCBwYXRoLCBkYXRhKToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHJldmlzaW9uIDI1MTU4OSkKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQkod29ya2lu ZyBjb3B5KQpAQCAtMjMyLDcgKzIzMiw3IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1hbmFnZXIo b2JqZWN0KToKIAogICAgICAgICBpZiBmdWxsX2RldmljZV90eXBlLmhhcmR3YXJlX3R5cGUgaXMg Tm9uZToKICAgICAgICAgICAgICMgQWdhaW4sIHdlIHVzZSB0aGUgZXhpc3RpbmcgZGV2aWNlcyB0 byBkZXRlcm1pbmUgYSBsZWdhbCBoYXJkd2FyZSB0eXBlCi0gICAgICAgICAgICBmb3IgbmFtZSBp biBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLl9kZXZpY2VfaWRlbnRpZmllcl90b19uYW1lLml0ZXJ2 YWx1ZXMoKToKKyAgICAgICAgICAgIGZvciBuYW1lIGluIFNpbXVsYXRlZERldmljZU1hbmFnZXIu X2RldmljZV9pZGVudGlmaWVyX3RvX25hbWUudmFsdWVzKCk6CiAgICAgICAgICAgICAgICAgdHlw ZV9mcm9tX25hbWUgPSBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKG5hbWUpCiAgICAgICAgICAgICAg ICAgaWYgdHlwZV9mcm9tX25hbWUgPT0gZnVsbF9kZXZpY2VfdHlwZToKICAgICAgICAgICAgICAg ICAgICAgZnVsbF9kZXZpY2VfdHlwZS5oYXJkd2FyZV90eXBlID0gdHlwZV9mcm9tX25hbWUuaGFy ZHdhcmVfdHlwZQpAQCAtMjQzLDcgKzI0Myw3IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1hbmFn ZXIob2JqZWN0KToKIAogICAgIEBzdGF0aWNtZXRob2QKICAgICBkZWYgX2dldF9kZXZpY2VfaWRl bnRpZmllcl9mb3JfdHlwZShkZXZpY2VfdHlwZSk6Ci0gICAgICAgIGZvciB0eXBlX2lkLCB0eXBl X25hbWUgaW4gU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5fZGV2aWNlX2lkZW50aWZpZXJfdG9fbmFt ZS5pdGVyaXRlbXMoKToKKyAgICAgICAgZm9yIHR5cGVfaWQsIHR5cGVfbmFtZSBpbiBTaW11bGF0 ZWREZXZpY2VNYW5hZ2VyLl9kZXZpY2VfaWRlbnRpZmllcl90b19uYW1lLml0ZW1zKCk6CiAgICAg ICAgICAgICBpZiB0eXBlX25hbWUubG93ZXIoKSA9PSB1J3t9IHt9Jy5mb3JtYXQoZGV2aWNlX3R5 cGUuaGFyZHdhcmVfZmFtaWx5Lmxvd2VyKCksIGRldmljZV90eXBlLmhhcmR3YXJlX3R5cGUubG93 ZXIoKSk6CiAgICAgICAgICAgICAgICAgcmV0dXJuIHR5cGVfaWQKICAgICAgICAgcmV0dXJuIE5v bmUKQEAgLTM0OCw3ICszNDgsNyBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVj dCk6CiAgICAgICAgICAgICBmaWx0ZXIgPSBsYW1iZGEgZGV2aWNlOiBkZXZpY2UucGxhdGZvcm1f ZGV2aWNlLmlzX2Jvb3RlZF9vcl9ib290aW5nKCkgYW5kIGRldmljZS5kZXZpY2VfdHlwZSBpbiBk ZXZpY2VfdHlwZQogICAgICAgICAgICAgcmV0dXJuIGxlbihTaW11bGF0ZWREZXZpY2VNYW5hZ2Vy LmRldmljZV9ieV9maWx0ZXIoZmlsdGVyLCBob3N0PWhvc3QpKQogCi0gICAgICAgIGZvciBuYW1l IGluIFNpbXVsYXRlZERldmljZU1hbmFnZXIuX2RldmljZV9pZGVudGlmaWVyX3RvX25hbWUuaXRl cnZhbHVlcygpOgorICAgICAgICBmb3IgbmFtZSBpbiBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLl9k ZXZpY2VfaWRlbnRpZmllcl90b19uYW1lLnZhbHVlcygpOgogICAgICAgICAgICAgaWYgRGV2aWNl VHlwZS5mcm9tX3N0cmluZyhuYW1lKSBpbiBkZXZpY2VfdHlwZToKICAgICAgICAgICAgICAgICBy ZXR1cm4gU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5tYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnMoaG9z dCkKICAgICAgICAgcmV0dXJuIDAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUv c2ltdWxhdGVkX2RldmljZV91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2VfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI1 MTU4OSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZV91 bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNTAyLDYgKzUwMiw3IEBAIGZyb20gd2Via2l0 cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmVfbW8KIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3Rl bS5maWxlc3lzdGVtX21vY2sgaW1wb3J0IE1vY2tGaWxlU3lzdGVtCiBmcm9tIHdlYmtpdHB5LmNv bW1vbi5zeXN0ZW0uc3lzdGVtaG9zdF9tb2NrIGltcG9ydCBNb2NrU3lzdGVtSG9zdAogZnJvbSB3 ZWJraXRweS5jb21tb24udmVyc2lvbiBpbXBvcnQgVmVyc2lvbgorZnJvbSB3ZWJraXRweS5jb21t b24udW5pY29kZV9jb21wYXRpYmlsaXR5IGltcG9ydCBlbmNvZGVfaWZfbmVjZXNzYXJ5CiBmcm9t IHdlYmtpdHB5Lnhjb2RlLmRldmljZV90eXBlIGltcG9ydCBEZXZpY2VUeXBlCiBmcm9tIHdlYmtp dHB5Lnhjb2RlLnNpbXVsYXRlZF9kZXZpY2UgaW1wb3J0IERldmljZVJlcXVlc3QsIFNpbXVsYXRl ZERldmljZU1hbmFnZXIsIFNpbXVsYXRlZERldmljZQogCkBAIC01MzQsNyArNTM1LDcgQEAgY2xh c3MgU2ltdWxhdGVkRGV2aWNlVGVzdCh1bml0dGVzdC5UZXN0QwogICAgICAgICBmb3IgZGV2aWNl X3R5cGUgaW4gc2ltY3RsX2pzb25bJ2RldmljZXR5cGVzJ106CiAgICAgICAgICAgICBkZXZpY2Vf dHlwZV9uYW1lX3RvX2lkW2RldmljZV90eXBlWyduYW1lJ11dID0gZGV2aWNlX3R5cGVbJ2lkZW50 aWZpZXInXQogCi0gICAgICAgIGZvciBydW50aW1lLCBkZXZpY2VfZ3JvdXBzIGluIHNpbWN0bF9q c29uWydkZXZpY2VzJ10uaXRlcml0ZW1zKCk6CisgICAgICAgIGZvciBydW50aW1lLCBkZXZpY2Vf Z3JvdXBzIGluIHNpbWN0bF9qc29uWydkZXZpY2VzJ10uaXRlbXMoKToKICAgICAgICAgICAgIGZv ciBkZXZpY2UgaW4gZGV2aWNlX2dyb3VwczoKICAgICAgICAgICAgICAgICBmaWxlX3BhdGggPSAn L1VzZXJzL21vY2snICsgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5zaW11bGF0b3JfZGV2aWNlX3Bh dGhbMTpdICsgJy8nICsgZGV2aWNlWyd1ZGlkJ10gKyAnL2RldmljZS5wbGlzdCcKICAgICAgICAg ICAgICAgICAjIFdlJ3JlIHRha2luZyBhZHZhbnRhZ2UgdGhlIGZhY3QgdGhhdCB0aGUgbmFtZXMg b2YgdGhlIGRldmljZXMgbWF0Y2ggdGhlIG5hbWVzIG9mIHRoZWlyIHJ1bnRpbWVzIGluIHRoZQpA QCAtNjMyLDggKzYzMyw4IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZVRlc3QodW5pdHRlc3QuVGVz dEMKICAgICAgICAgIyBSZWFjaGluZyBpbnRvIGRldmljZS5wbGlzdCB0byBjaGFuZ2UgZGV2aWNl IHN0YXRlLiBOb3RlIHRoYXQgdGhpcyB3aWxsIG5vdCBjaGFuZ2UgdGhlIGluaXRpYWwgc3RhdGUg b2YgdGhlIGRldmljZQogICAgICAgICAjIGFzIGRldGVybWluZWQgZnJvbSB0aGUgLmpzb24gb3V0 cHV0LgogICAgICAgICBkZXZpY2VfcGxpc3QgPSBkZXZpY2UuZmlsZXN5c3RlbS5leHBhbmR1c2Vy KGRldmljZS5maWxlc3lzdGVtLmpvaW4oU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5zaW11bGF0b3Jf ZGV2aWNlX3BhdGgsIGRldmljZS51ZGlkLCAnZGV2aWNlLnBsaXN0JykpCi0gICAgICAgIGluZGV4 X3Bvc2l0aW9uID0gZGV2aWNlLmZpbGVzeXN0ZW0uZmlsZXNbZGV2aWNlX3BsaXN0XS5pbmRleCgn PC9pbnRlZ2VyPicpIC0gMQotICAgICAgICBkZXZpY2UuZmlsZXN5c3RlbS5maWxlc1tkZXZpY2Vf cGxpc3RdID0gZGV2aWNlLmZpbGVzeXN0ZW0uZmlsZXNbZGV2aWNlX3BsaXN0XVs6aW5kZXhfcG9z aXRpb25dICsgc3RyKHN0YXRlKSArIGRldmljZS5maWxlc3lzdGVtLmZpbGVzW2RldmljZV9wbGlz dF1baW5kZXhfcG9zaXRpb24gKyAxOl0KKyAgICAgICAgaW5kZXhfcG9zaXRpb24gPSBkZXZpY2Uu ZmlsZXN5c3RlbS5maWxlc1tkZXZpY2VfcGxpc3RdLmluZGV4KGInPC9pbnRlZ2VyPicpIC0gMQor ICAgICAgICBkZXZpY2UuZmlsZXN5c3RlbS5maWxlc1tkZXZpY2VfcGxpc3RdID0gZGV2aWNlLmZp bGVzeXN0ZW0uZmlsZXNbZGV2aWNlX3BsaXN0XVs6aW5kZXhfcG9zaXRpb25dICsgZW5jb2RlX2lm X25lY2Vzc2FyeShzdHIoc3RhdGUpKSArIGRldmljZS5maWxlc3lzdGVtLmZpbGVzW2RldmljZV9w bGlzdF1baW5kZXhfcG9zaXRpb24gKyAxOl0KIAogICAgIGRlZiB0ZXN0X3N3YXBwaW5nX2Rldmlj ZXMoc2VsZik6CiAgICAgICAgIFNpbXVsYXRlZERldmljZVRlc3QucmVzZXRfc2ltdWxhdGVkX2Rl dmljZV9tYW5hZ2VyKCkK