203407 2019-10-25 05:16:20 -0700 enumerateDevices() doesn't return correct list of devices after device was changed by user in a system preferences 2019-11-04 08:42:40 -0800 1 1 1 Unclassified WebKit WebRTC Safari 13 Mac macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 1 olsviate eric.carlson commit-queue eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1583776 0 olsviate 2019-10-25 05:16:20 -0700 Steps to reproduce: 1. Have two or more available microphones 2. Call getUserMedia and then enumerateDevices: browser will return a list of devices, where first one is default 2. Change microphone is system preference 3. Call enumerateDevices again: first one in the list is a previous default device Js fiddler to show the issue: https://jsfiddle.net/h38bn7zq/15/ Note: if device is unplugged then enumerateDevices returns correct info, it works correct also when device was plugged in after. 1584266 1 webkit-bug-importer 2019-10-26 13:12:22 -0700 <rdar://problem/56648063> 1584267 2 youennf 2019-10-26 13:17:57 -0700 I can repro the bug. On page reload, the default device is the correct one. There is apparently no device change event being fired, which means we either do not receive the notification or we do not detect any change in the device setup while we should. 1586984 3 382738 eric.carlson 2019-11-04 07:53:34 -0800 Created attachment 382738 Patch 1586986 4 382738 youennf 2019-11-04 07:58:49 -0800 Comment on attachment 382738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382738&action=review > Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:131 > + callOnMainThread([] { We probably do not need callOnMainThread since we ask the listener to be called on dispatch_get_main_queue. 1586989 5 382740 eric.carlson 2019-11-04 08:10:29 -0800 Created attachment 382740 Patch for landing. 1587007 6 382740 commit-queue 2019-11-04 08:42:38 -0800 Comment on attachment 382740 Patch for landing. Clearing flags on attachment: 382740 Committed r251992: <https://trac.webkit.org/changeset/251992> 1587008 7 commit-queue 2019-11-04 08:42:40 -0800 All reviewed patches have been landed. Closing bug. 382738 2019-11-04 07:53:34 -0800 2019-11-04 08:10:28 -0800 Patch bug-203407-20191104075333.patch text/plain 3621 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjM4MWRjYWU3ZTIzNmZi MmJkOGEzYWI4NTFiODRkMjRkZDUzZjI3MC4uMzQ3ZmViNzc1YTQ2MGM3MDllYTA0Mzc1NDIyNDBj ZTYzNGE3NzU4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTExLTA0ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIGVudW1lcmF0ZURl dmljZXMoKSBkb2Vzbid0IHJldHVybiBjb3JyZWN0IGxpc3Qgb2YgZGV2aWNlcyBhZnRlciBkZXZp Y2Ugd2FzIGNoYW5nZWQgYnkgdXNlciBpbiBhIHN5c3RlbSBwcmVmZXJlbmNlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNDA3CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81NjY0ODA2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0ZWQgbWFudWFsbHkgYXMgdGhpcyBkb2Vzbid0IHJlcHJvZHVj ZSB3aXRoIG1vY2sgY2FwdHVyZSBkZXZpY2VzLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFz dHJlYW0vbWFjL0NvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyOjpjb3JlQXVkaW9DYXB0dXJlRGV2 aWNlcyk6IFJlZnJlc2ggdGhlIGxpc3Qgb2YgY2FwdHVyZQorICAgICAgICBkZXZpY2VzIHdoZW4g dGhlIGRlZmF1bHQgaW5wdXQgZGV2aWNlIGNoYW5nZXMuIEFsc28gZGlzcGF0Y2ggdG8gdGhlIG1h aW4gdGhyZWFkIHdoZW4gY2FsbGluZworICAgICAgICByZWZyZXNoQXVkaW9DYXB0dXJlRGV2aWNl cyBiZWNhdXNlIHRoZSBDb3JlQXVkaW8gbm90aWZpY2F0aW9uIGhhcHBlbnMgb24gYSBiYWNrZ3Jv dW5kIHRocmVhZC4KKyAgICAgICAgKFdlYkNvcmU6OkNvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5h Z2VyOjpyZWZyZXNoQXVkaW9DYXB0dXJlRGV2aWNlcyk6IEFzc2VydCBpZiBub3QgY2FsbGVkCisg ICAgICAgIG9uIHRoZSBtYWluIHRocmVhZC4KKwogMjAxOS0xMS0wNCAgeW91ZW5uIGZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgT3JkZXIgb2YgcG9zdE1lc3NhZ2UgYW5kIGZl dGNoIGV2ZW50cyBzaG91bGQgYmUgcHJlc2VydmVkIHdoZW4gZ29pbmcgZnJvbSBjbGllbnQgdG8g c2VydmljZSB3b3JrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlh c3RyZWFtL21hYy9Db3JlQXVkaW9DYXB0dXJlRGV2aWNlTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQ29yZUF1ZGlvQ2FwdHVyZURldmljZU1hbmFn ZXIuY3BwCmluZGV4IDk4ODdiYzIwODBlMzc5MGJkOTNhNzliNjJiZjMwZjRmZTI4NmU1NTQuLjhl Zjk5NThiNWIxZTgyOWU5ZGU4YjQxZmVkOTM3YTEzMDM1ODRjNjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9Db3JlQXVkaW9DYXB0dXJlRGV2aWNl TWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFj L0NvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcApAQCAtMzYsNiArMzYsNyBAQAogI2lu Y2x1ZGUgPENvcmVNZWRpYS9DTVN5bmMuaD4KICNpbmNsdWRlIDxwYWwvc3BpL2NmL0NvcmVBdWRp b1NQSS5oPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisjaW5jbHVkZSA8d3RmL01haW5U aHJlYWQuaD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KIAogI2ltcG9ydCA8cGFs L2NmL0NvcmVNZWRpYVNvZnRMaW5rLmg+CkBAIC0xMjIsMTQgKzEyMywxNCBAQCBWZWN0b3I8Q29y ZUF1ZGlvQ2FwdHVyZURldmljZT4mIENvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyOjpjb3Jl QXVkaW9DYXB0dXJlRAogICAgICAgICByZWZyZXNoQXVkaW9DYXB0dXJlRGV2aWNlcyhOb3RpZnlJ ZkRldmljZXNIYXZlQ2hhbmdlZDo6RG9Ob3ROb3RpZnkpOwogCiAgICAgICAgIGF1dG8gbGlzdGVu ZXIgPSBeKFVJbnQzMiBjb3VudCwgY29uc3QgQXVkaW9PYmplY3RQcm9wZXJ0eUFkZHJlc3MgcHJv cGVydGllc1tdKSB7Ci0gICAgICAgICAgICBmb3IgKFVJbnQzMiBpID0gMDsgaSA8IGNvdW50OyAr K2kpIHsKLSAgICAgICAgICAgICAgICBjb25zdCBBdWRpb09iamVjdFByb3BlcnR5QWRkcmVzcyYg cHJvcGVydHkgPSBwcm9wZXJ0aWVzW2ldOwotCi0gICAgICAgICAgICAgICAgaWYgKHByb3BlcnR5 Lm1TZWxlY3RvciAhPSBrQXVkaW9IYXJkd2FyZVByb3BlcnR5RGV2aWNlcykKLSAgICAgICAgICAg ICAgICAgICAgY29udGludWU7Ci0KLSAgICAgICAgICAgICAgICBDb3JlQXVkaW9DYXB0dXJlRGV2 aWNlTWFuYWdlcjo6c2luZ2xldG9uKCkucmVmcmVzaEF1ZGlvQ2FwdHVyZURldmljZXMoTm90aWZ5 SWZEZXZpY2VzSGF2ZUNoYW5nZWQ6Ok5vdGlmeSk7Ci0gICAgICAgICAgICAgICAgcmV0dXJuOwor ICAgICAgICAgICAgYm9vbCBub3RpZnkgPSBmYWxzZTsKKyAgICAgICAgICAgIGZvciAoVUludDMy IGkgPSAwOyBpIDwgY291bnQ7ICsraSkKKyAgICAgICAgICAgICAgICBub3RpZnkgfD0gKHByb3Bl cnRpZXNbaV0ubVNlbGVjdG9yID09IGtBdWRpb0hhcmR3YXJlUHJvcGVydHlEZXZpY2VzIHx8IHBy b3BlcnRpZXNbaV0ubVNlbGVjdG9yID09IGtBdWRpb0hhcmR3YXJlUHJvcGVydHlEZWZhdWx0SW5w dXREZXZpY2UpOworCisgICAgICAgICAgICBpZiAobm90aWZ5KSB7CisgICAgICAgICAgICAgICAg Y2FsbE9uTWFpblRocmVhZChbXSB7CisgICAgICAgICAgICAgICAgICAgIENvcmVBdWRpb0NhcHR1 cmVEZXZpY2VNYW5hZ2VyOjpzaW5nbGV0b24oKS5yZWZyZXNoQXVkaW9DYXB0dXJlRGV2aWNlcyhO b3RpZnlJZkRldmljZXNIYXZlQ2hhbmdlZDo6Tm90aWZ5KTsKKyAgICAgICAgICAgICAgICB9KTsK ICAgICAgICAgICAgIH0KICAgICAgICAgfTsKIApAQCAtMTU4LDYgKzE1OSw4IEBAIE9wdGlvbmFs PENvcmVBdWRpb0NhcHR1cmVEZXZpY2U+IENvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyOjpj b3JlQXVkaW9EZXZpY2VXCiAKIHZvaWQgQ29yZUF1ZGlvQ2FwdHVyZURldmljZU1hbmFnZXI6OnJl ZnJlc2hBdWRpb0NhcHR1cmVEZXZpY2VzKE5vdGlmeUlmRGV2aWNlc0hhdmVDaGFuZ2VkIG5vdGlm eSkKIHsKKyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworCiAgICAgQXVkaW9PYmplY3RQcm9w ZXJ0eUFkZHJlc3MgYWRkcmVzcyA9IHsga0F1ZGlvSGFyZHdhcmVQcm9wZXJ0eURldmljZXMsIGtB dWRpb09iamVjdFByb3BlcnR5U2NvcGVHbG9iYWwsIGtBdWRpb09iamVjdFByb3BlcnR5RWxlbWVu dE1hc3RlciB9OwogICAgIFVJbnQzMiBkYXRhU2l6ZSA9IDA7CiAgICAgYXV0byBlcnIgPSBBdWRp b09iamVjdEdldFByb3BlcnR5RGF0YVNpemUoa0F1ZGlvT2JqZWN0U3lzdGVtT2JqZWN0LCAmYWRk cmVzcywgMCwgbnVsbHB0ciwgJmRhdGFTaXplKTsK 382740 2019-11-04 08:10:29 -0800 2019-11-04 08:42:38 -0800 Patch for landing. bug-203407-20191104081029.patch text/plain 3428 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxOTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjM4MWRjYWU3ZTIzNmZi MmJkOGEzYWI4NTFiODRkMjRkZDUzZjI3MC4uNDlmNjAwYjhkNDY1OTE0YmZmMmVkMTc5OGI5OWNm ZWM5YjEzODc0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTExLTA0ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIGVudW1lcmF0ZURl dmljZXMoKSBkb2Vzbid0IHJldHVybiBjb3JyZWN0IGxpc3Qgb2YgZGV2aWNlcyBhZnRlciBkZXZp Y2Ugd2FzIGNoYW5nZWQgYnkgdXNlciBpbiBhIHN5c3RlbSBwcmVmZXJlbmNlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzNDA3CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81NjY0ODA2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFi bGV0LgorCisgICAgICAgIFRlc3RlZCBtYW51YWxseSBhcyB0aGlzIGRvZXNuJ3QgcmVwcm9kdWNl IHdpdGggbW9jayBjYXB0dXJlIGRldmljZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0 cmVhbS9tYWMvQ29yZUF1ZGlvQ2FwdHVyZURldmljZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q29yZUF1ZGlvQ2FwdHVyZURldmljZU1hbmFnZXI6OmNvcmVBdWRpb0NhcHR1cmVEZXZp Y2VzKTogUmVmcmVzaCB0aGUgbGlzdCBvZiBjYXB0dXJlCisgICAgICAgIGRldmljZXMgd2hlbiB0 aGUgZGVmYXVsdCBpbnB1dCBkZXZpY2UgY2hhbmdlcy4KKyAgICAgICAgKFdlYkNvcmU6OkNvcmVB dWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyOjpyZWZyZXNoQXVkaW9DYXB0dXJlRGV2aWNlcyk6IEFz c2VydCBpZiBub3QgY2FsbGVkCisgICAgICAgIG9uIHRoZSBtYWluIHRocmVhZC4KKwogMjAxOS0x MS0wNCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgT3JkZXIg b2YgcG9zdE1lc3NhZ2UgYW5kIGZldGNoIGV2ZW50cyBzaG91bGQgYmUgcHJlc2VydmVkIHdoZW4g Z29pbmcgZnJvbSBjbGllbnQgdG8gc2VydmljZSB3b3JrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9Db3JlQXVkaW9DYXB0dXJlRGV2aWNlTWFu YWdlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQ29yZUF1 ZGlvQ2FwdHVyZURldmljZU1hbmFnZXIuY3BwCmluZGV4IDk4ODdiYzIwODBlMzc5MGJkOTNhNzli NjJiZjMwZjRmZTI4NmU1NTQuLjhjY2Q4ODExYmUyZGExN2NmZmE3MTMwNmExZjVlY2M3ZDgxZGRm ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9D b3JlQXVkaW9DYXB0dXJlRGV2aWNlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vbWFjL0NvcmVBdWRpb0NhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcApA QCAtMzYsNiArMzYsNyBAQAogI2luY2x1ZGUgPENvcmVNZWRpYS9DTVN5bmMuaD4KICNpbmNsdWRl IDxwYWwvc3BpL2NmL0NvcmVBdWRpb1NQSS5oPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+ CisjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95 ZWQuaD4KIAogI2ltcG9ydCA8cGFsL2NmL0NvcmVNZWRpYVNvZnRMaW5rLmg+CkBAIC0xMjIsMTUg KzEyMywxMiBAQCBWZWN0b3I8Q29yZUF1ZGlvQ2FwdHVyZURldmljZT4mIENvcmVBdWRpb0NhcHR1 cmVEZXZpY2VNYW5hZ2VyOjpjb3JlQXVkaW9DYXB0dXJlRAogICAgICAgICByZWZyZXNoQXVkaW9D YXB0dXJlRGV2aWNlcyhOb3RpZnlJZkRldmljZXNIYXZlQ2hhbmdlZDo6RG9Ob3ROb3RpZnkpOwog CiAgICAgICAgIGF1dG8gbGlzdGVuZXIgPSBeKFVJbnQzMiBjb3VudCwgY29uc3QgQXVkaW9PYmpl Y3RQcm9wZXJ0eUFkZHJlc3MgcHJvcGVydGllc1tdKSB7Ci0gICAgICAgICAgICBmb3IgKFVJbnQz MiBpID0gMDsgaSA8IGNvdW50OyArK2kpIHsKLSAgICAgICAgICAgICAgICBjb25zdCBBdWRpb09i amVjdFByb3BlcnR5QWRkcmVzcyYgcHJvcGVydHkgPSBwcm9wZXJ0aWVzW2ldOwotCi0gICAgICAg ICAgICAgICAgaWYgKHByb3BlcnR5Lm1TZWxlY3RvciAhPSBrQXVkaW9IYXJkd2FyZVByb3BlcnR5 RGV2aWNlcykKLSAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICBib29s IG5vdGlmeSA9IGZhbHNlOworICAgICAgICAgICAgZm9yIChVSW50MzIgaSA9IDA7IGkgPCBjb3Vu dDsgKytpKQorICAgICAgICAgICAgICAgIG5vdGlmeSB8PSAocHJvcGVydGllc1tpXS5tU2VsZWN0 b3IgPT0ga0F1ZGlvSGFyZHdhcmVQcm9wZXJ0eURldmljZXMgfHwgcHJvcGVydGllc1tpXS5tU2Vs ZWN0b3IgPT0ga0F1ZGlvSGFyZHdhcmVQcm9wZXJ0eURlZmF1bHRJbnB1dERldmljZSk7CiAKKyAg ICAgICAgICAgIGlmIChub3RpZnkpCiAgICAgICAgICAgICAgICAgQ29yZUF1ZGlvQ2FwdHVyZURl dmljZU1hbmFnZXI6OnNpbmdsZXRvbigpLnJlZnJlc2hBdWRpb0NhcHR1cmVEZXZpY2VzKE5vdGlm eUlmRGV2aWNlc0hhdmVDaGFuZ2VkOjpOb3RpZnkpOwotICAgICAgICAgICAgICAgIHJldHVybjsK LSAgICAgICAgICAgIH0KICAgICAgICAgfTsKIAogICAgICAgICBBdWRpb09iamVjdFByb3BlcnR5 QWRkcmVzcyBhZGRyZXNzID0geyBrQXVkaW9IYXJkd2FyZVByb3BlcnR5RGV2aWNlcywga0F1ZGlv T2JqZWN0UHJvcGVydHlTY29wZUdsb2JhbCwga0F1ZGlvT2JqZWN0UHJvcGVydHlFbGVtZW50TWFz dGVyIH07CkBAIC0xNTgsNiArMTU2LDggQEAgT3B0aW9uYWw8Q29yZUF1ZGlvQ2FwdHVyZURldmlj ZT4gQ29yZUF1ZGlvQ2FwdHVyZURldmljZU1hbmFnZXI6OmNvcmVBdWRpb0RldmljZVcKIAogdm9p ZCBDb3JlQXVkaW9DYXB0dXJlRGV2aWNlTWFuYWdlcjo6cmVmcmVzaEF1ZGlvQ2FwdHVyZURldmlj ZXMoTm90aWZ5SWZEZXZpY2VzSGF2ZUNoYW5nZWQgbm90aWZ5KQogeworICAgIEFTU0VSVChpc01h aW5UaHJlYWQoKSk7CisKICAgICBBdWRpb09iamVjdFByb3BlcnR5QWRkcmVzcyBhZGRyZXNzID0g eyBrQXVkaW9IYXJkd2FyZVByb3BlcnR5RGV2aWNlcywga0F1ZGlvT2JqZWN0UHJvcGVydHlTY29w ZUdsb2JhbCwga0F1ZGlvT2JqZWN0UHJvcGVydHlFbGVtZW50TWFzdGVyIH07CiAgICAgVUludDMy IGRhdGFTaXplID0gMDsKICAgICBhdXRvIGVyciA9IEF1ZGlvT2JqZWN0R2V0UHJvcGVydHlEYXRh U2l6ZShrQXVkaW9PYmplY3RTeXN0ZW1PYmplY3QsICZhZGRyZXNzLCAwLCBudWxscHRyLCAmZGF0 YVNpemUpOwo=