<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>203387</bug_id>
          
          <creation_ts>2019-10-24 16:13:14 -0700</creation_ts>
          <short_desc>[JSC] SamplingProfiler is getting stale CallSiteIndex</short_desc>
          <delta_ts>2020-06-15 10:08:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>213108</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1583577</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-10-24 16:13:14 -0700</bug_when>
    <thetext>[JSC] SamplingProfiler is getting stale CallSiteIndex</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1583578</commentid>
    <comment_count>1</comment_count>
      <attachid>381853</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-10-24 16:13:28 -0700</bug_when>
    <thetext>Created attachment 381853
Patch

WIP</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1583622</commentid>
    <comment_count>2</comment_count>
      <attachid>381853</attachid>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-10-24 18:30:25 -0700</bug_when>
    <thetext>Comment on attachment 381853
Patch

Attachment 381853 did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/13174865

New failing tests:
stress/disposable-call-site-index-with-call-and-this.js.ftl-eager-no-cjit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1612961</commentid>
    <comment_count>3</comment_count>
      <attachid>381853</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2020-01-30 08:33:05 -0800</bug_when>
    <thetext>Comment on attachment 381853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381853&amp;action=review

&gt; Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp:133
&gt; +    // We will dispose when GCAwareJITStubRoutineWithExceptionHandler is destroyed, wihch is driven by GC after SamplingProfiler uses it well.

/wihch/which/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1662685</commentid>
    <comment_count>4</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-06-15 10:08:41 -0700</bug_when>
    <thetext>Fixed by bug 213108.

*** This bug has been marked as a duplicate of bug 213108 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>381853</attachid>
            <date>2019-10-24 16:13:28 -0700</date>
            <delta_ts>2019-10-24 18:30:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-203387-20191024161328.patch</filename>
            <type>text/plain</type>
            <size>3671</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2
ZTYzNTQ3MGUwNjAxNmRmZjFhNzFkNmYwYzIxNDU2ZjdjYjI3MzgzLi5lOGFiYzFhMjViOWIyNmMz
MDc1YjhiNzdjMTEyNGIxMjI0MTM0NDFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNSBAQAorMjAxOS0xMC0yNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t
PgorCisgICAgICAgIFtKU0NdIFNhbXBsaW5nUHJvZmlsZXIgaXMgZ2V0dGluZyBzdGFsZSBDYWxs
U2l0ZUluZGV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMDMzODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIGppdC9HQ0F3YXJlSklUU3R1YlJvdXRpbmUuY3BwOgorICAgICAgICAoSlNDOjpHQ0F3YXJl
SklUU3R1YlJvdXRpbmVXaXRoRXhjZXB0aW9uSGFuZGxlcjo6fkdDQXdhcmVKSVRTdHViUm91dGlu
ZVdpdGhFeGNlcHRpb25IYW5kbGVyKToKKyAgICAgICAgKEpTQzo6R0NBd2FyZUpJVFN0dWJSb3V0
aW5lV2l0aEV4Y2VwdGlvbkhhbmRsZXI6Om9ic2VydmVaZXJvUmVmQ291bnQpOgorICAgICAgICAq
IGppdC9HQ0F3YXJlSklUU3R1YlJvdXRpbmUuaDoKKwogMjAxOS0xMC0yNCAgWXVzdWtlIFN1enVr
aSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFByb3Blcmx5IG9yZ2FuaXpl
IHdhc20gb3BlcmF0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9H
Q0F3YXJlSklUU3R1YlJvdXRpbmUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9HQ0F3
YXJlSklUU3R1YlJvdXRpbmUuY3BwCmluZGV4IGQ1MDFkOTE1ZGJkMzI2MzgwNTBhMjQ4YTQ0ZTU1
OWI3YjlmNTMzYTEuLmQwMzY0NGQwNDkwOTBhYTU0MmRlMGU4M2U2OWVjMTI1ODhlMTZkZmYgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvR0NBd2FyZUpJVFN0dWJSb3V0aW5l
LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0dDQXdhcmVKSVRTdHViUm91dGlu
ZS5jcHAKQEAgLTExMSw2ICsxMTEsMTYgQEAgR0NBd2FyZUpJVFN0dWJSb3V0aW5lV2l0aEV4Y2Vw
dGlvbkhhbmRsZXI6OkdDQXdhcmVKSVRTdHViUm91dGluZVdpdGhFeGNlcHRpb25IYW4KICAgICBB
U1NFUlQoISFtX2NvZGVCbG9ja1dpdGhFeGNlcHRpb25IYW5kbGVyLT5oYW5kbGVyRm9ySW5kZXgo
ZXhjZXB0aW9uSGFuZGxlckNhbGxTaXRlSW5kZXguYml0cygpKSk7CiB9CiAKK0dDQXdhcmVKSVRT
dHViUm91dGluZVdpdGhFeGNlcHRpb25IYW5kbGVyOjp+R0NBd2FyZUpJVFN0dWJSb3V0aW5lV2l0
aEV4Y2VwdGlvbkhhbmRsZXIoKQoreworI2lmIEVOQUJMRShERkdfSklUKQorICAgIC8vIG1fY29k
ZUJsb2NrV2l0aEV4Y2VwdGlvbkhhbmRsZXIgaXMgY2xlYXJlZCwgaXQgbWVhbnMgbV9jb2RlQmxv
Y2tXaXRoRXhjZXB0aW9uSGFuZGxlciBpcyBkeWluZyB0b28uCisgICAgLy8gV2UgZG8gbm90IG5l
ZWQgdG8gZGlzcG9zZSBDYWxsU2l0ZUluZGV4IGhlcmUuCisgICAgaWYgKG1fY29kZUJsb2NrV2l0
aEV4Y2VwdGlvbkhhbmRsZXIpCisgICAgICAgIG1fY29kZUJsb2NrV2l0aEV4Y2VwdGlvbkhhbmRs
ZXItPmppdENvZGUoKS0+ZGZnQ29tbW9uKCktPnJlbW92ZURpc3Bvc2FibGVDYWxsU2l0ZUluZGV4
KG1fZXhjZXB0aW9uSGFuZGxlckNhbGxTaXRlSW5kZXgpOworI2VuZGlmCit9CisKIHZvaWQgR0NB
d2FyZUpJVFN0dWJSb3V0aW5lV2l0aEV4Y2VwdGlvbkhhbmRsZXI6OmFib3V0VG9EaWUoKQogewog
ICAgIG1fY29kZUJsb2NrV2l0aEV4Y2VwdGlvbkhhbmRsZXIgPSBudWxscHRyOwpAQCAtMTE5LDEx
ICsxMjksMTAgQEAgdm9pZCBHQ0F3YXJlSklUU3R1YlJvdXRpbmVXaXRoRXhjZXB0aW9uSGFuZGxl
cjo6YWJvdXRUb0RpZSgpCiB2b2lkIEdDQXdhcmVKSVRTdHViUm91dGluZVdpdGhFeGNlcHRpb25I
YW5kbGVyOjpvYnNlcnZlWmVyb1JlZkNvdW50KCkKIHsKICNpZiBFTkFCTEUoREZHX0pJVCkKLSAg
ICBpZiAobV9jb2RlQmxvY2tXaXRoRXhjZXB0aW9uSGFuZGxlcikgewotICAgICAgICBtX2NvZGVC
bG9ja1dpdGhFeGNlcHRpb25IYW5kbGVyLT5qaXRDb2RlKCktPmRmZ0NvbW1vbigpLT5yZW1vdmVE
aXNwb3NhYmxlQ2FsbFNpdGVJbmRleChtX2V4Y2VwdGlvbkhhbmRsZXJDYWxsU2l0ZUluZGV4KTsK
KyAgICAvLyBXZSB1bnJlZ2lzdGVyIGV4Y2VwdGlvbiBoYW5kbGVyLCBidXQgd2UgZG8gbm90IGlt
bWVkaWRhdGVseSBkaXNwb3NlIERpc3Bvc2FibGVDYWxsU2l0ZUluZGV4LCBiZWNhdXNlIGl0IGlz
IHN0aWxsIHVzZWQgaW4gU2FtcGxpbmdQcm9maWxlci4KKyAgICAvLyBXZSB3aWxsIGRpc3Bvc2Ug
d2hlbiBHQ0F3YXJlSklUU3R1YlJvdXRpbmVXaXRoRXhjZXB0aW9uSGFuZGxlciBpcyBkZXN0cm95
ZWQsIHdpaGNoIGlzIGRyaXZlbiBieSBHQyBhZnRlciBTYW1wbGluZ1Byb2ZpbGVyIHVzZXMgaXQg
d2VsbC4KKyAgICBpZiAobV9jb2RlQmxvY2tXaXRoRXhjZXB0aW9uSGFuZGxlcikKICAgICAgICAg
bV9jb2RlQmxvY2tXaXRoRXhjZXB0aW9uSGFuZGxlci0+cmVtb3ZlRXhjZXB0aW9uSGFuZGxlckZv
ckNhbGxTaXRlKG1fZXhjZXB0aW9uSGFuZGxlckNhbGxTaXRlSW5kZXgpOwotICAgICAgICBtX2Nv
ZGVCbG9ja1dpdGhFeGNlcHRpb25IYW5kbGVyID0gbnVsbHB0cjsKLSAgICB9CiAjZW5kaWYKIAog
ICAgIEJhc2U6Om9ic2VydmVaZXJvUmVmQ291bnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9qaXQvR0NBd2FyZUpJVFN0dWJSb3V0aW5lLmggYi9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvaml0L0dDQXdhcmVKSVRTdHViUm91dGluZS5oCmluZGV4IDQ3MWE2NzUxZTY2MTkwZjY2
YmE1MDNmMTMzZWIzMTI1NDQ2YmMxZDAuLjRjOWYzNjRmYjRkYjg4MGNmMjMzYmY2NzA3NjVhNDMw
YmZlYWZkNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvR0NBd2FyZUpJ
VFN0dWJSb3V0aW5lLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9HQ0F3YXJlSklU
U3R1YlJvdXRpbmUuaApAQCAtOTUsNiArOTUsNyBAQCBjbGFzcyBHQ0F3YXJlSklUU3R1YlJvdXRp
bmVXaXRoRXhjZXB0aW9uSGFuZGxlciA6IHB1YmxpYyBNYXJraW5nR0NBd2FyZUpJVFN0dWJSbwog
ICAgIHR5cGVkZWYgR0NBd2FyZUpJVFN0dWJSb3V0aW5lIEJhc2U7CiAKICAgICBHQ0F3YXJlSklU
U3R1YlJvdXRpbmVXaXRoRXhjZXB0aW9uSGFuZGxlcihjb25zdCBNYWNyb0Fzc2VtYmxlckNvZGVS
ZWY8SklUU3R1YlJvdXRpbmVQdHJUYWc+JiwgVk0mLCBjb25zdCBKU0NlbGwqIG93bmVyLCBjb25z
dCBWZWN0b3I8SlNDZWxsKj4mLCBDb2RlQmxvY2sqLCBEaXNwb3NhYmxlQ2FsbFNpdGVJbmRleCk7
CisgICAgdmlydHVhbCB+R0NBd2FyZUpJVFN0dWJSb3V0aW5lV2l0aEV4Y2VwdGlvbkhhbmRsZXIo
KTsKIAogICAgIHZvaWQgYWJvdXRUb0RpZSgpIG92ZXJyaWRlOwogICAgIHZvaWQgb2JzZXJ2ZVpl
cm9SZWZDb3VudCgpIG92ZXJyaWRlOwo=
</data>
<flag name="commit-queue"
          id="397607"
          type_id="3"
          status="-"
          setter="ews-watchlist"
    />
          </attachment>
      

    </bug>

</bugzilla>