20338 2008-08-08 18:28:55 -0700 [Gtk] Autotools should check for libxslt 2008-08-09 20:30:56 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED INVALID Gtk P2 Normal --- 1 jmalonzo webkit-unassigned alp oldest_to_newest 88143 0 jmalonzo 2008-08-08 18:28:55 -0700 We're not checking for libxslt and hence, missing -lxslt in the build. 88144 1 22716 jmalonzo 2008-08-08 18:29:24 -0700 Created attachment 22716 check for libxslt in autotools 88160 2 22716 mrowe 2008-08-09 18:35:22 -0700 Comment on attachment 22716 check for libxslt in autotools r=me 88164 3 jmalonzo 2008-08-09 19:04:01 -0700 Thanks. landed in r35654 88165 4 alp 2008-08-09 19:52:33 -0700 Hi, The patch was missing a $ and broke the build: + libxslt >= LIBXSLT_REQUIRED_VERSION Moreover, we do check for libxslt, but only if XSL support is enabled in configure: # check if libxslt is available if test "$enable_xslt" = "yes"; then PKG_CHECK_MODULES([LIBXSLT],[libxslt >= $LIBXSLT_REQUIRED_VERSION]) AC_SUBST([LIBXSLT_CFLAGS]) AC_SUBST([LIBXSLT_LIBS]) fi Jan, was the existing XSLT check broken for you? 88166 5 alp 2008-08-09 20:02:05 -0700 (In reply to comment #3) > Thanks. landed in r35654 > Backed out in r35655 to get things building. Jan, can you describe the configure issue so we can try again if there's still an issue? Cheers 88168 6 jmalonzo 2008-08-09 20:30:56 -0700 Hi Alp Thanks for the rollback. This issue doesn't seem to be a WebKit/Gtk issue, but rather a packaged webkitgtk issue. Closing as INVALID as we don't really have to do anything here. FYI, I think you need to update the changelog which revision was actually rolled back. Here's your commit message: GTK+ build fixes. Back out r20338 libxslt check (conditional check already exists and this broke the build). Make the flex version check a warning rather than fatal to fix the build bot. Cheers 22716 2008-08-08 18:29:24 -0700 2008-08-09 18:35:22 -0700 check for libxslt in autotools webkitgtk-libxslt-check.patch text/plain 848 jmalonzo ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzY2ViZWRkLi41ZjM4NTQ1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAK KzIwMDgtMDgtMDggIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXV0b3Rvb2xz IGNoZWNrIGZvciBsaWJ4c2x0CisKKyAgICAgICAgKiBjb25maWd1cmUuYWM6CisKIDIwMDgtMDgt MDcgIEthbGxlIFZhaGxtYW4gIDx6dWhAaWtpLmZpPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh dmlkIEtpbHplci4KZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRl eCA0ZDI2Y2M0Li4xMmNmMDlkIDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmln dXJlLmFjCkBAIC0yODQsNiArMjg0LDcgQEAgUEtHX0NIRUNLX01PRFVMRVMoW1dFQktJVERFUFNd LAogICAgICAgICAgICAgICAgICAgW2d0aystMi4wID49ICRHVEtfUkVRVUlSRURfVkVSU0lPTgog ICAgICAgICAgICAgICAgICAgcGFuZ28gPj0gJFBBTkdPX1JFUVVJUkVEX1ZFUlNJT04KICAgICAg ICAgICAgICAgICAgIGNhaXJvID49ICRDQUlST19SRVFVSVJFRF9WRVJTSU9OCisgICAgICAgICAg ICAgICAgICBsaWJ4c2x0ID49IExJQlhTTFRfUkVRVUlSRURfVkVSU0lPTgogICAgICAgICAgICAg ICAgICAgbGlieG1sLTIuMCA+PSAkTElCWE1MX1JFUVVJUkVEX1ZFUlNJT05dKQogQUNfU1VCU1Qo W1dFQktJVERFUFNfQ0ZMQUdTXSkKIEFDX1NVQlNUKFtXRUJLSVRERVBTX0xJQlNdKQo=