203339 2019-10-23 14:47:27 -0700 Undo incidental change from BytecodeIndex class patch 2019-10-23 20:09:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1583056 0 keith_miller 2019-10-23 14:47:27 -0700 Undo incidental change from BytecodeIndex class patch 1583058 1 381733 keith_miller 2019-10-23 14:54:12 -0700 Created attachment 381733 Patch 1583060 2 keith_miller 2019-10-23 14:54:59 -0700 rdar://problem/56529630 1583066 3 381733 mark.lam 2019-10-23 15:09:00 -0700 Comment on attachment 381733 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381733&action=review > Source/JavaScriptCore/ChangeLog:11 > + It's not totally clear why we need to claim our bytecode index is > +we can't figure what the true index is. I'd rather unbreak > + our build for now, however, and fix the underlying issue in > + https://bugs.webkit.org/show_bug.cgi?id=203340 Can you fix this? 1583069 4 381733 keith_miller 2019-10-23 15:10:54 -0700 Comment on attachment 381733 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381733&action=review >> Source/JavaScriptCore/ChangeLog:11 >> + https://bugs.webkit.org/show_bug.cgi?id=203340 > > Can you fix this? Woah, weird. Sure. 1583070 5 381736 keith_miller 2019-10-23 15:11:00 -0700 Created attachment 381736 Patch 1583073 6 381736 mark.lam 2019-10-23 15:14:12 -0700 Comment on attachment 381736 Patch r=me if JSC tests are green. 1583203 7 381736 commit-queue 2019-10-23 20:09:20 -0700 Comment on attachment 381736 Patch Clearing flags on attachment: 381736 Committed r251525: <https://trac.webkit.org/changeset/251525> 1583205 8 commit-queue 2019-10-23 20:09:30 -0700 All reviewed patches have been landed. Closing bug. 381733 2019-10-23 14:54:12 -0700 2019-10-23 15:10:58 -0700 Patch bug-203339-20191023145411.patch text/plain 2853 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZjRlODVmYTFkYThkODczMjhiNjliMWJkNTQzZDBkZmJjZmZiYThkLi42ZjNmYWJlZTY3MWNlOWQ4 ZDA5YjEyMTE4NzFjYzY2NDNiZmEwNDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0xMC0yMyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBVbmRvIGluY2lkZW50YWwgY2hhbmdlIGZyb20gQnl0ZWNvZGVJbmRl eCBjbGFzcyBwYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAzMzM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSXQncyBub3QgdG90YWxseSBjbGVhciB3aHkgd2UgbmVlZCB0byBjbGFpbSBvdXIgYnl0 ZWNvZGUgaW5kZXggaXMKK3dlIGNhbid0IGZpZ3VyZSB3aGF0IHRoZSB0cnVlIGluZGV4IGlzLiBJ J2QgcmF0aGVyIHVuYnJlYWsKKyAgICAgICAgb3VyIGJ1aWxkIGZvciBub3csIGhvd2V2ZXIsIGFu ZCBmaXggdGhlIHVuZGVybHlpbmcgaXNzdWUgaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzM0MAorCisgICAgICAgICogcnVudGltZS9FcnJvci5j cHA6CisgICAgICAgIChKU0M6OmdldEJ5dGVjb2RlSW5kZXgpOgorCiAyMDE5LTEwLTIzICBSb3Nz IEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBTdHJpbmcucHJv dG90eXBlLm1hdGNoQWxsIHNob3VsZCB0aHJvdyBvbiBub24tZ2xvYmFsIHJlZ2V4CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FcnJvci5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9FcnJvci5jcHAKaW5kZXggNDFmZGFhNDExN2YwMzcxZGFhZGM1 N2Q3ZTMyNjY2YmE1YWRiZWQ4Ny4uOWYzOTlkY2M0YjljNWE3YjA5YzM2ZGFkZjk1ZTM5NzM2NWFi Yjc3NSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXJyb3IuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Vycm9yLmNwcApAQCAtMTcyLDcg KzE3Miw3IEBAIHZvaWQgZ2V0Qnl0ZWNvZGVJbmRleChWTSYgdm0sIENhbGxGcmFtZSogc3RhcnRD YWxsRnJhbWUsIFZlY3RvcjxTdGFja0ZyYW1lPiogc3RhCiAgICAgU3RhY2tWaXNpdG9yOjp2aXNp dCh2bS50b3BDYWxsRnJhbWUsIHZtLCBmdW5jdG9yKTsKICAgICBjYWxsRnJhbWUgPSBmdW5jdG9y LmZvdW5kQ2FsbEZyYW1lKCk7CiAgICAgdW5zaWduZWQgc3RhY2tJbmRleCA9IGZ1bmN0b3IuaW5k ZXgoKTsKLSAgICBieXRlY29kZUluZGV4ID0gQnl0ZWNvZGVJbmRleCgpOworICAgIGJ5dGVjb2Rl SW5kZXggPSBCeXRlY29kZUluZGV4KDApOwogICAgIGlmIChzdGFja1RyYWNlICYmIHN0YWNrSW5k ZXggPCBzdGFja1RyYWNlLT5zaXplKCkgJiYgc3RhY2tUcmFjZS0+YXQoc3RhY2tJbmRleCkuaGFz Qnl0ZWNvZGVJbmRleCgpKQogICAgICAgICBieXRlY29kZUluZGV4ID0gc3RhY2tUcmFjZS0+YXQo c3RhY2tJbmRleCkuYnl0ZWNvZGVJbmRleCgpOwogfQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFu Z2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBjZTk4ODFlZjIzNmRlZWY3Y2Q3N2JhNDQ0 MjU2MTY2MDBjYTRiMWIyLi5iMTFjOGY1Y2EwOWY0M2E0NTAwMDFkODA5NjJjZGRhMjViMTQ5NTE0 IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEyIEBACisyMDE5LTEwLTIzICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJA YXBwbGUuY29tPgorCisgICAgICAgIFVuZG8gaW5jaWRlbnRhbCBjaGFuZ2UgZnJvbSBCeXRlY29k ZUluZGV4IGNsYXNzIHBhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDMzMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHN0cmVzcy9lcnJvci1zb3VyY2UtbG9jYXRpb24tYXNzZXJ0aW9uLmpzOiBB ZGRlZC4KKwogMjAxOS0xMC0yMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5j b20+CiAKICAgICAgICAgU3RyaW5nLnByb3RvdHlwZS5tYXRjaEFsbCBzaG91bGQgdGhyb3cgb24g bm9uLWdsb2JhbCByZWdleApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvZXJyb3Itc291cmNl LWxvY2F0aW9uLWFzc2VydGlvbi5qcyBiL0pTVGVzdHMvc3RyZXNzL2Vycm9yLXNvdXJjZS1sb2Nh dGlvbi1hc3NlcnRpb24uanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzg0ZTQ1YThkMTU3MDEwOGYyNzk4ZmYwZDcy OTFlYTA1ODQ2NWU0NgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL2Vycm9yLXNv dXJjZS1sb2NhdGlvbi1hc3NlcnRpb24uanMKQEAgLTAsMCArMSw3IEBACisvL0AgcmVxdWlyZU9w dGlvbnMoIi0tdXNlUmFuZG9taXppbmdGdXp6ZXJBZ2VudD0xIiwgIi0taml0UG9saWN5U2NhbGU9 MCIsICItLXVzZUNvbmN1cnJlbnRKSVQ9MCIpCitjb25zdCBmID0gVWludDhBcnJheS5vZjsKK2Zv ciAobGV0IGk9MDsgaTwyOyBpKyspIHsKKyAgdHJ5IHsKKyAgICBmKCk7CisgIH0gY2F0Y2gge30K K30K 381736 2019-10-23 15:11:00 -0700 2019-10-23 20:09:20 -0700 Patch bug-203339-20191023151059.patch text/plain 2868 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZjRlODVmYTFkYThkODczMjhiNjliMWJkNTQzZDBkZmJjZmZiYThkLi40YzdjN2FlOTUwMzI4YTQw NWI5MTlmYWIxN2M4YzVjZWE1MDBiNzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0xMC0yMyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBVbmRvIGluY2lkZW50YWwgY2hhbmdlIGZyb20gQnl0ZWNvZGVJbmRl eCBjbGFzcyBwYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAzMzM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSXQncyBub3QgdG90YWxseSBjbGVhciB3aHkgd2UgbmVlZCB0byBjbGFpbSBvdXIgYnl0 ZWNvZGUgaW5kZXggaXMKKyAgICAgICAgMCB3aGVuIHdlIGNhbid0IGZpZ3VyZSB3aGF0IHRoZSB0 cnVlIGluZGV4IGlzLiBJJ2QgcmF0aGVyIHVuYnJlYWsKKyAgICAgICAgb3VyIGJ1aWxkIGZvciBu b3csIGhvd2V2ZXIsIGFuZCBmaXggdGhlIHVuZGVybHlpbmcgaXNzdWUgaW4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzM0MAorCisgICAgICAgICog cnVudGltZS9FcnJvci5jcHA6CisgICAgICAgIChKU0M6OmdldEJ5dGVjb2RlSW5kZXgpOgorCiAy MDE5LTEwLTIzICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAg ICAgICBTdHJpbmcucHJvdG90eXBlLm1hdGNoQWxsIHNob3VsZCB0aHJvdyBvbiBub24tZ2xvYmFs IHJlZ2V4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FcnJvci5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FcnJvci5jcHAKaW5kZXggNDFmZGFh NDExN2YwMzcxZGFhZGM1N2Q3ZTMyNjY2YmE1YWRiZWQ4Ny4uOWYzOTlkY2M0YjljNWE3YjA5YzM2 ZGFkZjk1ZTM5NzM2NWFiYjc3NSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvRXJyb3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Vycm9y LmNwcApAQCAtMTcyLDcgKzE3Miw3IEBAIHZvaWQgZ2V0Qnl0ZWNvZGVJbmRleChWTSYgdm0sIENh bGxGcmFtZSogc3RhcnRDYWxsRnJhbWUsIFZlY3RvcjxTdGFja0ZyYW1lPiogc3RhCiAgICAgU3Rh Y2tWaXNpdG9yOjp2aXNpdCh2bS50b3BDYWxsRnJhbWUsIHZtLCBmdW5jdG9yKTsKICAgICBjYWxs RnJhbWUgPSBmdW5jdG9yLmZvdW5kQ2FsbEZyYW1lKCk7CiAgICAgdW5zaWduZWQgc3RhY2tJbmRl eCA9IGZ1bmN0b3IuaW5kZXgoKTsKLSAgICBieXRlY29kZUluZGV4ID0gQnl0ZWNvZGVJbmRleCgp OworICAgIGJ5dGVjb2RlSW5kZXggPSBCeXRlY29kZUluZGV4KDApOwogICAgIGlmIChzdGFja1Ry YWNlICYmIHN0YWNrSW5kZXggPCBzdGFja1RyYWNlLT5zaXplKCkgJiYgc3RhY2tUcmFjZS0+YXQo c3RhY2tJbmRleCkuaGFzQnl0ZWNvZGVJbmRleCgpKQogICAgICAgICBieXRlY29kZUluZGV4ID0g c3RhY2tUcmFjZS0+YXQoc3RhY2tJbmRleCkuYnl0ZWNvZGVJbmRleCgpOwogfQpkaWZmIC0tZ2l0 IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBjZTk4ODFlZjIz NmRlZWY3Y2Q3N2JhNDQ0MjU2MTY2MDBjYTRiMWIyLi5iMTFjOGY1Y2EwOWY0M2E0NTAwMDFkODA5 NjJjZGRhMjViMTQ5NTE0IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTEwLTIzICBLZWl0aCBNaWxsZXIg IDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIFVuZG8gaW5jaWRlbnRhbCBjaGFu Z2UgZnJvbSBCeXRlY29kZUluZGV4IGNsYXNzIHBhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMzMzkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9lcnJvci1zb3VyY2UtbG9jYXRpb24t YXNzZXJ0aW9uLmpzOiBBZGRlZC4KKwogMjAxOS0xMC0yMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mu a2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgU3RyaW5nLnByb3RvdHlwZS5tYXRjaEFsbCBz aG91bGQgdGhyb3cgb24gbm9uLWdsb2JhbCByZWdleApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJl c3MvZXJyb3Itc291cmNlLWxvY2F0aW9uLWFzc2VydGlvbi5qcyBiL0pTVGVzdHMvc3RyZXNzL2Vy cm9yLXNvdXJjZS1sb2NhdGlvbi1hc3NlcnRpb24uanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzg0ZTQ1YThkMTU3 MDEwOGYyNzk4ZmYwZDcyOTFlYTA1ODQ2NWU0NgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMv c3RyZXNzL2Vycm9yLXNvdXJjZS1sb2NhdGlvbi1hc3NlcnRpb24uanMKQEAgLTAsMCArMSw3IEBA CisvL0AgcmVxdWlyZU9wdGlvbnMoIi0tdXNlUmFuZG9taXppbmdGdXp6ZXJBZ2VudD0xIiwgIi0t aml0UG9saWN5U2NhbGU9MCIsICItLXVzZUNvbmN1cnJlbnRKSVQ9MCIpCitjb25zdCBmID0gVWlu dDhBcnJheS5vZjsKK2ZvciAobGV0IGk9MDsgaTwyOyBpKyspIHsKKyAgdHJ5IHsKKyAgICBmKCk7 CisgIH0gY2F0Y2gge30KK30K