203307 2019-10-23 11:22:51 -0700 [LFC] LayoutState should have out-of-line destructor 2019-10-23 11:50:52 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1582904 0 koivisto 2019-10-23 11:22:51 -0700 Otherwise instantiating it requires a pile of other headers. 1582911 1 381705 koivisto 2019-10-23 11:26:42 -0700 Created attachment 381705 patch 1582926 2 381705 commit-queue 2019-10-23 11:49:45 -0700 Comment on attachment 381705 patch Clearing flags on attachment: 381705 Committed r251484: <https://trac.webkit.org/changeset/251484> 1582927 3 commit-queue 2019-10-23 11:49:46 -0700 All reviewed patches have been landed. Closing bug. 1582928 4 webkit-bug-importer 2019-10-23 11:50:52 -0700 <rdar://problem/56547886> 381705 2019-10-23 11:26:42 -0700 2019-10-23 11:49:45 -0700 patch layoutstate-destructor.patch text/plain 2702 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZWQxODU5NThlMy4uNmZiNzM0NWYxODIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0xMC0yMyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ10gTGF5b3V0U3RhdGUgc2hvdWxkIGhhdmUgb3V0LW9mLWxpbmUgZGVz dHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAzMzA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg T3RoZXJ3aXNlIGluc3RhbnRpYXRpbmcgaXQgcmVxdWlyZXMgYSBwaWxlIG9mIG90aGVyIGhlYWRl cnMuCisKKyAgICAgICAgKiBsYXlvdXQvTGF5b3V0U3RhdGUuY3BwOgorICAgICAgICAqIGxheW91 dC9MYXlvdXRTdGF0ZS5oOgorICAgICAgICAqIGxheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVC dWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6VHJlZUJ1aWxkZXI6OmNyZWF0 ZUxheW91dFRyZWUpOgorCisgICAgICAgIFVzZSBtYWtlVW5pcXVlLgorCiAyMDE5LTEwLTIyICBN aWd1ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihy MjQ0MzcyKTogW0dUS11bV1BFXSBmYXN0L2ltYWdlcy9pY29uLWRlY29kaW5nLmh0bWwgYW5kIG90 aGVycyBhcmUgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91 dFN0YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRTdGF0ZS5jcHAKaW5kZXgg NjY2NjJkOGI4OTMuLjExZDJjYjRkZGFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvTGF5b3V0U3RhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRTdGF0 ZS5jcHAKQEAgLTQ1LDYgKzQ1LDggQEAgTGF5b3V0U3RhdGU6OkxheW91dFN0YXRlKGNvbnN0IENv bnRhaW5lciYgcm9vdCkKICAgICBBU1NFUlQocm9vdC5lc3RhYmxpc2hlc0Zvcm1hdHRpbmdDb250 ZXh0KCkpOwogfQogCitMYXlvdXRTdGF0ZTo6fkxheW91dFN0YXRlKCkgPSBkZWZhdWx0OworCiBE aXNwbGF5OjpCb3gmIExheW91dFN0YXRlOjpkaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KGNvbnN0IEJv eCYgbGF5b3V0Qm94KQogewogICAgIHJldHVybiAqbV9sYXlvdXRUb0Rpc3BsYXlCb3guZW5zdXJl KCZsYXlvdXRCb3gsIFtdIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlv dXRTdGF0ZS5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91dFN0YXRlLmgKaW5kZXggNTgw NWJjMTUwYzIuLjljNjFlZDIzMzVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv TGF5b3V0U3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0U3RhdGUuaApA QCAtNDksNiArNDksNyBAQCBjbGFzcyBMYXlvdXRTdGF0ZSB7CiAgICAgV1RGX01BS0VfSVNPX0FM TE9DQVRFRChMYXlvdXRTdGF0ZSk7CiBwdWJsaWM6CiAgICAgTGF5b3V0U3RhdGUoY29uc3QgQ29u dGFpbmVyJiByb290KTsKKyAgICB+TGF5b3V0U3RhdGUoKTsKIAogICAgIEZvcm1hdHRpbmdTdGF0 ZSYgY3JlYXRlRm9ybWF0dGluZ1N0YXRlRm9yRm9ybWF0dGluZ1Jvb3RJZk5lZWRlZChjb25zdCBD b250YWluZXImIGZvcm1hdHRpbmdDb250ZXh0Um9vdCk7CiAgICAgRm9ybWF0dGluZ1N0YXRlJiBl c3RhYmxpc2hlZEZvcm1hdHRpbmdTdGF0ZShjb25zdCBDb250YWluZXImIGZvcm1hdHRpbmdSb290 KSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xh eW91dFRyZWVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xh eW91dFRyZWVCdWlsZGVyLmNwcAppbmRleCAxODQ4YmM3Zjg5YS4uOTQwMGQwOTEyM2IgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVp bGRlci5jcHAKQEAgLTgxLDcgKzgxLDcgQEAgc3RkOjp1bmlxdWVfcHRyPENvbnRhaW5lcj4gVHJl ZUJ1aWxkZXI6OmNyZWF0ZUxheW91dFRyZWUoY29uc3QgUmVuZGVyVmlldyYgcmVuZGUKICAgICBz dHlsZS5zZXRMb2dpY2FsV2lkdGgoTGVuZ3RoKHJlbmRlclZpZXcud2lkdGgoKSwgRml4ZWQpKTsK ICAgICBzdHlsZS5zZXRMb2dpY2FsSGVpZ2h0KExlbmd0aChyZW5kZXJWaWV3LmhlaWdodCgpLCBG aXhlZCkpOwogCi0gICAgc3RkOjp1bmlxdWVfcHRyPENvbnRhaW5lcj4gaW5pdGlhbENvbnRhaW5p bmdCbG9jayhuZXcgQ29udGFpbmVyKFdURjo6bnVsbG9wdCwgV1RGTW92ZShzdHlsZSkpKTsKKyAg ICBhdXRvIGluaXRpYWxDb250YWluaW5nQmxvY2sgPSBtYWtlVW5pcXVlPENvbnRhaW5lcj4oV1RG OjpudWxsb3B0LCBXVEZNb3ZlKHN0eWxlKSk7CiAgICAgVHJlZUJ1aWxkZXI6OmNyZWF0ZVN1YlRy ZWUocmVuZGVyVmlldywgKmluaXRpYWxDb250YWluaW5nQmxvY2spOwogICAgIHJldHVybiBpbml0 aWFsQ29udGFpbmluZ0Jsb2NrOwogfQo=