203264 2019-10-22 13:14:08 -0700 [iOS] 3 editing/pasteboard/smart-paste-paragraph-* tests are flaky 2025-09-15 20:13:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203281 InRadar P2 Normal --- 1 repstein com.webkit.iidmsa aakash_jain ap ayumi_kojima bdakin commit-queue jbedard megan_gardner thorton tsavell webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1582503 0 repstein 2019-10-22 13:14:08 -0700 The following three layout tests have been flaky on iOS since they landed in r243124: editing/pasteboard/smart-paste-paragraph-001.html editing/pasteboard/smart-paste-paragraph-002.html editing/pasteboard/smart-paste-paragraph-004.html Test History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=editing%2Fpasteboard%2Fsmart-paste-paragraph-001.html&test=editing%2Fpasteboard%2Fsmart-paste-paragraph-002.html&test=editing%2Fpasteboard%2Fsmart-paste-paragraph-004.html&platform=ios Steps to Reproduce: run-webkit-tests --ios-simulator --no-retry --no-sample-on-timeout -f editing/pasteboard/smart-paste-paragraph-001.html editing/pasteboard/smart-paste-paragraph-002.html editing/pasteboard/smart-paste-paragraph-004.html --iter 1000 Diffs: editing/pasteboard/smart-paste-paragraph-001.html Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/editing/pasteboard/smart-paste-paragraph-001-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/editing/pasteboard/smart-paste-paragraph-001-actual.txt @@ -7,10 +7,6 @@ EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted -EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 15 of #text > DIV > DIV > BODY > HTML > #document to 15 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification Tests: Smart paste when pasting a paragraph between two paragraphs. Expected Results: @@ -22,8 +18,6 @@ Last test paragraph. Test paragraph. -Test paragraph. - Last test paragraph. execCopyCommand: <div id="test"> Test paragraph. </div> <div><br></div> <div> Last test paragraph. </div> -execPasteCommand: <div id="test"> Test paragraph. </div> <div><br></div><div>Test paragraph.<br></div><div><br></div> <div> Last test paragraph. </div> +execPasteCommand: <div id="test"> Test paragraph. </div> <div><br></div> <div> Last test paragraph. </div> editing/pasteboard/smart-paste-paragraph-002.html Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/editing/pasteboard/smart-paste-paragraph-002-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/editing/pasteboard/smart-paste-paragraph-002-actual.txt @@ -7,10 +7,6 @@ EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 12 of #text > PRE > BODY > HTML > #document to 12 of #text > PRE > BODY > HTML > #document givenAction:WebViewInsertActionPasted -EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of PRE > BODY > HTML > #document to 3 of PRE > BODY > HTML > #document toDOMRange:range from 0 of PRE > PRE > BODY > HTML > #document to 0 of PRE > PRE > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification Tests: Smart paste when pasting a paragraph between two paragraphs in a pre element. Expected Results: @@ -22,8 +18,6 @@ Last test paragraph. Test paragraph. -Test paragraph. - Last test paragraph. execCopyCommand: <span id="test">Test</span> paragraph. <br>Last test paragraph. -execPasteCommand: <span id="test">Test</span> paragraph. <pre id="root" class="editing" style="word-wrap: break-word;"><span><br></span></pre><pre id="root" class="editing" style="word-wrap: break-word;"><span id="test">Test</span> paragraph.</pre><pre id="root" class="editing" style="word-wrap: break-word;"><br></pre>Last test paragraph. +execPasteCommand: <span id="test">Test</span> paragraph. <br>Last test paragraph. editing/pasteboard/smart-paste-paragraph-004.html Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/editing/pasteboard/smart-paste-paragraph-004-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/editing/pasteboard/smart-paste-paragraph-004-actual.txt @@ -7,10 +7,6 @@ EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted -EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 15 of #text > DIV > DIV > BODY > HTML > #document to 15 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 15 of #text > DIV > DIV > BODY > HTML > #document to 15 of #text > DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification @@ -30,9 +26,7 @@ Test paragraph. -Test paragraph. - Last test paragraph. execCopyCommand: <div id="test"> Test paragraph. </div> <div><br></div> <div> Last test paragraph. </div> +execPasteCommand: <div id="test"> Test paragraph. </div> <div><br></div> <div> Last test paragraph. </div> execPasteCommand: <div id="test"> Test paragraph. </div> <div><br></div><div>Test paragraph.<br></div><div><br></div> <div> Last test paragraph. </div> -execPasteCommand: <div id="test"> Test paragraph. </div> <div><br></div><div>Test paragraph.<br></div><div><br></div><div>Test paragraph.<br></div><div><br></div> <div> Last test paragraph. </div> 1582504 1 webkit-bug-importer 2019-10-22 13:14:44 -0700 <rdar://problem/56512107> 1582519 2 repstein 2019-10-22 13:29:22 -0700 Issue appears to be limited to Release builds. Updated TestExpectations in r251449 1582796 3 aakash_jain 2019-10-23 07:12:39 -0700 @Russell, Can you please check the fourth test as well: editing/pasteboard/smart-paste-paragraph-003.html This is also seems extremely flaky and is slowing down EWS (ios-wk2 queue). e.g.: https://ews-build.webkit.org/#/builders/24/builds/2333 https://ews-build.webkit.org/#/builders/24/builds/2336 https://ews-build.webkit.org/#/builders/24/builds/2341 1582910 4 tsavell 2019-10-23 11:26:04 -0700 Strange(In reply to Aakash Jain from comment #3) > @Russell, Can you please check the fourth test as well: > editing/pasteboard/smart-paste-paragraph-003.html > > This is also seems extremely flaky and is slowing down EWS (ios-wk2 queue). > e.g.: https://ews-build.webkit.org/#/builders/24/builds/2333 > https://ews-build.webkit.org/#/builders/24/builds/2336 > https://ews-build.webkit.org/#/builders/24/builds/2341 This is strange because we are not seeing that test at all on the testers. This may be a test list related to only the EWS 1584016 5 aakash_jain 2019-10-25 14:36:43 -0700 (In reply to Truitt Savell from comment #4) > This is strange because we are not seeing that test at all on the testers. > This may be a test list related to only the EWS This is clearly failing on EWS consistently, we need to do something about this test. editing/pasteboard/smart-paste-paragraph-003.html e.g.: https://ews-build.webkit.org/#/builders/24/builds/2652 1584038 6 jbedard 2019-10-25 15:20:15 -0700 (In reply to Aakash Jain from comment #5) > (In reply to Truitt Savell from comment #4) > > This is strange because we are not seeing that test at all on the testers. > > This may be a test list related to only the EWS > This is clearly failing on EWS consistently, we need to do something about > this test. editing/pasteboard/smart-paste-paragraph-003.html > > e.g.: https://ews-build.webkit.org/#/builders/24/builds/2652 I saw an example on GuardMalloc internally. 1584052 7 tsavell 2019-10-25 15:50:12 -0700 I was able to reproduce this test failure locally by just running the test by itself. It fails every time. I thought it would require a test list 1584062 8 tsavell 2019-10-25 16:01:52 -0700 So this is occurring on EWS becasue: on regular testers the sharding of tests is like this: editing/pasteboard/smart-paste-008.html editing/pasteboard/smart-paste-in-text-control.html editing/pasteboard/smart-paste-paragraph-001.html editing/pasteboard/smart-paste-paragraph-002.html editing/pasteboard/smart-paste-paragraph-003.html editing/pasteboard/smart-paste-paragraph-004.html editing/pasteboard/style-from-rules.html editing/pasteboard/styled-element-markup.html while on EWS the sharding is like this: editing/pasteboard/smart-paste-006.html editing/pasteboard/smart-paste-007.html editing/pasteboard/smart-paste-008.html editing/pasteboard/smart-paste-in-text-control.html editing/pasteboard/smart-paste-paragraph-003.html editing/pasteboard/style-from-rules.html editing/pasteboard/styled-element-markup.html because editing/pasteboard/smart-paste-paragraph-003.html is running without these other three tests it is failing. some state is not being reset. 1584066 9 tsavell 2019-10-25 16:05:10 -0700 editing/pasteboard/smart-paste-paragraph-003.html fails even on a checkout of r246110 which I chose arbitrarily. so this is probably not a new failure but the test order must have changed recently 1584071 10 tsavell 2019-10-25 16:13:04 -0700 marked test as failing in https://trac.webkit.org/changeset/251609/webkit to remedy this for now 1584082 11 ap 2019-10-25 16:37:42 -0700 This makes me wonder if this has the same root cause as the bug Wenson just fixed, with software keyboard appearing unexpectedly. 1584083 12 wenson_hsieh 2019-10-25 16:41:50 -0700 (In reply to Alexey Proskuryakov from comment #11) > This makes me wonder if this has the same root cause as the bug Wenson just > fixed, with software keyboard appearing unexpectedly. I just ran this test with and without having the test force the software keyboard (using `UIHelper.setHardwareKeyboardAttached`), and confirmed that I see the same output in both cases. 1584084 13 wenson_hsieh 2019-10-25 16:42:09 -0700 (In reply to Wenson Hsieh from comment #12) > (In reply to Alexey Proskuryakov from comment #11) > > This makes me wonder if this has the same root cause as the bug Wenson just > > fixed, with software keyboard appearing unexpectedly. > > I just ran this test with and without having the test force the software > keyboard (using `UIHelper.setHardwareKeyboardAttached`), and confirmed that > I see the same output in both cases. (The same test failure output, that is) 1584089 14 wenson_hsieh 2019-10-25 16:47:05 -0700 (In reply to Wenson Hsieh from comment #13) > (In reply to Wenson Hsieh from comment #12) > > (In reply to Alexey Proskuryakov from comment #11) > > > This makes me wonder if this has the same root cause as the bug Wenson just > > > fixed, with software keyboard appearing unexpectedly. > > > > I just ran this test with and without having the test force the software > > keyboard (using `UIHelper.setHardwareKeyboardAttached`), and confirmed that > > I see the same output in both cases. > > (The same test failure output, that is) It seems that this line: await UIHelper.selectWordByDoubleTapOrClick(document.getElementById('test')); …is failing to actually produce a ranged selection. 1584091 15 wenson_hsieh 2019-10-25 16:50:29 -0700 (In reply to Wenson Hsieh from comment #14) > (In reply to Wenson Hsieh from comment #13) > > (In reply to Wenson Hsieh from comment #12) > > > (In reply to Alexey Proskuryakov from comment #11) > > > > This makes me wonder if this has the same root cause as the bug Wenson just > > > > fixed, with software keyboard appearing unexpectedly. > > > > > > I just ran this test with and without having the test force the software > > > keyboard (using `UIHelper.setHardwareKeyboardAttached`), and confirmed that > > > I see the same output in both cases. > > > > (The same test failure output, that is) > > It seems that this line: > > await > UIHelper.selectWordByDoubleTapOrClick(document.getElementById('test')); > > …is failing to actually produce a ranged selection. The test seems to start passing if I perturb the double tap location a bit, like so: diff --git a/LayoutTests/resources/ui-helper.js b/LayoutTests/resources/ui-helper.js index 3aaba293a2c..49c3d526023 100644 --- a/LayoutTests/resources/ui-helper.js +++ b/LayoutTests/resources/ui-helper.js @@ -201,7 +201,8 @@ window.UIHelper = class UIHelper { const y = boundingRect.y + relativeY; if (this.isIOSFamily()) { await UIHelper.activateAndWaitForInputSessionAt(x, y); - await UIHelper.doubleTapAt(x, y); + await UIHelper.activateAt(x + 1, y + 1); + await UIHelper.activateAt(x + 1, y + 1); // This is only here to deal with async/sync copy/paste calls, so // once <rdar://problem/16207002> is resolved, should be able to remove for faster tests. await new Promise(resolve => testRunner.runUIScript("uiController.uiScriptComplete()", resolve)); …this appears to share the same root cause as https://bugs.webkit.org/show_bug.cgi?id=203392. We should really consider fixing position information request caching in WKContentViewInteraction, so that we don’t end up with a stale value for `_positionInformation.nodeAtPositionIsFocusedElement` after focusing an element. 1584154 16 381989 wenson_hsieh 2019-10-25 20:14:10 -0700 Created attachment 381989 Patch 1584156 17 381991 wenson_hsieh 2019-10-25 20:18:57 -0700 Created attachment 381991 Rename a variable 1584279 18 381991 wenson_hsieh 2019-10-26 16:02:12 -0700 Comment on attachment 381991 Rename a variable > Found 2 new test failures: fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad.html, fast/scrolling/ios/frame-scrolling-no.html (failure)23 analyze-layout-tests-results I wasn’t able to reproduce these crashes locally. 1584353 19 aakash_jain 2019-10-27 15:22:25 -0700 (In reply to Wenson Hsieh from comment #18) > Comment on attachment 381991 [details] > Rename a variable > > > Found 2 new test failures: fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad.html, fast/scrolling/ios/frame-scrolling-no.html (failure)23 analyze-layout-tests-results > > I wasn’t able to reproduce these crashes locally. I retried the build, and the tests passed this time. 1584534 20 381991 thorton 2019-10-28 12:11:37 -0700 Comment on attachment 381991 Rename a variable View in context: https://bugs.webkit.org/attachment.cgi?id=381991&action=review > Source/WebKit/ChangeLog:31 > + While this may potentially leads to an additional synchronous position information request when tapping at the > + same location after focusing an element, this is very difficult to achieve in practice, since the tap location > + would need to be _exactly_ at the same location. As mentioned on IRC, there is a solution that avoids this pitfall 1584537 21 wenson_hsieh 2019-10-28 12:30:26 -0700 (In reply to Tim Horton from comment #20) > Comment on attachment 381991 [details] > Rename a variable > > View in context: > https://bugs.webkit.org/attachment.cgi?id=381991&action=review > > > Source/WebKit/ChangeLog:31 > > + While this may potentially leads to an additional synchronous position information request when tapping at the > > + same location after focusing an element, this is very difficult to achieve in practice, since the tap location > > + would need to be _exactly_ at the same location. > > As mentioned on IRC, there is a solution that avoids this pitfall Yep! Investigating it here: https://bugs.webkit.org/show_bug.cgi?id=203498 > IRC 😢 1584556 22 381991 commit-queue 2019-10-28 12:58:09 -0700 Comment on attachment 381991 Rename a variable Clearing flags on attachment: 381991 Committed r251665: <https://trac.webkit.org/changeset/251665> 1584557 23 commit-queue 2019-10-28 12:58:11 -0700 All reviewed patches have been landed. Closing bug. 1779503 24 ayumi_kojima 2021-07-26 12:05:32 -0700 For editing/pasteboard/smart-paste-paragraph-002.html editing/pasteboard/smart-paste-paragraph-003.html editing/pasteboard/smart-paste-paragraph-004.html iPhone debug is a flaky failure. Update expectations https://trac.webkit.org/changeset/280305/webkit 1779508 25 wenson_hsieh 2021-07-26 12:11:36 -0700 (In reply to ayumi_kojima from comment #24) > For > > editing/pasteboard/smart-paste-paragraph-002.html > editing/pasteboard/smart-paste-paragraph-003.html > editing/pasteboard/smart-paste-paragraph-004.html > > > iPhone debug is a flaky failure. Update expectations > https://trac.webkit.org/changeset/280305/webkit This Bugzilla bug is pretty old (from 2019), and the radar is closed, indicating that the failures from back then were resolved by this change. If these tests are starting to fail again, I suspect it might be due to a different root cause. 1779531 26 ayumi_kojima 2021-07-26 13:11:16 -0700 (In reply to Wenson Hsieh from comment #25) > (In reply to ayumi_kojima from comment #24) > > For > > > > editing/pasteboard/smart-paste-paragraph-002.html > > editing/pasteboard/smart-paste-paragraph-003.html > > editing/pasteboard/smart-paste-paragraph-004.html > > > > > > iPhone debug is a flaky failure. Update expectations > > https://trac.webkit.org/changeset/280305/webkit > > This Bugzilla bug is pretty old (from 2019), and the radar is closed, > indicating that the failures from back then were resolved by this change. > > If these tests are starting to fail again, I suspect it might be due to a > different root cause. New bug is filed here: https://bugs.webkit.org/show_bug.cgi?id=228285 2143140 27 com.webkit.iidmsa 2025-09-15 17:42:01 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/50779 2143147 28 ews-feeder 2025-09-15 17:59:14 -0700 Test gardening commit 299997@main (647207c27a95): <https://commits.webkit.org/299997@main> Reviewed commits have been landed. Closing PR #50779 and removing active labels. 381989 2019-10-25 20:14:10 -0700 2019-10-25 20:18:56 -0700 Patch bug-203264-20191025201410.patch text/plain 5767 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZjYjZjMTE2MGZiNmYzZjE1 NmI4MmFjMWEwZWU1NmFmN2Y2MzY5MzIuLjNjNjY3NmYwNmVjNTdhMzQxZjk3NjI3MjZmZTM2MGYx MTdkNTcxZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDIgQEAKKzIwMTktMTAtMjUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gMyBlZGl0aW5n L3Bhc3RlYm9hcmQvc21hcnQtcGFzdGUtcGFyYWdyYXBoLSogdGVzdHMgYXJlIGZsYWt5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMyNjQKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzU2NTEyMTA3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIHNldmVyYWwgZmxha3kgbGF5b3V0IHRlc3RzIHRo YXQgZXhlcmNpc2UgYSBjb3JuZXIgY2FzZSBpbiBvdXIgbG9naWMgZm9yIGNhY2hpbmcgcG9zaXRp b24gaW5mb3JtYXRpb24KKyAgICAgICAgcmVzcG9uc2VzIGluIHRoZSBVSSBwcm9jZXNzLiBXaGVu IGZvY3VzaW5nIGFuIGVsZW1lbnQgdmlhIGEgdGFwLCB3ZSBzZW5kIGEgcG9zaXRpb24gaW5mb3Jt YXRpb24gcmVxdWVzdCBmb3IgdGhlCisgICAgICAgIHRhcCBsb2NhdGlvbiBpbiAtX3dlYlRvdWNo RXZlbnRzUmVjb2duaXplZDouIEFmdGVyIHRoZSB3ZWIgcHJvY2VzcyBjb21wdXRlcyB0aGUgaW5m b3JtYXRpb24gYW5kIGhhbmRzIGl0IGJhY2sgdG8KKyAgICAgICAgdGhlIFVJIHByb2Nlc3MsIHdl IGNhY2hlIHRoaXMgaW4gV0tDb250ZW50VmlldydzIF9wb3NpdGlvbkluZm9ybWF0aW9uLgorCisg ICAgICAgIEhvd2V2ZXIsIGF0IHRoZSB0aW1lIG9mIGNvbXB1dGluZyB0aGUgcmVxdWVzdCwgdGhl IHRhcHBlZCBlbGVtZW50IGhhcyBub3QgYmVlbiBmb2N1c2VkIHlldCwgc28gdGhlIHZhbHVlIG9m IHRoZQorICAgICAgICBwb3NpdGlvbiBpbmZvcm1hdGlvbidzIG5vZGVBdFBvc2l0aW9uSXNGb2N1 c2VkRWxlbWVudCBmbGFnIGlzIGZhbHNlLiBBZnRlciB0aGUgdGFwIGlzIHJlY29nbml6ZWQsIHdl J2xsIHRoZW4KKyAgICAgICAgZm9jdXMgdGhlIGVsZW1lbnQsIHN1Y2ggdGhhdCBpZiBhIHN1YnNl cXVlbnQgcG9zaXRpb24gaW5mb3JtYXRpb24gcmVxdWVzdCB3ZXJlIHRvIGFycml2ZSBhdCB0aGUg c2FtZSBsb2NhdGlvbiwKKyAgICAgICAgaXQgd291bGQgaGF2ZSBhIG5vZGVBdFBvc2l0aW9uSXNG b2N1c2VkRWxlbWVudCBmbGFnIHNldCB0byB0cnVlLgorCisgICAgICAgIEluIHRoaXMgc3RhdGUs IGlmIHRoZSB1c2VyIHRhcHMgX2V4YWN0bHlfIGF0IHRoZSBzYW1lIGxvY2F0aW9uIGFnYWluLCBV SUtpdCAodGhyb3VnaCB0ZXh0IGludGVyYWN0aW9uIGdlc3R1cmVzKQorICAgICAgICB3aWxsIGFz ayB1cyBmb3IgaW5mb3JtYXRpb24gYXQgdGhlIHNhbWUgcG9pbnQ7IHdlIHdpbGwgZW5kIHVwIHVz aW5nIHRoZSBjYWNoZWQgaW5mb3JtYXRpb24sIGZvciB3aGljaAorICAgICAgICBub2RlQXRQb3Np dGlvbklzRm9jdXNlZEVsZW1lbnQgaXMgZmFsc2UsIGNhdXNpbmcgdXMgdG8gaW5jb3JyZWN0bHkg cHJldmVudCB0aGUgdGV4dCBpbnRlcmFjdGlvbi4gSW4gdGhpcworICAgICAgICBwYXJ0aWN1bGFy IGNhc2UsIHdlIGZhaWwgdG8gc2VsZWN0IHRleHQgdmlhIGEgZG91YmxlIHRhcCBnZXN0dXJlLgor CisgICAgICAgIFRvIGFkZHJlc3MgdGhpcywgd2UgaW52YWxpZGF0ZSB0aGUgY2FjaGVkIHBvc2l0 aW9uIGluZm9ybWF0aW9uIGluIHRoZSBVSSBwcm9jZXNzIHdoZW5ldmVyIHRoZSBmb2N1c2VkIGVs ZW1lbnQKKyAgICAgICAgcmVjdCBjaGFuZ2VzIChlLmcuIHdoZW4gdGhlIGZvY3VzZWQgZWxlbWVu dCBjaGFuZ2VzKTsgdGhlIG9ubHkgZXhjZXB0aW9uIHRvIHRoaXMgaXMgd2hlbiB0aGUgcHJldmlv dXNseSBjYWNoZWQKKyAgICAgICAgcG9zaXRpb24gaW5mb3JtYXRpb24gd2FzIG5vdCBvdmVyIHRo ZSBmb2N1c2VkIGVsZW1lbnQsIGFuZCB0aGUgbmV3IGZvY3VzZWQgZWxlbWVudCByZWN0IGlzIGVt cHR5LCBpbiB3aGljaCBjYXNlCisgICAgICAgIHRoZSB2YWx1ZSBvZiBub2RlQXRQb3NpdGlvbklz Rm9jdXNlZEVsZW1lbnQgaXMgZ3VhcmFudGVlZCB0byBoYXZlIG5vdCBjaGFuZ2VkLgorCisgICAg ICAgIFdoaWxlIHRoaXMgbWF5IHBvdGVudGlhbGx5IGxlYWRzIHRvIGFuIGFkZGl0aW9uYWwgc3lu Y2hyb25vdXMgcG9zaXRpb24gaW5mb3JtYXRpb24gcmVxdWVzdCB3aGVuIHRhcHBpbmcgYXQgdGhl CisgICAgICAgIHNhbWUgbG9jYXRpb24gYWZ0ZXIgZm9jdXNpbmcgYW4gZWxlbWVudCwgdGhpcyBp cyB2ZXJ5IGRpZmZpY3VsdCB0byBhY2hpZXZlIGluIHByYWN0aWNlLCBzaW5jZSB0aGUgdGFwIGxv Y2F0aW9uCisgICAgICAgIHdvdWxkIG5lZWQgdG8gYmUgX2V4YWN0bHlfIGF0IHRoZSBzYW1lIGxv Y2F0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0LCBzaW5jZSB0aGlzIGlzIGV4ZXJjaXNlZCBi eSBleGlzdGluZyBmbGFreSBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBf ZWxlbWVudERpZEZvY3VzOnVzZXJJc0ludGVyYWN0aW5nOmJsdXJQcmV2aW91c05vZGU6YWN0aXZp dHlTdGF0ZUNoYW5nZXM6dXNlck9iamVjdDpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBf ZWxlbWVudERpZEJsdXJdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZGlkQ2hhbmdlRm9j dXNlZEVsZW1lbnRSZWN0OnRvUmVjdDpdKToKKwogMjAxOS0xMC0yNCAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TIDEzXSBmYXN0L2Zvcm1zL2lv cy9hY2Nlc3NvcnktYmFyLW5hdmlnYXRpb24uaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCmluZGV4IDM4ZmFlMTYxMzVkOTY2ZTAzYjc4MDhhNzI0MzY3MWUzODVhZjM0MTQuLjBh OWI2YjliMWQ1ODNmNzMzZjZhNzE2MzM4OWRkZGYwNDcwMTRiYzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpA QCAtNTU1Niw2ICs1NTU2LDcgQEAgLSAodm9pZClfZWxlbWVudERpZEZvY3VzOihjb25zdCBXZWJL aXQ6OkZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24mKWluZm9ybWF0aW9uIHUKICAgICBpZiAoZGVs ZWdhdGVJbXBsZW1lbnRzV2lsbFN0YXJ0SW5wdXRTZXNzaW9uKQogICAgICAgICBbaW5wdXREZWxl Z2F0ZSBfd2ViVmlldzpfd2ViVmlldyB3aWxsU3RhcnRJbnB1dFNlc3Npb246X2Zvcm1JbnB1dFNl c3Npb24uZ2V0KCldOwogCisgICAgYXV0byBwcmV2aW91c0ZvY3VzZWRFbGVtZW50UmVjdCA9IF9p c0NoYW5naW5nRm9jdXMgPyBfZm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5lbGVtZW50UmVjdCA6 IFdlYkNvcmU6OkludFJlY3QoKTsKICAgICBCT09MIGlzU2VsZWN0YWJsZSA9IG1heUNvbnRhaW5T ZWxlY3RhYmxlVGV4dChpbmZvcm1hdGlvbi5lbGVtZW50VHlwZSk7CiAgICAgQk9PTCBlZGl0YWJs ZUNoYW5nZWQgPSBbc2VsZiBzZXRJc0VkaXRhYmxlOmlzU2VsZWN0YWJsZV07CiAgICAgX2ZvY3Vz ZWRFbGVtZW50SW5mb3JtYXRpb24gPSBpbmZvcm1hdGlvbjsKQEAgLTU2MDIsNiArNTYwMyw4IEBA IC0gKHZvaWQpX2VsZW1lbnREaWRGb2N1czooY29uc3QgV2ViS2l0OjpGb2N1c2VkRWxlbWVudElu Zm9ybWF0aW9uJilpbmZvcm1hdGlvbiB1CiAgICAgICAgIFtpbnB1dERlbGVnYXRlIF93ZWJWaWV3 Ol93ZWJWaWV3IGRpZFN0YXJ0SW5wdXRTZXNzaW9uOl9mb3JtSW5wdXRTZXNzaW9uLmdldCgpXTsK ICAgICAKICAgICBbX3dlYlZpZXcgZGlkU3RhcnRGb3JtQ29udHJvbEludGVyYWN0aW9uXTsKKwor ICAgIFtzZWxmIF9kaWRDaGFuZ2VGb2N1c2VkRWxlbWVudFJlY3Q6cHJldmlvdXNGb2N1c2VkRWxl bWVudFJlY3QgdG9SZWN0Ol9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmVsZW1lbnRSZWN0XTsK IH0KIAogLSAodm9pZClfZWxlbWVudERpZEJsdXIKQEAgLTU2MjUsNyArNTYyOCw4IEBAIC0gKHZv aWQpX2VsZW1lbnREaWRCbHVyCiAjZW5kaWYKIAogICAgIEJPT0wgZWRpdGFibGVDaGFuZ2VkID0g W3NlbGYgc2V0SXNFZGl0YWJsZTpOT107Ci0KKyAgICBhdXRvIHByZXZpb3VzRWxlbWVudFJlY3Qg PSBfZm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5lbGVtZW50UmVjdDsKKyAgICAvLyBGSVhNRTog V2Ugc2hvdWxkIGNvbXBsZXRlbHkgaW52YWxpZGF0ZSBfZm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlv biBoZXJlLCBpbnN0ZWFkIG9mIGEgc3Vic2V0IG9mIGluZGl2aWR1YWwgbWVtYmVycy4KICAgICBf Zm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5lbGVtZW50VHlwZSA9IFdlYktpdDo6SW5wdXRUeXBl OjpOb25lOwogICAgIF9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLnNob3VsZFN5bnRoZXNpemVL ZXlFdmVudHNGb3JFZGl0aW5nID0gZmFsc2U7CiAgICAgX2ZvY3VzZWRFbGVtZW50SW5mb3JtYXRp b24uc2hvdWxkQXZvaWRSZXNpemluZ1doZW5JbnB1dFZpZXdCb3VuZHNDaGFuZ2UgPSBmYWxzZTsK QEAgLTU2NTgsOCArNTY2MiwyMyBAQCAtICh2b2lkKV9lbGVtZW50RGlkQmx1cgogICAgICAgICBf cGFnZS0+c2V0SXNTaG93aW5nSW5wdXRWaWV3Rm9yRm9jdXNlZEVsZW1lbnQoZmFsc2UpOwogICAg IH0KIAotICAgIGlmICghX2lzQ2hhbmdpbmdGb2N1cykKKyAgICBpZiAoIV9pc0NoYW5naW5nRm9j dXMpIHsKICAgICAgICAgX2RpZEFjY2Vzc29yeVRhYkluaXRpYXRlRm9jdXMgPSBOTzsKKyAgICAg ICAgW3NlbGYgX2RpZENoYW5nZUZvY3VzZWRFbGVtZW50UmVjdDpwcmV2aW91c0VsZW1lbnRSZWN0 IHRvUmVjdDpXZWJDb3JlOjpJbnRSZWN0KCldOworICAgIH0KK30KKworLSAodm9pZClfZGlkQ2hh bmdlRm9jdXNlZEVsZW1lbnRSZWN0Oihjb25zdCBXZWJDb3JlOjpJbnRSZWN0JilwcmV2aW91c1Jl Y3QgdG9SZWN0Oihjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiluZXdSZWN0Cit7CisgICAgaWYgKHBy ZXZpb3VzUmVjdCA9PSBuZXdSZWN0KQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAobmV3UmVj dC5pc0VtcHR5KCkgJiYgIV9wb3NpdGlvbkluZm9ybWF0aW9uLm5vZGVBdFBvc2l0aW9uSXNGb2N1 c2VkRWxlbWVudCkKKyAgICAgICAgcmV0dXJuOworCisgICAgLy8gSWYgdGhlIGZvY3VzZWQgZWxl bWVudCByZWN0IGNoYW5nZWQsIHRoZSBjYWNoZWQgcG9zaXRpb24gaW5mb3JtYXRpb24ncyBub2Rl QXRQb3NpdGlvbklzRm9jdXNlZEVsZW1lbnQgbWF5IGJlIHN0YWxlLgorICAgIF9oYXNWYWxpZFBv c2l0aW9uSW5mb3JtYXRpb24gPSBOTzsKKyAgICBfcG9zaXRpb25JbmZvcm1hdGlvbiA9IHsgfTsK IH0KIAogLSAodm9pZClfdXBkYXRlSW5wdXRDb250ZXh0QWZ0ZXJCbHVycmluZ0FuZFJlZm9jdXNp bmdFbGVtZW50Cg== 381991 2019-10-25 20:18:57 -0700 2019-10-28 12:58:09 -0700 Rename a variable bug-203264-20191025201856.patch text/plain 5901 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZjYjZjMTE2MGZiNmYzZjE1 NmI4MmFjMWEwZWU1NmFmN2Y2MzY5MzIuLmQ5YjYyNDI5NzUyZTMxZTgzYmEyYjY4ZDlhNTdjZTFi YzM3MWY5Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDYgQEAKKzIwMTktMTAtMjUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gMyBlZGl0aW5n L3Bhc3RlYm9hcmQvc21hcnQtcGFzdGUtcGFyYWdyYXBoLSogdGVzdHMgYXJlIGZsYWt5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMyNjQKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzU2NTEyMTA3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIHNldmVyYWwgZmxha3kgbGF5b3V0IHRlc3RzIHRo YXQgZXhlcmNpc2UgYSBjb3JuZXIgY2FzZSBpbiBvdXIgbG9naWMgZm9yIGNhY2hpbmcgcG9zaXRp b24gaW5mb3JtYXRpb24KKyAgICAgICAgcmVzcG9uc2VzIGluIHRoZSBVSSBwcm9jZXNzLiBXaGVu IGZvY3VzaW5nIGFuIGVsZW1lbnQgdmlhIGEgdGFwLCB3ZSBzZW5kIGEgcG9zaXRpb24gaW5mb3Jt YXRpb24gcmVxdWVzdCBmb3IgdGhlCisgICAgICAgIHRhcCBsb2NhdGlvbiBpbiAtX3dlYlRvdWNo RXZlbnRzUmVjb2duaXplZDouIEFmdGVyIHRoZSB3ZWIgcHJvY2VzcyBjb21wdXRlcyB0aGUgaW5m b3JtYXRpb24gYW5kIGhhbmRzIGl0IGJhY2sgdG8KKyAgICAgICAgdGhlIFVJIHByb2Nlc3MsIHdl IGNhY2hlIHRoaXMgaW4gV0tDb250ZW50VmlldydzIF9wb3NpdGlvbkluZm9ybWF0aW9uLgorCisg ICAgICAgIEhvd2V2ZXIsIGF0IHRoZSB0aW1lIG9mIGNvbXB1dGluZyB0aGUgcmVxdWVzdCwgdGhl IHRhcHBlZCBlbGVtZW50IGhhcyBub3QgYmVlbiBmb2N1c2VkIHlldCwgc28gdGhlIHZhbHVlIG9m IHRoZQorICAgICAgICBwb3NpdGlvbiBpbmZvcm1hdGlvbidzIG5vZGVBdFBvc2l0aW9uSXNGb2N1 c2VkRWxlbWVudCBmbGFnIGlzIGZhbHNlLiBBZnRlciB0aGUgdGFwIGlzIHJlY29nbml6ZWQsIHdl J2xsIHRoZW4KKyAgICAgICAgZm9jdXMgdGhlIGVsZW1lbnQsIHN1Y2ggdGhhdCBpZiBhIHN1YnNl cXVlbnQgcG9zaXRpb24gaW5mb3JtYXRpb24gcmVxdWVzdCB3ZXJlIHRvIGFycml2ZSBhdCB0aGUg c2FtZSBsb2NhdGlvbiwKKyAgICAgICAgaXQgd291bGQgaGF2ZSBhIG5vZGVBdFBvc2l0aW9uSXNG b2N1c2VkRWxlbWVudCBmbGFnIHNldCB0byB0cnVlLgorCisgICAgICAgIEluIHRoaXMgc3RhdGUs IGlmIHRoZSB1c2VyIHRhcHMgX2V4YWN0bHlfIGF0IHRoZSBzYW1lIGxvY2F0aW9uIGFnYWluLCBV SUtpdCAodGhyb3VnaCB0ZXh0IGludGVyYWN0aW9uIGdlc3R1cmVzKQorICAgICAgICB3aWxsIGFz ayB1cyBmb3IgaW5mb3JtYXRpb24gYXQgdGhlIHNhbWUgcG9pbnQ7IHdlIHdpbGwgZW5kIHVwIHVz aW5nIHRoZSBjYWNoZWQgaW5mb3JtYXRpb24sIGZvciB3aGljaAorICAgICAgICBub2RlQXRQb3Np dGlvbklzRm9jdXNlZEVsZW1lbnQgaXMgZmFsc2UsIGNhdXNpbmcgdXMgdG8gaW5jb3JyZWN0bHkg cHJldmVudCB0aGUgdGV4dCBpbnRlcmFjdGlvbi4gSW4gdGhpcworICAgICAgICBwYXJ0aWN1bGFy IGNhc2UsIHdlIGZhaWwgdG8gc2VsZWN0IHRleHQgdmlhIGEgZG91YmxlIHRhcCBnZXN0dXJlLgor CisgICAgICAgIFRvIGFkZHJlc3MgdGhpcywgd2UgaW52YWxpZGF0ZSB0aGUgY2FjaGVkIHBvc2l0 aW9uIGluZm9ybWF0aW9uIGluIHRoZSBVSSBwcm9jZXNzIHdoZW5ldmVyIHRoZSBmb2N1c2VkIGVs ZW1lbnQKKyAgICAgICAgcmVjdCBjaGFuZ2VzIChlLmcuIHdoZW4gdGhlIGZvY3VzZWQgZWxlbWVu dCBjaGFuZ2VzKTsgdGhlIG9ubHkgZXhjZXB0aW9uIHRvIHRoaXMgaXMgd2hlbiB0aGUgcHJldmlv dXNseSBjYWNoZWQKKyAgICAgICAgcG9zaXRpb24gaW5mb3JtYXRpb24gd2FzIG5vdCBvdmVyIHRo ZSBmb2N1c2VkIGVsZW1lbnQsIGFuZCB0aGUgbmV3IGZvY3VzZWQgZWxlbWVudCByZWN0IGlzIGVt cHR5LCBpbiB3aGljaCBjYXNlCisgICAgICAgIHRoZSB2YWx1ZSBvZiBub2RlQXRQb3NpdGlvbklz Rm9jdXNlZEVsZW1lbnQgaXMgZ3VhcmFudGVlZCB0byBoYXZlIG5vdCBjaGFuZ2VkLgorCisgICAg ICAgIFdoaWxlIHRoaXMgbWF5IHBvdGVudGlhbGx5IGxlYWRzIHRvIGFuIGFkZGl0aW9uYWwgc3lu Y2hyb25vdXMgcG9zaXRpb24gaW5mb3JtYXRpb24gcmVxdWVzdCB3aGVuIHRhcHBpbmcgYXQgdGhl CisgICAgICAgIHNhbWUgbG9jYXRpb24gYWZ0ZXIgZm9jdXNpbmcgYW4gZWxlbWVudCwgdGhpcyBp cyB2ZXJ5IGRpZmZpY3VsdCB0byBhY2hpZXZlIGluIHByYWN0aWNlLCBzaW5jZSB0aGUgdGFwIGxv Y2F0aW9uCisgICAgICAgIHdvdWxkIG5lZWQgdG8gYmUgX2V4YWN0bHlfIGF0IHRoZSBzYW1lIGxv Y2F0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0LCBzaW5jZSB0aGlzIGlzIGV4ZXJjaXNlZCBi eSBleGlzdGluZyBmbGFreSBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBf ZWxlbWVudERpZEZvY3VzOnVzZXJJc0ludGVyYWN0aW5nOmJsdXJQcmV2aW91c05vZGU6YWN0aXZp dHlTdGF0ZUNoYW5nZXM6dXNlck9iamVjdDpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBf ZWxlbWVudERpZEJsdXJdKToKKworICAgICAgICBBbHNvLCBhZGQgYSBGSVhNRSBhYm91dCBob3cg d2UgY2xlYXIgb3V0IHN1cnByaXNpbmdseSBsaXR0bGUgb2YgX2ZvY3VzZWRFbGVtZW50SW5mb3Jt YXRpb24gd2hlbiBibHVycmluZyB0aGUKKyAgICAgICAgZm9jdXNlZCBlbGVtZW50LgorCisgICAg ICAgICgtW1dLQ29udGVudFZpZXcgX2RpZENoYW5nZUZvY3VzZWRFbGVtZW50UmVjdDp0b1JlY3Q6 XSk6CisKIDIwMTktMTAtMjQgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CiAKICAgICAgICAgW2lPUyAxM10gZmFzdC9mb3Jtcy9pb3MvYWNjZXNzb3J5LWJhci1uYXZpZ2F0 aW9uLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCAzOGZhZTE2MTM1 ZDk2NmUwM2I3ODA4YTcyNDM2NzFlMzg1YWYzNDE0Li5lNGMzZDQ2OGY4MjU3NmUyNjBmNzFhMDQz NGNjYWVkYTI0MGVkZGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTU1NTYsNiArNTU1Niw3IEBAIC0g KHZvaWQpX2VsZW1lbnREaWRGb2N1czooY29uc3QgV2ViS2l0OjpGb2N1c2VkRWxlbWVudEluZm9y bWF0aW9uJilpbmZvcm1hdGlvbiB1CiAgICAgaWYgKGRlbGVnYXRlSW1wbGVtZW50c1dpbGxTdGFy dElucHV0U2Vzc2lvbikKICAgICAgICAgW2lucHV0RGVsZWdhdGUgX3dlYlZpZXc6X3dlYlZpZXcg d2lsbFN0YXJ0SW5wdXRTZXNzaW9uOl9mb3JtSW5wdXRTZXNzaW9uLmdldCgpXTsKIAorICAgIGF1 dG8gcHJldmlvdXNFbGVtZW50UmVjdCA9IF9pc0NoYW5naW5nRm9jdXMgPyBfZm9jdXNlZEVsZW1l bnRJbmZvcm1hdGlvbi5lbGVtZW50UmVjdCA6IFdlYkNvcmU6OkludFJlY3QoKTsKICAgICBCT09M IGlzU2VsZWN0YWJsZSA9IG1heUNvbnRhaW5TZWxlY3RhYmxlVGV4dChpbmZvcm1hdGlvbi5lbGVt ZW50VHlwZSk7CiAgICAgQk9PTCBlZGl0YWJsZUNoYW5nZWQgPSBbc2VsZiBzZXRJc0VkaXRhYmxl OmlzU2VsZWN0YWJsZV07CiAgICAgX2ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24gPSBpbmZvcm1h dGlvbjsKQEAgLTU2MDIsNiArNTYwMyw4IEBAIC0gKHZvaWQpX2VsZW1lbnREaWRGb2N1czooY29u c3QgV2ViS2l0OjpGb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uJilpbmZvcm1hdGlvbiB1CiAgICAg ICAgIFtpbnB1dERlbGVnYXRlIF93ZWJWaWV3Ol93ZWJWaWV3IGRpZFN0YXJ0SW5wdXRTZXNzaW9u Ol9mb3JtSW5wdXRTZXNzaW9uLmdldCgpXTsKICAgICAKICAgICBbX3dlYlZpZXcgZGlkU3RhcnRG b3JtQ29udHJvbEludGVyYWN0aW9uXTsKKworICAgIFtzZWxmIF9kaWRDaGFuZ2VGb2N1c2VkRWxl bWVudFJlY3Q6cHJldmlvdXNFbGVtZW50UmVjdCB0b1JlY3Q6X2ZvY3VzZWRFbGVtZW50SW5mb3Jt YXRpb24uZWxlbWVudFJlY3RdOwogfQogCiAtICh2b2lkKV9lbGVtZW50RGlkQmx1cgpAQCAtNTYy NSw3ICs1NjI4LDggQEAgLSAodm9pZClfZWxlbWVudERpZEJsdXIKICNlbmRpZgogCiAgICAgQk9P TCBlZGl0YWJsZUNoYW5nZWQgPSBbc2VsZiBzZXRJc0VkaXRhYmxlOk5PXTsKLQorICAgIGF1dG8g cHJldmlvdXNFbGVtZW50UmVjdCA9IF9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmVsZW1lbnRS ZWN0OworICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgY29tcGxldGVseSBpbnZhbGlkYXRlIF9mb2N1 c2VkRWxlbWVudEluZm9ybWF0aW9uIGhlcmUsIGluc3RlYWQgb2YgYSBzdWJzZXQgb2YgaW5kaXZp ZHVhbCBtZW1iZXJzLgogICAgIF9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmVsZW1lbnRUeXBl ID0gV2ViS2l0OjpJbnB1dFR5cGU6Ok5vbmU7CiAgICAgX2ZvY3VzZWRFbGVtZW50SW5mb3JtYXRp b24uc2hvdWxkU3ludGhlc2l6ZUtleUV2ZW50c0ZvckVkaXRpbmcgPSBmYWxzZTsKICAgICBfZm9j dXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5zaG91bGRBdm9pZFJlc2l6aW5nV2hlbklucHV0Vmlld0Jv dW5kc0NoYW5nZSA9IGZhbHNlOwpAQCAtNTY1OCw4ICs1NjYyLDIzIEBAIC0gKHZvaWQpX2VsZW1l bnREaWRCbHVyCiAgICAgICAgIF9wYWdlLT5zZXRJc1Nob3dpbmdJbnB1dFZpZXdGb3JGb2N1c2Vk RWxlbWVudChmYWxzZSk7CiAgICAgfQogCi0gICAgaWYgKCFfaXNDaGFuZ2luZ0ZvY3VzKQorICAg IGlmICghX2lzQ2hhbmdpbmdGb2N1cykgewogICAgICAgICBfZGlkQWNjZXNzb3J5VGFiSW5pdGlh dGVGb2N1cyA9IE5POworICAgICAgICBbc2VsZiBfZGlkQ2hhbmdlRm9jdXNlZEVsZW1lbnRSZWN0 OnByZXZpb3VzRWxlbWVudFJlY3QgdG9SZWN0OldlYkNvcmU6OkludFJlY3QoKV07CisgICAgfQor fQorCistICh2b2lkKV9kaWRDaGFuZ2VGb2N1c2VkRWxlbWVudFJlY3Q6KGNvbnN0IFdlYkNvcmU6 OkludFJlY3QmKXByZXZpb3VzUmVjdCB0b1JlY3Q6KGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKW5l d1JlY3QKK3sKKyAgICBpZiAocHJldmlvdXNSZWN0ID09IG5ld1JlY3QpCisgICAgICAgIHJldHVy bjsKKworICAgIGlmIChuZXdSZWN0LmlzRW1wdHkoKSAmJiAhX3Bvc2l0aW9uSW5mb3JtYXRpb24u bm9kZUF0UG9zaXRpb25Jc0ZvY3VzZWRFbGVtZW50KQorICAgICAgICByZXR1cm47CisKKyAgICAv LyBJZiB0aGUgZm9jdXNlZCBlbGVtZW50IHJlY3QgY2hhbmdlZCwgdGhlIGNhY2hlZCBwb3NpdGlv biBpbmZvcm1hdGlvbidzIG5vZGVBdFBvc2l0aW9uSXNGb2N1c2VkRWxlbWVudCBtYXkgYmUgc3Rh bGUuCisgICAgX2hhc1ZhbGlkUG9zaXRpb25JbmZvcm1hdGlvbiA9IE5POworICAgIF9wb3NpdGlv bkluZm9ybWF0aW9uID0geyB9OwogfQogCiAtICh2b2lkKV91cGRhdGVJbnB1dENvbnRleHRBZnRl ckJsdXJyaW5nQW5kUmVmb2N1c2luZ0VsZW1lbnQK