203261 2019-10-22 11:49:33 -0700 [ews] Status bubble should show previous failures if any in case patch is skipped 2019-10-22 13:49:15 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202163 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1582467 0 aakash_jain 2019-10-22 11:49:33 -0700 [ews] Status bubble should show previous failures if any in case patch is skipped. For e.g.: if a patch failed EWS, and someone lands/obsoletes the patch, and then click on 'Retry failed builds' button, status-bubble for would be white (skipped). However the status-bubble doesn't indicate that before being skipped, patch did encountered failures. We should update the status-bubbble tool-tip for skipped patches so as to indicate the previous failures. 1582470 1 381576 aakash_jain 2019-10-22 11:52:40 -0700 Created attachment 381576 Patch 1582472 2 aakash_jain 2019-10-22 11:54:38 -0700 Sample run: Skipped build with previous failed build: https://ews.webkit-uat.org/status-bubble/381492/ (look at 'style' bubble) Skipped build without previous failed build: https://ews.webkit-uat.org/status-bubble/381322/ 1582537 3 aakash_jain 2019-10-22 13:48:11 -0700 Committed r251453: <https://trac.webkit.org/changeset/251453> 1582539 4 webkit-bug-importer 2019-10-22 13:49:15 -0700 <rdar://problem/56514010> 381576 2019-10-22 11:52:40 -0700 2019-10-22 13:44:05 -0700 Patch bug-203261-20191022145239.patch text/plain 1728 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTQ0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTEwLTIyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBTdGF0dXMgYnViYmxlIHNob3VsZCBzaG93IHByZXZpb3VzIGZh aWx1cmVzIGlmIGFueSBpbiBjYXNlIHBhdGNoIGlzIHNraXBwZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzI2MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFw cC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5OgorICAgICAgICAoU3RhdHVzQnViYmxlLl9idWls ZF9idWJibGUpOiBEaXNwbGF5IGJ1aWxkIGluZm9ybWF0aW9uIGZyb20gcHJldmlvdXMgYnVpbGRz IGZvciBza2lwcGVkIHBhdGNoIGluCisgICAgICAgIGNhc2UgdGhlcmUgYXJlIG11bHRpcGxlIGJ1 aWxkcy4KKwogMjAxOS0xMC0yMiAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVtb3ZlIG1heUhhdmVTZXJ2aWNlV29ya2VyUmVnaXN0ZXJlZEZvck9yaWdpbgpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnVi YmxlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdz L3ZpZXdzL3N0YXR1c2J1YmJsZS5weQkocmV2aXNpb24gMjUxNDQxKQorKysgVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5CSh3b3JraW5nIGNv cHkpCkBAIC0xMjksNiArMTI5LDEwIEBAIGNsYXNzIFN0YXR1c0J1YmJsZShWaWV3KToKICAgICAg ICAgICAgIGVsaWYgcmUuc2VhcmNoKHInUGF0Y2ggLiogaXMgb2Jzb2xldGUnLCBidWlsZC5zdGF0 ZV9zdHJpbmcpOgogICAgICAgICAgICAgICAgIGJ1YmJsZVsnZGV0YWlsc19tZXNzYWdlJ10gKz0g JyBQYXRjaCB3YXMgb2Jzb2xldGUgd2hlbiBFV1MgYXR0ZW1wdGVkIHRvIHByb2Nlc3MgaXQuJwog CisgICAgICAgICAgICBpZiBsZW4oYnVpbGRzKSA+IDE6CisgICAgICAgICAgICAgICAgYnViYmxl WydkZXRhaWxzX21lc3NhZ2UnXSArPSAnXG5Tb21lIG1lc3NhZ2VzIHdlcmUgbG9nZ2VkIHdoaWxl IHRoZSBwYXRjaCB3YXMgc3RpbGwgZWxpZ2libGU6JworICAgICAgICAgICAgICAgIGJ1YmJsZVsn ZGV0YWlsc19tZXNzYWdlJ10gKz0gc2VsZi5fc3RlcHNfbWVzc2FnZXNfZnJvbV9tdWx0aXBsZV9i dWlsZHMoYnVpbGRzKQorCiAgICAgICAgIGVsaWYgYnVpbGQucmVzdWx0ID09IEJ1aWxkYm90LkVY Q0VQVElPTjoKICAgICAgICAgICAgIGJ1YmJsZVsnc3RhdGUnXSA9ICdlcnJvcicKICAgICAgICAg ICAgIGJ1YmJsZVsnZGV0YWlsc19tZXNzYWdlJ10gPSAnQW4gdW5leHBlY3RlZCBlcnJvciBvY2N1 cmVkLiBSZWNlbnQgbWVzc2FnZXM6JyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzX2Zyb21fbXVsdGlw bGVfYnVpbGRzKGJ1aWxkcykK