203243 2019-10-22 04:14:34 -0700 WebSWServerToContextConnection should not assert when failing loads at destruction time 2019-10-22 08:56:16 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1582325 0 youennf 2019-10-22 04:14:34 -0700 WebSWServerToContextConnection should not assert when failing loads at destruction time 1582326 1 youennf 2019-10-22 04:18:02 -0700 See https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r251183%20(9971)/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https-crash-log.txt Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010edfee70 WTFCrash + 16 (Assertions.cpp:305) 1 com.apple.WebKit 0x0000000105ba578b WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebKit 0x00000001073346f3 WebKit::WebSWServerToContextConnection::unregisterFetch(WebKit::ServiceWorkerFetchTask&) + 147 (WebSWServerToContextConnection.cpp:171) 3 com.apple.WebKit 0x0000000105f1201c WebKit::ServiceWorkerFetchTask::~ServiceWorkerFetchTask() + 76 (ServiceWorkerFetchTask.cpp:66) 4 com.apple.WebKit 0x0000000105f121b5 WebKit::ServiceWorkerFetchTask::~ServiceWorkerFetchTask() + 21 (ServiceWorkerFetchTask.cpp:66) 5 com.apple.WebKit 0x0000000105fecffd WebKit::NetworkResourceLoader::~NetworkResourceLoader() + 941 (NetworkResourceLoader.cpp:133) 6 com.apple.WebKit 0x0000000105fed875 WebKit::NetworkResourceLoader::~NetworkResourceLoader() + 21 (NetworkResourceLoader.cpp:133) 7 com.apple.WebKit 0x0000000105fed8d9 WebKit::NetworkResourceLoader::~NetworkResourceLoader() + 25 (NetworkResourceLoader.cpp:126) 8 com.apple.WebKit 0x0000000105f78aff WTF::RefCounted<WebKit::NetworkResourceLoader, std::__1::default_delete<WebKit::NetworkResourceLoader> >::deref() const + 95 (RefCounted.h:190) 9 com.apple.WebKit 0x0000000105f78a73 WTF::Ref<WebKit::NetworkResourceLoader, WTF::DumbPtrTraits<WebKit::NetworkResourceLoader> >::~Ref() + 51 (Ref.h:61) 10 com.apple.WebKit 0x0000000105f55355 WTF::Ref<WebKit::NetworkResourceLoader, WTF::DumbPtrTraits<WebKit::NetworkResourceLoader> >::~Ref() + 21 (Ref.h:61) 11 com.apple.WebKit 0x000000010608e2fb WebKit::NetworkSession::removeKeptAliveLoad(WebKit::NetworkResourceLoader&) + 347 (NetworkSession.cpp:275) 12 com.apple.WebKit 0x0000000105fe7221 WebKit::NetworkProcess::removeKeptAliveLoad(WebKit::NetworkResourceLoader&) + 81 (NetworkProcess.cpp:2583) 13 com.apple.WebKit 0x0000000105f54fae WebKit::NetworkConnectionToWebProcess::didCleanupResourceLoader(WebKit::NetworkResourceLoader&) + 254 (NetworkConnectionToWebProcess.cpp:132) 14 com.apple.WebKit 0x0000000105ff30dc WebKit::NetworkResourceLoader::cleanup(WebKit::NetworkResourceLoader::LoadResult) + 492 (NetworkResourceLoader.cpp:352) 15 com.apple.WebKit 0x0000000105ff2ca1 WebKit::NetworkResourceLoader::didFailLoading(WebCore::ResourceError const&) + 1489 (NetworkResourceLoader.cpp:631) 16 com.apple.WebKit 0x0000000105f1345f WebKit::ServiceWorkerFetchTask::didFail(WebCore::ResourceError const&) + 319 (ServiceWorkerFetchTask.cpp:145) 17 com.apple.WebKit 0x000000010733323d WebKit::ServiceWorkerFetchTask::fail(WebCore::ResourceError const&) + 29 (ServiceWorkerFetchTask.h:66) 18 com.apple.WebKit 0x0000000107332ea9 WebKit::WebSWServerToContextConnection::~WebSWServerToContextConnection() + 425 (WebSWServerToContextConnection.cpp:58) 19 com.apple.WebKit 0x0000000107333435 WebKit::WebSWServerToContextConnection::~WebSWServerToContextConnection() + 21 (WebSWServerToContextConnection.cpp:62) 20 com.apple.WebKit 0x0000000107333499 WebKit::WebSWServerToContextConnection::~WebSWServerToContextConnection() + 25 (WebSWServerToContextConnection.cpp:55) 21 com.apple.WebKit 0x0000000105f56982 WebKit::NetworkConnectionToWebProcess::didClose(IPC::Connection&) + 306 (NetworkConnectionToWebProcess.cpp:289) 22 com.apple.WebKit 0x0000000105c2e076 IPC::Connection::connectionDidClose()::$_6::operator()() + 246 (Connection.cpp:816) 1582327 2 381537 youennf 2019-10-22 04:20:59 -0700 Created attachment 381537 Patch 1582339 3 381537 youennf 2019-10-22 05:56:14 -0700 Comment on attachment 381537 Patch iOS-wk2 failure is unrelated 1582383 4 381537 commit-queue 2019-10-22 08:55:40 -0700 Comment on attachment 381537 Patch Clearing flags on attachment: 381537 Committed r251434: <https://trac.webkit.org/changeset/251434> 1582384 5 commit-queue 2019-10-22 08:55:42 -0700 All reviewed patches have been landed. Closing bug. 1582385 6 webkit-bug-importer 2019-10-22 08:56:16 -0700 <rdar://problem/56501449> 381537 2019-10-22 04:20:59 -0700 2019-10-22 08:55:40 -0700 Patch bug-203243-20191022132057.patch text/plain 3906 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUzNDU1MmRlYmYwYjkwN2M2 NWQ3M2I2YTU3MTM5MzE0ZjdmNWExN2YuLjI4OTM1OTAwNzAyNzk3NDE2MjVhYmM1YjMzOGFkZDM0 M2UzZmRkNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMTAtMjIgIHlvdWVubiBm YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlNXU2VydmVyVG9Db250ZXh0 Q29ubmVjdGlvbiBzaG91bGQgbm90IGFzc2VydCB3aGVuIGZhaWxpbmcgbG9hZHMgYXQgZGVzdHJ1 Y3Rpb24gdGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAzMjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgT24gV2ViU1dTZXJ2ZXJUb0NvbnRleHRDb25uZWN0aW9uIGRlc3RydWN0aW9uLCB3ZSBtb3Zl IHRoZSBmZXRjaCB0YXNrIG1hcCBhbmQgZmFpbCB0aGUgdGFza3MuCisgICAgICAgIEF0IGRlc3Ry dWN0aW9uIG9mIHRoZSB0YXNrcywgd2hpY2ggaGFwcGVucyBzeW5jaHJvbm91c2x5LCB0aGV5IHdp bGwgdHJ5IHRvIHVucmVnaXN0ZXIgdGhlbXNlbHZlcworICAgICAgICBhbmQgdGhlIGFzc2VydGlv biB0aGF0IHRoZSB0YXNrIGlzIGluIHRoZSBtYXAgd2lsbCBmYWlsLgorICAgICAgICBUbyBmaXgg dGhhdCwgYWRkIGEgc3BlY2lmaWMgY29udGV4dENsb3NlZCBtZXRob2QgdGhhdCB3aWxsIGNsZWFy IHRoZSB0YXNrIGNvbm5lY3Rpb24gd2VhayBwb2ludGVyLgorCisgICAgICAgICogTmV0d29ya1By b2Nlc3MvU2VydmljZVdvcmtlci9TZXJ2aWNlV29ya2VyRmV0Y2hUYXNrLmNwcDoKKyAgICAgICAg KFdlYktpdDo6U2VydmljZVdvcmtlckZldGNoVGFzazo6Y29udGV4dENsb3NlZCk6CisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9TZXJ2aWNlV29ya2VyRmV0Y2hUYXNrLmg6 CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9XZWJTV1NlcnZlclRvQ29u dGV4dENvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTV1NlcnZlclRvQ29udGV4 dENvbm5lY3Rpb246On5XZWJTV1NlcnZlclRvQ29udGV4dENvbm5lY3Rpb24pOgorCiAyMDE5LTEw LTIyICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUg dGhlIGFiaWxpdHkgdG8gZmFsbGJhY2sgdG8gY3VzdG9tIHNjaGVtZSBoYW5kbGVycyBhZnRlciBh IHNlcnZpY2Ugd29ya2VyIGRpZCBub3QgaGFuZGxlIHRoZSBsb2FkCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvU2VydmljZVdvcmtlckZldGNo VGFzay5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvU2Vy dmljZVdvcmtlckZldGNoVGFzay5jcHAKaW5kZXggNjdlZGFjZmYzYWY5YWJkMmQ4MzkxM2EzYmQ3 MTI4NzEzNWU2ZWY4MS4uZjA3MThhYWI0M2EwNWUxYTkxZjkyMGY5NTc2MzRjNjMwM2JiYzk1NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1Nl cnZpY2VXb3JrZXJGZXRjaFRhc2suY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvU2VydmljZVdvcmtlci9TZXJ2aWNlV29ya2VyRmV0Y2hUYXNrLmNwcApAQCAtODQsNiArODQs MTIgQEAgdm9pZCBTZXJ2aWNlV29ya2VyRmV0Y2hUYXNrOjpzdGFydChXZWJTV1NlcnZlclRvQ29u dGV4dENvbm5lY3Rpb24mIHNlcnZpY2VXb3JrZXIKICAgICBzdGFydEZldGNoKCk7CiB9CiAKK3Zv aWQgU2VydmljZVdvcmtlckZldGNoVGFzazo6Y29udGV4dENsb3NlZCgpCit7CisgICAgbV9zZXJ2 aWNlV29ya2VyQ29ubmVjdGlvbiA9IG51bGxwdHI7CisgICAgZGlkRmFpbChSZXNvdXJjZUVycm9y IHsgZXJyb3JEb21haW5XZWJLaXRJbnRlcm5hbCwgMCwgeyB9LCAiU2VydmljZSBXb3JrZXIgY29u dGV4dCBjbG9zZWQiX3MgfSk7Cit9CisKIHZvaWQgU2VydmljZVdvcmtlckZldGNoVGFzazo6c3Rh cnRGZXRjaCgpCiB7CiAgICAgYXV0byYgb3B0aW9ucyA9IG1fbG9hZGVyLnBhcmFtZXRlcnMoKS5v cHRpb25zOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNl V29ya2VyL1NlcnZpY2VXb3JrZXJGZXRjaFRhc2suaCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvU2VydmljZVdvcmtlci9TZXJ2aWNlV29ya2VyRmV0Y2hUYXNrLmgKaW5kZXggOTlkNjVk YTJlM2FhZjQ1OGNmZmM3MDMyOGUxYzNhZDk3YjU1NDkyMi4uZDcxNmJiZTAyZTY5Y2ZhZDFjNGQz NDYwZTNlZDRkYWVlZWM5YzQwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9TZXJ2aWNlV29ya2VyL1NlcnZpY2VXb3JrZXJGZXRjaFRhc2suaAorKysgYi9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvU2VydmljZVdvcmtlckZldGNoVGFz ay5oCkBAIC03NSw2ICs3NSw4IEBAIHB1YmxpYzoKICAgICBXZWJDb3JlOjpSZXNvdXJjZVJlcXVl c3QgdGFrZVJlcXVlc3QoKSB7IHJldHVybiBXVEZNb3ZlKG1fY3VycmVudFJlcXVlc3QpOyB9CiAg ICAgYm9vbCB3YXNIYW5kbGVkKCkgY29uc3QgeyByZXR1cm4gbV93YXNIYW5kbGVkOyB9CiAKKyAg ICB2b2lkIGNvbnRleHRDbG9zZWQoKTsKKwogcHJpdmF0ZToKICAgICB2b2lkIGRpZFJlY2VpdmVS ZWRpcmVjdFJlc3BvbnNlKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmJik7CiAgICAgdm9pZCBk aWRSZWNlaXZlUmVzcG9uc2UoV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYmLCBib29sIG5lZWRz Q29udGludWVEaWRSZWNlaXZlUmVzcG9uc2VNZXNzYWdlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9XZWJTV1NlcnZlclRvQ29udGV4dENv bm5lY3Rpb24uY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2Vy L1dlYlNXU2VydmVyVG9Db250ZXh0Q29ubmVjdGlvbi5jcHAKaW5kZXggYzg1MGE5MzA1MzdmN2Jm MTZlMjUyOGViMGIzOWQ4MmE1NTE5MGRkYS4uMjRkNzllNzE0Y2VhZGI1ZjQ3ZGFiMjg2MDkzM2Vi NDNmNTIzMmQ0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2 aWNlV29ya2VyL1dlYlNXU2VydmVyVG9Db250ZXh0Q29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVyVG9Db250ZXh0 Q29ubmVjdGlvbi5jcHAKQEAgLTU1LDcgKzU1LDcgQEAgV2ViU1dTZXJ2ZXJUb0NvbnRleHRDb25u ZWN0aW9uOjp+V2ViU1dTZXJ2ZXJUb0NvbnRleHRDb25uZWN0aW9uKCkKIHsKICAgICBhdXRvIGZl dGNoZXMgPSBXVEZNb3ZlKG1fb25nb2luZ0ZldGNoZXMpOwogICAgIGZvciAoYXV0byYgZmV0Y2gg OiBmZXRjaGVzLnZhbHVlcygpKQotICAgICAgICBmZXRjaC0+ZmFpbChSZXNvdXJjZUVycm9yIHsg ZXJyb3JEb21haW5XZWJLaXRJbnRlcm5hbCwgMCwgeyB9LCAiU2VydmljZSBXb3JrZXIgY29udGV4 dCBjbG9zZWQiX3MgfSk7CisgICAgICAgIGZldGNoLT5jb250ZXh0Q2xvc2VkKCk7CiAKICAgICBp ZiAobV9zZXJ2ZXIgJiYgbV9zZXJ2ZXItPmNvbnRleHRDb25uZWN0aW9uRm9yUmVnaXN0cmFibGVE b21haW4ocmVnaXN0cmFibGVEb21haW4oKSkgPT0gdGhpcykKICAgICAgICAgbV9zZXJ2ZXItPnJl bW92ZUNvbnRleHRDb25uZWN0aW9uKCp0aGlzKTsK