203239 2019-10-22 01:33:32 -0700 Remove the ability to fallback to custom scheme handlers after a service worker did not handle the load 2019-10-22 08:02:55 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1582295 0 youennf 2019-10-22 01:33:32 -0700 Remove the ability to fallback to custom scheme handlers after a service worker did not handle the load 1582296 1 381529 youennf 2019-10-22 01:36:21 -0700 Created attachment 381529 Patch 1582359 2 381529 commit-queue 2019-10-22 08:01:59 -0700 Comment on attachment 381529 Patch Clearing flags on attachment: 381529 Committed r251430: <https://trac.webkit.org/changeset/251430> 1582360 3 commit-queue 2019-10-22 08:02:01 -0700 All reviewed patches have been landed. Closing bug. 1582362 4 webkit-bug-importer 2019-10-22 08:02:55 -0700 <rdar://problem/56499986> 381529 2019-10-22 01:36:21 -0700 2019-10-22 08:01:59 -0700 Patch bug-203239-20191022103619.patch text/plain 6295 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ4ODE0MjA0MDU0Y2FkM2Ni NjVkNjgwYmQzMGViNTU1MmQzYjQ2OTcuLjUzNDU1MmRlYmYwYjkwN2M2NWQ3M2I2YTU3MTM5MzE0 ZjdmNWExN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMTAtMjIgIHlvdWVubiBm YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB0aGUgYWJpbGl0eSB0 byBmYWxsYmFjayB0byBjdXN0b20gc2NoZW1lIGhhbmRsZXJzIGFmdGVyIGEgc2VydmljZSB3b3Jr ZXIgZGlkIG5vdCBoYW5kbGUgdGhlIGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMzIzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlIHJlbW92ZSB0aGUgYWJpbGl0eSBmb3Igc2VydmljZSB3b3Jr ZXJzIHRvIGludGVyY2VwdCBjdXN0b20gc2NoZW1lIGhhbmRsZXJzLgorICAgICAgICBXZSBjYW4g dGhlbiByZW1vdmUgdGhlIGFiaWxpdHkgZm9yIGxvYWRzIHRoYXQgYXJlIG5vdCBoYW5kbGVkIGJ5 IHNlcnZpY2Ugd29ya2VycyB0byBnbyB0aHJvdWdoIGN1c3RvbSBzY2hlbWUgaGFuZGxlcnMuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJMb2FkZXJTdHJhdGVneTo6c2NoZWR1bGVMb2FkKToKKyAgICAgICAg KFdlYktpdDo6V2ViTG9hZGVyU3RyYXRlZ3k6OnNjaGVkdWxlTG9hZEZyb21OZXR3b3JrUHJvY2Vz cyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkZXI6OnNlcnZpY2VXb3JrZXJEaWROb3RI YW5kbGUpOgorCiAyMDE5LTEwLTIyICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K IAogICAgICAgICBTZXJ2aWNlV29ya2VyRmV0Y2hUYXNrIGNhbiB1c2UgdGhlIE5ldHdvcmtDb25u ZWN0aW9uVG9XZWJQcm9jZXNzIHNlc3Npb25JRApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3BwIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3BwCmluZGV4IDQ2ODhmZWNkN2Fm NjhjZmVhNmUxMjQ5MGMyYTk2YmE2ODU0MjJiNTYuLmE5NWY3YzE4YWUyZDI2NGIxMTJiYTcyNTJm YzkzMDU4ZjBhNDg0MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3 b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv TmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAKQEAgLTIxNCwxNyArMjE0LDcgQEAgdm9pZCBX ZWJMb2FkZXJTdHJhdGVneTo6c2NoZWR1bGVMb2FkKFJlc291cmNlTG9hZGVyJiByZXNvdXJjZUxv YWRlciwgQ2FjaGVkUmVzb3UKICAgICB9CiAjZW5kaWYKIAotI2lmIEVOQUJMRShTRVJWSUNFX1dP UktFUikKLSAgICBhdXRvIHVybCA9IHJlc291cmNlTG9hZGVyLnJlcXVlc3QoKS51cmwoKTsKLSAg ICBhdXRvKiBkYXRhID0gdXJsLnN0cmluZygpLnV0ZjgoKS5kYXRhKCk7Ci0gICAgaWYgKGRhdGEp Ci0gICAgICAgIHVybC5zdHJpbmcoKTsKLQotICAgIGJvb2wgY2FuYmVMb2FkZWRUaHJvdWdoU2Vy dmljZVdvcmtlcnMgPSByZXNvdXJjZUxvYWRlci5vcHRpb25zKCkuc2VydmljZVdvcmtlcnNNb2Rl ICE9IFNlcnZpY2VXb3JrZXJzTW9kZTo6Tm9uZSAmJiAocmVzb3VyY2VMb2FkZXIub3B0aW9ucygp LnNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25JZGVudGlmaWVyIHx8IHJlc291cmNlTG9hZGVyLm9w dGlvbnMoKS5tb2RlID09IEZldGNoT3B0aW9uczo6TW9kZTo6TmF2aWdhdGUpOwotICAgIGlmIChj YW5iZUxvYWRlZFRocm91Z2hTZXJ2aWNlV29ya2VycyB8fCAhdHJ5TG9hZGluZ1VzaW5nVVJMU2No ZW1lSGFuZGxlcihyZXNvdXJjZUxvYWRlcikpIHsKLSNlbHNlCiAgICAgaWYgKCF0cnlMb2FkaW5n VXNpbmdVUkxTY2hlbWVIYW5kbGVyKHJlc291cmNlTG9hZGVyKSkgewotI2VuZGlmCiAgICAgICAg IFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoInNjaGVkdWxlTG9hZDogVVJMIHdpbGwgYmUgc2NoZWR1 bGVkIHdpdGggdGhlIE5ldHdvcmtQcm9jZXNzIChmcmFtZSA9ICVwLCBwYWdlSUQgPSAlIiBQUkl1 NjQgIiwgZnJhbWVJRCA9ICUiIFBSSXU2NCAiLCByZXNvdXJjZUlEID0gJSIgUFJJdTY0ICIpIiwg cmVzb3VyY2VMb2FkZXIuZnJhbWUoKSwgdHJhY2tpbmdQYXJhbWV0ZXJzLnBhZ2VJRC50b1VJbnQ2 NCgpLCB0cmFja2luZ1BhcmFtZXRlcnMuZnJhbWVJRC50b1VJbnQ2NCgpLCBpZGVudGlmaWVyKTsK ICAgICAgICAgc2NoZWR1bGVMb2FkRnJvbU5ldHdvcmtQcm9jZXNzKHJlc291cmNlTG9hZGVyLCBy ZXNvdXJjZUxvYWRlci5yZXF1ZXN0KCksIHRyYWNraW5nUGFyYW1ldGVycywgc2hvdWxkQ2xlYXJS ZWZlcnJlck9uSFRUUFNUb0hUVFBSZWRpcmVjdCwgbWF4aW11bUJ1ZmZlcmluZ1RpbWUocmVzb3Vy Y2UpKTsKICAgICAgICAgcmV0dXJuOwpAQCAtMjUxLDEwICsyNDEsNiBAQCBib29sIFdlYkxvYWRl clN0cmF0ZWd5Ojp0cnlMb2FkaW5nVXNpbmdVUkxTY2hlbWVIYW5kbGVyKFJlc291cmNlTG9hZGVy JiByZXNvdXJjZQogCiB2b2lkIFdlYkxvYWRlclN0cmF0ZWd5OjpzY2hlZHVsZUxvYWRGcm9tTmV0 d29ya1Byb2Nlc3MoUmVzb3VyY2VMb2FkZXImIHJlc291cmNlTG9hZGVyLCBjb25zdCBSZXNvdXJj ZVJlcXVlc3QmIHJlcXVlc3QsIGNvbnN0IFdlYlJlc291cmNlTG9hZGVyOjpUcmFja2luZ1BhcmFt ZXRlcnMmIHRyYWNraW5nUGFyYW1ldGVycywgYm9vbCBzaG91bGRDbGVhclJlZmVycmVyT25IVFRQ U1RvSFRUUFJlZGlyZWN0LCBTZWNvbmRzIG1heGltdW1CdWZmZXJpbmdUaW1lKQogewotICAgIGF1 dG8qIHdlYkZyYW1lTG9hZGVyQ2xpZW50ID0gdG9XZWJGcmFtZUxvYWRlckNsaWVudChyZXNvdXJj ZUxvYWRlci5mcmFtZUxvYWRlcigpLT5jbGllbnQoKSk7Ci0gICAgYXV0byogd2ViRnJhbWUgPSB3 ZWJGcmFtZUxvYWRlckNsaWVudCA/IHdlYkZyYW1lTG9hZGVyQ2xpZW50LT53ZWJGcmFtZSgpIDog bnVsbHB0cjsKLSAgICBhdXRvKiB3ZWJQYWdlID0gd2ViRnJhbWUgPyB3ZWJGcmFtZS0+cGFnZSgp IDogbnVsbHB0cjsKLQogICAgIFJlc291cmNlTG9hZElkZW50aWZpZXIgaWRlbnRpZmllciA9IHJl c291cmNlTG9hZGVyLmlkZW50aWZpZXIoKTsKICAgICBBU1NFUlQoaWRlbnRpZmllcik7CiAKQEAg LTI4NywxMiArMjczLDcgQEAgdm9pZCBXZWJMb2FkZXJTdHJhdGVneTo6c2NoZWR1bGVMb2FkRnJv bU5ldHdvcmtQcm9jZXNzKFJlc291cmNlTG9hZGVyJiByZXNvdXJjZUwKICAgICBsb2FkUGFyYW1l dGVycy5pc0hUVFBTVXBncmFkZUVuYWJsZWQgPSByZXNvdXJjZUxvYWRlci5mcmFtZSgpID8gcmVz b3VyY2VMb2FkZXIuZnJhbWUoKS0+c2V0dGluZ3MoKS5IVFRQU1VwZ3JhZGVFbmFibGVkKCkgOiBm YWxzZTsKIAogI2lmIEVOQUJMRShTRVJWSUNFX1dPUktFUikKLSAgICAvLyBJbiBjYXNlIG9mIFVS TCBzY2hlbWUgaGFuZGxlciwgd2Ugd2lsbCB0cnkgdG8gbG9hZCBvbiBzZXJ2aWNlIHdvcmtlcnMg YW5kIGlmIHVuaGFuZGxlZCwgZmFsbGJhY2sgdG8gVVJMIHNjaGVtZSBoYW5kbGVyLgotICAgIGlm ICh3ZWJQYWdlICYmIHdlYlBhZ2UtPnVybFNjaGVtZUhhbmRsZXJGb3JTY2hlbWUocmVzb3VyY2VM b2FkZXIucmVxdWVzdCgpLnVybCgpLnByb3RvY29sKCkudG9TdHJpbmdXaXRob3V0Q29weWluZygp KSkKLSAgICAgICAgbG9hZFBhcmFtZXRlcnMuc2VydmljZVdvcmtlcnNNb2RlID0gU2VydmljZVdv cmtlcnNNb2RlOjpPbmx5OwotICAgIGVsc2UKLSAgICAgICAgbG9hZFBhcmFtZXRlcnMuc2Vydmlj ZVdvcmtlcnNNb2RlID0gcmVzb3VyY2VMb2FkZXIub3B0aW9ucygpLnNlcnZpY2VXb3JrZXJzTW9k ZTsKLQorICAgIGxvYWRQYXJhbWV0ZXJzLnNlcnZpY2VXb3JrZXJzTW9kZSA9IHJlc291cmNlTG9h ZGVyLm9wdGlvbnMoKS5zZXJ2aWNlV29ya2Vyc01vZGU7CiAgICAgbG9hZFBhcmFtZXRlcnMuc2Vy dmljZVdvcmtlclJlZ2lzdHJhdGlvbklkZW50aWZpZXIgPSByZXNvdXJjZUxvYWRlci5vcHRpb25z KCkuc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbklkZW50aWZpZXI7CiAgICAgbG9hZFBhcmFtZXRl cnMuaHR0cEhlYWRlcnNUb0tlZXAgPSByZXNvdXJjZUxvYWRlci5vcHRpb25zKCkuaHR0cEhlYWRl cnNUb0tlZXA7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9O ZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9O ZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcAppbmRleCA1YjNlZjIzOWFkZDY5ZTRlYWZjYjlm ZDE1MGNmMTU3MjRiZDFlNTIzLi4wODVkNTA5ZDZlOTEyZWZmNDYzMjdkNzg4OTJiZWE0ZmJlNzJl YWE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNv dXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2Vi UmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0yNDIsMjIgKzI0Miw3IEBAIHZvaWQgV2ViUmVzb3VyY2VM b2FkZXI6OnNlcnZpY2VXb3JrZXJEaWROb3RIYW5kbGUoKQogI2lmIEVOQUJMRShTRVJWSUNFX1dP UktFUikKICAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJzZXJ2aWNlV29ya2VyRGlkTm90SGFu ZGxlOiAocGFnZUlEID0gJSIgUFJJdTY0ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQgIiwgcmVzb3Vy Y2VJRCA9ICUiIFBSSXU2NCAiKSIsIG1fdHJhY2tpbmdQYXJhbWV0ZXJzLnBhZ2VJRC50b1VJbnQ2 NCgpLCBtX3RyYWNraW5nUGFyYW1ldGVycy5mcmFtZUlELnRvVUludDY0KCksIG1fdHJhY2tpbmdQ YXJhbWV0ZXJzLnJlc291cmNlSUQpOwogCi0gICAgaWYgKG1fY29yZUxvYWRlci0+b3B0aW9ucygp LnNlcnZpY2VXb3JrZXJzTW9kZSAhPSBTZXJ2aWNlV29ya2Vyc01vZGU6Ok9ubHkpIHsKLSAgICAg ICAgYXV0byogd2ViRnJhbWVMb2FkZXJDbGllbnQgPSB0b1dlYkZyYW1lTG9hZGVyQ2xpZW50KG1f Y29yZUxvYWRlci0+ZnJhbWVMb2FkZXIoKS0+Y2xpZW50KCkpOwotICAgICAgICBhdXRvKiB3ZWJG cmFtZSA9IHdlYkZyYW1lTG9hZGVyQ2xpZW50ID8gd2ViRnJhbWVMb2FkZXJDbGllbnQtPndlYkZy YW1lKCkgOiBudWxscHRyOwotICAgICAgICBhdXRvKiB3ZWJQYWdlID0gd2ViRnJhbWUgPyB3ZWJG cmFtZS0+cGFnZSgpIDogbnVsbHB0cjsKLQotICAgICAgICBpZiAoYXV0byogaGFuZGxlciA9IHdl YlBhZ2UtPnVybFNjaGVtZUhhbmRsZXJGb3JTY2hlbWUobV9jb3JlTG9hZGVyLT5yZXF1ZXN0KCku dXJsKCkucHJvdG9jb2woKS50b1N0cmluZ1dpdGhvdXRDb3B5aW5nKCkpKSB7Ci0gICAgICAgICAg ICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJyZXNvdXJjZSBsb2FkZWQgYnkgVVJMIHNjaGVtZSBo YW5kbGVyOiAocGFnZUlEID0gJSIgUFJJdTY0ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQgIiwgcmVz b3VyY2VJRCA9ICUiIFBSSXU2NCAiKSIsIG1fdHJhY2tpbmdQYXJhbWV0ZXJzLnBhZ2VJRC50b1VJ bnQ2NCgpLCBtX3RyYWNraW5nUGFyYW1ldGVycy5mcmFtZUlELnRvVUludDY0KCksIG1fdHJhY2tp bmdQYXJhbWV0ZXJzLnJlc291cmNlSUQpOwotCi0gICAgICAgICAgICBhdXRvIGxvYWRlciA9IG1f Y29yZUxvYWRlcjsKLSAgICAgICAgICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLndlYkxvYWRl clN0cmF0ZWd5KCkucmVtb3ZlKG1fY29yZUxvYWRlci5nZXQoKSk7Ci0KLSAgICAgICAgICAgIGhh bmRsZXItPnN0YXJ0TmV3VGFzaygqbG9hZGVyKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAg ICAgfQotICAgIH0KLQorICAgIEFTU0VSVChtX2NvcmVMb2FkZXItPm9wdGlvbnMoKS5zZXJ2aWNl V29ya2Vyc01vZGUgPT0gU2VydmljZVdvcmtlcnNNb2RlOjpPbmx5KTsKICAgICBhdXRvIGVycm9y ID0gaW50ZXJuYWxFcnJvcihtX2NvcmVMb2FkZXItPnJlcXVlc3QoKS51cmwoKSk7CiAgICAgZXJy b3Iuc2V0VHlwZShSZXNvdXJjZUVycm9yOjpUeXBlOjpDYW5jZWxsYXRpb24pOwogICAgIG1fY29y ZUxvYWRlci0+ZGlkRmFpbChlcnJvcik7Cg==