203227 2019-10-21 17:42:24 -0700 Fix missing exception check in JSON Stringifier. 2019-10-21 17:52:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1582167 0 mark.lam 2019-10-21 17:42:24 -0700 <rdar://problem/56459854> 1582170 1 381487 mark.lam 2019-10-21 17:45:58 -0700 Created attachment 381487 proposed patch. 1582171 2 381487 keith_miller 2019-10-21 17:48:13 -0700 Comment on attachment 381487 proposed patch. r=me 1582173 3 mark.lam 2019-10-21 17:52:09 -0700 Thanks for the review. Landed in r251403: <http://trac.webkit.org/r251403>. 381487 2019-10-21 17:45:58 -0700 2019-10-21 17:48:13 -0700 proposed patch. bug-203227.patch text/plain 2618 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTE0MDEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTEwLTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggbWlzc2luZyBleGNlcHRpb24gY2hlY2sgaW4gSlNPTiBTdHJpbmdp Zmllci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MzIyNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTY0NTk4NTQ+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvbWlzc2luZy1leGNlcHRp b24tY2hlY2staW4tam9zbi1zdHJpbmdpZmllci5qczogQWRkZWQuCisKIDIwMTktMTAtMjEgIFNh YW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgSlNPTi5wYXJzZSBoYXMg YmFkIGlzIGFycmF5IGFzc2VydApJbmRleDogSlNUZXN0cy9zdHJlc3MvbWlzc2luZy1leGNlcHRp b24tY2hlY2staW4tam9zbi1zdHJpbmdpZmllci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0 cmVzcy9taXNzaW5nLWV4Y2VwdGlvbi1jaGVjay1pbi1qb3NuLXN0cmluZ2lmaWVyLmpzCShub25l eGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLWluLWpv c24tc3RyaW5naWZpZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw4IEBACisvL0AgcnVu RGVmYXVsdAorCitsZXQgcCA9IG5ldyBQcm94eShbXSwgeworICAgIGdldDogZnVuY3Rpb24oKSB7 CisgICAgICAgIHJldHVybiB7fTsKKyAgICB9Cit9KTsKK0pTT04uc3RyaW5naWZ5KG51bGwsIHAp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTEzOTkpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTktMTAtMjEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAg IEZpeCBtaXNzaW5nIGV4Y2VwdGlvbiBjaGVjayBpbiBKU09OIFN0cmluZ2lmaWVyLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMjI3CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS81NjQ1OTg1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPTk9iamVjdC5jcHA6CisgICAgICAgIChK U0M6OlN0cmluZ2lmaWVyOjpTdHJpbmdpZmllcik6CisKIDIwMTktMTAtMjEgIE1hcmsgTGFtICA8 bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBpc3N1ZXMgd2hlbiBzZXR0aW5nIHB1 YmxpYyBsZW5ndGggb24gQXJyYXlXaXRoQ29udGlndW91cyB0eXBlIGJ1dHRlcmZsaWVzLgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5jcHAJKHJldmlz aW9uIDI1MTM5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3Qu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzcsNyArMjM3LDkgQEAgU3RyaW5naWZpZXI6OlN0cmlu Z2lmaWVyKEV4ZWNTdGF0ZSogZXhlYwogICAgICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihz Y29wZSwgKTsKICAgICAgICAgICAgIGlmIChpc0FycmF5UmVwbGFjZXIpIHsKICAgICAgICAgICAg ICAgICBtX3VzaW5nQXJyYXlSZXBsYWNlciA9IHRydWU7Ci0gICAgICAgICAgICAgICAgdW5zaWdu ZWQgbGVuZ3RoID0gcmVwbGFjZXJPYmplY3QtPmdldChleGVjLCB2bS5wcm9wZXJ0eU5hbWVzLT5s ZW5ndGgpLnRvVUludDMyKGV4ZWMpOworICAgICAgICAgICAgICAgIEpTVmFsdWUgbGVuZ3RoVmFs dWUgPSByZXBsYWNlck9iamVjdC0+Z2V0KGV4ZWMsIHZtLnByb3BlcnR5TmFtZXMtPmxlbmd0aCk7 CisgICAgICAgICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgKTsKKyAgICAgICAg ICAgICAgICB1bnNpZ25lZCBsZW5ndGggPSBsZW5ndGhWYWx1ZS50b1VJbnQzMihleGVjKTsKICAg ICAgICAgICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCApOwogICAgICAgICAgICAg ICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgewogICAgICAgICAgICAg ICAgICAgICBKU1ZhbHVlIG5hbWUgPSByZXBsYWNlck9iamVjdC0+Z2V0KGV4ZWMsIGkpOwo=