20322 2008-08-07 13:50:40 -0700 XHRs logged in the console do not have line numbers 2008-09-25 09:05:03 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 17776 1 kmccullough kmccullough oldest_to_newest 88060 0 kmccullough 2008-08-07 13:50:40 -0700 8/5/08 11:04 AM Kevin McCullough: * SUMMARY In the console an XHR that is logged does not have line numbers so when clicking the URL of the resource that loaded it, the user is not taken to the line where the load occurred. This is a feature that works in Firebug. <rdar://problem/6126262 > 92622 1 23770 kmccullough 2008-09-24 16:49:40 -0700 Created attachment 23770 proposed patch 92625 2 23770 ggaren 2008-09-24 16:54:56 -0700 Comment on attachment 23770 proposed patch This work seems harmless enough that it's OK to do even when the develop menu is disabled. Perhaps a Shark profile will tell us otherwise in the future. 92658 3 timothy 2008-09-24 20:13:34 -0700 You need to check the line number for -1, the error case. Otherwise storing it in the unsigned will give a huge number. The inspector expects 0 for unknown line numbers, not -1. This is done in Console.cpp like: lineNumber = (signedLineNumber >= 0 ? signedLineNumber : 0); 92727 4 kmccullough 2008-09-25 09:05:03 -0700 Committed revision 36894. 23770 2008-09-24 16:49:40 -0700 2008-09-24 16:54:56 -0700 proposed patch XHRLineNumbers.txt text/plain 3440 kmccullough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM2ODc0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMDkt MjQgIEtldmluIE1jQ3VsbG91Z2ggIDxrbWNjdWxsb3VnaEBhcHBsZS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIwMzIyOiBYSFJzIGxv Z2dlZCBpbiB0aGUgY29uc29sZSBkbyBub3QgaGF2ZSBsaW5lIG51bWJlcnMKKyAgICAgICAgLSBH ZXQgdGhlIGxpbmUgbnVtYmVyIGF0IHRoZSB0aW1lIG9mIHRoZSBzZW5kIGFuZCBwYXNzIGl0IG9u IHRvIHRoZSBYSFIuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0Q3Vz dG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTWE1MSHR0cFJlcXVlc3Q6OnNlbmQpOgorICAg ICAgICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRw UmVxdWVzdDo6WE1MSHR0cFJlcXVlc3QpOgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVl c3Q6OmRpZEZpbmlzaExvYWRpbmcpOgorICAgICAgICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5oOgor ICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OnNldExhc3RTZW5kTGluZU51bWJlcik6 CisKIDIwMDgtMDktMjQgIEplcmVteSBNb3Nrb3ZpY2ggIDxqZXJlbXlAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBiaW5kaW5ncy9qcy9K U1hNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBiaW5kaW5ncy9qcy9KU1hN TEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcAkocmV2aXNpb24gMzY4NzApCisrKyBiaW5kaW5ncy9qcy9K U1hNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDMsNiArNDMsNyBA QAogI2luY2x1ZGUgIkpTRmlsZS5oIgogI2luY2x1ZGUgIlhNTEh0dHBSZXF1ZXN0LmgiCiAjaW5j bHVkZSA8a2pzL0Vycm9yLmg+CisjaW5jbHVkZSA8Vk0vTWFjaGluZS5oPgogCiB1c2luZyBuYW1l c3BhY2UgSlNDOwogCkBAIC0yNTEsNiArMjUyLDEzIEBAIEpTVmFsdWUqIEpTWE1MSHR0cFJlcXVl c3Q6OnNlbmQoRXhlY1N0YXQKICAgICAgICAgICAgIGltcGwoKS0+c2VuZCh2YWwtPnRvU3RyaW5n KGV4ZWMpLCBlYyk7CiAgICAgfQogCisgICAgaW50IGxpbmVOdW1iZXI7CisgICAgaW50IHNvdXJj ZUlEOworICAgIFVTdHJpbmcgc291cmNlVVJMOworICAgIEpTVmFsdWUqIGZ1bmN0aW9uOworICAg IGV4ZWMtPm1hY2hpbmUoKS0+cmV0cmlldmVMYXN0Q2FsbGVyKGV4ZWMsIGxpbmVOdW1iZXIsIHNv dXJjZUlELCBzb3VyY2VVUkwsIGZ1bmN0aW9uKTsKKyAgICBpbXBsKCktPnNldExhc3RTZW5kTGlu ZU51bWJlcihsaW5lTnVtYmVyKTsKKwogICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBlYyk7CiAg ICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiB9CkluZGV4OiB4bWwvWE1MSHR0cFJlcXVlc3QuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIHhtbC9YTUxIdHRwUmVxdWVzdC5jcHAJKHJldmlzaW9uIDM2ODcwKQor KysgeG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE2LDYgKzIxNiw3 IEBAIFhNTEh0dHBSZXF1ZXN0OjpYTUxIdHRwUmVxdWVzdChEb2N1bWVudCoKICAgICAsIG1fc2Ft ZU9yaWdpblJlcXVlc3QodHJ1ZSkKICAgICAsIG1faW5QcmVmbGlnaHQoZmFsc2UpCiAgICAgLCBt X3JlY2VpdmVkTGVuZ3RoKDApCisgICAgLCBtX2xhc3RTZW5kTGluZU51bWJlcigwKQogewogICAg IEFTU0VSVChtX2RvYyk7CiAgICAgYWRkVG9SZXF1ZXN0c0J5RG9jdW1lbnQobV9kb2MsIHRoaXMp OwpAQCAtMTA3Myw3ICsxMDc0LDcgQEAgdm9pZCBYTUxIdHRwUmVxdWVzdDo6ZGlkRmluaXNoTG9h ZGluZyhTdQogICAgIGlmIChGcmFtZSogZnJhbWUgPSBtX2RvYy0+ZnJhbWUoKSkgewogICAgICAg ICBpZiAoUGFnZSogcGFnZSA9IGZyYW1lLT5wYWdlKCkpIHsKICAgICAgICAgICAgIHBhZ2UtPmlu c3BlY3RvckNvbnRyb2xsZXIoKS0+cmVzb3VyY2VSZXRyaWV2ZWRCeVhNTEh0dHBSZXF1ZXN0KG1f bG9hZGVyID8gbV9sb2FkZXItPmlkZW50aWZpZXIoKSA6IG1faWRlbnRpZmllciwgbV9yZXNwb25z ZVRleHQpOwotICAgICAgICAgICAgcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT5hZGRNZXNz YWdlVG9Db25zb2xlKEpTTWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZUxldmVsLCAiWEhSIGZpbmlz aGVkIGxvYWRpbmcgXCIiICsgbV91cmwgKyAiXCIuIiwgMCwgbV9kb2MtPnVybCgpKTsKKyAgICAg ICAgICAgIHBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+YWRkTWVzc2FnZVRvQ29uc29sZShK U01lc3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VMZXZlbCwgIlhIUiBmaW5pc2hlZCBsb2FkaW5nOiBc IiIgKyBtX3VybCArICJcIi4iLCBtX2xhc3RTZW5kTGluZU51bWJlciwgbV9kb2MtPnVybCgpKTsK ICAgICAgICAgfQogICAgIH0KIApJbmRleDogeG1sL1hNTEh0dHBSZXF1ZXN0LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0geG1sL1hNTEh0dHBSZXF1ZXN0LmgJKHJldmlzaW9uIDM2ODcwKQorKysgeG1sL1hNTEh0 dHBSZXF1ZXN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTY5LDYgKzY5LDcgQEAgcHVibGljOgogICAg IFN0cmluZyBnZXRSZXNwb25zZUhlYWRlcihjb25zdCBTdHJpbmcmIG5hbWUsIEV4Y2VwdGlvbkNv ZGUmKSBjb25zdDsKICAgICBjb25zdCBKU0M6OlVTdHJpbmcmIHJlc3BvbnNlVGV4dCgpIGNvbnN0 OwogICAgIERvY3VtZW50KiByZXNwb25zZVhNTCgpIGNvbnN0OworICAgIHZvaWQgc2V0TGFzdFNl bmRMaW5lTnVtYmVyKHVuc2lnbmVkIGxpbmVOdW1iZXIpIHsgbV9sYXN0U2VuZExpbmVOdW1iZXIg PSBsaW5lTnVtYmVyOyB9CiAKICAgICBYTUxIdHRwUmVxdWVzdFVwbG9hZCogdXBsb2FkKCk7CiAg ICAgWE1MSHR0cFJlcXVlc3RVcGxvYWQqIG9wdGlvbmFsVXBsb2FkKCkgY29uc3QgeyByZXR1cm4g bV91cGxvYWQuZ2V0KCk7IH0KQEAgLTIxOCw2ICsyMTksOCBAQCBwcml2YXRlOgogCiAgICAgLy8g VXNlZCBmb3Igb25wcm9ncmVzcyB0cmFja2luZwogICAgIGxvbmcgbG9uZyBtX3JlY2VpdmVkTGVu Z3RoOworICAgIAorICAgIHVuc2lnbmVkIG1fbGFzdFNlbmRMaW5lTnVtYmVyOwogfTsKIAogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQo=