203201 2019-10-21 12:40:09 -0700 [GTK] Web Inspector: add an option for disabling minification and concatenation of inspector UI in release build 2019-10-22 10:05:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 yurys yurys annulen cgarcia commit-queue ews-watchlist gyuyoung.kim inspector-bugzilla-changes ryuan.choi sergio webkit-bug-importer oldest_to_newest 1581952 0 yurys 2019-10-21 12:40:09 -0700 This is possible on Mac but only works in Debug mode in GTK. Most of the Web Inspector UI is written in JavaScript so it's very convenient to be able to run release binary with original js source files. Disabling minification saves a lot of build time otherwise spent in jsmin.py when .js sources change. 1581955 1 381430 yurys 2019-10-21 12:45:52 -0700 Created attachment 381430 Patch 1582294 2 381430 cgarcia 2019-10-22 01:33:18 -0700 Comment on attachment 381430 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381430&action=review > Source/WebKit/InspectorGResources.cmake:52 > + elseif (DEVELOPER_MODE) > + set(COMBINE_INSPECTOR_RESOURCES YES) Now that inspector and test resources are split we don't need this branch. > Source/WebKit/InspectorGResources.cmake:61 > + if (CMAKE_BUILD_TYPE STREQUAL "Debug") > + set(COMBINE_TEST_RESOURCES YES) > + elseif (DEVELOPER_MODE) > + set(COMBINE_TEST_RESOURCES YES) And here we could use OR 1582387 3 381430 yurys 2019-10-22 09:12:41 -0700 Comment on attachment 381430 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381430&action=review Thanks for quick review! >> Source/WebKit/InspectorGResources.cmake:52 >> + set(COMBINE_INSPECTOR_RESOURCES YES) > > Now that inspector and test resources are split we don't need this branch. Done. >> Source/WebKit/InspectorGResources.cmake:61 >> + set(COMBINE_TEST_RESOURCES YES) > > And here we could use OR Done. 1582390 4 381551 yurys 2019-10-22 09:19:28 -0700 Created attachment 381551 Patch for landing 1582420 5 381551 commit-queue 2019-10-22 10:04:48 -0700 Comment on attachment 381551 Patch for landing Clearing flags on attachment: 381551 Committed r251438: <https://trac.webkit.org/changeset/251438> 1582421 6 commit-queue 2019-10-22 10:04:50 -0700 All reviewed patches have been landed. Closing bug. 1582422 7 webkit-bug-importer 2019-10-22 10:05:16 -0700 <rdar://problem/56504037> 381430 2019-10-21 12:45:52 -0700 2019-10-22 09:19:26 -0700 Patch bug-203201-20191021124551.patch text/plain 2350 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY5OWJmMDljN2ZmY2E4MTEw N2RjMWZhNDcxZDJlYTBkNDM2M2ExMzEuLjUxMWRjZGNiZmMyMDQzZDdjZWI1NjFlM2YzYzExOTli NzYwNDM0ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMTAtMjEgIFl1cnkgU2Vt aWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0dUS10gV2ViIEluc3Bl Y3RvcjogYWRkIGFuIG9wdGlvbiBmb3IgZGlzYWJsaW5nIG1pbmlmaWNhdGlvbiBhbmQgY29uY2F0 ZW5hdGlvbiBvZiBpbnNwZWN0b3IgVUkgaW4gcmVsZWFzZSBidWlsZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMjAxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgcGFzc2luZyBDT01CSU5FX0lO U1BFQ1RPUl9SRVNPVVJDRVMgYW5kIENPTUJJTkVfVEVTVF9SRVNPVVJDRVMgYXMgY21ha2UgYXJn dW1lbnRzLiBUaGlzCisgICAgICAgIGVuYWJsZXMgdG8gYXZvaWQgbWluaWZpY2F0aW9uIG9mIFdl YiBJbnNwZWN0b3Igc2NyaXB0cyBpbiByZWxlYXNlIGJpbmFyaWVzIHdoaWNoIGlzIHZlcnkKKyAg ICAgICAgY29udmVuaWVudCBkdXJpbmcgaW5zcGVjdG9yIFVJIGRldmVsb3BtZW50LgorCisgICAg ICAgICogSW5zcGVjdG9yR1Jlc291cmNlcy5jbWFrZToKKwogMjAxOS0xMC0yMSAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gT2JqZWN0 cyBjYXRlZ29yeSBpbiBlbW9qaSBwaWNrZXIgaXMgZW1wdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvSW5zcGVjdG9yR1Jlc291cmNlcy5jbWFrZSBiL1NvdXJjZS9XZWJLaXQvSW5zcGVjdG9y R1Jlc291cmNlcy5jbWFrZQppbmRleCBmNDZmNDBlY2RmZjE0ZGNiNGUxNTU2ZGUzZmUzYmRhZWJj NjcxMTA0Li40YzJmYjU4NGUxOGFhOTFkMTlhYzYyMjliZDJkYjg5NTEwMWRjOWQ4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L0luc3BlY3RvckdSZXNvdXJjZXMuY21ha2UKKysrIGIvU291cmNl L1dlYktpdC9JbnNwZWN0b3JHUmVzb3VyY2VzLmNtYWtlCkBAIC00NSwxNSArNDUsMjMgQEAgbWFj cm8oV0VCS0lUX0JVSUxEX0lOU1BFQ1RPUl9HUkVTT1VSQ0VTIF9kZXJpdmVkX3NvdXJjZXNfZGly KQogICAgICAgICBWRVJCQVRJTQogICAgICkKIAotICAgIGlmIChDTUFLRV9CVUlMRF9UWVBFIFNU UkVRVUFMICJEZWJ1ZyIpCi0gICAgICAgIHNldChDT01CSU5FX0lOU1BFQ1RPUl9SRVNPVVJDRVMg Tk8pCi0gICAgICAgIHNldChDT01CSU5FX1RFU1RfUkVTT1VSQ0VTIFlFUykKLSAgICBlbHNlaWYg KERFVkVMT1BFUl9NT0RFKQotICAgICAgICBzZXQoQ09NQklORV9JTlNQRUNUT1JfUkVTT1VSQ0VT IFlFUykKLSAgICAgICAgc2V0KENPTUJJTkVfVEVTVF9SRVNPVVJDRVMgWUVTKQotICAgIGVsc2Ug KCkKLSAgICAgICAgc2V0KENPTUJJTkVfSU5TUEVDVE9SX1JFU09VUkNFUyBZRVMpCi0gICAgICAg IHNldChDT01CSU5FX1RFU1RfUkVTT1VSQ0VTIE5PKQorICAgIGlmIChOT1QgREVGSU5FRCBDT01C SU5FX0lOU1BFQ1RPUl9SRVNPVVJDRVMpCisgICAgICAgIGlmIChDTUFLRV9CVUlMRF9UWVBFIFNU UkVRVUFMICJEZWJ1ZyIpCisgICAgICAgICAgICBzZXQoQ09NQklORV9JTlNQRUNUT1JfUkVTT1VS Q0VTIE5PKQorICAgICAgICBlbHNlaWYgKERFVkVMT1BFUl9NT0RFKQorICAgICAgICAgICAgc2V0 KENPTUJJTkVfSU5TUEVDVE9SX1JFU09VUkNFUyBZRVMpCisgICAgICAgIGVsc2UgKCkKKyAgICAg ICAgICAgIHNldChDT01CSU5FX0lOU1BFQ1RPUl9SRVNPVVJDRVMgWUVTKQorICAgICAgICBlbmRp ZiAoKQorICAgIGVuZGlmICgpCisgICAgaWYgKE5PVCBERUZJTkVEIENPTUJJTkVfVEVTVF9SRVNP VVJDRVMpCisgICAgICAgIGlmIChDTUFLRV9CVUlMRF9UWVBFIFNUUkVRVUFMICJEZWJ1ZyIpCisg ICAgICAgICAgICBzZXQoQ09NQklORV9URVNUX1JFU09VUkNFUyBZRVMpCisgICAgICAgIGVsc2Vp ZiAoREVWRUxPUEVSX01PREUpCisgICAgICAgICAgICBzZXQoQ09NQklORV9URVNUX1JFU09VUkNF UyBZRVMpCisgICAgICAgIGVsc2UgKCkKKyAgICAgICAgICAgIHNldChDT01CSU5FX1RFU1RfUkVT T1VSQ0VTIE5PKQorICAgICAgICBlbmRpZiAoKQogICAgIGVuZGlmICgpCiAKICAgICBhZGRfY3Vz dG9tX2NvbW1hbmQoCg== 381551 2019-10-22 09:19:28 -0700 2019-10-22 10:04:48 -0700 Patch for landing bug-203201-20191022091927.patch text/plain 2244 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM4ZTdmOTVmZjM4MmFmZDJl YTgwOGVkY2M0ZWZmZjlkNWRjYmVjOGEuLjkxNjJmM2RiYTMwOTU5MGNhZjRkYmY0ZWFiOTgyOTY3 NmI2YmE3ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMTAtMjEgIFl1cnkgU2Vt aWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0dUS10gV2ViIEluc3Bl Y3RvcjogYWRkIGFuIG9wdGlvbiBmb3IgZGlzYWJsaW5nIG1pbmlmaWNhdGlvbiBhbmQgY29uY2F0 ZW5hdGlvbiBvZiBpbnNwZWN0b3IgVUkgaW4gcmVsZWFzZSBidWlsZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMjAxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQ2FybG9zIEdhcmNpYSBDYW1wb3MuCisKKyAgICAgICAgQWxsb3cgcGFzc2luZyBDT01C SU5FX0lOU1BFQ1RPUl9SRVNPVVJDRVMgYW5kIENPTUJJTkVfVEVTVF9SRVNPVVJDRVMgYXMgY21h a2UgYXJndW1lbnRzLiBUaGlzCisgICAgICAgIGVuYWJsZXMgdG8gYXZvaWQgbWluaWZpY2F0aW9u IG9mIFdlYiBJbnNwZWN0b3Igc2NyaXB0cyBpbiByZWxlYXNlIGJpbmFyaWVzIHdoaWNoIGlzIHZl cnkKKyAgICAgICAgY29udmVuaWVudCBkdXJpbmcgaW5zcGVjdG9yIFVJIGRldmVsb3BtZW50Lgor CisgICAgICAgICogSW5zcGVjdG9yR1Jlc291cmNlcy5jbWFrZToKKwogMjAxOS0xMC0yMiAgeW91 ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViU1dTZXJ2ZXJUb0Nv bnRleHRDb25uZWN0aW9uIHNob3VsZCBub3QgYXNzZXJ0IHdoZW4gZmFpbGluZyBsb2FkcyBhdCBk ZXN0cnVjdGlvbiB0aW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0luc3BlY3RvckdSZXNv dXJjZXMuY21ha2UgYi9Tb3VyY2UvV2ViS2l0L0luc3BlY3RvckdSZXNvdXJjZXMuY21ha2UKaW5k ZXggZjQ2ZjQwZWNkZmYxNGRjYjRlMTU1NmRlM2ZlM2JkYWViYzY3MTEwNC4uNjc0YjVlZjBiZTRi ZWIyYTJlODFiMWJjZTk4NDc4MjJiZDRiNDgyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9J bnNwZWN0b3JHUmVzb3VyY2VzLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvSW5zcGVjdG9yR1Jl c291cmNlcy5jbWFrZQpAQCAtNDUsMTUgKzQ1LDE5IEBAIG1hY3JvKFdFQktJVF9CVUlMRF9JTlNQ RUNUT1JfR1JFU09VUkNFUyBfZGVyaXZlZF9zb3VyY2VzX2RpcikKICAgICAgICAgVkVSQkFUSU0K ICAgICApCiAKLSAgICBpZiAoQ01BS0VfQlVJTERfVFlQRSBTVFJFUVVBTCAiRGVidWciKQotICAg ICAgICBzZXQoQ09NQklORV9JTlNQRUNUT1JfUkVTT1VSQ0VTIE5PKQotICAgICAgICBzZXQoQ09N QklORV9URVNUX1JFU09VUkNFUyBZRVMpCi0gICAgZWxzZWlmIChERVZFTE9QRVJfTU9ERSkKLSAg ICAgICAgc2V0KENPTUJJTkVfSU5TUEVDVE9SX1JFU09VUkNFUyBZRVMpCi0gICAgICAgIHNldChD T01CSU5FX1RFU1RfUkVTT1VSQ0VTIFlFUykKLSAgICBlbHNlICgpCi0gICAgICAgIHNldChDT01C SU5FX0lOU1BFQ1RPUl9SRVNPVVJDRVMgWUVTKQotICAgICAgICBzZXQoQ09NQklORV9URVNUX1JF U09VUkNFUyBOTykKKyAgICBpZiAoTk9UIERFRklORUQgQ09NQklORV9JTlNQRUNUT1JfUkVTT1VS Q0VTKQorICAgICAgICBpZiAoQ01BS0VfQlVJTERfVFlQRSBTVFJFUVVBTCAiRGVidWciKQorICAg ICAgICAgICAgc2V0KENPTUJJTkVfSU5TUEVDVE9SX1JFU09VUkNFUyBOTykKKyAgICAgICAgZWxz ZSAoKQorICAgICAgICAgICAgc2V0KENPTUJJTkVfSU5TUEVDVE9SX1JFU09VUkNFUyBZRVMpCisg ICAgICAgIGVuZGlmICgpCisgICAgZW5kaWYgKCkKKyAgICBpZiAoTk9UIERFRklORUQgQ09NQklO RV9URVNUX1JFU09VUkNFUykKKyAgICAgICAgaWYgKENNQUtFX0JVSUxEX1RZUEUgU1RSRVFVQUwg IkRlYnVnIiBPUiBERVZFTE9QRVJfTU9ERSkKKyAgICAgICAgICAgIHNldChDT01CSU5FX1RFU1Rf UkVTT1VSQ0VTIFlFUykKKyAgICAgICAgZWxzZSAoKQorICAgICAgICAgICAgc2V0KENPTUJJTkVf VEVTVF9SRVNPVVJDRVMgTk8pCisgICAgICAgIGVuZGlmICgpCiAgICAgZW5kaWYgKCkKIAogICAg IGFkZF9jdXN0b21fY29tbWFuZCgK