203191 2019-10-21 03:20:07 -0700 [GTK] C++ comments used in C header files 2019-10-22 01:48:31 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mcrha webkit-unassigned berto bugs-noreply cgarcia ews-watchlist gustavo zan oldest_to_newest 1581834 0 mcrha 2019-10-21 03:20:07 -0700 I just tried to compile Evolution with -ansi -D_DEFAULT_SOURCE=1 and I see a lot of warnings coming from WebKitGTK+ like this: /usr/include/webkitgtk-4.0/webkit2/WebKitAutocleanups.h:88:8: warning: extra tokens at end of #endif directive [-Wendif-labels] 88 | #endif // WebKitAutocleanups_h There are a lot of these, from various files. The fix is to use C comments, thus: #endif /* WebKitAutocleanups_h */ 1581838 1 381412 cgarcia 2019-10-21 04:42:24 -0700 Created attachment 381412 Patch 1581839 2 ews-watchlist 2019-10-21 04:43:12 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1582302 3 cgarcia 2019-10-22 01:48:31 -0700 Committed r251423: <https://trac.webkit.org/changeset/251423> 381412 2019-10-21 04:42:24 -0700 2019-10-21 06:26:51 -0700 Patch wk2-comments.diff text/plain 7123 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZjk5YmYwOWM3ZmYuLmZkM2MwMjViYjZlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIxIEBACisyMDE5LTEwLTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBDKysgY29tbWVudHMgdXNlZCBpbiBDIGhlYWRlciBmaWxl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMTkx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRBdXRvY2xlYW51cHMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXREZWZpbmVzLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0Rm9yd2FyZERlY2xhcmF0aW9ucy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFdlYlZpZXdCYXNlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS93cGUvV2ViS2l0QXV0 b2NsZWFudXBzLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS93cGUvV2ViS2l0RGVmaW5lcy5o OgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJF ZGl0b3IuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvV2Vi S2l0V2ViRXh0ZW5zaW9uQXV0b2NsZWFudXBzLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9Jbmpl Y3RlZEJ1bmRsZS9BUEkvd3BlL1dlYktpdFdlYkVkaXRvci5oOgorICAgICAgICAqIFdlYlByb2Nl c3MvSW5qZWN0ZWRCdW5kbGUvQVBJL3dwZS9XZWJLaXRXZWJFeHRlbnNpb25BdXRvY2xlYW51cHMu aDoKKwogMjAxOS0xMC0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS10gT2JqZWN0cyBjYXRlZ29yeSBpbiBlbW9qaSBwaWNrZXIgaXMg ZW1wdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 QXV0b2NsZWFudXBzLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1 dG9jbGVhbnVwcy5oCmluZGV4IDU3NTdmNTc3NjI2Li44MjQ2M2I1NWQ5YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRBdXRvY2xlYW51cHMuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dG9jbGVhbnVwcy5oCkBA IC04Myw3ICs4Myw3IEBAIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRVc2Vy Q29udGVudEZpbHRlciwgd2Via2l0X3VzZXJfY29udGVudF9maWx0CiBHX0RFRklORV9BVVRPUFRS X0NMRUFOVVBfRlVOQyAoV2ViS2l0V2Vic2l0ZURhdGEsIHdlYmtpdF93ZWJzaXRlX2RhdGFfdW5y ZWYpCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2ViVmlld1Nlc3Npb25T dGF0ZSwgd2Via2l0X3dlYl92aWV3X3Nlc3Npb25fc3RhdGVfdW5yZWYpCiAKLSNlbmRpZiAvLyBf X0dJX1NDQU5ORVJfXwotI2VuZGlmIC8vIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DCisj ZW5kaWYgLyogX19HSV9TQ0FOTkVSX18gKi8KKyNlbmRpZiAvKiBHX0RFRklORV9BVVRPUFRSX0NM RUFOVVBfRlVOQyAqLwogCi0jZW5kaWYgLy8gV2ViS2l0QXV0b2NsZWFudXBzX2gKKyNlbmRpZiAv KiBXZWJLaXRBdXRvY2xlYW51cHNfaCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXREZWZpbmVzLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdERlZmluZXMuaAppbmRleCA1MjBlOTk1N2MzOC4uZmYzZDVlZmZmOTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RGVmaW5lcy5o CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RGVmaW5lcy5oCkBA IC00NSw0ICs0NSw0IEBACiAjZGVmaW5lIFdFQktJVF9ERVBSRUNBVEVEIFdFQktJVF9BUEkgR19E RVBSRUNBVEVECiAjZGVmaW5lIFdFQktJVF9ERVBSRUNBVEVEX0ZPUihmKSBXRUJLSVRfQVBJIEdf REVQUkVDQVRFRF9GT1IoZikKIAotI2VuZGlmIC8vIFdlYktpdERlZmluZXNfaAorI2VuZGlmIC8q IFdlYktpdERlZmluZXNfaCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRGb3J3YXJkRGVjbGFyYXRpb25zLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdEZvcndhcmREZWNsYXJhdGlvbnMuaAppbmRleCA1NDNmNGIxMzY4 OC4uZTc2ZTdhMWJiNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0Rm9yd2FyZERlY2xhcmF0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0Rm9yd2FyZERlY2xhcmF0aW9ucy5oCkBAIC0zNiw0ICszNiw0IEBA IHR5cGVkZWYgc3RydWN0IF9XZWJLaXRXZWJWaWV3ICAgICAgICAgV2ViS2l0V2ViVmlldzsKIHR5 cGVkZWYgc3RydWN0IF9XZWJLaXRDb250ZXh0TWVudSAgICAgV2ViS2l0Q29udGV4dE1lbnU7CiB0 eXBlZGVmIHN0cnVjdCBfV2ViS2l0Q29udGV4dE1lbnVJdGVtIFdlYktpdENvbnRleHRNZW51SXRl bTsKIAotI2VuZGlmIC8vIFdlYktpdEZvcndhcmRfaAorI2VuZGlmIC8qIFdlYktpdEZvcndhcmRf aCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3QmFzZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJW aWV3QmFzZS5oCmluZGV4IGYyNDQ1N2Y1N2JjLi5kMDVkMGRkYTYwYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuaApAQCAtNjgs NCArNjgsNCBAQCB3ZWJraXRfd2ViX3ZpZXdfYmFzZV9nZXRfdHlwZSAodm9pZCk7CiAKIEdfRU5E X0RFQ0xTCiAKLSNlbmRpZiAvLyBXZWJLaXRXZWJWaWV3QmFzZV9oCisjZW5kaWYgLyogV2ViS2l0 V2ViVmlld0Jhc2VfaCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L3dwZS9XZWJLaXRBdXRvY2xlYW51cHMuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93 cGUvV2ViS2l0QXV0b2NsZWFudXBzLmgKaW5kZXggNDUzMDJmNmQ5N2IuLjhmZjMzMzlmMGEzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdEF1dG9jbGVh bnVwcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvV2ViS2l0QXV0b2Ns ZWFudXBzLmgKQEAgLTc4LDcgKzc4LDcgQEAgR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMg KFdlYktpdFVzZXJDb250ZW50RmlsdGVyLCB3ZWJraXRfdXNlcl9jb250ZW50X2ZpbHQKIEdfREVG SU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRXZWJzaXRlRGF0YSwgd2Via2l0X3dlYnNp dGVfZGF0YV91bnJlZikKIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRXZWJW aWV3U2Vzc2lvblN0YXRlLCB3ZWJraXRfd2ViX3ZpZXdfc2Vzc2lvbl9zdGF0ZV91bnJlZikKIAot I2VuZGlmIC8vIF9fR0lfU0NBTk5FUl9fCi0jZW5kaWYgLy8gR19ERUZJTkVfQVVUT1BUUl9DTEVB TlVQX0ZVTkMKKyNlbmRpZiAvKiBfX0dJX1NDQU5ORVJfXyAqLworI2VuZGlmIC8qIEdfREVGSU5F X0FVVE9QVFJfQ0xFQU5VUF9GVU5DICovCiAKLSNlbmRpZiAvLyBXZWJLaXRBdXRvY2xlYW51cHNf aAorI2VuZGlmIC8qIFdlYktpdEF1dG9jbGVhbnVwc19oICovCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdERlZmluZXMuaCBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS93cGUvV2ViS2l0RGVmaW5lcy5oCmluZGV4IDc3YzM1MjRjNTkyLi42MTM4 ZTQxYTNjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9XZWJL aXREZWZpbmVzLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9XZWJLaXRE ZWZpbmVzLmgKQEAgLTQ1LDQgKzQ1LDQgQEAKICNkZWZpbmUgV0VCS0lUX0RFUFJFQ0FURUQgV0VC S0lUX0FQSSBHX0RFUFJFQ0FURUQKICNkZWZpbmUgV0VCS0lUX0RFUFJFQ0FURURfRk9SKGYpIFdF QktJVF9BUEkgR19ERVBSRUNBVEVEX0ZPUihmKQogCi0jZW5kaWYgLy8gV2ViS2l0RGVmaW5lc19o CisjZW5kaWYgLyogV2ViS2l0RGVmaW5lc19oICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJFZGl0b3IuaCBiL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL1dlYktpdFdlYkVk aXRvci5oCmluZGV4IDBjZmU5ZjAwODJhLi4yMDYwNzE1MWYxMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvV2ViS2l0V2ViRWRpdG9y LmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsv V2ViS2l0V2ViRWRpdG9yLmgKQEAgLTYyLDQgKzYyLDQgQEAgd2Via2l0X3dlYl9lZGl0b3JfZ2V0 X3BhZ2UgKFdlYktpdFdlYkVkaXRvciAqZWRpdG9yKTsKIAogR19FTkRfREVDTFMKIAotI2VuZGlm IC8vIFdlYktpdFdlYkVkaXRvcl9oCisjZW5kaWYgLyogV2ViS2l0V2ViRWRpdG9yX2ggKi8KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3Rr L1dlYktpdFdlYkV4dGVuc2lvbkF1dG9jbGVhbnVwcy5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvV2ViS2l0V2ViRXh0ZW5zaW9uQXV0b2NsZWFudXBz LmgKaW5kZXggMjhjYWYzYTU4YzcuLjg0OWM3ZGI3NjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJFeHRlbnNpb25B dXRvY2xlYW51cHMuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5k bGUvQVBJL2d0ay9XZWJLaXRXZWJFeHRlbnNpb25BdXRvY2xlYW51cHMuaApAQCAtMzUsNyArMzUs NyBAQCBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2ViRXh0ZW5zaW9uLCBn X29iamVjdF91bnJlZikKIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRXZWJI aXRUZXN0UmVzdWx0LCBnX29iamVjdF91bnJlZikKIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9G VU5DIChXZWJLaXRXZWJQYWdlLCBnX29iamVjdF91bnJlZikKIAotI2VuZGlmIC8vIF9fR0lfU0NB Tk5FUl9fCi0jZW5kaWYgLy8gR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMKKyNlbmRpZiAv KiBfX0dJX1NDQU5ORVJfXyAqLworI2VuZGlmIC8qIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9G VU5DICovCiAKLSNlbmRpZiAvLyBXZWJLaXRXZWJFeHRlbnNpb25BdXRvY2xlYW51cHNfaAorI2Vu ZGlmIC8qIFdlYktpdFdlYkV4dGVuc2lvbkF1dG9jbGVhbnVwc19oICovCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL3dwZS9XZWJLaXRXZWJF ZGl0b3IuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvd3Bl L1dlYktpdFdlYkVkaXRvci5oCmluZGV4IDBkNDExYjBlZDRjLi4wNWE0MTQ5OGYxYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS93cGUvV2Vi S2l0V2ViRWRpdG9yLmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0FQSS93cGUvV2ViS2l0V2ViRWRpdG9yLmgKQEAgLTYyLDQgKzYyLDQgQEAgd2Via2l0X3dl Yl9lZGl0b3JfZ2V0X3BhZ2UgKFdlYktpdFdlYkVkaXRvciAqZWRpdG9yKTsKIAogR19FTkRfREVD TFMKIAotI2VuZGlmIC8vIFdlYktpdFdlYkVkaXRvcl9oCisjZW5kaWYgLyogV2ViS2l0V2ViRWRp dG9yX2ggKi8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvd3BlL1dlYktpdFdlYkV4dGVuc2lvbkF1dG9jbGVhbnVwcy5oIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS93cGUvV2ViS2l0V2ViRXh0ZW5zaW9u QXV0b2NsZWFudXBzLmgKaW5kZXggMzU0MDY3NjA2MjUuLjRjNGQ3ODQ0NTk2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL3dwZS9XZWJLaXRX ZWJFeHRlbnNpb25BdXRvY2xlYW51cHMuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv SW5qZWN0ZWRCdW5kbGUvQVBJL3dwZS9XZWJLaXRXZWJFeHRlbnNpb25BdXRvY2xlYW51cHMuaApA QCAtMzUsNyArMzUsNyBAQCBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2Vi RXh0ZW5zaW9uLCBnX29iamVjdF91bnJlZikKIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5D IChXZWJLaXRXZWJIaXRUZXN0UmVzdWx0LCBnX29iamVjdF91bnJlZikKIEdfREVGSU5FX0FVVE9Q VFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRXZWJQYWdlLCBnX29iamVjdF91bnJlZikKIAotI2VuZGlm IC8vIF9fR0lfU0NBTk5FUl9fCi0jZW5kaWYgLy8gR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZV TkMKKyNlbmRpZiAvKiBfX0dJX1NDQU5ORVJfXyAqLworI2VuZGlmIC8qIEdfREVGSU5FX0FVVE9Q VFJfQ0xFQU5VUF9GVU5DICovCiAKLSNlbmRpZiAvLyBXZWJLaXRXZWJFeHRlbnNpb25BdXRvY2xl YW51cHNfaAorI2VuZGlmIC8qIFdlYktpdFdlYkV4dGVuc2lvbkF1dG9jbGVhbnVwc19oICovCg==