203185 2019-10-19 20:45:13 -0700 Closing a MiniBrowser WK2 window does not release the WKWebView 2020-02-01 23:08:29 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser ap commit-queue simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1581761 0 simon.fraser 2019-10-19 20:45:13 -0700 I noticed that video keeps playing after closing its containing MiniBrowser window. We never hit -[WKWebView dealloc]. Need to figure out who's keeping it alive. 1613748 1 simon.fraser 2020-02-01 12:43:10 -0800 This is creating a retain cycle: _textFinder.hideInterfaceCallback = ^{ [_webView _hideFindUI]; }; 1613749 2 389465 simon.fraser 2020-02-01 12:51:56 -0800 Created attachment 389465 Patch 1613750 3 389465 commit-queue 2020-02-01 14:26:39 -0800 Comment on attachment 389465 Patch Clearing flags on attachment: 389465 Committed r255543: <https://trac.webkit.org/changeset/255543> 1613751 4 commit-queue 2020-02-01 14:26:40 -0800 All reviewed patches have been landed. Closing bug. 1613752 5 webkit-bug-importer 2020-02-01 14:27:17 -0800 <rdar://problem/59090239> 1613789 6 thorton 2020-02-01 23:08:29 -0800 There's a warning for that that we should consider turning on! 389465 2020-02-01 12:51:56 -0800 2020-02-01 14:26:39 -0800 Patch bug-203185-20200201125155.patch text/plain 1625 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NjY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODFjZjQxMGFhMjY2ODI3MGNkZWNlOWY0Y2IwOWNlMDI5 MjZjN2FiYS4uZjMyZGUyZWYxMjdlMTkxYWZiZGQ1MDBkZDNkMDNiNDE1ODFkNzNkMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTAyLTAxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIENsb3NpbmcgYSBNaW5pQnJvd3NlciBXSzIgd2luZG93IGRvZXMgbm90IHJlbGVh c2UgdGhlIFdLV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAzMTg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIAorICAgICAgICBVc2UgYSB3ZWFrIFdLV2ViVmlldyByZWZlcmVuY2UgaW4gdGhlIF90 ZXh0RmluZGVyLmhpZGVJbnRlcmZhY2VDYWxsYmFjaygpIGJsb2NrCisgICAgICAgIHRvIGF2b2lk IGEgcmV0YWluIGN5Y2xlIHRoYXQga2VlcHMgdGhlIHdpbmRvdyBjb250cm9sbGVyIGFuZCBXS1dl YlZpZXcgYWxpdmUuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRv d0NvbnRyb2xsZXIubToKKyAgICAgICAgKC1bV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIgYXdh a2VGcm9tTmliXSk6CisKIDIwMjAtMDEtMTUgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBw bGUuY29tPgogCiAgICAgICAgIHJ1bi1hcGktdGVzdHMgbm8gbG9uZ2VyIHN1cHBvcnRzIHdpbGRj YXJkcyBpbiB0ZXN0IG5hbWVzCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9tYWMvV0sy QnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubSBiL1Rvb2xzL01pbmlCcm93c2VyL21hYy9XSzJCcm93 c2VyV2luZG93Q29udHJvbGxlci5tCmluZGV4IDAzMWVkZDUzM2FlMWI3OTFiYzY4NjJjNjMxYjkw OWFlOTlkYWM4ODYuLjkzOWNiYWY2ODg1YzVjMjliMWI0OGJlZWJhYzEyNmJjYTAwMmU3YmYgMTAw NjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL21hYy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxl ci5tCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL21hYy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxl ci5tCkBAIC0xMjUsOCArMTI1LDExIEBAIC0gKHZvaWQpYXdha2VGcm9tTmliCiAgICAgX3RleHRG aW5kZXIuaW5jcmVtZW50YWxTZWFyY2hpbmdTaG91bGREaW1Db250ZW50VmlldyA9IE5POwogICAg IF90ZXh0RmluZGVyLmNsaWVudCA9IF93ZWJWaWV3OwogICAgIF90ZXh0RmluZGVyLmZpbmRCYXJD b250YWluZXIgPSBzZWxmOworICAgIAorICAgIF9fd2VhayBXS1dlYlZpZXcgKndlYWtXZWJWaWV3 ID0gX3dlYlZpZXc7CiAgICAgX3RleHRGaW5kZXIuaGlkZUludGVyZmFjZUNhbGxiYWNrID0gXnsK LSAgICAgICAgW193ZWJWaWV3IF9oaWRlRmluZFVJXTsKKyAgICAgICAgV0tXZWJWaWV3ICp3ZWJW aWV3ID0gd2Vha1dlYlZpZXc7CisgICAgICAgIFt3ZWJWaWV3IF9oaWRlRmluZFVJXTsKICAgICB9 OwogCiAgICAgX3pvb21UZXh0T25seSA9IE5POwo=