20318 2008-08-07 07:34:43 -0700 [Gtk] SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add 2008-08-13 12:43:16 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo webkit-unassigned alp oldest_to_newest 88041 0 jmalonzo 2008-08-07 07:34:43 -0700 In setSharedTimerFireTime: if (intervalInMS == 0) - sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT, timeout_cb, NULL, NULL); + sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT_IDLE, timeout_cb, NULL, NULL); I'm attaching a patch for this. 88042 1 22697 jmalonzo 2008-08-07 07:37:30 -0700 Created attachment 22697 use G_PRIORITY_DEFAULT_IDLE for g_idle_add function 88044 2 alp 2008-08-07 08:49:30 -0700 (In reply to comment #0) > In setSharedTimerFireTime: > > if (intervalInMS == 0) > - sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT, timeout_cb, NULL, > NULL); > + sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT_IDLE, timeout_cb, > NULL, NULL); > > I'm attaching a patch for this. > Did this cause incorrect behaviour or is this patch just a cleanup? How about just using g_idle_add() (docs suggest it does the same thing)? 88142 3 22715 jmalonzo 2008-08-08 17:50:25 -0700 Created attachment 22715 updated to use g_idle_add rather than the _full variant Hi Alp This is just a cleanup. I've updated the patch to use g_idle_add rather than g_idle_add_full. 88332 4 22715 zecke 2008-08-12 13:31:14 -0700 Comment on attachment 22715 updated to use g_idle_add rather than the _full variant Please adjust the changelog when landing. According to the glib documentation g_idle_add is there from the beginning so we can safely use that. 88430 5 jmalonzo 2008-08-13 12:43:16 -0700 landed in r35724 22697 2008-08-07 07:37:30 -0700 2008-08-08 17:50:25 -0700 use G_PRIORITY_DEFAULT_IDLE for g_idle_add function webkitgtk-sharedtimergtk-idleadd.patch text/plain 1160 jmalonzo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTE4MTg1NC4uMzVjZGM5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOC0wOC0wNyAgSmFuIE1pY2hhZWwg QWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDMxOAorICAgICAgICBTaGFyZWRUaW1lckd0ayBzaG91bGQgdXNlIEdfUFJJT1JJVFlf REVGQVVMVF9JRExFIGZvciBnX2lkbGVfYWRkCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2hh cmVkVGltZXJHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2V0U2hhcmVkVGltZXJGaXJlVGlt ZSk6CisKIDIwMDgtMDgtMDcgIEFscCBUb2tlciAgPGFscEBudWFudGkuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvU2hhcmVkVGltZXJHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2hhcmVkVGltZXJH dGsuY3BwCmluZGV4IGE1MzdmZmIuLjEwNzdmNTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1NoYXJlZFRpbWVyR3RrLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TaGFy ZWRUaW1lckd0ay5jcHAKQEAgLTY0LDcgKzY0LDcgQEAgdm9pZCBzZXRTaGFyZWRUaW1lckZpcmVU aW1lKGRvdWJsZSBmaXJlVGltZSkKIAogICAgIHN0b3BTaGFyZWRUaW1lcigpOwogICAgIGlmIChp bnRlcnZhbEluTVMgPT0gMCkKLSAgICAgICAgc2hhcmVkVGltZXIgPSBnX2lkbGVfYWRkX2Z1bGwo R19QUklPUklUWV9ERUZBVUxULCB0aW1lb3V0X2NiLCBOVUxMLCBOVUxMKTsKKyAgICAgICAgc2hh cmVkVGltZXIgPSBnX2lkbGVfYWRkX2Z1bGwoR19QUklPUklUWV9ERUZBVUxUX0lETEUsIHRpbWVv dXRfY2IsIE5VTEwsIE5VTEwpOwogICAgIGVsc2UKICAgICAgICAgc2hhcmVkVGltZXIgPSBnX3Rp bWVvdXRfYWRkX2Z1bGwoR19QUklPUklUWV9ERUZBVUxULCBpbnRlcnZhbEluTVMsIHRpbWVvdXRf Y2IsIE5VTEwsIE5VTEwpOwogfQo= 22715 2008-08-08 17:50:25 -0700 2008-08-12 13:31:14 -0700 updated to use g_idle_add rather than the _full variant webkitgtk-sharedtimergtk-idleadd.patch text/plain 1124 jmalonzo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGI4YWVjMS4uZGIyZmI4MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOC0wOC0wOCAgSmFuIE1pY2hhZWwg QWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDMxOAorICAgICAgICBTaGFyZWRUaW1lckd0ayBzaG91bGQgdXNlIEdfUFJJT1JJVFlf REVGQVVMVF9JRExFIGZvciBnX2lkbGVfYWRkCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2hh cmVkVGltZXJHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2V0U2hhcmVkVGltZXJGaXJlVGlt ZSk6CisKIDIwMDgtMDgtMDggIE1heGltZSBCcml0dG8gIDxicml0dG9AYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkZWxlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvU2hhcmVkVGltZXJHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2hhcmVkVGltZXJH dGsuY3BwCmluZGV4IGE1MzdmZmIuLmUwYTViNjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1NoYXJlZFRpbWVyR3RrLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TaGFy ZWRUaW1lckd0ay5jcHAKQEAgLTY0LDcgKzY0LDcgQEAgdm9pZCBzZXRTaGFyZWRUaW1lckZpcmVU aW1lKGRvdWJsZSBmaXJlVGltZSkKIAogICAgIHN0b3BTaGFyZWRUaW1lcigpOwogICAgIGlmIChp bnRlcnZhbEluTVMgPT0gMCkKLSAgICAgICAgc2hhcmVkVGltZXIgPSBnX2lkbGVfYWRkX2Z1bGwo R19QUklPUklUWV9ERUZBVUxULCB0aW1lb3V0X2NiLCBOVUxMLCBOVUxMKTsKKyAgICAgICAgc2hh cmVkVGltZXIgPSBnX2lkbGVfYWRkKHRpbWVvdXRfY2IsIE5VTEwpOwogICAgIGVsc2UKICAgICAg ICAgc2hhcmVkVGltZXIgPSBnX3RpbWVvdXRfYWRkX2Z1bGwoR19QUklPUklUWV9ERUZBVUxULCBp bnRlcnZhbEluTVMsIHRpbWVvdXRfY2IsIE5VTEwsIE5VTEwpOwogfQo=