203132 2019-10-17 20:29:37 -0700 Pinch to zoom gesture has to be repeated twice if the cursor isn't moved between gestures 2020-03-26 15:39:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari 13 Mac macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 1 tym46383 thorton bfulgham simon.fraser thorton webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1581276 0 tym46383 2019-10-17 20:29:37 -0700 Pinching to zoom in Safari 13 (and 12) results in the gesture not being recognized unless the mouse cursor is moved between gestures. Instead, it has to be performed twice before the browser reacts. This works correctly in the WebKit nightly (i.e. you can zoom without moving the mouse), so I'm wondering if it's related to the "tab overview" gesture, which is not in the nightly. As an example, on any page: 1. Pinch out to zoom the page in. 2. Lift up your fingers but don't move the mouse cursor. 3. Do the same gesture again and observe that it doesn't work. The scrollbars appear but the page contents don't zoom. 4. Lift your fingers and do the gesture again. It will work this time. This also applies to zooming out. It doesn't work in Safari Technology Preview 94 either. 1581712 1 ap 2019-10-19 12:12:14 -0700 I can reproduce with Safari 12.1.2 on macOS 10.14.6. 1581713 2 webkit-bug-importer 2019-10-19 12:12:25 -0700 <rdar://problem/56436797> 1631632 3 tym46383 2020-03-19 06:56:15 -0700 This still occurs on macOS 10.15.4 and Safari Technology Preview 102. It doesn’t happen on an iPad using iPadOS 13.4 beta 6 using the same trackpad. 1631723 4 simon.fraser 2020-03-19 10:27:21 -0700 I can reproduce. 1632143 5 tym46383 2020-03-20 10:03:47 -0700 I just tried it with the newest WebKit nightly (r258747) and it still works correctly there. Also I've forgotten to mention that I've only tested it on an external trackpad so I don't know if it's specific to them or if it extends to MacBooks too. 1632177 6 thorton 2020-03-20 11:21:27 -0700 (In reply to tym46383 from comment #5) > I just tried it with the newest WebKit nightly (r258747) and it still works > correctly there. This is ... for a silly reason. It's not actually fixed. > Also I've forgotten to mention that I've only tested it on an external > trackpad so I don't know if it's specific to them or if it extends to > MacBooks too. It applies to MacBooks too. This is actually tracked in <rdar://problem/27439348>. 1632408 7 tym46383 2020-03-20 17:58:29 -0700 (In reply to Tim Horton from comment #6) > This is ... for a silly reason. It's not actually fixed. Ah, so it works coincidentally. I wonder what's broken in the Nightly that makes the zooming work. Thanks for the Radar Problem ID! 1634591 8 394661 thorton 2020-03-26 15:05:14 -0700 Created attachment 394661 Patch 1634605 9 thorton 2020-03-26 15:39:06 -0700 https://trac.webkit.org/changeset/259085/webkit 394661 2020-03-26 15:05:14 -0700 2020-03-26 15:18:47 -0700 Patch bug-203132-20200326150513.patch text/plain 6719 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjY1MWRkZTQ0MTQ1M2Y5 Mjc4YjY5ZjAxYmYxZTg0ZTJlMTc0NGNhMi4uNDRkYTdhNTkxOTQyNzNiOGVkODY2OTY5Y2YzY2M4 ZDc5MWY3NmRmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTI2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFBpbmNoIHRvIHpv b20gZ2VzdHVyZSBoYXMgdG8gYmUgcmVwZWF0ZWQgdHdpY2UgaWYgdGhlIGN1cnNvciBpc24ndCBt b3ZlZCBiZXR3ZWVuIGdlc3R1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDMxMzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3NDM5MzQ4Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9F dmVudEhhbmRsZXIuaDoKKwogMjAyMC0wMy0yNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIFsgTWFjIHdrMV0gQVNTRVJUSU9OIEZBSUxFRDogbV93cmFwcGVyIHVu ZGVyIFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0VXBsb2FkOjpkaXNwYXRjaFByb2dyZXNzRXZlbnQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTgxMmQxNzRlZWMyYTc5OTkyMjkxYWEzNTRjNzI1MWY3NjA4MjQ5NC4uM2E1 OGU4YTc5NjU1ODRkZjE1ZjU3ODc5MjYyNzY4MWUzNTdjMTNhNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyMiBAQAorMjAyMC0wMy0yNiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KKworICAgICAgICBQaW5jaCB0byB6b29tIGdlc3R1cmUgaGFzIHRvIGJlIHJlcGVhdGVkIHR3 aWNlIGlmIHRoZSBjdXJzb3IgaXNuJ3QgbW92ZWQgYmV0d2VlbiBnZXN0dXJlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMTMyCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8yNzQzOTM0OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAq IFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVBy b3h5Lm1lc3NhZ2VzLmluOgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250 cm9sbGVyTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OmVu ZE1hZ25pZmljYXRpb25HZXN0dXJlKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmlu OgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbToKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZTo6ZGlkRW5kTWFnbmlmaWNhdGlvbkdlc3R1cmUpOgorICAgICAg ICBQbHVtYiB0aGUgZW5kIG9mIGEgcGluY2gtem9vbSBnZXN0dXJlIHRvIEV2ZW50SGFuZGxlci4K KwogMjAyMC0wMy0yNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViUGFnZTo6c2VsZWN0UG9zaXRpb25BdFBvaW50KCkgZG9lcyBub3QgZm9jdXMgYW4gZWxl bWVudCBpbiBhIG5vbi1mb2N1c2VkIGZyYW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaApp bmRleCBiMTlmMTNmMjI5MzU1ZGM1OTU3ZDMyYzJkMGViZjlhMzk5MDc1OWQ3Li44Y2JhZWFkNGM3 MmRjOWZiNTA5ZDA0YmM0YjNjODQ0ZWZiZmY4YTc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5k bGVyLmgKQEAgLTIzOCw2ICsyMzgsNyBAQCBwdWJsaWM6CiAjZWxpZiBFTkFCTEUoTUFDX0dFU1RV UkVfRVZFTlRTKQogICAgIGJvb2wgZGlzcGF0Y2hHZXN0dXJlRXZlbnQoY29uc3QgUGxhdGZvcm1H ZXN0dXJlRXZlbnQmLCBjb25zdCBBdG9tU3RyaW5nJiwgY29uc3QgRXZlbnRUYXJnZXRTZXQmLCBm bG9hdCwgZmxvYXQpOwogICAgIFdFQkNPUkVfRVhQT1JUIGJvb2wgaGFuZGxlR2VzdHVyZUV2ZW50 KGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50Jik7CisgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBk aWRFbmRNYWduaWZpY2F0aW9uR2VzdHVyZSgpOwogI2VuZGlmCiAKICNpZiBQTEFURk9STShJT1Nf RkFNSUxZKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYmJh ODRiMGFlM2FhYWM3YWRkMjY3MzQ1OTI5Y2MyZmViMjg0MmNmOS4uYTFjMjZlZDBiMDJiOGZlYTQ0 ZGUwZWE1YmU1Y2IyYzQwYjBlOTQ0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdl UHJveHkuY3BwCkBAIC04OTU1LDYgKzg5NTUsMTEgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnNldEZv b3RlckJhbm5lckhlaWdodEZvclRlc3RpbmcoaW50IGhlaWdodCkKICAgICBzZW5kKE1lc3NhZ2Vz OjpXZWJQYWdlOjpTZXRGb290ZXJCYW5uZXJIZWlnaHRGb3JUZXN0aW5nKGhlaWdodCkpOwogfQog Cit2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkRW5kTWFnbmlmaWNhdGlvbkdlc3R1cmUoKQoreworICAg IHNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OkRpZEVuZE1hZ25pZmljYXRpb25HZXN0dXJlKCkpOwor fQorCiAjZW5kaWYKIAogdm9pZCBXZWJQYWdlUHJveHk6Omluc3RhbGxBY3Rpdml0eVN0YXRlQ2hh bmdlQ29tcGxldGlvbkhhbmRsZXIoRnVuY3Rpb248dm9pZCgpPiYmIGNvbXBsZXRpb25IYW5kbGVy KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmggYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAppbmRleCA1N2FjNTQ0ZGY4OTc1 NDRjOTM2ZjdmODllMjRjY2RkMjgyZDY1OTBkLi4wYTE4NzM1OTM2YTAyYzI1NDY3MmMyMjYwY2Q1 MjhiN2U1ZmIyYjU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdl UHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaApAQCAt MTQ0MCw2ICsxNDQwLDggQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRIZWFkZXJCYW5uZXJIZWln aHRGb3JUZXN0aW5nKGludCk7CiAgICAgdm9pZCBzZXRGb290ZXJCYW5uZXJIZWlnaHRGb3JUZXN0 aW5nKGludCk7CisKKyAgICB2b2lkIGRpZEVuZE1hZ25pZmljYXRpb25HZXN0dXJlKCk7CiAjZW5k aWYKIAogICAgIGJvb2wgc2Nyb2xsaW5nVXBkYXRlc0Rpc2FibGVkRm9yVGVzdGluZygpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxl ck1hYy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xs ZXJNYWMubW0KaW5kZXggMjEwNTQ4Y2MwN2FlZWZiNTJiY2RlZjMwMDQ2ODc3M2MwNWMyMjMyNS4u ZjU1OWEyMWM5ZDQ3YmViZGQ2MmFkZDc0Mzk2ODZhNTMzZTY2NjFhZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyTWFjLm1t CkBAIC0xODcsNiArMTg3LDggQEAgdm9pZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OmVuZE1hZ25p ZmljYXRpb25HZXN0dXJlKCkKICAgICAgICAgICAgIGRyYXdpbmdBcmVhLT5jb21taXRUcmFuc2ll bnRab29tKG5ld01hZ25pZmljYXRpb24sIHNjYWxlZE1hZ25pZmljYXRpb25PcmlnaW4obV9tYWdu aWZpY2F0aW9uT3JpZ2luLCBuZXdNYWduaWZpY2F0aW9uKSk7CiAgICAgfQogCisgICAgbV93ZWJQ YWdlUHJveHkuZGlkRW5kTWFnbmlmaWNhdGlvbkdlc3R1cmUoKTsKKwogICAgIGRpZEVuZEdlc3R1 cmUoKTsKICAgICBtX3Zpc2libGVDb250ZW50UmVjdElzVmFsaWQgPSBmYWxzZTsKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaCBiL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAppbmRleCAxZDE2Yzg0MzlkMmRi NjEzNDE4ZjE4NTZmZTkxNDA0MjgzOTI0NTE0Li40MjYyNzAzN2E3ZTlmYmNlYzk0NmY3ZDM0M2Fk Y2I3MzIzMDM2ZTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5oCkBAIC01NzgsNiArNTc4LDggQEAgcHVibGljOgogICAgIHZvaWQgc2V0Qm90dG9tT3Zlcmhh bmdJbWFnZShXZWJJbWFnZSopOwogICAgIAogICAgIHZvaWQgc2V0VXNlU3lzdGVtQXBwZWFyYW5j ZShib29sKTsKKworICAgIHZvaWQgZGlkRW5kTWFnbmlmaWNhdGlvbkdlc3R1cmUoKTsKICNlbmRp ZgogCiAgICAgdm9pZCBlZmZlY3RpdmVBcHBlYXJhbmNlRGlkQ2hhbmdlKGJvb2wgdXNlRGFya0Fw cGVhcmFuY2UsIGJvb2wgdXNlRWxldmF0ZWRVc2VySW50ZXJmYWNlTGV2ZWwpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbiBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4KaW5k ZXggNzYyMDJlNTM2YWFiYjNmYjA2ZTE0OGEzZjVjNjU2Y2M2NzM2MDAzOC4uMGY4ODQ2ZDIzNTYz NWJlNjBkNjVkMzEzMDE1MmZiYmY2MDk3MjBiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbgorKysgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCkBAIC00OTMsMTMgKzQ5Mywx NSBAQCBHZW5lcmF0ZVN5bnRoZXRpY0VkaXRpbmdDb21tYW5kKGVudW06dWludDhfdCBXZWJLaXQ6 OlN5bnRoZXRpY0VkaXRpbmdDb21tYW5kVHlwZQogCiAgICAgSGFuZGxlQWNjZXB0ZWRDYW5kaWRh dGUoc3RydWN0IFdlYkNvcmU6OlRleHRDaGVja2luZ1Jlc3VsdCBhY2NlcHRlZENhbmRpZGF0ZSkK IAotICAgIFNldFVzZVN5c3RlbUFwcGVhcmFuY2UoYm9vbCB1c2VTeXN0ZW1BcHBlYXJhbmNlKTsK KyAgICBTZXRVc2VTeXN0ZW1BcHBlYXJhbmNlKGJvb2wgdXNlU3lzdGVtQXBwZWFyYW5jZSkKIAot ICAgIFNldEhlYWRlckJhbm5lckhlaWdodEZvclRlc3RpbmcoaW50IGhlaWdodCk7Ci0gICAgU2V0 Rm9vdGVyQmFubmVySGVpZ2h0Rm9yVGVzdGluZyhpbnQgaGVpZ2h0KTsKKyAgICBTZXRIZWFkZXJC YW5uZXJIZWlnaHRGb3JUZXN0aW5nKGludCBoZWlnaHQpCisgICAgU2V0Rm9vdGVyQmFubmVySGVp Z2h0Rm9yVGVzdGluZyhpbnQgaGVpZ2h0KQorCisgICAgRGlkRW5kTWFnbmlmaWNhdGlvbkdlc3R1 cmUoKQogI2VuZGlmCiAKLSAgICBFZmZlY3RpdmVBcHBlYXJhbmNlRGlkQ2hhbmdlKGJvb2wgdXNl RGFya0FwcGVhcmFuY2UsIGJvb2wgdXNlRWxldmF0ZWRVc2VySW50ZXJmYWNlTGV2ZWwpOworICAg IEVmZmVjdGl2ZUFwcGVhcmFuY2VEaWRDaGFuZ2UoYm9vbCB1c2VEYXJrQXBwZWFyYW5jZSwgYm9v bCB1c2VFbGV2YXRlZFVzZXJJbnRlcmZhY2VMZXZlbCkKIAogI2lmIFBMQVRGT1JNKEdUSykKICAg ICBUaGVtZURpZENoYW5nZShTdHJpbmcgdGhlbWVOYW1lKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0gYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQppbmRleCA0MGYwNTIwZjBmNzc2 N2VkZTY2ODMzZGY5ZDU1YzA3NWUwZThhMTEyLi45NjI4MWFiODRmMWFhOGM3NWUzNmY0ZWJkMTc3 NzM0NzQxNjVjMjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvV2ViUGFnZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvV2ViUGFnZU1hYy5tbQpAQCAtMTA0Niw2ICsxMDQ2LDEzIEBAIHZvaWQgV2ViUGFnZTo6 cGxheWJhY2tUYXJnZXRQaWNrZXJXYXNEaXNtaXNzZWQodWludDY0X3QgY29udGV4dElkKQogfQog I2VuZGlmCiAKK3ZvaWQgV2ViUGFnZTo6ZGlkRW5kTWFnbmlmaWNhdGlvbkdlc3R1cmUoKQorewor I2lmIEVOQUJMRShNQUNfR0VTVFVSRV9FVkVOVFMpCisgICAgbV9wYWdlLT5tYWluRnJhbWUoKS5l dmVudEhhbmRsZXIoKS5kaWRFbmRNYWduaWZpY2F0aW9uR2VzdHVyZSgpOworI2VuZGlmCit9CisK IH0gLy8gbmFtZXNwYWNlIFdlYktpdAogCiAjZW5kaWYgLy8gUExBVEZPUk0oTUFDKQo=