20313 2008-08-06 21:48:03 -0700 Add null check in String::fromUTF8() 2008-08-07 05:10:28 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 17432 1 alp webkit-unassigned oldest_to_newest 88018 0 alp 2008-08-06 21:48:03 -0700 String::fromUTF8() crashes when passed a null pointer. This behaviour is inconsistent with the other constructors, which return a null String() in this case: String::String(const char* str) { if (!str) return; m_impl = StringImpl::create(str); } String::String(const char* str, unsigned length) { if (!str) return; m_impl = StringImpl::create(str, length); } Fix attached. This allows us to simplify (or avoid) null checking logic wherever String::fromUTF8() is used. 88019 1 22692 alp 2008-08-06 21:51:25 -0700 Created attachment 22692 Add null checks 88023 2 22692 eric 2008-08-06 22:43:12 -0700 Comment on attachment 22692 Add null checks Looks fine. 88032 3 jmalonzo 2008-08-07 05:10:28 -0700 landed in r35623 22692 2008-08-06 21:51:25 -0700 2008-08-06 22:43:12 -0700 Add null checks string.patch text/plain 1298 alp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTYyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMDgtMDYgIEFscCBUb2tlciAgPGFscEBudWFudGkuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMxMworICAgICAgICBBZGQgbnVsbCBj aGVjayBpbiBTdHJpbmc6OmZyb21VVEY4KCkKKworICAgICAgICBNYWtlIFN0cmluZzo6ZnJvbVVU RjgoKSBjb25zaXN0ZW50IHdpdGggb3RoZXIgY29uc3RydWN0b3JzIGJ5CisgICAgICAgIHJldHVy bmluZyBhIG51bGwgU3RyaW5nIHdoZW4gdGhlIGlucHV0IGlzIG51bGwgaW5zdGVhZCBvZiBjcmFz aGluZy4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvU3RyaW5nLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlN0cmluZzo6ZnJvbVVURjgpOgorCiAyMDA4LTA4LTA2ICBLZXZpbiBPbGxpdmllciAg PGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIHd4IGJ1aWxkIGZpeCBhZnRlciBG cmFtZSAtPiBTY3JpcHRDb250cm9sbGVyIG1vdmVzLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS90 ZXh0L1N0cmluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmlu Zy5jcHAJKHJldmlzaW9uIDM1NjIwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmluZy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTU4MiwxMSArNTgyLDE1IEBAIENTdHJpbmcgU3RyaW5nOjp1 dGY4KCkgY29uc3QKIAogU3RyaW5nIFN0cmluZzo6ZnJvbVVURjgoY29uc3QgY2hhciogc3RyaW5n LCBzaXplX3Qgc2l6ZSkKIHsKKyAgICBpZiAoIXN0cmluZykKKyAgICAgICAgcmV0dXJuIFN0cmlu ZygpOwogICAgIHJldHVybiBVVEY4RW5jb2RpbmcoKS5kZWNvZGUoc3RyaW5nLCBzaXplKTsKIH0K IAogU3RyaW5nIFN0cmluZzo6ZnJvbVVURjgoY29uc3QgY2hhciogc3RyaW5nKQogeworICAgIGlm ICghc3RyaW5nKQorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAgICAgcmV0dXJuIFVURjhFbmNv ZGluZygpLmRlY29kZShzdHJpbmcsIHN0cmxlbihzdHJpbmcpKTsKIH0KIAo=