203124 2019-10-17 15:33:44 -0700 GetByVal and PutByVal on ArrayStorage need to use the same AbstractHeap 2019-10-17 17:42:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1581187 0 saam 2019-10-17 15:33:44 -0700 ... 1581188 1 saam 2019-10-17 15:34:35 -0700 <rdar://problem/55988183> 1581189 2 381237 saam 2019-10-17 15:37:21 -0700 Created attachment 381237 patch 1581192 3 381239 saam 2019-10-17 15:41:54 -0700 Created attachment 381239 patch 1581195 4 381239 ysuzuki 2019-10-17 15:43:49 -0700 Comment on attachment 381239 patch r=me 1581242 5 381239 commit-queue 2019-10-17 17:42:32 -0700 Comment on attachment 381239 patch Clearing flags on attachment: 381239 Committed r251271: <https://trac.webkit.org/changeset/251271> 1581243 6 commit-queue 2019-10-17 17:42:34 -0700 All reviewed patches have been landed. Closing bug. 381237 2019-10-17 15:37:21 -0700 2019-10-17 15:41:54 -0700 patch c-backup.diff text/plain 3823 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTEyNjMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTEwLTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIEdldEJ5VmFsIGFuZCBQdXRCeVZhbCBvbiBBcnJheVN0b3JhZ2UgbmVl ZCB0byB1c2UgdGhlIHNhbWUgQWJzdHJhY3RIZWFwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMxMjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1 OTg4MTgzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogc3RyZXNzL2xpY20tYXJyYXktc3RvcmFnZS1nZXQtYW5kLXB1dC1ieS12YWwuanM6IEFkZGVk LgorICAgICAgICAoYXNzZXJ0KToKKyAgICAgICAgKGZvbyk6CisKIDIwMTktMTAtMTYgIEtlaXRo IE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBhc3NlcnQg aW4gV2FzbTo6UGxhbjo6ZmFpbC4KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2xpY20tYXJyYXktc3Rv cmFnZS1nZXQtYW5kLXB1dC1ieS12YWwuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3Mv bGljbS1hcnJheS1zdG9yYWdlLWdldC1hbmQtcHV0LWJ5LXZhbC5qcwkobm9uZXhpc3RlbnQpCisr KyBKU1Rlc3RzL3N0cmVzcy9saWNtLWFycmF5LXN0b3JhZ2UtZ2V0LWFuZC1wdXQtYnktdmFsLmpz CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjUgQEAKK2Z1bmN0aW9uIGFzc2VydChiKSB7Cisg ICAgaWYgKCFiKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3I7Cit9CitmdW5jdGlvbsKgZm9vKGEp IHsKK8KgwqDCoMKgYVsxXcKgPcKgMTsKK8KgwqDCoMKgbGV0wqBiwqA9wqAwOworwqDCoMKgwqBm b3IgKGxldMKgasKgPcKgMDvCoGrCoDzCoDEwO8KgaisrKSB7CivCoMKgwqDCoMKgwqDCoMKgYVsx XcKgPcKgMjsKK8KgwqDCoMKgwqDCoMKgwqBiwqA9wqBhWzFdOworwqDCoMKgwqB9CivCoMKgwqDC oHJldHVybsKgYjsKK30KK25vSW5saW5lKGZvbyk7CisKK2xldMKgYXJywqA9wqBuZXfCoEFycmF5 KDUpOworZm9yIChsZXTCoGnCoD3CoDA7wqBpwqA8wqAweDEwMDA7wqBpKyspwqB7CivCoMKgwqDC oGFycltpXcKgPcKgaTsKK30KK2FyclsxMDAwMDBdwqA9wqAxOworCitmb3IgKGxldMKgacKgPcKg MDvCoGnCoDzCoDMwMDAxO8KgaSsrKXsKK8KgwqDCoMKgYXJyWzFdwqA9wqAxOworICAgIGFzc2Vy dChmb28oYXJyKSA9PT0gMik7Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlz aW9uIDI1MTI2MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0xMC0xNyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRp QGFwcGxlLmNvbT4KKworICAgICAgICBHZXRCeVZhbCBhbmQgUHV0QnlWYWwgb24gQXJyYXlTdG9y YWdlIG5lZWQgdG8gdXNlIHRoZSBzYW1lIEFic3RyYWN0SGVhcAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMTI0CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81NTk4ODE4Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdEhlYXAuaDoKKyAgICAgICAgKiBkZmcvREZHQ2xvYmJl cml6ZS5oOgorICAgICAgICAoSlNDOjpERkc6OmNsb2JiZXJpemUpOgorCiAyMDE5LTEwLTE3ICBC cmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCBm b3IgbmV3ZXIgdmVyc2lvbnMgb2YgTVNWQy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQWJzdHJhY3RIZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdBYnN0cmFjdEhlYXAuaAkocmV2aXNpb24gMjUxMjYxKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdEhlYXAuaAkod29ya2luZyBjb3B5KQpAQCAtNjUsNyAr NjUsNiBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAgICAgbWFjcm8oSW5kZXhl ZERvdWJsZVByb3BlcnRpZXMpIFwKICAgICBtYWNybyhJbmRleGVkQ29udGlndW91c1Byb3BlcnRp ZXMpIFwKICAgICBtYWNybyhJbmRleGVkQXJyYXlTdG9yYWdlUHJvcGVydGllcykgXAotICAgIG1h Y3JvKEFycmF5U3RvcmFnZVByb3BlcnRpZXMpIFwKICAgICBtYWNybyhEaXJlY3RBcmd1bWVudHNQ cm9wZXJ0aWVzKSBcCiAgICAgbWFjcm8oU2NvcGVQcm9wZXJ0aWVzKSBcCiAgICAgbWFjcm8oVHlw ZWRBcnJheVByb3BlcnRpZXMpIFwKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Q2xvYmJlcml6ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Q2xvYmJlcml6ZS5oCShyZXZpc2lvbiAyNTEyNjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0Nsb2JiZXJpemUuaAkod29ya2luZyBjb3B5KQpAQCAtMTAyMyw4ICsxMDIzLDggQEAg dm9pZCBjbG9iYmVyaXplKEdyYXBoJiBncmFwaCwgTm9kZSogbm9kZQogICAgICAgICAgICAgfQog ICAgICAgICAgICAgcmVhZChCdXR0ZXJmbHlfcHVibGljTGVuZ3RoKTsKICAgICAgICAgICAgIHJl YWQoQnV0dGVyZmx5X3ZlY3Rvckxlbmd0aCk7Ci0gICAgICAgICAgICByZWFkKEFycmF5U3RvcmFn ZVByb3BlcnRpZXMpOwotICAgICAgICAgICAgd3JpdGUoQXJyYXlTdG9yYWdlUHJvcGVydGllcyk7 CisgICAgICAgICAgICByZWFkKEluZGV4ZWRBcnJheVN0b3JhZ2VQcm9wZXJ0aWVzKTsKKyAgICAg ICAgICAgIHdyaXRlKEluZGV4ZWRBcnJheVN0b3JhZ2VQcm9wZXJ0aWVzKTsKICAgICAgICAgICAg IGlmIChub2RlLT5hcnJheU1vZGUoKS5tYXlTdG9yZVRvSG9sZSgpKQogICAgICAgICAgICAgICAg IHdyaXRlKEJ1dHRlcmZseV9wdWJsaWNMZW5ndGgpOwogICAgICAgICAgICAgcmV0dXJuOwpAQCAt MTAzNyw4ICsxMDM3LDggQEAgdm9pZCBjbG9iYmVyaXplKEdyYXBoJiBncmFwaCwgTm9kZSogbm9k ZQogICAgICAgICAgICAgfQogICAgICAgICAgICAgcmVhZChCdXR0ZXJmbHlfcHVibGljTGVuZ3Ro KTsKICAgICAgICAgICAgIHJlYWQoQnV0dGVyZmx5X3ZlY3Rvckxlbmd0aCk7Ci0gICAgICAgICAg ICByZWFkKEFycmF5U3RvcmFnZVByb3BlcnRpZXMpOwotICAgICAgICAgICAgd3JpdGUoQXJyYXlT dG9yYWdlUHJvcGVydGllcyk7CisgICAgICAgICAgICByZWFkKEluZGV4ZWRBcnJheVN0b3JhZ2VQ cm9wZXJ0aWVzKTsKKyAgICAgICAgICAgIHdyaXRlKEluZGV4ZWRBcnJheVN0b3JhZ2VQcm9wZXJ0 aWVzKTsKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBjYXNlIEFycmF5OjpJbnQ4QXJy YXk6Cg== 381239 2019-10-17 15:41:54 -0700 2019-10-17 17:42:32 -0700 patch c-backup.diff text/plain 3736 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTEyNjMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTEwLTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIEdldEJ5VmFsIGFuZCBQdXRCeVZhbCBvbiBBcnJheVN0b3JhZ2UgbmVl ZCB0byB1c2UgdGhlIHNhbWUgQWJzdHJhY3RIZWFwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMxMjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU1 OTg4MTgzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogc3RyZXNzL2xpY20tYXJyYXktc3RvcmFnZS1nZXQtYW5kLXB1dC1ieS12YWwuanM6IEFkZGVk LgorICAgICAgICAoYXNzZXJ0KToKKyAgICAgICAgKGZvbyk6CisKIDIwMTktMTAtMTYgIEtlaXRo IE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBhc3NlcnQg aW4gV2FzbTo6UGxhbjo6ZmFpbC4KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2xpY20tYXJyYXktc3Rv cmFnZS1nZXQtYW5kLXB1dC1ieS12YWwuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3Mv bGljbS1hcnJheS1zdG9yYWdlLWdldC1hbmQtcHV0LWJ5LXZhbC5qcwkobm9uZXhpc3RlbnQpCisr KyBKU1Rlc3RzL3N0cmVzcy9saWNtLWFycmF5LXN0b3JhZ2UtZ2V0LWFuZC1wdXQtYnktdmFsLmpz CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjUgQEAKK2Z1bmN0aW9uIGFzc2VydChiKSB7Cisg ICAgaWYgKCFiKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3I7Cit9CitmdW5jdGlvbiBmb28oYSkg eworICAgIGFbMV0gPSAxOworICAgIGxldCBiID0gMDsKKyAgICBmb3IgKGxldCBqID0gMDsgaiA8 IDEwOyBqKyspIHsKKyAgICAgICAgYVsxXSA9IDI7CisgICAgICAgIGIgPSBhWzFdOworICAgIH0K KyAgICByZXR1cm4gYjsKK30KK25vSW5saW5lKGZvbyk7CisKK2xldCBhcnIgPSBuZXcgQXJyYXko NSk7Citmb3IgKGxldCBpID0gMDsgaSA8IDB4MTAwMDsgaSsrKSB7CisgICAgYXJyW2ldID0gaTsK K30KK2FyclsxMDAwMDBdID0gMTsKKworZm9yIChsZXQgaSA9IDA7IGkgPCAyMDAwMDsgaSsrKXsK KyAgICBhcnJbMV0gPSAxOworICAgIGFzc2VydChmb28oYXJyKSA9PT0gMik7Cit9CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MTI2MSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0x MC0xNyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBHZXRCeVZh bCBhbmQgUHV0QnlWYWwgb24gQXJyYXlTdG9yYWdlIG5lZWQgdG8gdXNlIHRoZSBzYW1lIEFic3Ry YWN0SGVhcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAzMTI0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTk4ODE4Mz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdEhlYXAu aDoKKyAgICAgICAgKiBkZmcvREZHQ2xvYmJlcml6ZS5oOgorICAgICAgICAoSlNDOjpERkc6OmNs b2JiZXJpemUpOgorCiAyMDE5LTEwLTE3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCBmb3IgbmV3ZXIgdmVyc2lvbnMgb2YgTVNWQy4KSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RIZWFwLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdEhlYXAuaAkocmV2aXNp b24gMjUxMjYxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdEhlYXAu aAkod29ya2luZyBjb3B5KQpAQCAtNjUsNyArNjUsNiBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNw YWNlIERGRyB7CiAgICAgbWFjcm8oSW5kZXhlZERvdWJsZVByb3BlcnRpZXMpIFwKICAgICBtYWNy byhJbmRleGVkQ29udGlndW91c1Byb3BlcnRpZXMpIFwKICAgICBtYWNybyhJbmRleGVkQXJyYXlT dG9yYWdlUHJvcGVydGllcykgXAotICAgIG1hY3JvKEFycmF5U3RvcmFnZVByb3BlcnRpZXMpIFwK ICAgICBtYWNybyhEaXJlY3RBcmd1bWVudHNQcm9wZXJ0aWVzKSBcCiAgICAgbWFjcm8oU2NvcGVQ cm9wZXJ0aWVzKSBcCiAgICAgbWFjcm8oVHlwZWRBcnJheVByb3BlcnRpZXMpIFwKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ2xvYmJlcml6ZS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ2xvYmJlcml6ZS5oCShyZXZpc2lvbiAyNTEyNjEp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAkod29ya2luZyBj b3B5KQpAQCAtMTAyMyw4ICsxMDIzLDggQEAgdm9pZCBjbG9iYmVyaXplKEdyYXBoJiBncmFwaCwg Tm9kZSogbm9kZQogICAgICAgICAgICAgfQogICAgICAgICAgICAgcmVhZChCdXR0ZXJmbHlfcHVi bGljTGVuZ3RoKTsKICAgICAgICAgICAgIHJlYWQoQnV0dGVyZmx5X3ZlY3Rvckxlbmd0aCk7Ci0g ICAgICAgICAgICByZWFkKEFycmF5U3RvcmFnZVByb3BlcnRpZXMpOwotICAgICAgICAgICAgd3Jp dGUoQXJyYXlTdG9yYWdlUHJvcGVydGllcyk7CisgICAgICAgICAgICByZWFkKEluZGV4ZWRBcnJh eVN0b3JhZ2VQcm9wZXJ0aWVzKTsKKyAgICAgICAgICAgIHdyaXRlKEluZGV4ZWRBcnJheVN0b3Jh Z2VQcm9wZXJ0aWVzKTsKICAgICAgICAgICAgIGlmIChub2RlLT5hcnJheU1vZGUoKS5tYXlTdG9y ZVRvSG9sZSgpKQogICAgICAgICAgICAgICAgIHdyaXRlKEJ1dHRlcmZseV9wdWJsaWNMZW5ndGgp OwogICAgICAgICAgICAgcmV0dXJuOwpAQCAtMTAzNyw4ICsxMDM3LDggQEAgdm9pZCBjbG9iYmVy aXplKEdyYXBoJiBncmFwaCwgTm9kZSogbm9kZQogICAgICAgICAgICAgfQogICAgICAgICAgICAg cmVhZChCdXR0ZXJmbHlfcHVibGljTGVuZ3RoKTsKICAgICAgICAgICAgIHJlYWQoQnV0dGVyZmx5 X3ZlY3Rvckxlbmd0aCk7Ci0gICAgICAgICAgICByZWFkKEFycmF5U3RvcmFnZVByb3BlcnRpZXMp OwotICAgICAgICAgICAgd3JpdGUoQXJyYXlTdG9yYWdlUHJvcGVydGllcyk7CisgICAgICAgICAg ICByZWFkKEluZGV4ZWRBcnJheVN0b3JhZ2VQcm9wZXJ0aWVzKTsKKyAgICAgICAgICAgIHdyaXRl KEluZGV4ZWRBcnJheVN0b3JhZ2VQcm9wZXJ0aWVzKTsKICAgICAgICAgICAgIHJldHVybjsKIAog ICAgICAgICBjYXNlIEFycmF5OjpJbnQ4QXJyYXk6Cg==