<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>203121</bug_id>
          
          <creation_ts>2019-10-17 14:44:39 -0700</creation_ts>
          <short_desc>[bmalloc] Bug fix for wait time when it&apos;s in mini mode.</short_desc>
          <delta_ts>2019-11-07 17:29:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>bmalloc</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Basuke Suzuki">basuke</reporter>
          <assigned_to name="Basuke Suzuki">basuke</assigned_to>
          <cc>basuke</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1581164</commentid>
    <comment_count>0</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2019-10-17 14:44:39 -0700</bug_when>
    <thetext>m_waitTime is never changed on mini mode since https://trac.webkit.org/changeset/243144/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1581168</commentid>
    <comment_count>1</comment_count>
      <attachid>381232</attachid>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2019-10-17 14:57:26 -0700</bug_when>
    <thetext>Created attachment 381232
PATCH</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1581169</commentid>
    <comment_count>2</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2019-10-17 14:57:51 -0700</bug_when>
    <thetext>Simple bug fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1581171</commentid>
    <comment_count>3</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2019-10-17 15:01:37 -0700</bug_when>
    <thetext>Oh, there&apos;s no watchOS EWS...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1581210</commentid>
    <comment_count>4</comment_count>
      <attachid>381232</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-10-17 16:05:45 -0700</bug_when>
    <thetext>Comment on attachment 381232
PATCH

r=me. Yes, this is apparently not intended behavior.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1581212</commentid>
    <comment_count>5</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2019-10-17 16:20:42 -0700</bug_when>
    <thetext>Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1581230</commentid>
    <comment_count>6</comment_count>
      <attachid>381232</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-17 17:02:17 -0700</bug_when>
    <thetext>Comment on attachment 381232
PATCH

Clearing flags on attachment: 381232

Committed r251268: &lt;https://trac.webkit.org/changeset/251268&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1581231</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-17 17:02:18 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1581232</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-10-17 17:03:36 -0700</bug_when>
    <thetext>&lt;rdar://problem/56391220&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1587919</commentid>
    <comment_count>9</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-11-06 14:32:58 -0800</bug_when>
    <thetext>Internally, we found that this behavior is making RAMification 1% regressed.
And this is because,

1. Due to this accidental behavior, we are always using 10ms for the time interval.
2. And this works well for mini-mode.

For now, I&apos;ll roll-out this change and keep mini-mode scavenging period 10ms. And another thing I would like to see is that the memory number w/ system malloc.
Our bmalloc is focusing on performance, while system malloc does good thing for memory footprint in sacrifice of throughput. The purpose of Mini mode is making memory footprint small w/ small throughput loss, and this policy matches well to the system malloc. It would be possible that we could get some good memory footprint further by switching to system malloc by specifying Malloc=1 environment option.

So, for now, I&apos;ll roll out this patch, (or, just removing adjusting part for mini-mode too).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1587964</commentid>
    <comment_count>10</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-11-06 15:58:10 -0800</bug_when>
    <thetext>Committed r252157: &lt;https://trac.webkit.org/changeset/252157&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588028</commentid>
    <comment_count>11</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-11-06 17:48:07 -0800</bug_when>
    <thetext>(In reply to Yusuke Suzuki from comment #10)
&gt; Committed r252157: &lt;https://trac.webkit.org/changeset/252157&gt;

why roll out this code? At least we should make the code sensible instead of updating a local variable which is never used</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588065</commentid>
    <comment_count>12</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-11-06 18:42:33 -0800</bug_when>
    <thetext>(In reply to Saam Barati from comment #11)
&gt; (In reply to Yusuke Suzuki from comment #10)
&gt; &gt; Committed r252157: &lt;https://trac.webkit.org/changeset/252157&gt;
&gt; 
&gt; why roll out this code? At least we should make the code sensible instead of
&gt; updating a local variable which is never used

Because of RAMification regression, we decide that the old broken behavior (always using 10ms) is the safest option for now. We will add a patch that is removing adjusting part for mini-mode in a separate patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588068</commentid>
    <comment_count>13</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-11-06 18:43:06 -0800</bug_when>
    <thetext>(In reply to Saam Barati from comment #11)
&gt; (In reply to Yusuke Suzuki from comment #10)
&gt; &gt; Committed r252157: &lt;https://trac.webkit.org/changeset/252157&gt;
&gt; 
&gt; why roll out this code? At least we should make the code sensible instead of
&gt; updating a local variable which is never used

See the ChangeLog of roll-out.

&gt;  We should clean up to make this bug&apos;s behavior default. And we should look for a bit larger interval here</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588084</commentid>
    <comment_count>14</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-11-06 19:24:12 -0800</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588085</commentid>
    <comment_count>15</comment_count>
      <attachid>383012</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-11-06 19:24:13 -0800</bug_when>
    <thetext>Created attachment 383012
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588086</commentid>
    <comment_count>16</comment_count>
      <attachid>383013</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-11-06 19:25:30 -0800</bug_when>
    <thetext>Created attachment 383013
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588303</commentid>
    <comment_count>17</comment_count>
      <attachid>383013</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-11-07 11:11:16 -0800</bug_when>
    <thetext>Comment on attachment 383013
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383013&amp;action=review

r=me

&gt; Source/bmalloc/bmalloc/Scavenger.cpp:-504
&gt; -        if (m_isInMiniMode) {
&gt; -            timeSpentScavenging *= 50;
&gt; -            newWaitTime = std::chrono::duration_cast&lt;std::chrono::milliseconds&gt;(timeSpentScavenging);
&gt; -            newWaitTime = std::min(std::max(newWaitTime, std::chrono::milliseconds(25)), std::chrono::milliseconds(500));
&gt; -        } else {

Can we file a FIXME?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1588518</commentid>
    <comment_count>18</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-11-07 17:29:14 -0800</bug_when>
    <thetext>Committed r252224: &lt;https://trac.webkit.org/changeset/252224&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>381232</attachid>
            <date>2019-10-17 14:57:26 -0700</date>
            <delta_ts>2019-11-06 19:24:11 -0800</delta_ts>
            <desc>PATCH</desc>
            <filename>bug-203121.diff</filename>
            <type>text/plain</type>
            <size>1509</size>
            <attacher name="Basuke Suzuki">basuke</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZyBiL1NvdXJjZS9ibWFsbG9jL0No
YW5nZUxvZwppbmRleCA2N2RjOThhZTNjOC4uNTA1Nzk4Mzg0NjMgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9ibWFsbG9jL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNSBAQAorMjAxOS0xMC0xNyAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29u
eS5jb20+CisKKyAgICAgICAgW2JtYWxsb2NdIEJ1ZyBmaXggZm9yIHdhaXQgdGltZSB3aGVuIGl0
J3MgaW4gbWluaSBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MjAzMTIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgU2luY2UgcjI0MzE0NCwgbV93YWl0VGltZSBpcyBuZXZlciBjaGFuZ2VkIG9uIG1p
bmkgbW9kZS4KKworICAgICAgICAqIGJtYWxsb2MvU2NhdmVuZ2VyLmNwcDoKKyAgICAgICAgKGJt
YWxsb2M6OlNjYXZlbmdlcjo6dGhyZWFkUnVuTG9vcCk6CisKIDIwMTktMTAtMDcgIFdlbnNvbiBI
c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgbWlzc2luZyAj
aW5jbHVkZSBpbiBEZWZlcnJlZFRyaWdnZXJJbmxpbmVzLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9i
bWFsbG9jL2JtYWxsb2MvU2NhdmVuZ2VyLmNwcCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvU2Nh
dmVuZ2VyLmNwcAppbmRleCA0MzE1Yzg5NDc5OC4uNTFiY2I1MGU1YmYgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9ibWFsbG9jL2JtYWxsb2MvU2NhdmVuZ2VyLmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9i
bWFsbG9jL1NjYXZlbmdlci5jcHAKQEAgLTUwMCw3ICs1MDAsNyBAQCB2b2lkIFNjYXZlbmdlcjo6
dGhyZWFkUnVuTG9vcCgpCiAgICAgICAgIGlmIChtX2lzSW5NaW5pTW9kZSkgewogICAgICAgICAg
ICAgdGltZVNwZW50U2NhdmVuZ2luZyAqPSA1MDsKICAgICAgICAgICAgIG5ld1dhaXRUaW1lID0g
c3RkOjpjaHJvbm86OmR1cmF0aW9uX2Nhc3Q8c3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcz4odGlt
ZVNwZW50U2NhdmVuZ2luZyk7Ci0gICAgICAgICAgICBuZXdXYWl0VGltZSA9IHN0ZDo6bWluKHN0
ZDo6bWF4KG5ld1dhaXRUaW1lLCBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzKDI1KSksIHN0ZDo6
Y2hyb25vOjptaWxsaXNlY29uZHMoNTAwKSk7CisgICAgICAgICAgICBtX3dhaXRUaW1lID0gc3Rk
OjptaW4oc3RkOjptYXgobmV3V2FpdFRpbWUsIHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHMoMjUp
KSwgc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcyg1MDApKTsKICAgICAgICAgfSBlbHNlIHsKICAg
ICAgICAgICAgIHRpbWVTcGVudFNjYXZlbmdpbmcgKj0gMTUwOwogICAgICAgICAgICAgbmV3V2Fp
dFRpbWUgPSBzdGQ6OmNocm9ubzo6ZHVyYXRpb25fY2FzdDxzdGQ6OmNocm9ubzo6bWlsbGlzZWNv
bmRzPih0aW1lU3BlbnRTY2F2ZW5naW5nKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>383012</attachid>
            <date>2019-11-06 19:24:13 -0800</date>
            <delta_ts>2019-11-06 19:25:29 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-203121-20191106192412.patch</filename>
            <type>text/plain</type>
            <size>2457</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D
aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMTM1OGU4MDg0MGIwNTcy
NzU1YmFmYTAxMzAwZGFlNzRlNDM1MzEwYy4uOTMxZDg3YzYyMDQzODk1MTA4NGMzYWQ4ZjRmNzk1
ZmRjN2VjNTY5NyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTExLTA2ICBZdXN1
a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW2JtYWxsb2NdIEJ1ZyBm
aXggZm9yIHdhaXQgdGltZSB3aGVuIGl0J3MgaW4gbWluaSBtb2RlLgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMTIxCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFzdWtlIHBvaW50ZWQgb3V0IHRoYXQg
d2UgbmV2ZXIgY2hhbmdlZCBtX3dhaXRUaW1lIGluIHNjYXZlbmdlciB3aGVuIHdlIGFyZSBpbiBp
T1MgYW5kIG1pbmktbW9kZS4KKyAgICAgICAgU28gcHJldmlvdXNseSwgd2UgYXJlIGFsd2F5cyBl
eGVjdXRpbmcgc2NhdmVuZ2VyIGZvciBlYWNoIDEwbXMgaW4gbWluaS1tb2RlLiBBZnRlciBmaXhp
bmcgaXQsIHdlCisgICAgICAgIGZvdW5kIHRoYXQgdGhpcyB1bmludGVudGlvbmFsIGJlaGF2aW9y
IHdhcyBiZXR0ZXIgcG9saWN5IGZvciBSQU1pZmljYXRpb24uCisgICAgICAgIEluIHRoaXMgcGF0
Y2gsIHdlIGV4cGxpY2l0bHkgdXNlIHRoZSBvbGQgYmVoYXZpb3IsICJzY2F2ZW5nZSBmb3IgZWFj
aCAxMG1zIiBpbiBpT1MgbWluaS1tb2RlLgorICAgICAgICBXZSBzaG91bGQgcmV2aXNpdCBzY2F2
ZW5nZXIncyBiZWhhdmlvciBpbiB0aGUgZnV0dXJlIHRvIGV4cGxvcmUgZnVydGhlciBiZXR0ZXIg
YmVoYXZpb3IuCisKKyAgICAgICAgKiBibWFsbG9jL1NjYXZlbmdlci5jcHA6CisgICAgICAgIChi
bWFsbG9jOjpTY2F2ZW5nZXI6OnRocmVhZFJ1bkxvb3ApOgorCiAyMDE5LTExLTA2ICBZdXN1a2Ug
U3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbC1v
dXQgcjI1MTI2OCBkdWUgdG8gUkFNaWZpY2F0aW9uIHJlZ3Jlc3Npb24KZGlmZiAtLWdpdCBhL1Nv
dXJjZS9ibWFsbG9jL2JtYWxsb2MvU2NhdmVuZ2VyLmNwcCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxs
b2MvU2NhdmVuZ2VyLmNwcAppbmRleCA0MzE1Yzg5NDc5ODgwOGEyMGY1MGFkNDgxMjJlNDg4YzM1
ZjRlYjU0Li44ZjExYjMzMGYxZTUzM2ExZDkyODgwOGM2NWYzZDczM2I4MTU4ZjE5IDEwMDY0NAot
LS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1NjYXZlbmdlci5jcHAKKysrIGIvU291cmNlL2Jt
YWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIuY3BwCkBAIC00OTUsMTUgKzQ5NSw5IEBAIHZvaWQgU2Nh
dmVuZ2VyOjp0aHJlYWRSdW5Mb29wKCkKICAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxkb3Vi
bGU+KHN0ZDo6Y2hyb25vOjpkdXJhdGlvbl9jYXN0PHN0ZDo6Y2hyb25vOjptaWNyb3NlY29uZHM+
KHRpbWVTcGVudFNjYXZlbmdpbmcpLmNvdW50KCkpIC8gMTAwMCk7CiAgICAgICAgIH0KIAotICAg
ICAgICBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzIG5ld1dhaXRUaW1lOwotCi0gICAgICAgIGlm
IChtX2lzSW5NaW5pTW9kZSkgewotICAgICAgICAgICAgdGltZVNwZW50U2NhdmVuZ2luZyAqPSA1
MDsKLSAgICAgICAgICAgIG5ld1dhaXRUaW1lID0gc3RkOjpjaHJvbm86OmR1cmF0aW9uX2Nhc3Q8
c3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcz4odGltZVNwZW50U2NhdmVuZ2luZyk7Ci0gICAgICAg
ICAgICBuZXdXYWl0VGltZSA9IHN0ZDo6bWluKHN0ZDo6bWF4KG5ld1dhaXRUaW1lLCBzdGQ6OmNo
cm9ubzo6bWlsbGlzZWNvbmRzKDI1KSksIHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHMoNTAwKSk7
Ci0gICAgICAgIH0gZWxzZSB7CisgICAgICAgIGlmICghbV9pc0luTWluaU1vZGUpIHsKICAgICAg
ICAgICAgIHRpbWVTcGVudFNjYXZlbmdpbmcgKj0gMTUwOwotICAgICAgICAgICAgbmV3V2FpdFRp
bWUgPSBzdGQ6OmNocm9ubzo6ZHVyYXRpb25fY2FzdDxzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRz
Pih0aW1lU3BlbnRTY2F2ZW5naW5nKTsKKyAgICAgICAgICAgIHN0ZDo6Y2hyb25vOjptaWxsaXNl
Y29uZHMgbmV3V2FpdFRpbWUgPSBzdGQ6OmNocm9ubzo6ZHVyYXRpb25fY2FzdDxzdGQ6OmNocm9u
bzo6bWlsbGlzZWNvbmRzPih0aW1lU3BlbnRTY2F2ZW5naW5nKTsKICAgICAgICAgICAgIG1fd2Fp
dFRpbWUgPSBzdGQ6Om1pbihzdGQ6Om1heChuZXdXYWl0VGltZSwgc3RkOjpjaHJvbm86Om1pbGxp
c2Vjb25kcygxMDApKSwgc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcygxMDAwMCkpOwogICAgICAg
ICB9CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>383013</attachid>
            <date>2019-11-06 19:25:30 -0800</date>
            <delta_ts>2019-11-07 11:11:16 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-203121-20191106192529.patch</filename>
            <type>text/plain</type>
            <size>2501</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyMTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D
aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMTM1OGU4MDg0MGIwNTcy
NzU1YmFmYTAxMzAwZGFlNzRlNDM1MzEwYy4uYzM4YWYyMjRiM2Y4MGFjMTRhZDZiMmVlOTBlMWFi
MWM4YzUyODY1OCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTExLTA2ICBCYXN1
a2UgU3V6dWtpICA8QmFzdWtlLlN1enVraUBzb255LmNvbT4gYW5kIFl1c3VrZSBTdXp1a2kgIDx5
c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbYm1hbGxvY10gQnVnIGZpeCBmb3Igd2FpdCB0
aW1lIHdoZW4gaXQncyBpbiBtaW5pIG1vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMxMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBCYXN1a2UgcG9pbnRlZCBvdXQgdGhhdCB3ZSBuZXZlciBjaGFu
Z2VkIG1fd2FpdFRpbWUgaW4gc2NhdmVuZ2VyIHdoZW4gd2UgYXJlIGluIGlPUyBhbmQgbWluaS1t
b2RlLgorICAgICAgICBTbyBwcmV2aW91c2x5LCB3ZSBhcmUgYWx3YXlzIGV4ZWN1dGluZyBzY2F2
ZW5nZXIgZm9yIGVhY2ggMTBtcyBpbiBtaW5pLW1vZGUuIEFmdGVyIGZpeGluZyBpdCwgd2UKKyAg
ICAgICAgZm91bmQgdGhhdCB0aGlzIHVuaW50ZW50aW9uYWwgYmVoYXZpb3Igd2FzIGJldHRlciBw
b2xpY3kgZm9yIFJBTWlmaWNhdGlvbi4KKyAgICAgICAgSW4gdGhpcyBwYXRjaCwgd2UgZXhwbGlj
aXRseSB1c2UgdGhlIG9sZCBiZWhhdmlvciwgInNjYXZlbmdlIGZvciBlYWNoIDEwbXMiIGluIGlP
UyBtaW5pLW1vZGUuCisgICAgICAgIFdlIHNob3VsZCByZXZpc2l0IHNjYXZlbmdlcidzIGJlaGF2
aW9yIGluIHRoZSBmdXR1cmUgdG8gZXhwbG9yZSBmdXJ0aGVyIGJldHRlciBiZWhhdmlvci4KKwor
ICAgICAgICAqIGJtYWxsb2MvU2NhdmVuZ2VyLmNwcDoKKyAgICAgICAgKGJtYWxsb2M6OlNjYXZl
bmdlcjo6dGhyZWFkUnVuTG9vcCk6CisKIDIwMTktMTEtMDYgIFl1c3VrZSBTdXp1a2kgIDx5c3V6
dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsLW91dCByMjUxMjY4IGR1
ZSB0byBSQU1pZmljYXRpb24gcmVncmVzc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2Mv
Ym1hbGxvYy9TY2F2ZW5nZXIuY3BwIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIu
Y3BwCmluZGV4IDQzMTVjODk0Nzk4ODA4YTIwZjUwYWQ0ODEyMmU0ODhjMzVmNGViNTQuLjhmMTFi
MzMwZjFlNTMzYTFkOTI4ODA4YzY1ZjNkNzMzYjgxNThmMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9i
bWFsbG9jL2JtYWxsb2MvU2NhdmVuZ2VyLmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9j
L1NjYXZlbmdlci5jcHAKQEAgLTQ5NSwxNSArNDk1LDkgQEAgdm9pZCBTY2F2ZW5nZXI6OnRocmVh
ZFJ1bkxvb3AoKQogICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGRvdWJsZT4oc3RkOjpjaHJv
bm86OmR1cmF0aW9uX2Nhc3Q8c3RkOjpjaHJvbm86Om1pY3Jvc2Vjb25kcz4odGltZVNwZW50U2Nh
dmVuZ2luZykuY291bnQoKSkgLyAxMDAwKTsKICAgICAgICAgfQogCi0gICAgICAgIHN0ZDo6Y2hy
b25vOjptaWxsaXNlY29uZHMgbmV3V2FpdFRpbWU7Ci0KLSAgICAgICAgaWYgKG1faXNJbk1pbmlN
b2RlKSB7Ci0gICAgICAgICAgICB0aW1lU3BlbnRTY2F2ZW5naW5nICo9IDUwOwotICAgICAgICAg
ICAgbmV3V2FpdFRpbWUgPSBzdGQ6OmNocm9ubzo6ZHVyYXRpb25fY2FzdDxzdGQ6OmNocm9ubzo6
bWlsbGlzZWNvbmRzPih0aW1lU3BlbnRTY2F2ZW5naW5nKTsKLSAgICAgICAgICAgIG5ld1dhaXRU
aW1lID0gc3RkOjptaW4oc3RkOjptYXgobmV3V2FpdFRpbWUsIHN0ZDo6Y2hyb25vOjptaWxsaXNl
Y29uZHMoMjUpKSwgc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcyg1MDApKTsKLSAgICAgICAgfSBl
bHNlIHsKKyAgICAgICAgaWYgKCFtX2lzSW5NaW5pTW9kZSkgewogICAgICAgICAgICAgdGltZVNw
ZW50U2NhdmVuZ2luZyAqPSAxNTA7Ci0gICAgICAgICAgICBuZXdXYWl0VGltZSA9IHN0ZDo6Y2hy
b25vOjpkdXJhdGlvbl9jYXN0PHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHM+KHRpbWVTcGVudFNj
YXZlbmdpbmcpOworICAgICAgICAgICAgc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcyBuZXdXYWl0
VGltZSA9IHN0ZDo6Y2hyb25vOjpkdXJhdGlvbl9jYXN0PHN0ZDo6Y2hyb25vOjptaWxsaXNlY29u
ZHM+KHRpbWVTcGVudFNjYXZlbmdpbmcpOwogICAgICAgICAgICAgbV93YWl0VGltZSA9IHN0ZDo6
bWluKHN0ZDo6bWF4KG5ld1dhaXRUaW1lLCBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzKDEwMCkp
LCBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzKDEwMDAwKSk7CiAgICAgICAgIH0KIAo=
</data>
<flag name="review"
          id="398765"
          type_id="1"
          status="+"
          setter="saam"
    />
          </attachment>
      

    </bug>

</bugzilla>