203117 2019-10-17 12:04:04 -0700 [ews] status bubbles should show details from all the builds in case build is retried 2019-10-18 06:37:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1581082 0 aakash_jain 2019-10-17 12:04:04 -0700 EWS status bubbles should show details from all the builds in case build is retried. 1581100 1 381215 aakash_jain 2019-10-17 12:34:50 -0700 Created attachment 381215 Patch 1581102 2 aakash_jain 2019-10-17 12:36:23 -0700 Sample run: https://ews.webkit-uat.org/status-bubble/380828/ Notice that services bubble is listing all the retried builds. 1581103 3 381215 jbedard 2019-10-17 12:51:49 -0700 Comment on attachment 381215 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381215&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:189 > + message += '\n\n' + self._steps_messages(build) How long can this get? Looking at your example, the tooltip is totally reasonable, but it seems like we don't actually have a limit on how many builds you have here 1581122 4 aakash_jain 2019-10-17 13:37:49 -0700 (In reply to Jonathan Bedard from comment #3) > > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:189 > > + message += '\n\n' + self._steps_messages(build) > > How long can this get? We are not limiting anything currently. > > Looking at your example, the tooltip is totally reasonable, but it seems like we don't actually have a limit on how many builds you have here We can have the problem of too much text even with a single build. Not sure what's a good limit to put. Maybe we can land this patch as is, and see if and how exactly do we hit this issue of too much text, and then solve it appropriately. 1581133 5 381215 commit-queue 2019-10-17 14:02:52 -0700 Comment on attachment 381215 Patch Clearing flags on attachment: 381215 Committed r251256: <https://trac.webkit.org/changeset/251256> 1581134 6 commit-queue 2019-10-17 14:02:53 -0700 All reviewed patches have been landed. Closing bug. 1581135 7 webkit-bug-importer 2019-10-17 14:03:26 -0700 <rdar://problem/56384566> 1581388 8 aakash_jain 2019-10-18 06:37:18 -0700 Deployed in production. 381215 2019-10-17 12:34:50 -0700 2019-10-17 14:02:52 -0700 Patch bug-203117-20191017153449.patch text/plain 6766 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTI1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTEwLTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBzdGF0dXMgYnViYmxlcyBzaG91bGQgc2hvdyBkZXRhaWxzIGZy b20gYWxsIHRoZSBidWlsZHMgaW4gY2FzZSBidWlsZCBpcyByZXRyaWVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMxMTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weToKKyAgICAgICAgKFN0YXR1c0J1YmJsZS5f YnVpbGRfYnViYmxlKTogRGlzcGxheSBtZXNzYWdlcyBmcm9tIGFsbCB0aGUgYnVpbGRzIChpbmNs dWRpbmcgcmV0cmllZCBidWlsZHMpIGZvciBhIHBhdGNoIG9uIGEgcXVldWUuCisgICAgICAgIChT dGF0dXNCdWJibGUuX3N0ZXBzX21lc3NhZ2VzX2Zyb21fbXVsdGlwbGVfYnVpbGRzKTogTWV0aG9k IHRvIGdlbmVyYXRlIHN0YXR1cyB1c2luZyBpbmZvcm1hdGlvbiBmcm9tIGFsbCB0aGUgcmV0cmll ZCBidWlsZHMuIAorICAgICAgICAoU3RhdHVzQnViYmxlLmdldF9hbGxfYnVpbGRzX2Zvcl9xdWV1 ZSk6IE1ldGhvZCB0byBnZXQgYWxsIHRoZSBidWlsZHMgaW5zdGVhZCBvZiBqdXN0IHRoZSBsYXRl c3Qgb25lLgorICAgICAgICAoU3RhdHVzQnViYmxlLmdldF9sYXRlc3RfYnVpbGRfZm9yX3F1ZXVl KTogTW9kaWZpZWQgdG8gdXNlIHRoZSBuZXcgZ2V0X2FsbF9idWlsZHNfZm9yX3F1ZXVlKCkgbWV0 aG9kLgorCiAyMDE5LTEwLTE3ICBFbWlsaW8gQ29ib3Mgw4FsdmFyZXogIDxlbWlsaW9AY3Jpc2Fs LmlvPgogCiAgICAgICAgIFtHVEtdIEV4cGxpY2l0bHkgdXNlIFB5dGhvbiAyIGluIGpoYnVpbGQt d3JhcHBlcgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mv c3RhdHVzYnViYmxlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQkocmV2aXNpb24gMjUxMjUzKQorKysgVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC03Myw3ICs3MywxMCBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6 CiAgICAgICAgICAgICBpZiBzZWxmLl9pc19idWlsZGVyX3F1ZXVlKHF1ZXVlKToKICAgICAgICAg ICAgICAgICBidWJibGVbJ25hbWUnXSA9IFN0YXR1c0J1YmJsZS5CVUlMREVSX0lDT04gKyAnICAn ICsgYnViYmxlWyduYW1lJ10KIAotICAgICAgICBidWlsZCwgaXNfcGFyZW50X2J1aWxkID0gc2Vs Zi5nZXRfbGF0ZXN0X2J1aWxkX2Zvcl9xdWV1ZShwYXRjaCwgcXVldWUsIHNlbGYuX2dldF9wYXJl bnRfcXVldWUocXVldWUpKQorICAgICAgICBidWlsZHMsIGlzX3BhcmVudF9idWlsZCA9IHNlbGYu Z2V0X2FsbF9idWlsZHNfZm9yX3F1ZXVlKHBhdGNoLCBxdWV1ZSwgc2VsZi5fZ2V0X3BhcmVudF9x dWV1ZShxdWV1ZSkpCisgICAgICAgIGJ1aWxkID0gTm9uZQorICAgICAgICBpZiBidWlsZHM6Cisg ICAgICAgICAgICBidWlsZCA9IGJ1aWxkc1swXQogICAgICAgICBpZiBub3Qgc2VsZi5fc2hvdWxk X3Nob3dfYnViYmxlX2Zvcl9idWlsZChidWlsZCk6CiAgICAgICAgICAgICByZXR1cm4gTm9uZQog CkBAIC05NCw3ICs5Nyw3IEBAIGNsYXNzIFN0YXR1c0J1YmJsZShWaWV3KToKICAgICAgICAgICAg ICAgICBidWJibGVbJ3N0YXRlJ10gPSAncHJvdmlzaW9uYWwtZmFpbCcKICAgICAgICAgICAgIGVs c2U6CiAgICAgICAgICAgICAgICAgYnViYmxlWydzdGF0ZSddID0gJ3N0YXJ0ZWQnCi0gICAgICAg ICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ0J1aWxkIGlzIGluLXByb2dyZXNzLiBS ZWNlbnQgbWVzc2FnZXM6XG5cbicgKyBzZWxmLl9zdGVwc19tZXNzYWdlcyhidWlsZCkKKyAgICAg ICAgICAgIGJ1YmJsZVsnZGV0YWlsc19tZXNzYWdlJ10gPSAnQnVpbGQgaXMgaW4tcHJvZ3Jlc3Mu IFJlY2VudCBtZXNzYWdlczonICsgc2VsZi5fc3RlcHNfbWVzc2FnZXNfZnJvbV9tdWx0aXBsZV9i dWlsZHMoYnVpbGRzKQogICAgICAgICBlbGlmIGJ1aWxkLnJlc3VsdCA9PSBCdWlsZGJvdC5TVUND RVNTOgogICAgICAgICAgICAgaWYgaXNfcGFyZW50X2J1aWxkOgogICAgICAgICAgICAgICAgIGlm IHBhdGNoLm1vZGlmaWVkIDwgKHRpbWV6b25lLm5vdygpIC0gZGF0ZXRpbWUudGltZWRlbHRhKGRh eXM9U3RhdHVzQnViYmxlLkRBWVNfVE9fQ0hFQ0spKToKQEAgLTEwMywxMyArMTA2LDEzIEBAIGNs YXNzIFN0YXR1c0J1YmJsZShWaWV3KToKICAgICAgICAgICAgICAgICAgICAgIyBhZGRlZCBhZnRl ciB0aGUgcGF0Y2ggd2FzIHN1Ym1pdHRlZCwgb3IgYnVpbGQgcmVxdWVzdCBmb3IgdGhhdCBwYXRj aCB3YXMgY2FuY2VsbGVkLgogICAgICAgICAgICAgICAgICAgICByZXR1cm4gTm9uZQogICAgICAg ICAgICAgICAgIGJ1YmJsZVsnc3RhdGUnXSA9ICdzdGFydGVkJwotICAgICAgICAgICAgICAgIGJ1 YmJsZVsnZGV0YWlsc19tZXNzYWdlJ10gPSAnQnVpbGQgaXMgaW4tcHJvZ3Jlc3MuIFJlY2VudCBt ZXNzYWdlczpcblxuJyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzKGJ1aWxkKSArICdcblxuV2FpdGlu ZyB0byBydW4gdGVzdHMuJworICAgICAgICAgICAgICAgIGJ1YmJsZVsnZGV0YWlsc19tZXNzYWdl J10gPSAnQnVpbGQgaXMgaW4tcHJvZ3Jlc3MuIFJlY2VudCBtZXNzYWdlczonICsgc2VsZi5fc3Rl cHNfbWVzc2FnZXNfZnJvbV9tdWx0aXBsZV9idWlsZHMoYnVpbGRzKSArICdcblxuV2FpdGluZyB0 byBydW4gdGVzdHMuJwogICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICBidWJibGVb J3N0YXRlJ10gPSAncGFzcycKICAgICAgICAgICAgICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2Fn ZSddID0gJ1Bhc3MnCiAgICAgICAgIGVsaWYgYnVpbGQucmVzdWx0ID09IEJ1aWxkYm90LldBUk5J TkdTOgogICAgICAgICAgICAgYnViYmxlWydzdGF0ZSddID0gJ3Bhc3MnCi0gICAgICAgICAgICBi dWJibGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ1dhcm5pbmdcblxuJyArIHNlbGYuX3N0ZXBzX21l c3NhZ2VzKGJ1aWxkKQorICAgICAgICAgICAgYnViYmxlWydkZXRhaWxzX21lc3NhZ2UnXSA9ICdX YXJuaW5nJyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzX2Zyb21fbXVsdGlwbGVfYnVpbGRzKGJ1aWxk cykKICAgICAgICAgZWxpZiBidWlsZC5yZXN1bHQgPT0gQnVpbGRib3QuRkFJTFVSRToKICAgICAg ICAgICAgIGJ1YmJsZVsnc3RhdGUnXSA9ICdmYWlsJwogICAgICAgICAgICAgYnViYmxlWydkZXRh aWxzX21lc3NhZ2UnXSA9IHNlbGYuX21vc3RfcmVjZW50X3N0ZXBfbWVzc2FnZShidWlsZCkKQEAg LTEyNSwxNiArMTI4LDE2IEBAIGNsYXNzIFN0YXR1c0J1YmJsZShWaWV3KToKIAogICAgICAgICBl bGlmIGJ1aWxkLnJlc3VsdCA9PSBCdWlsZGJvdC5FWENFUFRJT046CiAgICAgICAgICAgICBidWJi bGVbJ3N0YXRlJ10gPSAnZXJyb3InCi0gICAgICAgICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2Fn ZSddID0gJ0FuIHVuZXhwZWN0ZWQgZXJyb3Igb2NjdXJlZC4gUmVjZW50IG1lc3NhZ2VzOlxuXG4n ICsgc2VsZi5fc3RlcHNfbWVzc2FnZXMoYnVpbGQpCisgICAgICAgICAgICBidWJibGVbJ2RldGFp bHNfbWVzc2FnZSddID0gJ0FuIHVuZXhwZWN0ZWQgZXJyb3Igb2NjdXJlZC4gUmVjZW50IG1lc3Nh Z2VzOicgKyBzZWxmLl9zdGVwc19tZXNzYWdlc19mcm9tX211bHRpcGxlX2J1aWxkcyhidWlsZHMp CiAgICAgICAgIGVsaWYgYnVpbGQucmVzdWx0ID09IEJ1aWxkYm90LlJFVFJZOgogICAgICAgICAg ICAgYnViYmxlWydzdGF0ZSddID0gJ3Byb3Zpc2lvbmFsLWZhaWwnCi0gICAgICAgICAgICBidWJi bGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ0J1aWxkIGlzIGJlaW5nIHJldHJpZWQuIFJlY2VudCBt ZXNzYWdlczpcblxuJyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzKGJ1aWxkKQorICAgICAgICAgICAg YnViYmxlWydkZXRhaWxzX21lc3NhZ2UnXSA9ICdCdWlsZCBpcyBiZWluZyByZXRyaWVkLiBSZWNl bnQgbWVzc2FnZXM6JyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzX2Zyb21fbXVsdGlwbGVfYnVpbGRz KGJ1aWxkcykKICAgICAgICAgZWxpZiBidWlsZC5yZXN1bHQgPT0gQnVpbGRib3QuQ0FOQ0VMTEVE OgogICAgICAgICAgICAgYnViYmxlWydzdGF0ZSddID0gJ2ZhaWwnCi0gICAgICAgICAgICBidWJi bGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ0J1aWxkIHdhcyBjYW5jZWxsZWQuIFJlY2VudCBtZXNz YWdlczpcblxuJyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzKGJ1aWxkKQorICAgICAgICAgICAgYnVi YmxlWydkZXRhaWxzX21lc3NhZ2UnXSA9ICdCdWlsZCB3YXMgY2FuY2VsbGVkLiBSZWNlbnQgbWVz c2FnZXM6JyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzX2Zyb21fbXVsdGlwbGVfYnVpbGRzKGJ1aWxk cykKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIGJ1YmJsZVsnc3RhdGUnXSA9ICdlcnJvcicK LSAgICAgICAgICAgIGJ1YmJsZVsnZGV0YWlsc19tZXNzYWdlJ10gPSAnQW4gdW5leHBlY3RlZCBl cnJvciBvY2N1cmVkLiBSZWNlbnQgbWVzc2FnZXM6XG5cbicgKyBzZWxmLl9zdGVwc19tZXNzYWdl cyhidWlsZCkKKyAgICAgICAgICAgIGJ1YmJsZVsnZGV0YWlsc19tZXNzYWdlJ10gPSAnQW4gdW5l eHBlY3RlZCBlcnJvciBvY2N1cmVkLiBSZWNlbnQgbWVzc2FnZXM6JyArIHNlbGYuX3N0ZXBzX21l c3NhZ2VzX2Zyb21fbXVsdGlwbGVfYnVpbGRzKGJ1aWxkcykKIAogICAgICAgICBpZiAnZGV0YWls c19tZXNzYWdlJyBpbiBidWJibGU6CiAgICAgICAgICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2Fn ZSddID0gYnVpbGRlcl9mdWxsX25hbWUgKyAnXG5cbicgKyBidWJibGVbJ2RldGFpbHNfbWVzc2Fn ZSddCkBAIC0xODAsNiArMTgzLDEyIEBAIGNsYXNzIFN0YXR1c0J1YmJsZShWaWV3KToKICAgICBk ZWYgX3N0ZXBzX21lc3NhZ2VzKHNlbGYsIGJ1aWxkKToKICAgICAgICAgcmV0dXJuICdcbicuam9p bihbc3RlcC5zdGF0ZV9zdHJpbmcgZm9yIHN0ZXAgaW4gYnVpbGQuc3RlcF9zZXQuYWxsKCkub3Jk ZXJfYnkoJ3VpZCcpIGlmIHNlbGYuX3Nob3VsZF9kaXNwbGF5X3N0ZXAoc3RlcCldKQogCisgICAg ZGVmIF9zdGVwc19tZXNzYWdlc19mcm9tX211bHRpcGxlX2J1aWxkcyhzZWxmLCBidWlsZHMpOgor ICAgICAgICBtZXNzYWdlID0gJycKKyAgICAgICAgZm9yIGJ1aWxkIGluIHJldmVyc2VkKGJ1aWxk cyk6CisgICAgICAgICAgICBtZXNzYWdlICs9ICdcblxuJyArIHNlbGYuX3N0ZXBzX21lc3NhZ2Vz KGJ1aWxkKQorICAgICAgICByZXR1cm4gbWVzc2FnZQorCiAgICAgZGVmIF9zaG91bGRfZGlzcGxh eV9zdGVwKHNlbGYsIHN0ZXApOgogICAgICAgICByZXR1cm4gbm90IGZpbHRlcihsYW1iZGEgc3Rl cF90b19oaWRlOiByZS5zZWFyY2goc3RlcF90b19oaWRlLCBzdGVwLnN0YXRlX3N0cmluZyksIFN0 YXR1c0J1YmJsZS5TVEVQU19UT19ISURFKQogCkBAIC0xOTYsNiArMjA1LDEyIEBAIGNsYXNzIFN0 YXR1c0J1YmJsZShWaWV3KToKICAgICAgICAgcmV0dXJuIHJlY2VudF9zdGVwLnN0YXRlX3N0cmlu ZwogCiAgICAgZGVmIGdldF9sYXRlc3RfYnVpbGRfZm9yX3F1ZXVlKHNlbGYsIHBhdGNoLCBxdWV1 ZSwgcGFyZW50X3F1ZXVlPU5vbmUpOgorICAgICAgICBidWlsZHMsIGlzX3BhcmVudF9idWlsZCA9 IHNlbGYuZ2V0X2FsbF9idWlsZHNfZm9yX3F1ZXVlKHBhdGNoLCBxdWV1ZSwgcGFyZW50X3F1ZXVl KQorICAgICAgICBpZiBub3QgYnVpbGRzOgorICAgICAgICAgICAgcmV0dXJuIChOb25lLCBOb25l KQorICAgICAgICByZXR1cm4gKGJ1aWxkc1swXSwgaXNfcGFyZW50X2J1aWxkKQorCisgICAgZGVm IGdldF9hbGxfYnVpbGRzX2Zvcl9xdWV1ZShzZWxmLCBwYXRjaCwgcXVldWUsIHBhcmVudF9xdWV1 ZT1Ob25lKToKICAgICAgICAgYnVpbGRzID0gc2VsZi5nZXRfYnVpbGRzX2Zvcl9xdWV1ZShwYXRj aCwgcXVldWUpCiAgICAgICAgIGlzX3BhcmVudF9idWlsZCA9IEZhbHNlCiAgICAgICAgIGlmIG5v dCBidWlsZHMgYW5kIHBhcmVudF9xdWV1ZToKQEAgLTIwNCw3ICsyMTksNyBAQCBjbGFzcyBTdGF0 dXNCdWJibGUoVmlldyk6CiAgICAgICAgIGlmIG5vdCBidWlsZHM6CiAgICAgICAgICAgICByZXR1 cm4gKE5vbmUsIE5vbmUpCiAgICAgICAgIGJ1aWxkcy5zb3J0KGtleT1sYW1iZGEgYnVpbGQ6IGJ1 aWxkLnN0YXJ0ZWRfYXQsIHJldmVyc2U9VHJ1ZSkKLSAgICAgICAgcmV0dXJuIChidWlsZHNbMF0s IGlzX3BhcmVudF9idWlsZCkKKyAgICAgICAgcmV0dXJuIChidWlsZHMsIGlzX3BhcmVudF9idWls ZCkKIAogICAgIGRlZiBnZXRfYnVpbGRzX2Zvcl9xdWV1ZShzZWxmLCBwYXRjaCwgcXVldWUpOgog ICAgICAgICByZXR1cm4gW2J1aWxkIGZvciBidWlsZCBpbiBwYXRjaC5idWlsZF9zZXQuYWxsKCkg aWYgYnVpbGQuYnVpbGRlcl9kaXNwbGF5X25hbWUgPT0gcXVldWVdCg==