203114 2019-10-17 11:14:48 -0700 Remove unused WKWebsiteDataStore setter SPI 2019-10-28 17:10:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen andersca webkit-bug-importer oldest_to_newest 1581059 0 achristensen 2019-10-17 11:14:48 -0700 Remove unused WKWebsiteDataStore setter SPI 1581061 1 381203 achristensen 2019-10-17 11:15:28 -0700 Created attachment 381203 Patch 1581067 2 381203 achristensen 2019-10-17 11:19:32 -0700 Comment on attachment 381203 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381203&action=review > Source/WebKit/ChangeLog:8 > + They have been replaced by _WKWebsiteDataStoreConfiguration SPI which was adopted in rdar://problem/56349165 I'll wait for this radar to be integrated before landing. 1584650 3 achristensen 2019-10-28 14:52:22 -0700 http://trac.webkit.org/r251675 1584651 4 webkit-bug-importer 2019-10-28 14:53:19 -0700 <rdar://problem/56686031> 1584757 5 381203 achristensen 2019-10-28 17:10:21 -0700 Comment on attachment 381203 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381203&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:-56 > -@property (nonatomic, setter=_setAllowsCellularAccess:) BOOL _allowsCellularAccess WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration.allowsCellularAccess", macos(10.13.4, WK_MAC_TBA), ios(11.3, WK_IOS_TBA)); Somebody's still using this. Grumble grumble. Will not break their build again. 381203 2019-10-17 11:15:28 -0700 2019-10-18 08:26:12 -0700 Patch bug-203114-20191017111527.patch text/plain 6807 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTEyNDYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE5LTEwLTE3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVudXNl ZCBXS1dlYnNpdGVEYXRhU3RvcmUgc2V0dGVyIFNQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMTE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhleSBoYXZlIGJlZW4gcmVwbGFjZWQgYnkgX1dLV2Vi c2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24gU1BJIHdoaWNoIHdhcyBhZG9wdGVkIGluIHJkYXI6 Ly9wcm9ibGVtLzU2MzQ5MTY1CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi c2l0ZURhdGFTdG9yZS5tbToKKyAgICAgICAgKC1bV0tXZWJzaXRlRGF0YVN0b3JlIF9zZXRCb3Vu ZEludGVyZmFjZUlkZW50aWZpZXI6XSk6IERlbGV0ZWQuCisgICAgICAgICgtW1dLV2Vic2l0ZURh dGFTdG9yZSBfYm91bmRJbnRlcmZhY2VJZGVudGlmaWVyXSk6IERlbGV0ZWQuCisgICAgICAgICgt W1dLV2Vic2l0ZURhdGFTdG9yZSBfc2V0QWxsb3dzQ2VsbHVsYXJBY2Nlc3M6XSk6IERlbGV0ZWQu CisgICAgICAgICgtW1dLV2Vic2l0ZURhdGFTdG9yZSBfYWxsb3dzQ2VsbHVsYXJBY2Nlc3NdKTog RGVsZXRlZC4KKyAgICAgICAgKC1bV0tXZWJzaXRlRGF0YVN0b3JlIF9zZXRQcm94eUNvbmZpZ3Vy YXRpb246XSk6IERlbGV0ZWQuCisgICAgICAgICgtW1dLV2Vic2l0ZURhdGFTdG9yZSBfcHJveHlD b25maWd1cmF0aW9uXSk6IERlbGV0ZWQuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYnNpdGVEYXRhU3RvcmVQcml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVE YXRhL1dlYnNpdGVEYXRhU3RvcmUuaDoKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9y ZTo6c2V0Qm91bmRJbnRlcmZhY2VJZGVudGlmaWVyKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYktp dDo6V2Vic2l0ZURhdGFTdG9yZTo6c2V0QWxsb3dzQ2VsbHVsYXJBY2Nlc3MpOiBEZWxldGVkLgor ICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpzZXRQcm94eUNvbmZpZ3VyYXRpb24p OiBEZWxldGVkLgorCiAyMDE5LTEwLTE3ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5j b20+CiAKICAgICAgICAgW1dlYiBBbmltYXRpb25zXSBFbmFibGUgdGhlIFdlYiBBbmltYXRpb25z IEphdmFTY3JpcHQgQVBJIGJ5IGRlZmF1bHQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9yZS5tbQkocmV2aXNpb24g MjUxMTQ1KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURh dGFTdG9yZS5tbQkod29ya2luZyBjb3B5KQpAQCAtMzI2LDMxICszMjYsNiBAQCAtICh2b2lkKV9z ZXRTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uRGlyCiAgICAgX3dlYnNpdGVEYXRhU3RvcmUtPnNl dFNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25EaXJlY3RvcnkoZGlyZWN0b3J5KTsKIH0KIAotLSAo dm9pZClfc2V0Qm91bmRJbnRlcmZhY2VJZGVudGlmaWVyOihOU1N0cmluZyAqKWlkZW50aWZpZXIK LXsKLSAgICBfd2Vic2l0ZURhdGFTdG9yZS0+c2V0Qm91bmRJbnRlcmZhY2VJZGVudGlmaWVyKGlk ZW50aWZpZXIpOwotfQotCi0tIChOU1N0cmluZyAqKV9ib3VuZEludGVyZmFjZUlkZW50aWZpZXIK LXsKLSAgICByZXR1cm4gX3dlYnNpdGVEYXRhU3RvcmUtPmJvdW5kSW50ZXJmYWNlSWRlbnRpZmll cigpOwotfQotCi0tICh2b2lkKV9zZXRBbGxvd3NDZWxsdWxhckFjY2VzczooQk9PTClhbGxvd3MK LXsKLSAgICBfd2Vic2l0ZURhdGFTdG9yZS0+c2V0QWxsb3dzQ2VsbHVsYXJBY2Nlc3MoYWxsb3dz ID8gV2ViS2l0OjpBbGxvd3NDZWxsdWxhckFjY2Vzczo6WWVzIDogV2ViS2l0OjpBbGxvd3NDZWxs dWxhckFjY2Vzczo6Tm8pOwotfQotCi0tIChCT09MKV9hbGxvd3NDZWxsdWxhckFjY2Vzcwotewot ICAgIHJldHVybiBfd2Vic2l0ZURhdGFTdG9yZS0+YWxsb3dzQ2VsbHVsYXJBY2Nlc3MoKSA9PSBX ZWJLaXQ6OkFsbG93c0NlbGx1bGFyQWNjZXNzOjpZZXM7Ci19Ci0KLS0gKHZvaWQpX3NldFByb3h5 Q29uZmlndXJhdGlvbjooTlNEaWN0aW9uYXJ5ICopY29uZmlndXJhdGlvbgotewotICAgIF93ZWJz aXRlRGF0YVN0b3JlLT5zZXRQcm94eUNvbmZpZ3VyYXRpb24oKF9fYnJpZGdlIENGRGljdGlvbmFy eVJlZiljb25maWd1cmF0aW9uKTsKLX0KLQogLSAoTlNTdHJpbmcgKilfc291cmNlQXBwbGljYXRp b25CdW5kbGVJZGVudGlmaWVyCiB7CiAgICAgcmV0dXJuIF93ZWJzaXRlRGF0YVN0b3JlLT5zb3Vy Y2VBcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXIoKTsKQEAgLTM4MiwxMSArMzU3LDYgQEAgLSAo Qk9PTClfYWxsb3dzVExTRmFsbGJhY2sKICAgICByZXR1cm4gTk87CiB9CiAKLS0gKE5TRGljdGlv bmFyeSAqKV9wcm94eUNvbmZpZ3VyYXRpb24KLXsKLSAgICByZXR1cm4gKF9fYnJpZGdlIE5TRGlj dGlvbmFyeSAqKV93ZWJzaXRlRGF0YVN0b3JlLT5wcm94eUNvbmZpZ3VyYXRpb24oKTsKLX0KLQog LSAoTlNVUkwgKilfaW5kZXhlZERCRGF0YWJhc2VEaXJlY3RvcnkKIHsKICAgICByZXR1cm4gW05T VVJMIGZpbGVVUkxXaXRoUGF0aDpfd2Vic2l0ZURhdGFTdG9yZS0+Y29uZmlndXJhdGlvbigpLmlu ZGV4ZWREQkRhdGFiYXNlRGlyZWN0b3J5KCkgaXNEaXJlY3Rvcnk6WUVTXTsKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmVQcml2YXRlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0 ZURhdGFTdG9yZVByaXZhdGUuaAkocmV2aXNpb24gMjUxMTQ1KQorKysgU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9yZVByaXZhdGUuaAkod29ya2luZyBj b3B5KQpAQCAtNTIsOSArNTIsNiBAQCB0eXBlZGVmIE5TX09QVElPTlMoTlNVSW50ZWdlciwgX1dL V2Vic2l0CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRDYWNoZVN0b3JhZ2VEaXJl Y3Rvcnk6KSBOU1N0cmluZyogX2NhY2hlU3RvcmFnZURpcmVjdG9yeSBXS19BUElfREVQUkVDQVRF RF9XSVRIX1JFUExBQ0VNRU5UKCJfV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5jYWNo ZVN0b3JhZ2VEaXJlY3RvcnkiLCBtYWNvcygxMC4xMy40LCBXS19NQUNfVEJBKSwgaW9zKDExLjMs IFdLX0lPU19UQkEpKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldFNlcnZpY2VX b3JrZXJSZWdpc3RyYXRpb25EaXJlY3Rvcnk6KSBOU1N0cmluZyogX3NlcnZpY2VXb3JrZXJSZWdp c3RyYXRpb25EaXJlY3RvcnkgV0tfQVBJX0RFUFJFQ0FURURfV0lUSF9SRVBMQUNFTUVOVCgiX1dL V2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24uc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRp cmVjdG9yeSIsIG1hY29zKDEwLjEzLjQsIFdLX01BQ19UQkEpLCBpb3MoMTEuMywgV0tfSU9TX1RC QSkpOwogCi1AcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRCb3VuZEludGVyZmFjZUlk ZW50aWZpZXI6KSBOU1N0cmluZyAqX2JvdW5kSW50ZXJmYWNlSWRlbnRpZmllciBXS19BUElfREVQ UkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJfV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlv bi5ib3VuZEludGVyZmFjZUlkZW50aWZpZXIiLCBtYWNvcygxMC4xMy40LCBXS19NQUNfVEJBKSwg aW9zKDExLjMsIFdLX0lPU19UQkEpKTsKLUBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3Nl dEFsbG93c0NlbGx1bGFyQWNjZXNzOikgQk9PTCBfYWxsb3dzQ2VsbHVsYXJBY2Nlc3MgV0tfQVBJ X0RFUFJFQ0FURURfV0lUSF9SRVBMQUNFTUVOVCgiX1dLV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3Vy YXRpb24uYWxsb3dzQ2VsbHVsYXJBY2Nlc3MiLCBtYWNvcygxMC4xMy40LCBXS19NQUNfVEJBKSwg aW9zKDExLjMsIFdLX0lPU19UQkEpKTsKLUBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3Nl dFByb3h5Q29uZmlndXJhdGlvbjopIE5TRGljdGlvbmFyeSAqX3Byb3h5Q29uZmlndXJhdGlvbiBX S19BUElfREVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJfV0tXZWJzaXRlRGF0YVN0b3JlQ29u ZmlndXJhdGlvbi5wcm94eUNvbmZpZ3VyYXRpb24iLCBtYWNvcygxMC4xNCwgV0tfTUFDX1RCQSks IGlvcygxMi4wLCBXS19JT1NfVEJBKSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgY29weSwgc2V0 dGVyPV9zZXRTb3VyY2VBcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXI6KSBOU1N0cmluZyAqX3Nv dXJjZUFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmllciBXS19BUElfREVQUkVDQVRFRF9XSVRIX1JF UExBQ0VNRU5UKCJfV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5zb3VyY2VBcHBsaWNh dGlvbkJ1bmRsZUlkZW50aWZpZXIiLCBtYWNvcygxMC4xNC40LCBXS19NQUNfVEJBKSwgaW9zKDEy LjIsIFdLX0lPU19UQkEpKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5LCBzZXR0ZXI9X3Nl dFNvdXJjZUFwcGxpY2F0aW9uU2Vjb25kYXJ5SWRlbnRpZmllcjopIE5TU3RyaW5nICpfc291cmNl QXBwbGljYXRpb25TZWNvbmRhcnlJZGVudGlmaWVyIFdLX0FQSV9ERVBSRUNBVEVEX1dJVEhfUkVQ TEFDRU1FTlQoIl9XS1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLnNldFNvdXJjZUFwcGxp Y2F0aW9uU2Vjb25kYXJ5SWRlbnRpZmllciIsIG1hY29zKDEwLjE0LjQsIFdLX01BQ19UQkEpLCBp b3MoMTIuMiwgV0tfSU9TX1RCQSkpOwogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0 QWxsb3dzVExTRmFsbGJhY2s6KSBCT09MIF9hbGxvd3NUTFNGYWxsYmFjayBXS19BUElfQVZBSUxB QkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwpJbmRleDogU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUu aAkocmV2aXNpb24gMjUxMTQ1KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURh dGEvV2Vic2l0ZURhdGFTdG9yZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMjEsNyArMjIxLDYgQEAg cHVibGljOgogICAgIHZvaWQgcmVtb3ZlUGVuZGluZ0Nvb2tpZShjb25zdCBXZWJDb3JlOjpDb29r aWUmKTsKICAgICB2b2lkIGNsZWFyUGVuZGluZ0Nvb2tpZXMoKTsKIAotICAgIHZvaWQgc2V0Qm91 bmRJbnRlcmZhY2VJZGVudGlmaWVyKFN0cmluZyYmIGlkZW50aWZpZXIpIHsgbV9yZXNvbHZlZENv bmZpZ3VyYXRpb24tPnNldEJvdW5kSW50ZXJmYWNlSWRlbnRpZmllcihXVEZNb3ZlKGlkZW50aWZp ZXIpKTsgfQogICAgIGNvbnN0IFN0cmluZyYgYm91bmRJbnRlcmZhY2VJZGVudGlmaWVyKCkgeyBy ZXR1cm4gbV9yZXNvbHZlZENvbmZpZ3VyYXRpb24tPmJvdW5kSW50ZXJmYWNlSWRlbnRpZmllcigp OyB9CiAKICAgICBjb25zdCBTdHJpbmcmIHNvdXJjZUFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmll cigpIGNvbnN0IHsgcmV0dXJuIG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLT5zb3VyY2VBcHBsaWNh dGlvbkJ1bmRsZUlkZW50aWZpZXIoKTsgfQpAQCAtMjMyLDExICsyMzEsOSBAQCBwdWJsaWM6CiAK ICAgICB2b2lkIG5ldHdvcmtpbmdIYXNCZWd1bigpIHsgbV9uZXR3b3JraW5nSGFzQmVndW4gPSB0 cnVlOyB9CiAgICAgCi0gICAgdm9pZCBzZXRBbGxvd3NDZWxsdWxhckFjY2VzcyhBbGxvd3NDZWxs dWxhckFjY2VzcyBhbGxvd3MpIHsgbV9yZXNvbHZlZENvbmZpZ3VyYXRpb24tPnNldEFsbG93c0Nl bGx1bGFyQWNjZXNzKGFsbG93cyA9PSBBbGxvd3NDZWxsdWxhckFjY2Vzczo6WWVzKTsgfQogICAg IEFsbG93c0NlbGx1bGFyQWNjZXNzIGFsbG93c0NlbGx1bGFyQWNjZXNzKCkgeyByZXR1cm4gbV9y ZXNvbHZlZENvbmZpZ3VyYXRpb24tPmFsbG93c0NlbGx1bGFyQWNjZXNzKCkgPyBBbGxvd3NDZWxs dWxhckFjY2Vzczo6WWVzIDogQWxsb3dzQ2VsbHVsYXJBY2Nlc3M6Ok5vOyB9CiAKICNpZiBQTEFU Rk9STShDT0NPQSkKLSAgICB2b2lkIHNldFByb3h5Q29uZmlndXJhdGlvbihDRkRpY3Rpb25hcnlS ZWYgY29uZmlndXJhdGlvbikgeyBtX3Jlc29sdmVkQ29uZmlndXJhdGlvbi0+c2V0UHJveHlDb25m aWd1cmF0aW9uKGNvbmZpZ3VyYXRpb24pOyB9CiAgICAgQ0ZEaWN0aW9uYXJ5UmVmIHByb3h5Q29u ZmlndXJhdGlvbigpIHsgcmV0dXJuIG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLT5wcm94eUNvbmZp Z3VyYXRpb24oKTsgfQogI2VuZGlmCiAK