203109 2019-10-17 10:19:04 -0700 [Linux] Avoid usage of <sys/sysctl.h> in MallocBench 2019-10-17 14:45:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez cdumez cgarcia clopez commit-queue ews-watchlist jbedard rniwa webkit-bug-importer oldest_to_newest 1581028 0 aperez 2019-10-17 10:19:04 -0700 On Linux systems which use glibc ≥2.30 the following will be logged during compilation: In file included from ../PerformanceTests/MallocBench/MallocBench/CPUCount.cpp:29: /usr/include/sys/sysctl.h:21:2: warning: "The <sys/sysctl.h> header is deprecated and will be removed." [-W#warnings] #warning "The <sys/sysctl.h> header is deprecated and will be removed." ^ The release notes for glibc 2.30 read: “The Linux-specific <sys/sysctl.h> header and the sysctl function have been deprecated and will be removed from a future version of glibc. Application should directly access /proc instead. For obtaining random bits, the getentropy function can be used.” (See also https://sourceware.org/ml/libc-alpha/2019-08/msg00029.html for the full release notes.) 1581030 1 aperez 2019-10-17 10:20:33 -0700 Turns out, usage of sysctl() is guarded with an “#ifdef __APPLE__” guard and in Linux the sysconf() function is used instead. Adding the same guard for the header inclusion should suffice. 1581031 2 381198 aperez 2019-10-17 10:23:34 -0700 Created attachment 381198 Patch 1581165 3 381198 commit-queue 2019-10-17 14:44:46 -0700 Comment on attachment 381198 Patch Clearing flags on attachment: 381198 Committed r251260: <https://trac.webkit.org/changeset/251260> 1581166 4 commit-queue 2019-10-17 14:44:48 -0700 All reviewed patches have been landed. Closing bug. 1581167 5 webkit-bug-importer 2019-10-17 14:45:18 -0700 <rdar://problem/56386384> 381198 2019-10-17 10:23:34 -0700 2019-10-17 14:44:46 -0700 Patch bug-203109-20191017202332.patch text/plain 1354 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMjQxCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZjOTM4NWQ3ZTRm ZWIxNDE1ZjRiNmQ1YWNiZTNiOWE5YzBlZTA2YWYuLmE2YTY3MWU0NGJjMDA2NjA3NzNkMzcyZjVl ZjdmOWFmNmQ3YjI1MDMgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMTAt MTcgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAg ICBbTGludXhdIEF2b2lkIHVzYWdlIG9mIDxzeXMvc3lzY3RsLmg+IGluIE1hbGxvY0JlbmNoCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMxMDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1hbGxvY0Jl bmNoL01hbGxvY0JlbmNoL0NQVUNvdW50LmNwcDogT25seSBpbmNsdWRlIDxzeXMvc3lzY3RsLmg+ IGlmCisgICAgICAgIHRoZSBzeXNjdGwoKSBmdW5jdGlvbiB3aWxsIGJlIHVzZWQuCisKIDIwMTkt MTAtMTcgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS10gUGVyZiB0ZXN0IEluZGV4ZWREQi9iYXNpYy9pbmRleC1jdXJzb3ItZGVs ZXRlLmh0bWwgdGltZW91dHMKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvTWFsbG9jQmVu Y2gvTWFsbG9jQmVuY2gvQ1BVQ291bnQuY3BwIGIvUGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5j aC9NYWxsb2NCZW5jaC9DUFVDb3VudC5jcHAKaW5kZXggMzFkNmQyZDgzOTlhMDIwYWM3MGNkOGQ4 OGU4MmE4MTg4YTU0ZTIwYS4uZjI0MzNkNzI2NGU1NDc0NTI4OWViMjUxODBlYTMxOGY3MmM5YzZi MyAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5jaC9NYWxsb2NCZW5jaC9D UFVDb3VudC5jcHAKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5jaC9NYWxsb2NCZW5j aC9DUFVDb3VudC5jcHAKQEAgLTI2LDEwICsyNiwxMyBAQAogI2luY2x1ZGUgIkNQVUNvdW50Lmgi CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8c3lzL3BhcmFtLmg+Ci0jaW5jbHVkZSA8 c3lzL3N5c2N0bC5oPgogI2luY2x1ZGUgPHN5cy90eXBlcy5oPgogI2luY2x1ZGUgPHVuaXN0ZC5o PgogCisjaWZkZWYgX19BUFBMRV9fCisjaW5jbHVkZSA8c3lzL3N5c2N0bC5oPgorI2VuZGlmCisK IHN0YXRpYyBzaXplX3QgY291bnQ7CiAKIHNpemVfdCBjcHVDb3VudCgpCg==