203063 2019-10-16 17:22:38 -0700 Cannot run some WPT cases manually 2019-10-22 10:44:24 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 commit-queue eric.carlson jer.noble rniwa webkit-bug-importer youennf oldest_to_newest 1580784 0 peng.liu6 2019-10-16 17:22:38 -0700 Due to the updates about LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js in https://trac.webkit.org/changeset/251043, we are not able to run some WPT cases manually. 1580792 1 381137 peng.liu6 2019-10-16 17:32:24 -0700 Created attachment 381137 Patch 1580842 2 peng.liu6 2019-10-16 20:16:25 -0700 One affected WPT case: LayoutTests/imported/w3c/web-platform-tests/picture-in-picture/exit-picture-in-picture.html. We need to make sure the test case can run in the browser. 1580944 3 youennf 2019-10-17 06:42:06 -0700 I guess the affected test expects user to click somewhere. There might be a race in the sense the promise will get resolved while the user might not have clicked already. This seems better than throwing though. What would be the result of rejecting the promise? 1580973 4 peng.liu6 2019-10-17 08:53:57 -0700 With this patch, when we run the case manually in a browser tab, the promise in window.test_driver_internal.click will be resolved directly. However, that will be OK because the promise of the bless function will not be resolved and the page will wait for a user to click the button to execute the test. Without this patch, the case will fail with "promise_test: Unhandled rejection with value: object "Error: window.eventSender is undefined."". The test case will not have a chance to execute. 1581131 5 381137 rniwa 2019-10-17 14:00:40 -0700 Comment on attachment 381137 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381137&action=review > LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:184 > + if (!window.testRunner) > + return Promise.resolve(); Hm... I'm not sure if this is right thing to do here. Some tests would expect that the click had already happened after this. We probably want to wait for click event to get dispatched on element. 1581146 6 381137 peng.liu6 2019-10-17 14:11:37 -0700 Comment on attachment 381137 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381137&action=review >> LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:184 >> + return Promise.resolve(); > > Hm... I'm not sure if this is right thing to do here. > Some tests would expect that the click had already happened after this. > We probably want to wait for click event to get dispatched on element. In a manual test (open the test page in a browser tab), user can click the button to execute the test case. Could you give an example test case that needs the click to be done automatically? 1582432 7 381137 commit-queue 2019-10-22 10:43:08 -0700 Comment on attachment 381137 Patch Clearing flags on attachment: 381137 Committed r251440: <https://trac.webkit.org/changeset/251440> 1582433 8 commit-queue 2019-10-22 10:43:09 -0700 All reviewed patches have been landed. Closing bug. 1582434 9 webkit-bug-importer 2019-10-22 10:44:24 -0700 <rdar://problem/56505834> 381137 2019-10-16 17:32:24 -0700 2019-10-22 10:43:08 -0700 Patch 203063.patch text/plain 1341 peng.liu6 ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDRlYmJjMmQyNGYxLi5iMDU0NTc0M2E4 ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTkt MTAtMTYgIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KKworICAgICAgICBDYW5ub3Qg cnVuIHNvbWUgV1BUIGNhc2VzIG1hbnVhbGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDMwNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9yZXNvdXJjZXMvdGVzdGRy aXZlci12ZW5kb3IuanM6CisKIDIwMTktMTAtMTUgIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxl LmNvbT4KIAogICAgICAgICBbUGljdHVyZS1pbi1QaWN0dXJlIFdlYiBBUEldIEltcGxlbWVudCBI VE1MVmlkZW9FbGVtZW50LnJlcXVlc3RQaWN0dXJlSW5QaWN0dXJlKCkgLyBEb2N1bWVudC5leGl0 UGljdHVyZUluUGljdHVyZSgpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL3Jlc291cmNlcy90ZXN0ZHJpdmVyLXZlbmRvci5qcyBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcmVzb3VyY2VzL3Rlc3Rkcml2 ZXItdmVuZG9yLmpzCmluZGV4IGM5MzBlY2Y5Y2Q3Li40MTg2YTRjNjk5ZCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9yZXNvdXJjZXMvdGVz dGRyaXZlci12ZW5kb3IuanMKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9yZXNvdXJjZXMvdGVzdGRyaXZlci12ZW5kb3IuanMKQEAgLTE4MCw2ICsxODAs OSBAQCB3aW5kb3cudGVzdF9kcml2ZXJfaW50ZXJuYWwuc2VuZF9rZXlzID0gZnVuY3Rpb24oZWxl bWVudCwga2V5cykKIAogd2luZG93LnRlc3RfZHJpdmVyX2ludGVybmFsLmNsaWNrID0gZnVuY3Rp b24gKGVsZW1lbnQsIGNvb3JkcykKIHsKKyAgICBpZiAoIXdpbmRvdy50ZXN0UnVubmVyKQorICAg ICAgICByZXR1cm4gUHJvbWlzZS5yZXNvbHZlKCk7CisKICAgICBpZiAoIXdpbmRvdy5ldmVudFNl bmRlcikKICAgICAgICAgcmV0dXJuIFByb21pc2UucmVqZWN0KG5ldyBFcnJvcigid2luZG93LmV2 ZW50U2VuZGVyIGlzIHVuZGVmaW5lZC4iKSk7CiAK