20306 2008-08-06 13:35:10 -0700 [gtk] implements FrameLoaderClient::dispatchDidChangeLocationWithinPage 2009-05-06 16:36:00 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 17066 0 a.renevier webkit-unassigned christian cosimoc jmalonzo oldest_to_newest 87983 0 a.renevier 2008-08-06 13:35:10 -0700 Hi, When a user clicks an internal link on a webpage (a link to an anchor within that page), document location changes, but webkit-gtk embedders are not notified of that change. Therefore, it would be nice to implement FrameLoaderClient::dispatchDidChangeLocationWithinPage for gtk, so a signal would be sent to notify location change. 88098 1 22705 a.renevier 2008-08-08 05:47:58 -0700 Created attachment 22705 first attempt patch 88102 2 22706 a.renevier 2008-08-08 08:11:07 -0700 Created attachment 22706 second attempt emit signal on frame, and on view only if we're in the main frame 92325 3 jmalonzo 2008-09-23 05:27:10 -0700 Hi arno Is your patch for review? If so can you please change the flag to '?' so it will go to the review queue? Thanks for the patch! 92904 4 22706 a.renevier 2008-09-26 04:23:17 -0700 Comment on attachment 22706 second attempt I was waiting for bug 17066, but may be we can still fix this one before 98108 5 22706 zecke 2008-11-09 15:26:25 -0800 Comment on attachment 22706 second attempt Let me comment on the style first: > void FrameLoaderClient::dispatchDidChangeLocationWithinPage() > { > - notImplemented(); > + /* Update the URI > + */ // Update the URI or /* * Update the URI */ > + if (m_frame == webkit_web_view_get_main_frame(webView)) > + g_signal_emit_by_name(webView, "location-changed-within-page", m_frame); > } early exits (like found in many places): if (m_frame != webkit_web_get_main_frame(webView)) return; g_signal_emit_by_name(webView, "... 98213 6 25028 a.renevier 2008-11-10 14:47:28 -0800 Created attachment 25028 style update Thanks for your comments. Here is an updated patch 106904 7 christian 2009-01-24 21:54:15 -0800 Do we really need a separate signal signal for this? In bug 14807 I'm adding notifications for the URI and title properties, so it should be sufficient to monitor the URI. It is easily distiguishable since no loading or progress information would change. 118112 8 25028 gustavo 2009-04-20 08:02:07 -0700 Comment on attachment 25028 style update I agree with Christian in this matter - there is no need to create a new signal for this, let's just use the properties, and have them notified at dispatchDidChangeLocationWithinPage. 22705 2008-08-08 05:47:58 -0700 2008-08-08 08:11:07 -0700 first attempt patch 20306.patch text/plain 2922 a.renevier ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRH dGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5j cHAKaW5kZXggOGNmMDg4Ni4uYjdhYTJhZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKQEAgLTUwMCwxNyArNTAwLDI0IEBAIHZv aWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkQ2FuY2VsQ2xpZW50UmVkaXJlY3QoKQog CiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaFdpbGxQZXJmb3JtQ2xpZW50UmVkaXJl Y3QoY29uc3QgS1VSTCYsIGRvdWJsZSwgZG91YmxlKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7 CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkQ2hhbmdlTG9jYXRpb25X aXRoaW5QYWdlKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIC8qIFVwZGF0ZSB0aGUg VVJJCisgICAgICovCisgICAgV2ViS2l0V2ViRnJhbWVQcml2YXRlKiBmcmFtZURhdGEgPSBXRUJL SVRfV0VCX0ZSQU1FX0dFVF9QUklWQVRFKG1fZnJhbWUpOworICAgIGdfZnJlZShmcmFtZURhdGEt PnVyaSk7CisgICAgZnJhbWVEYXRhLT51cmkgPSBnX3N0cmR1cChjb3JlKG1fZnJhbWUpLT5sb2Fk ZXIoKS0+dXJsKCkucHJldHR5VVJMKCkudXRmOCgpLmRhdGEoKSk7CisKKyAgICBXZWJLaXRXZWJW aWV3KiB3ZWJWaWV3ID0gZ2V0Vmlld0Zyb21GcmFtZShtX2ZyYW1lKTsKKyAgICBnX3NpZ25hbF9l bWl0X2J5X25hbWUod2ViVmlldywgImxvY2F0aW9uLWNoYW5nZWQtd2l0aGluLXBhZ2UiLCBtX2Zy YW1lKTsKIH0KIAogdm9pZCBGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hXaWxsQ2xvc2UoKQog ewogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRp c3BhdGNoRGlkUmVjZWl2ZUljb24oKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRl eCBlMDZkY2JmLi5mY2IyMjQ5IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAt NzAsMTYgKzcwLDE3IEBAIGV4dGVybiAiQyIgewogZW51bSB7CiAgICAgLyogbm9ybWFsIHNpZ25h bHMgKi8KICAgICBOQVZJR0FUSU9OX1JFUVVFU1RFRCwKICAgICBXSU5ET1dfT0JKRUNUX0NMRUFS RUQsCiAgICAgTE9BRF9TVEFSVEVELAogICAgIExPQURfQ09NTUlUVEVELAogICAgIExPQURfUFJP R1JFU1NfQ0hBTkdFRCwKICAgICBMT0FEX0ZJTklTSEVELAorICAgIExPQ0FUSU9OX0NIQU5HRURf V0lUSElOX1BBR0UsCiAgICAgVElUTEVfQ0hBTkdFRCwKICAgICBIT1ZFUklOR19PVkVSX0xJTkss CiAgICAgUE9QVUxBVEVfUE9QVVAsCiAgICAgU1RBVFVTX0JBUl9URVhUX0NIQU5HRUQsCiAgICAg SUNPTkRfTE9BREVELAogICAgIFNFTEVDVElPTl9DSEFOR0VELAogICAgIENPTlNPTEVfTUVTU0FH RSwKICAgICBTQ1JJUFRfQUxFUlQsCkBAIC04NjksMTYgKzg3MCwzMyBAQCBzdGF0aWMgdm9pZCB3 ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFz cykKICAgICAgICAgICAgIDAsCiAgICAgICAgICAgICBOVUxMLAogICAgICAgICAgICAgTlVMTCwK ICAgICAgICAgICAgIGdfY2Nsb3N1cmVfbWFyc2hhbF9WT0lEX19PQkpFQ1QsCiAgICAgICAgICAg ICBHX1RZUEVfTk9ORSwgMSwKICAgICAgICAgICAgIFdFQktJVF9UWVBFX1dFQl9GUkFNRSk7CiAK ICAgICAvKioKKyAgICAgKiBXZWJLaXRXZWJWaWV3Ojpsb2NhdGlvbi1jaGFuZ2VkLXdpdGhpbi1w YWdlOgorICAgICAqIEB3ZWJfdmlldzogdGhlIG9iamVjdCBvbiB3aGljaCB0aGUgc2lnbmFsIGlz IGVtaXR0ZWQKKyAgICAgKiBAZnJhbWU6IHRoZSBmcmFtZSB3aG9zZSB1cmkgaGFzIGNoYW5nZWQK KyAgICAgKgorICAgICAqIFdoZW4gI1dlYktpdFdlYkZyYW1lIHVyaSBjaGFuZ2VzIHdpdGhpbiB0 aGUgc2FtZSBkb2N1bWVudAorICAgICAqLworICAgIHdlYmtpdF93ZWJfdmlld19zaWduYWxzW0xP Q0FUSU9OX0NIQU5HRURfV0lUSElOX1BBR0VdID0gZ19zaWduYWxfbmV3KCJsb2NhdGlvbi1jaGFu Z2VkLXdpdGhpbi1wYWdlIiwKKyAgICAgICAgICAgIEdfVFlQRV9GUk9NX0NMQVNTKHdlYlZpZXdD bGFzcyksCisgICAgICAgICAgICAoR1NpZ25hbEZsYWdzKShHX1NJR05BTF9SVU5fTEFTVCB8IEdf U0lHTkFMX0FDVElPTiksCisgICAgICAgICAgICAwLAorICAgICAgICAgICAgTlVMTCwKKyAgICAg ICAgICAgIE5VTEwsCisgICAgICAgICAgICBnX2NjbG9zdXJlX21hcnNoYWxfVk9JRF9fT0JKRUNU LAorICAgICAgICAgICAgR19UWVBFX05PTkUsIDEsCisgICAgICAgICAgICBXRUJLSVRfVFlQRV9X RUJfRlJBTUUpOworCisgICAgLyoqCiAgICAgICogV2ViS2l0V2ViVmlldzo6dGl0bGUtY2hhbmdl ZDoKICAgICAgKiBAd2ViX3ZpZXc6IHRoZSBvYmplY3Qgb24gd2hpY2ggdGhlIHNpZ25hbCBpcyBl bWl0dGVkCiAgICAgICogQGZyYW1lOiB0aGUgbWFpbiBmcmFtZQogICAgICAqIEB0aXRsZTogdGhl IG5ldyB0aXRsZQogICAgICAqCiAgICAgICogV2hlbiBhICNXZWJLaXRXZWJGcmFtZSBjaGFuZ2Vz IHRoZSBkb2N1bWVudCB0aXRsZSB0aGlzIHNpZ25hbCBpcyBlbWl0dGVkLgogICAgICAqLwogICAg IHdlYmtpdF93ZWJfdmlld19zaWduYWxzW1RJVExFX0NIQU5HRURdID0gZ19zaWduYWxfbmV3KCJ0 aXRsZS1jaGFuZ2VkIiwK 22706 2008-08-08 08:11:07 -0700 2008-11-10 14:47:28 -0800 second attempt 20306.patch text/plain 4515 a.renevier ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRH dGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5j cHAKaW5kZXggOGNmMDg4Ni4uOTgxY2Y1ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKQEAgLTUwMCwxNyArNTAwLDI3IEBAIHZv aWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkQ2FuY2VsQ2xpZW50UmVkaXJlY3QoKQog CiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaFdpbGxQZXJmb3JtQ2xpZW50UmVkaXJl Y3QoY29uc3QgS1VSTCYsIGRvdWJsZSwgZG91YmxlKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7 CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkQ2hhbmdlTG9jYXRpb25X aXRoaW5QYWdlKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIC8qIFVwZGF0ZSB0aGUg VVJJCisgICAgICovCisgICAgV2ViS2l0V2ViRnJhbWVQcml2YXRlKiBmcmFtZURhdGEgPSBXRUJL SVRfV0VCX0ZSQU1FX0dFVF9QUklWQVRFKG1fZnJhbWUpOworICAgIGdfZnJlZShmcmFtZURhdGEt PnVyaSk7CisgICAgZnJhbWVEYXRhLT51cmkgPSBnX3N0cmR1cChjb3JlKG1fZnJhbWUpLT5sb2Fk ZXIoKS0+dXJsKCkucHJldHR5VVJMKCkudXRmOCgpLmRhdGEoKSk7CisKKyAgICBnX3NpZ25hbF9l bWl0X2J5X25hbWUobV9mcmFtZSwgImxvY2F0aW9uLWNoYW5nZWQtd2l0aGluLXBhZ2UiKTsKKwor ICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBnZXRWaWV3RnJvbUZyYW1lKG1fZnJhbWUpOwor ICAgIGlmIChtX2ZyYW1lID09IHdlYmtpdF93ZWJfdmlld19nZXRfbWFpbl9mcmFtZSh3ZWJWaWV3 KSkKKyAgICAgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKHdlYlZpZXcsICJsb2NhdGlvbi1jaGFu Z2VkLXdpdGhpbi1wYWdlIiwgbV9mcmFtZSk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnQ6 OmRpc3BhdGNoV2lsbENsb3NlKCkKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQogCiB2b2lk IEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZFJlY2VpdmVJY29uKCkKZGlmZiAtLWdpdCBh L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcCBiL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHdlYmZyYW1lLmNwcAppbmRleCAxMDJkYzA1Li4yMzBkY2JhIDEwMDY0NAotLS0gYS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2ViZnJhbWUuY3BwCkBAIC00OCwxNiArNDgsMTcgQEAgdXNpbmcgbmFtZXNwYWNl IFdlYkNvcmU7CiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCiBleHRlcm4gIkMiIHsKIAogZW51bSB7 CiAgICAgQ0xFQVJFRCwKICAgICBMT0FEX0NPTU1JVFRFRCwKICAgICBMT0FEX0RPTkUsCisgICAg TE9DQVRJT05fQ0hBTkdFRF9XSVRISU5fUEFHRSwKICAgICBUSVRMRV9DSEFOR0VELAogICAgIEhP VkVSSU5HX09WRVJfTElOSywKICAgICBMQVNUX1NJR05BTAogfTsKIAogZW51bSB7CiAgICAgUFJP UF8wLAogCkBAIC0xMzUsMTYgKzEzNiwyNSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX2ZyYW1l X2NsYXNzX2luaXQoV2ViS2l0V2ViRnJhbWVDbGFzcyogZnJhbWVDbGFzcykKICAgICAgICAgICAg IChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNUIHwgR19TSUdOQUxfQUNUSU9OKSwKICAg ICAgICAgICAgIDAsCiAgICAgICAgICAgICBOVUxMLAogICAgICAgICAgICAgTlVMTCwKICAgICAg ICAgICAgIGdfY2Nsb3N1cmVfbWFyc2hhbF9WT0lEX19CT09MRUFOLAogICAgICAgICAgICAgR19U WVBFX05PTkUsIDEsCiAgICAgICAgICAgICBHX1RZUEVfQk9PTEVBTik7CiAKKyAgICB3ZWJraXRf d2ViX2ZyYW1lX3NpZ25hbHNbTE9DQVRJT05fQ0hBTkdFRF9XSVRISU5fUEFHRV0gPSBnX3NpZ25h bF9uZXcoImxvY2F0aW9uLWNoYW5nZWQtd2l0aGluLXBhZ2UiLAorICAgICAgICAgICAgR19UWVBF X0ZST01fQ0xBU1MoZnJhbWVDbGFzcyksCisgICAgICAgICAgICAoR1NpZ25hbEZsYWdzKShHX1NJ R05BTF9SVU5fTEFTVCB8IEdfU0lHTkFMX0FDVElPTiksCisgICAgICAgICAgICAwLAorICAgICAg ICAgICAgTlVMTCwKKyAgICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICBnX2NjbG9zdXJlX21h cnNoYWxfVk9JRF9fVk9JRCwKKyAgICAgICAgICAgIEdfVFlQRV9OT05FLCAwKTsKKwogICAgIHdl YmtpdF93ZWJfZnJhbWVfc2lnbmFsc1tUSVRMRV9DSEFOR0VEXSA9IGdfc2lnbmFsX25ldygidGl0 bGUtY2hhbmdlZCIsCiAgICAgICAgICAgICBHX1RZUEVfRlJPTV9DTEFTUyhmcmFtZUNsYXNzKSwK ICAgICAgICAgICAgIChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNUIHwgR19TSUdOQUxf QUNUSU9OKSwKICAgICAgICAgICAgIDAsCiAgICAgICAgICAgICBOVUxMLAogICAgICAgICAgICAg TlVMTCwKICAgICAgICAgICAgIHdlYmtpdF9tYXJzaGFsX1ZPSURfX1NUUklORywKICAgICAgICAg ICAgIEdfVFlQRV9OT05FLCAxLApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCBl MDZkY2JmLi5mY2IyMjQ5IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2 aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtNzAs MTYgKzcwLDE3IEBAIGV4dGVybiAiQyIgewogZW51bSB7CiAgICAgLyogbm9ybWFsIHNpZ25hbHMg Ki8KICAgICBOQVZJR0FUSU9OX1JFUVVFU1RFRCwKICAgICBXSU5ET1dfT0JKRUNUX0NMRUFSRUQs CiAgICAgTE9BRF9TVEFSVEVELAogICAgIExPQURfQ09NTUlUVEVELAogICAgIExPQURfUFJPR1JF U1NfQ0hBTkdFRCwKICAgICBMT0FEX0ZJTklTSEVELAorICAgIExPQ0FUSU9OX0NIQU5HRURfV0lU SElOX1BBR0UsCiAgICAgVElUTEVfQ0hBTkdFRCwKICAgICBIT1ZFUklOR19PVkVSX0xJTkssCiAg ICAgUE9QVUxBVEVfUE9QVVAsCiAgICAgU1RBVFVTX0JBUl9URVhUX0NIQU5HRUQsCiAgICAgSUNP TkRfTE9BREVELAogICAgIFNFTEVDVElPTl9DSEFOR0VELAogICAgIENPTlNPTEVfTUVTU0FHRSwK ICAgICBTQ1JJUFRfQUxFUlQsCkBAIC04NjksMTYgKzg3MCwzMyBAQCBzdGF0aWMgdm9pZCB3ZWJr aXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykK ICAgICAgICAgICAgIDAsCiAgICAgICAgICAgICBOVUxMLAogICAgICAgICAgICAgTlVMTCwKICAg ICAgICAgICAgIGdfY2Nsb3N1cmVfbWFyc2hhbF9WT0lEX19PQkpFQ1QsCiAgICAgICAgICAgICBH X1RZUEVfTk9ORSwgMSwKICAgICAgICAgICAgIFdFQktJVF9UWVBFX1dFQl9GUkFNRSk7CiAKICAg ICAvKioKKyAgICAgKiBXZWJLaXRXZWJWaWV3Ojpsb2NhdGlvbi1jaGFuZ2VkLXdpdGhpbi1wYWdl OgorICAgICAqIEB3ZWJfdmlldzogdGhlIG9iamVjdCBvbiB3aGljaCB0aGUgc2lnbmFsIGlzIGVt aXR0ZWQKKyAgICAgKiBAZnJhbWU6IHRoZSBmcmFtZSB3aG9zZSB1cmkgaGFzIGNoYW5nZWQKKyAg ICAgKgorICAgICAqIFdoZW4gI1dlYktpdFdlYkZyYW1lIHVyaSBjaGFuZ2VzIHdpdGhpbiB0aGUg c2FtZSBkb2N1bWVudAorICAgICAqLworICAgIHdlYmtpdF93ZWJfdmlld19zaWduYWxzW0xPQ0FU SU9OX0NIQU5HRURfV0lUSElOX1BBR0VdID0gZ19zaWduYWxfbmV3KCJsb2NhdGlvbi1jaGFuZ2Vk LXdpdGhpbi1wYWdlIiwKKyAgICAgICAgICAgIEdfVFlQRV9GUk9NX0NMQVNTKHdlYlZpZXdDbGFz cyksCisgICAgICAgICAgICAoR1NpZ25hbEZsYWdzKShHX1NJR05BTF9SVU5fTEFTVCB8IEdfU0lH TkFMX0FDVElPTiksCisgICAgICAgICAgICAwLAorICAgICAgICAgICAgTlVMTCwKKyAgICAgICAg ICAgIE5VTEwsCisgICAgICAgICAgICBnX2NjbG9zdXJlX21hcnNoYWxfVk9JRF9fT0JKRUNULAor ICAgICAgICAgICAgR19UWVBFX05PTkUsIDEsCisgICAgICAgICAgICBXRUJLSVRfVFlQRV9XRUJf RlJBTUUpOworCisgICAgLyoqCiAgICAgICogV2ViS2l0V2ViVmlldzo6dGl0bGUtY2hhbmdlZDoK ICAgICAgKiBAd2ViX3ZpZXc6IHRoZSBvYmplY3Qgb24gd2hpY2ggdGhlIHNpZ25hbCBpcyBlbWl0 dGVkCiAgICAgICogQGZyYW1lOiB0aGUgbWFpbiBmcmFtZQogICAgICAqIEB0aXRsZTogdGhlIG5l dyB0aXRsZQogICAgICAqCiAgICAgICogV2hlbiBhICNXZWJLaXRXZWJGcmFtZSBjaGFuZ2VzIHRo ZSBkb2N1bWVudCB0aXRsZSB0aGlzIHNpZ25hbCBpcyBlbWl0dGVkLgogICAgICAqLwogICAgIHdl YmtpdF93ZWJfdmlld19zaWduYWxzW1RJVExFX0NIQU5HRURdID0gZ19zaWduYWxfbmV3KCJ0aXRs ZS1jaGFuZ2VkIiwK 25028 2008-11-10 14:47:28 -0800 2009-04-20 08:02:07 -0700 style update 20306.patch text/plain 4539 a.renevier ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRH dGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5j cHAKaW5kZXggOGNlYTU4Zi4uYjg0NDg5OSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKQEAgLTQ4MSwxNyArNDgxLDMwIEBAIHZv aWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkQ2FuY2VsQ2xpZW50UmVkaXJlY3QoKQog CiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaFdpbGxQZXJmb3JtQ2xpZW50UmVkaXJl Y3QoY29uc3QgS1VSTCYsIGRvdWJsZSwgZG91YmxlKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7 CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkQ2hhbmdlTG9jYXRpb25X aXRoaW5QYWdlKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIC8qIAorICAgICAqIFVw ZGF0ZSB0aGUgVVJJCisgICAgICovCisgICAgV2ViS2l0V2ViRnJhbWVQcml2YXRlKiBmcmFtZURh dGEgPSBXRUJLSVRfV0VCX0ZSQU1FX0dFVF9QUklWQVRFKG1fZnJhbWUpOworICAgIGdfZnJlZShm cmFtZURhdGEtPnVyaSk7CisgICAgZnJhbWVEYXRhLT51cmkgPSBnX3N0cmR1cChjb3JlKG1fZnJh bWUpLT5sb2FkZXIoKS0+dXJsKCkucHJldHR5VVJMKCkudXRmOCgpLmRhdGEoKSk7CisKKyAgICBn X3NpZ25hbF9lbWl0X2J5X25hbWUobV9mcmFtZSwgImxvY2F0aW9uLWNoYW5nZWQtd2l0aGluLXBh Z2UiKTsKKworICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBnZXRWaWV3RnJvbUZyYW1lKG1f ZnJhbWUpOworICAgIGlmIChtX2ZyYW1lICE9IHdlYmtpdF93ZWJfdmlld19nZXRfbWFpbl9mcmFt ZSh3ZWJWaWV3KSkKKyAgICAgICAgcmV0dXJuOworCisgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1l KHdlYlZpZXcsICJsb2NhdGlvbi1jaGFuZ2VkLXdpdGhpbi1wYWdlIiwgbV9mcmFtZSk7CiB9CiAK IHZvaWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoV2lsbENsb3NlKCkKIHsKICAgICBub3RJ bXBsZW1lbnRlZCgpOwogfQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZFJl Y2VpdmVJY29uKCkKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1l LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcAppbmRleCA2YTRjNGQ1 Li5hZTQwMmRjIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5j cHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwCkBAIC01MCwxNiAr NTAsMTcgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiB1c2luZyBuYW1lc3BhY2Ugc3RkOwog CiBleHRlcm4gIkMiIHsKIAogZW51bSB7CiAgICAgQ0xFQVJFRCwKICAgICBMT0FEX0NPTU1JVFRF RCwKICAgICBMT0FEX0RPTkUsCisgICAgTE9DQVRJT05fQ0hBTkdFRF9XSVRISU5fUEFHRSwKICAg ICBUSVRMRV9DSEFOR0VELAogICAgIEhPVkVSSU5HX09WRVJfTElOSywKICAgICBMQVNUX1NJR05B TAogfTsKIAogZW51bSB7CiAgICAgUFJPUF8wLAogCkBAIC0xMzcsMTYgKzEzOCwyNSBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRfd2ViX2ZyYW1lX2NsYXNzX2luaXQoV2ViS2l0V2ViRnJhbWVDbGFzcyog ZnJhbWVDbGFzcykKICAgICAgICAgICAgIChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNU IHwgR19TSUdOQUxfQUNUSU9OKSwKICAgICAgICAgICAgIDAsCiAgICAgICAgICAgICBOVUxMLAog ICAgICAgICAgICAgTlVMTCwKICAgICAgICAgICAgIGdfY2Nsb3N1cmVfbWFyc2hhbF9WT0lEX19C T09MRUFOLAogICAgICAgICAgICAgR19UWVBFX05PTkUsIDEsCiAgICAgICAgICAgICBHX1RZUEVf Qk9PTEVBTik7CiAKKyAgICB3ZWJraXRfd2ViX2ZyYW1lX3NpZ25hbHNbTE9DQVRJT05fQ0hBTkdF RF9XSVRISU5fUEFHRV0gPSBnX3NpZ25hbF9uZXcoImxvY2F0aW9uLWNoYW5nZWQtd2l0aGluLXBh Z2UiLAorICAgICAgICAgICAgR19UWVBFX0ZST01fQ0xBU1MoZnJhbWVDbGFzcyksCisgICAgICAg ICAgICAoR1NpZ25hbEZsYWdzKShHX1NJR05BTF9SVU5fTEFTVCB8IEdfU0lHTkFMX0FDVElPTiks CisgICAgICAgICAgICAwLAorICAgICAgICAgICAgTlVMTCwKKyAgICAgICAgICAgIE5VTEwsCisg ICAgICAgICAgICBnX2NjbG9zdXJlX21hcnNoYWxfVk9JRF9fVk9JRCwKKyAgICAgICAgICAgIEdf VFlQRV9OT05FLCAwKTsKKwogICAgIHdlYmtpdF93ZWJfZnJhbWVfc2lnbmFsc1tUSVRMRV9DSEFO R0VEXSA9IGdfc2lnbmFsX25ldygidGl0bGUtY2hhbmdlZCIsCiAgICAgICAgICAgICBHX1RZUEVf RlJPTV9DTEFTUyhmcmFtZUNsYXNzKSwKICAgICAgICAgICAgIChHU2lnbmFsRmxhZ3MpKEdfU0lH TkFMX1JVTl9MQVNUIHwgR19TSUdOQUxfQUNUSU9OKSwKICAgICAgICAgICAgIDAsCiAgICAgICAg ICAgICBOVUxMLAogICAgICAgICAgICAgTlVMTCwKICAgICAgICAgICAgIHdlYmtpdF9tYXJzaGFs X1ZPSURfX1NUUklORywKICAgICAgICAgICAgIEdfVFlQRV9OT05FLCAxLApkaWZmIC0tZ2l0IGEv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAyYzkwYjRlLi5iMjY5Y2I5IDEwMDY0NAotLS0gYS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJ2aWV3LmNwcApAQCAtNzMsMTYgKzczLDE3IEBAIGV4dGVybiAiQyIgewogZW51bSB7 CiAgICAgLyogbm9ybWFsIHNpZ25hbHMgKi8KICAgICBOQVZJR0FUSU9OX1JFUVVFU1RFRCwKICAg ICBXSU5ET1dfT0JKRUNUX0NMRUFSRUQsCiAgICAgTE9BRF9TVEFSVEVELAogICAgIExPQURfQ09N TUlUVEVELAogICAgIExPQURfUFJPR1JFU1NfQ0hBTkdFRCwKICAgICBMT0FEX0ZJTklTSEVELAor ICAgIExPQ0FUSU9OX0NIQU5HRURfV0lUSElOX1BBR0UsCiAgICAgVElUTEVfQ0hBTkdFRCwKICAg ICBIT1ZFUklOR19PVkVSX0xJTkssCiAgICAgUE9QVUxBVEVfUE9QVVAsCiAgICAgU1RBVFVTX0JB Ul9URVhUX0NIQU5HRUQsCiAgICAgSUNPTkRfTE9BREVELAogICAgIFNFTEVDVElPTl9DSEFOR0VE LAogICAgIENPTlNPTEVfTUVTU0FHRSwKICAgICBTQ1JJUFRfQUxFUlQsCkBAIC05MTQsMTYgKzkx NSwzMyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJW aWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAgICAgICAgIDAsCiAgICAgICAgICAgICBOVUxM LAogICAgICAgICAgICAgTlVMTCwKICAgICAgICAgICAgIGdfY2Nsb3N1cmVfbWFyc2hhbF9WT0lE X19PQkpFQ1QsCiAgICAgICAgICAgICBHX1RZUEVfTk9ORSwgMSwKICAgICAgICAgICAgIFdFQktJ VF9UWVBFX1dFQl9GUkFNRSk7CiAKICAgICAvKioKKyAgICAgKiBXZWJLaXRXZWJWaWV3Ojpsb2Nh dGlvbi1jaGFuZ2VkLXdpdGhpbi1wYWdlOgorICAgICAqIEB3ZWJfdmlldzogdGhlIG9iamVjdCBv biB3aGljaCB0aGUgc2lnbmFsIGlzIGVtaXR0ZWQKKyAgICAgKiBAZnJhbWU6IHRoZSBmcmFtZSB3 aG9zZSB1cmkgaGFzIGNoYW5nZWQKKyAgICAgKgorICAgICAqIFdoZW4gI1dlYktpdFdlYkZyYW1l IHVyaSBjaGFuZ2VzIHdpdGhpbiB0aGUgc2FtZSBkb2N1bWVudAorICAgICAqLworICAgIHdlYmtp dF93ZWJfdmlld19zaWduYWxzW0xPQ0FUSU9OX0NIQU5HRURfV0lUSElOX1BBR0VdID0gZ19zaWdu YWxfbmV3KCJsb2NhdGlvbi1jaGFuZ2VkLXdpdGhpbi1wYWdlIiwKKyAgICAgICAgICAgIEdfVFlQ RV9GUk9NX0NMQVNTKHdlYlZpZXdDbGFzcyksCisgICAgICAgICAgICAoR1NpZ25hbEZsYWdzKShH X1NJR05BTF9SVU5fTEFTVCB8IEdfU0lHTkFMX0FDVElPTiksCisgICAgICAgICAgICAwLAorICAg ICAgICAgICAgTlVMTCwKKyAgICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICBnX2NjbG9zdXJl X21hcnNoYWxfVk9JRF9fT0JKRUNULAorICAgICAgICAgICAgR19UWVBFX05PTkUsIDEsCisgICAg ICAgICAgICBXRUJLSVRfVFlQRV9XRUJfRlJBTUUpOworCisgICAgLyoqCiAgICAgICogV2ViS2l0 V2ViVmlldzo6dGl0bGUtY2hhbmdlZDoKICAgICAgKiBAd2ViX3ZpZXc6IHRoZSBvYmplY3Qgb24g d2hpY2ggdGhlIHNpZ25hbCBpcyBlbWl0dGVkCiAgICAgICogQGZyYW1lOiB0aGUgbWFpbiBmcmFt ZQogICAgICAqIEB0aXRsZTogdGhlIG5ldyB0aXRsZQogICAgICAqCiAgICAgICogV2hlbiBhICNX ZWJLaXRXZWJGcmFtZSBjaGFuZ2VzIHRoZSBkb2N1bWVudCB0aXRsZSB0aGlzIHNpZ25hbCBpcyBl bWl0dGVkLgogICAgICAqLwogICAgIHdlYmtpdF93ZWJfdmlld19zaWduYWxzW1RJVExFX0NIQU5H RURdID0gZ19zaWduYWxfbmV3KCJ0aXRsZS1jaGFuZ2VkIiwK