203056 2019-10-16 14:51:21 -0700 Simulator testers are filling up 2019-10-30 12:43:44 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn jbedard repstein webkit-bug-importer oldest_to_newest 1580699 0 jbedard 2019-10-16 14:51:21 -0700 Some of our simulator testers are filling up their hardrives alarmingly quickly, probably due to our habit of recreating simulators constantly. We should do some cleanup every time we tear down automatically created simulators. 1580704 1 jbedard 2019-10-16 14:51:50 -0700 <rdar://problem/56344905> 1580712 2 381119 jbedard 2019-10-16 15:04:19 -0700 Created attachment 381119 Patch 1585445 3 381119 aakash_jain 2019-10-30 11:40:59 -0700 Comment on attachment 381119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381119&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:483 > + for directory in host.filesystem.glob('/tmp/com.apple.CoreSimulator.SimDevice.*'): will this work fine for windows? 1585446 4 381119 jbedard 2019-10-30 11:44:43 -0700 Comment on attachment 381119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381119&action=review >> Tools/Scripts/webkitpy/xcode/simulated_device.py:483 >> + for directory in host.filesystem.glob('/tmp/com.apple.CoreSimulator.SimDevice.*'): > > will this work fine for windows? No, but you can't initialize simulators if you aren't on a Mac, and if we don't have initialized simulators, we early return on line 470. 1585461 5 381119 commit-queue 2019-10-30 12:43:42 -0700 Comment on attachment 381119 Patch Clearing flags on attachment: 381119 Committed r251793: <https://trac.webkit.org/changeset/251793> 1585462 6 commit-queue 2019-10-30 12:43:44 -0700 All reviewed patches have been landed. Closing bug. 381119 2019-10-16 15:04:19 -0700 2019-10-30 12:43:42 -0700 Patch bug-203056-20191016150419.patch text/plain 1761 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTIwNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTEwLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBTaW11bGF0b3IgdGVzdGVycyBhcmUgZmlsbGluZyB1cAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAzMDU2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81NjM0NDkwNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2Rldmlj ZS5weToKKyAgICAgICAgKFNpbXVsYXRlZERldmljZU1hbmFnZXIudGVhcl9kb3duKTogUmVtb3Zl IHNvbWUgQ29yZVNpbXVsYXRvciB0ZW1wb3JhcnkgZGlyZWN0b3JpZXMKKyAgICAgICAgYWZ0ZXIg dGVhcmluZyBkb3duIGRldmljZXMuCisKIDIwMTktMTAtMTYgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgRHVtcFJlbmRlclRyZWUgc2hvdWxkIGNs ZWFyIFdURkxvZ0NoYW5uZWxTdGF0ZTo6T25XaXRoQWNjdW11bGF0aW9uIHN0YXRlIHNldCBieSB0 ZXN0UnVubmVyLmFjY3VtbXVsYXRlTG9nc0ZvckNoYW5uZWwKSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHJldmlzaW9uIDI1MTE2 NSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQko d29ya2luZyBjb3B5KQpAQCAtNDc5LDYgKzQ3OSwxMyBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VN YW5hZ2VyKG9iamVjdCk6CiAKICAgICAgICAgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5JTklUSUFM SVpFRF9ERVZJQ0VTID0gTm9uZQogCisgICAgICAgICMgSWYgd2Ugd2VyZSBtYW5hZ2luZyB0aGUg c2ltdWxhdG9yLCB0aGVyZSBhcmUgc29tZSBjYWNoZSBmaWxlcyB3ZSBuZWVkIHRvIHJlbW92ZQor ICAgICAgICBmb3IgZGlyZWN0b3J5IGluIGhvc3QuZmlsZXN5c3RlbS5nbG9iKCcvdG1wL2NvbS5h cHBsZS5Db3JlU2ltdWxhdG9yLlNpbURldmljZS4qJyk6CisgICAgICAgICAgICBob3N0LmZpbGVz eXN0ZW0ucm10cmVlKGRpcmVjdG9yeSkKKyAgICAgICAgY29yZV9zaW11bGF0b3JfZGlyZWN0b3J5 ID0gaG9zdC5maWxlc3lzdGVtLmV4cGFuZHVzZXIoaG9zdC5maWxlc3lzdGVtLmpvaW4oJ34nLCAn TGlicmFyeScsICdEZXZlbG9wZXInLCAnQ29yZVNpbXVsYXRvcicpKQorICAgICAgICBob3N0LmZp bGVzeXN0ZW0ucm10cmVlKGhvc3QuZmlsZXN5c3RlbS5qb2luKGNvcmVfc2ltdWxhdG9yX2RpcmVj dG9yeSwgJ0NhY2hlcycpKQorICAgICAgICBob3N0LmZpbGVzeXN0ZW0ucm10cmVlKGhvc3QuZmls ZXN5c3RlbS5qb2luKGNvcmVfc2ltdWxhdG9yX2RpcmVjdG9yeSwgJ1RlbXAnKSkKKwogCiBjbGFz cyBTaW11bGF0ZWREZXZpY2Uob2JqZWN0KToKICAgICBjbGFzcyBEZXZpY2VTdGF0ZToK