203049 2019-10-16 12:14:06 -0700 fast/events/ios/forward-delete-in-editable.html is a flaky failure 2019-10-18 15:24:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad iOS 13 RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates webkit-bug-importer wenson_hsieh oldest_to_newest 1580619 0 dbates 2019-10-16 12:14:06 -0700 Sometimes fast/events/ios/forward-delete-in-editable.html fails. I suspect this is because it was written using a workaround for <rdar://problem/45772078>, which meant it waited until a blur event to check the test result. The assumption behind the workaround was that the keyboard code would call back to ask WebKit to perform the forward delete BEFORE the WebKit would blur() the field. There is no such guarantee. Instead we should do what we couldn't do at the time of writing this test and check that we receive a DOM key up event before checking the result. 1580620 1 dbates 2019-10-16 12:14:12 -0700 <rdar://problem/52969457> 1580625 2 381096 dbates 2019-10-16 12:23:29 -0700 Created attachment 381096 Patch 1581559 3 dbates 2019-10-18 15:22:52 -0700 Thanks Wenson! 1581560 4 381096 dbates 2019-10-18 15:24:01 -0700 Comment on attachment 381096 Patch Clearing flags on attachment: 381096 Committed r251301: <https://trac.webkit.org/changeset/251301> 1581561 5 dbates 2019-10-18 15:24:02 -0700 All reviewed patches have been landed. Closing bug. 381096 2019-10-16 12:23:29 -0700 2019-10-18 15:24:01 -0700 Patch bug-203049-20191016122332.patch text/plain 2531 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzVlMmY1MTQwOTVmNTE4NmFlMGRh YjQxMjAyYjZkY2FhODgzMjFmZi4uMjk2OGM1NjlmZDFlMGFhYzViMGY4OGRlN2Y5OTE2Y2QzMzYx YjYwYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTEwLTE2ICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBmYXN0L2V2ZW50cy9pb3MvZm9yd2FyZC1kZWxl dGUtaW4tZWRpdGFibGUuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMzA0OQorICAgICAgICA8cmRhcjovL3By b2JsZW0vNTI5Njk0NTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm93IHRoYXQgPHJkYXI6Ly9wcm9ibGVtLzQ1NzcyMDc4PiBpcyBmaXhlZCB3ZSBj YW4gd3JpdGUgdGhlIHRlc3Qgc3VjaCB0aGF0IHdlIGNoZWNrIHRoZSB0ZXN0CisgICAgICAgIHJl c3VsdCBhZnRlciB3ZSByZWNlaXZlIGEgRE9NIGtleSB1cCBmb3IgdGhlIGZvcndhcmQgZGVsZXRl LiBDdXJyZW50bHkgdGhlIHRlc3QgbWFrZXMgdXNlIG9mIGEKKyAgICAgICAgd29ya2Fyb3VuZCB0 aGF0IGluY29ycmVjdGx5IGFzc3VtZXMgdGhhdCB0aGUga2V5Ym9hcmQgd2lsbCBjYWxsIGJhY2sg aW50byBXZWJLaXQgdG8gcGVyZm9ybSB0aGUKKyAgICAgICAgZm9yd2FyZCBkZWxldGlvbiBiZWZv cmUgdGhlIHdlYiBwcm9jZXNzIGJsdXIoKXMgdGhlIGZpZWxkLiBUaGlzIGlzIG5vdCBndWFyYW50 ZWVkIHRvIGhhcHBlbi4KKyAgICAgICAgSW5zdGVhZCB3YWl0IHVudGlsIHdlIHJlY2VpdmUgYSBE T00ga2V5IHVwIGZvciB0aGUgZGVsZXRlIGtleS4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL2lv cy9mb3J3YXJkLWRlbGV0ZS1pbi1lZGl0YWJsZS5odG1sOgorCiAyMDE5LTEwLTE1ICBEYW5pZWwg QmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjQxNzQ3 KTogW2lPU10gQWRqdXN0IGRlZmF1bHQgU1ZHIGZvY3VzIHJpbmcgd2lkdGggdG8gbWF0Y2ggd2lk dGggZm9yIEhUTUwgZG9jdW1lbnRzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9pb3MvZm9yd2FyZC1kZWxldGUtaW4tZWRpdGFibGUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2lvcy9mb3J3YXJkLWRlbGV0ZS1pbi1lZGl0YWJsZS5odG1sCmluZGV4IGE5M2I5Yjcw YWFmNTVlZDE0NDMzODlkY2E3MTcxZjU4NDVlMGZkYmIuLjI5YzljMTM4NDRjNzIxYzIxM2ZlNGU5 ZGVlZDljYjRiZTc2YWJmZGQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lv cy9mb3J3YXJkLWRlbGV0ZS1pbi1lZGl0YWJsZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2lvcy9mb3J3YXJkLWRlbGV0ZS1pbi1lZGl0YWJsZS5odG1sCkBAIC0yNCwxNyArMjQs MTUgQEAgYXN5bmMgZnVuY3Rpb24gcnVuVGVzdCgpCiAgICAgICAgIGlucHV0RWxlbWVudC5zZXRT ZWxlY3Rpb25SYW5nZSgwLCAwKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSAgICAvLyBGSVhN RTogV2UgY2Fubm90IGxpc3RlbiBmb3IgYSBrZXl1cCBldmVudCBiZWNhdXNlIHRoZSBmb3J3YXJk IGRlbGV0ZSBrZXkgZG9lcyBub3QgZ2VuZXJhdGUgb25lCi0gICAgLy8gZHVlIHRvIDxyZGFyOi8v cHJvYmxlbS80NTc3MjA3OD4uIFNvLCB3ZSBsaXN0ZW4gZm9yIGEgYmx1ciBldmVudC4KLSAgICBp bnB1dEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiYmx1ciIsIGNoZWNrUmVzdWx0QW5kTm90aWZ5 RG9uZSwge29uY2U6IHRydWV9KTsKKyAgICBpbnB1dEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigi a2V5dXAiLCBjaGVja1Jlc3VsdEFuZE5vdGlmeURvbmUsIHtvbmNlOiB0cnVlfSk7CiAgICAgYXdh aXQgVUlIZWxwZXIuYWN0aXZhdGVGb3JtQ29udHJvbChpbnB1dEVsZW1lbnQpOwogICAgIGlucHV0 RWxlbWVudC5zZXRTZWxlY3Rpb25SYW5nZSgwLCAwKTsKICAgICBhd2FpdCBVSUhlbHBlci50eXBl Q2hhcmFjdGVyKCJmb3J3YXJkRGVsZXRlIik7Ci0gICAgaW5wdXRFbGVtZW50LmJsdXIoKTsKIH0K IAotZnVuY3Rpb24gY2hlY2tSZXN1bHRBbmROb3RpZnlEb25lKCkKK2Z1bmN0aW9uIGNoZWNrUmVz dWx0QW5kTm90aWZ5RG9uZShrZXlFdmVudCkKIHsKKyAgICBjb25zb2xlLmFzc2VydChrZXlFdmVu dC5rZXkgPT09ICJEZWxldGUiKTsKICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2RvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJpbnB1dCIpLnZhbHVlJywgImV4dCIpOwogICAgIGRvY3VtZW50LmJv ZHkucmVtb3ZlQ2hpbGQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QtY29udGFpbmVyIikp OwogICAgIGZpbmlzaEpTVGVzdCgpOwo=