203043 2019-10-16 10:46:25 -0700 Non-cocoa platforms don't pass networkCacheDirectory from WebsiteDataStore::parameters() 2019-11-14 10:23:17 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 emilio emilio achristensen alex cgarcia commit-queue pnormand webkit-bug-importer zimmermann oldest_to_newest 1580579 0 emilio 2019-10-16 10:46:25 -0700 Which causes the test runner and minibrowser error non-fatally with various messages like: ERROR: Failed to initialize the WebKit network disk cache 1580580 1 381085 emilio 2019-10-16 10:50:45 -0700 Created attachment 381085 Patch 1580581 2 emilio 2019-10-16 10:52:21 -0700 Probably need to do a bit of archeology, but this should be enough for EWS. 1580818 3 achristensen 2019-10-16 18:59:07 -0700 We should probably unite the WebsiteDataStore::parameters functions. 1580826 4 381085 commit-queue 2019-10-16 19:42:36 -0700 Comment on attachment 381085 Patch Clearing flags on attachment: 381085 Committed r251222: <https://trac.webkit.org/changeset/251222> 1580827 5 commit-queue 2019-10-16 19:42:37 -0700 All reviewed patches have been landed. Closing bug. 1580828 6 webkit-bug-importer 2019-10-16 19:43:15 -0700 <rdar://problem/56356248> 1590233 7 pnormand 2019-11-14 05:22:45 -0800 I suspect this might have caused bug #203460. Setting parameters.networkSessionParameters.networkCacheDirectory is not enough, I think you need to ensure the directory exists, like done for localStorageDirectory. 1590265 8 pnormand 2019-11-14 10:23:17 -0800 (In reply to Philippe Normand from comment #7) > I suspect this might have caused bug #203460. It's not the cause of that bug, but > Setting > parameters.networkSessionParameters.networkCacheDirectory is not enough, I > think you need to ensure the directory exists, like done for > localStorageDirectory. It would be good to have this suggested change as a follow-up :) 381085 2019-10-16 10:50:45 -0700 2019-10-16 19:42:36 -0700 Patch bug-203043-20191016195043.patch text/plain 1563 emilio U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU4NTkyY2U5ZWZjZTdmYWM2 MmFhNWUwZmYwYWM2NzkwMDEzOTZjZWIuLmMxZjJjNDVjNTAxMThmNmE2NTMyYzAzZDZhMDNlMThk YjU1ZDA5ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMTAtMTYgIEVtaWxpbyBD b2JvcyDDgWx2YXJleiAgPGVtaWxpb0BjcmlzYWwuaW8+CisKKyAgICAgICAgUGFzcyBuZXR3b3Jr IGNhY2hlIGRpcmVjdG9yeSBpbiBXZWJzaXRlRGF0YVN0b3JlOjpwYXJhbWV0ZXJzKCkgZm9yIG5v bi1Db2NvYSBwbGF0Zm9ybXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDMwNDMKKworICAgICAgICBUaGlzIHdhcyBjYXVzaW5nIHZhcmlvdXMgZXJy b3JzIGluIHRoZSBuZXR3b3JrIHByb2Nlc3MgdGhhdCB3ZXJlCisgICAgICAgIHZpc2libGUgaW4g ZGVidWcgYnVpbGRzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpwYXJhbWV0ZXJzKToKKwogMjAxOS0xMC0x MCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gQWxs b3cgU1lTX19fcHRocmVhZF9tYXJrY2FuY2VsIGNhbGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKaW5kZXggMjYx OTAxNmIyNGM5ZThmN2E1ODQ3YTlkYmI2ZjBmNmM1OWYwOWFkZS4uY2FkYTg3ZTkyMDI3N2RmOThj NWEyZWU0YWU0NTkxZjg1YWQ3YmJkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKQEAgLTIwNjIsNiArMjA2 Miw3IEBAIFdlYnNpdGVEYXRhU3RvcmVQYXJhbWV0ZXJzIFdlYnNpdGVEYXRhU3RvcmU6OnBhcmFt ZXRlcnMoKQogCiAgICAgcGFyYW1ldGVycy5wZXJPcmlnaW5TdG9yYWdlUXVvdGEgPSBwZXJPcmln aW5TdG9yYWdlUXVvdGEoKTsKICAgICBwYXJhbWV0ZXJzLnBlclRoaXJkUGFydHlPcmlnaW5TdG9y YWdlUXVvdGEgPSBwZXJUaGlyZFBhcnR5T3JpZ2luU3RvcmFnZVF1b3RhKCk7CisgICAgcGFyYW1l dGVycy5uZXR3b3JrU2Vzc2lvblBhcmFtZXRlcnMubmV0d29ya0NhY2hlRGlyZWN0b3J5ID0gcmVz b2x2ZWROZXR3b3JrQ2FjaGVEaXJlY3RvcnkoKTsKIAogICAgIHBsYXRmb3JtU2V0TmV0d29ya1Bh cmFtZXRlcnMocGFyYW1ldGVycyk7CiAK