203040 2019-10-16 09:59:39 -0700 Disable pichdr generation on MIPS for return location labels 2019-10-24 01:37:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 203290 1 pmatos pmatos commit-queue ews-watchlist guijemont keith_miller mark.lam msaboff saam ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1580558 0 pmatos 2019-10-16 09:59:39 -0700 Disable pichdr generation on MIPS for return location labels 1580559 1 381079 pmatos 2019-10-16 10:02:42 -0700 Created attachment 381079 Patch 1580872 2 381079 ticaiolima 2019-10-16 22:38:41 -0700 Comment on attachment 381079 Patch LGTM if bots are green. It seems that MIPS EWS is down. 1582313 3 381079 guijemont 2019-10-22 02:25:57 -0700 Comment on attachment 381079 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381079&action=review > Source/JavaScriptCore/offlineasm/mips.rb:686 > + # Only generate a pichdr if the label is not a return location - a cpload > + # (generated by pichdr) after this type of label would cause the a gp register > + # corruption. This regular expression needs to stay in sync with the labels > + # generated in macro defineOSRExitReturnLabel defined llint/LowLevelInterpreter.asm As far as I understand, the issue is when regular (non-OSR) execution gets through the OSR return label, but the cpload only sets gp correctly if t9 contains the address of the start of cpload, which is the case when we call into it (with "jr t9"), but not when we just execute through the label. I think a note explaining the above should be included in this comment to clarify the reasons for this check. 1583255 4 381782 pmatos 2019-10-24 00:14:46 -0700 Created attachment 381782 Patch 1583269 5 381782 commit-queue 2019-10-24 01:36:07 -0700 Comment on attachment 381782 Patch Clearing flags on attachment: 381782 Committed r251533: <https://trac.webkit.org/changeset/251533> 1583270 6 commit-queue 2019-10-24 01:36:09 -0700 All reviewed patches have been landed. Closing bug. 1583271 7 webkit-bug-importer 2019-10-24 01:37:34 -0700 <rdar://problem/56571914> 381079 2019-10-16 10:02:42 -0700 2019-10-24 00:14:42 -0700 Patch bug-203040-20191016190241.patch text/plain 1893 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi Nzg0ZTUyOTgxNzYzYTdhOGJlMDQ2MWI2YmYxMThlYTliNjQ5YmJmLi5iOGVmYTNlMGI1OGNmNWY2 NjhjMDM0YTY2ZWVlYjE4MzVlOGRkZDk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0xMC0xNiAgUGF1bG8gTWF0b3MgIDxwbWF0b3NAaWdhbGlhLmNvbT4K KworICAgICAgICBEaXNhYmxlIHBpY2hkciBnZW5lcmF0aW9uIG9uIE1JUFMgZm9yIHJldHVybiBs b2NhdGlvbiBsYWJlbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMzA0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERpc2FibGUgZ2VuZXJhdGlvbiBvZiBwaWNoZHIgZm9yIHJldHVybiBsb2NhdGlvbiBs YWJlbHMgZ2VuZXJhdGVkIGluIAorICAgICAgICBkZWZpbmVPU1JFeGl0UmV0dXJuTGFiZWwuIFNp bmNlIHIyNTA4MDYgKEFsbG93IE9TUiBleGl0IHRvIHRoZSBMTEludCksCisgICAgICAgIE1JUFMg d2FzIHNlZ2ZhdWx0aW5nIHNpbmNlIHRoZSBwaWNoZHIgYWZ0ZXIgYW4gT1NSIGV4aXQgd2FzIGNv cnJ1cHRpb24gCisgICAgICAgIHRoZSBncCByZWdpc3Rlci4KKworICAgICAgICAqIG9mZmxpbmVh c20vbWlwcy5yYjoKKwogMjAxOS0xMC0xNiAgUGF1bG8gTWF0b3MgIDxwbWF0b3NAbGlua2kudG9v bHM+CiAKICAgICAgICAgRml4IEdDQyB3YXJuaW5nIG9uIE1JUFMgYWJvdXQgZGVhZCB2YXJpYWJs ZSBtZXRhZGF0YQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v bWlwcy5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKaW5kZXgg ZTQ0NjQ3Y2QzYjI3NTFhY2ZhMmM1MTU0ZjIwYTFmMzM3YjRlMDg1Zi4uYWMyNDVlZThjMDE4Njc3 YzEwYjZmNTE2ZTgxZTMyYjlkYjUyYWNkZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL29mZmxpbmVhc20vbWlwcy5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGlu ZWFzbS9taXBzLnJiCkBAIC02NzksNyArNjc5LDExIEBAIGRlZiBtaXBzQWRkUElDQ29kZShsaXN0 KQogICAgIGxpc3QuZWFjaCB7CiAgICAgICAgIHwgbm9kZSB8CiAgICAgICAgIG15TGlzdCA8PCBu b2RlCi0gICAgICAgIGlmIG5vZGUuaXNfYT8gTGFiZWwKKyAgICAgICAgaWYgbm9kZS5pc19hPyBM YWJlbCBhbmQgbm9kZS5uYW1lICF+IC9eLipfcmV0dXJuX2xvY2F0aW9uKD86Xyg/OndpZGUxNnx3 aWRlMzIpKT8kLworICAgICAgICAgICAgIyBPbmx5IGdlbmVyYXRlIGEgcGljaGRyIGlmIHRoZSBs YWJlbCBpcyBub3QgYSByZXR1cm4gbG9jYXRpb24gLSBhIGNwbG9hZCAKKyAgICAgICAgICAgICMg KGdlbmVyYXRlZCBieSBwaWNoZHIpIGFmdGVyIHRoaXMgdHlwZSBvZiBsYWJlbCB3b3VsZCBjYXVz ZSB0aGUgYSBncCByZWdpc3RlcgorICAgICAgICAgICAgIyBjb3JydXB0aW9uLiBUaGlzIHJlZ3Vs YXIgZXhwcmVzc2lvbiBuZWVkcyB0byBzdGF5IGluIHN5bmMgd2l0aCB0aGUgbGFiZWxzCisgICAg ICAgICAgICAjIGdlbmVyYXRlZCBpbiBtYWNybyBkZWZpbmVPU1JFeGl0UmV0dXJuTGFiZWwgZGVm aW5lZCBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSAKICAgICAgICAgICAgIG15TGlzdCA8 PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLCAicGljaGRyIiwgW10pCiAgICAgICAg IGVuZAogICAgIH0K 381782 2019-10-24 00:14:46 -0700 2019-10-24 01:36:07 -0700 Patch bug-203040-20191024091425.patch text/plain 2068 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj Yzg0NTllNzc1NzJiMjk3MjVjY2YxODM5OGUzODk2MDk1MmUyNjhiLi4yMTQyZDg0ZjdiNjcxNGJk Njg4Y2Q0ODYxMDQxNWVkM2YxZmMwZTBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0xMC0yMyAgUGF1bG8gTWF0b3MgIDxwbWF0b3NAaWdhbGlhLmNvbT4K KworICAgICAgICBEaXNhYmxlIHBpY2hkciBnZW5lcmF0aW9uIG9uIE1JUFMgZm9yIHJldHVybiBs b2NhdGlvbiBsYWJlbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMzA0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERpc2FibGUgZ2VuZXJhdGlvbiBvZiBwaWNoZHIgZm9yIHJldHVybiBsb2NhdGlvbiBs YWJlbHMgZ2VuZXJhdGVkIGluCisgICAgICAgIGRlZmluZU9TUkV4aXRSZXR1cm5MYWJlbC4gU2lu Y2UgcjI1MDgwNiAoQWxsb3cgT1NSIGV4aXQgdG8gdGhlIExMSW50KSwKKyAgICAgICAgTUlQUyB3 YXMgc2VnZmF1bHRpbmcgc2luY2UgdGhlIHBpY2hkciBhZnRlciBhbiBPU1IgZXhpdCB3YXMgY29y cnVwdGlvbgorICAgICAgICB0aGUgZ3AgcmVnaXN0ZXIuCisKKyAgICAgICAgKiBvZmZsaW5lYXNt L21pcHMucmI6CisKIDIwMTktMTAtMjMgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KIAogICAgICAgICBbSlNDXSBSZW1vdmUgd2FzbUF3YXJlTGV4aWNhbEdsb2JhbE9iamVjdApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYiBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKaW5kZXggZTQ0NjQ3Y2QzYjI3 NTFhY2ZhMmM1MTU0ZjIwYTFmMzM3YjRlMDg1Zi4uOWVlZDI1NDk5ZWM4YWRmNWQ2MzBmNWNjNTNk ZTc1NmIwY2E0MTYzZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVh c20vbWlwcy5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJi CkBAIC02NzksNyArNjc5LDEzIEBAIGRlZiBtaXBzQWRkUElDQ29kZShsaXN0KQogICAgIGxpc3Qu ZWFjaCB7CiAgICAgICAgIHwgbm9kZSB8CiAgICAgICAgIG15TGlzdCA8PCBub2RlCi0gICAgICAg IGlmIG5vZGUuaXNfYT8gTGFiZWwKKyAgICAgICAgaWYgbm9kZS5pc19hPyBMYWJlbCBhbmQgbm9k ZS5uYW1lICF+IC9eLipfcmV0dXJuX2xvY2F0aW9uKD86Xyg/OndpZGUxNnx3aWRlMzIpKT8kLwor ICAgICAgICAgICAgIyBPbmx5IGdlbmVyYXRlIGEgcGljaGRyIGlmIHRoZSBsYWJlbCBpcyBub3Qg YSByZXR1cm4gbG9jYXRpb24gKE9TUiBFeGl0KSAtIGEgY3Bsb2FkIAorICAgICAgICAgICAgIyAo Z2VuZXJhdGVkIGJ5IHBpY2hkcikgYWZ0ZXIgdGhpcyB0eXBlIG9mIGxhYmVsIHdvdWxkIGNhdXNl IHRoZSBhIGdwIHJlZ2lzdGVyCisgICAgICAgICAgICAjIGNvcnJ1cHRpb24uIFRoZSBjcGxvYWQg b25seSBzZXRzIGdwIGNvcnJlY3RseSBpZiB0OSBjb250YWlucyB0aGUgYWRkcmVzcyBvZiB0aGUg c3RhcnQKKyAgICAgICAgICAgICMgb2YgY3Bsb2FkLCB3aGljaCBpcyBvbmx5IHRoZSBjYXNlIHdo ZW4gd2UgZG8gYSBganIgdDlgIChvbiBhIE9TUiBFeGl0KS4KKyAgICAgICAgICAgICMgVGhpcyBy ZWd1bGFyIGV4cHJlc3Npb24gbmVlZHMgdG8gc3RheSBpbiBzeW5jIHdpdGggdGhlIGxhYmVscwor ICAgICAgICAgICAgIyBnZW5lcmF0ZWQgaW4gbWFjcm8gZGVmaW5lT1NSRXhpdFJldHVybkxhYmVs IGRlZmluZWQgbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20gCiAgICAgICAgICAgICBteUxp c3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9yaWdpbiwgInBpY2hkciIsIFtdKQogICAg ICAgICBlbmQKICAgICB9Cg==