203027 2019-10-16 00:07:03 -0700 prepare-ChangeLog should whine about not having tests in WebKit-only patches 2019-10-23 00:32:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin megan_gardner mjs rniwa simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1580468 0 thorton 2019-10-16 00:07:03 -0700 prepare-ChangeLog should whine about not having tests in WebKit 1580469 1 381059 thorton 2019-10-16 00:08:26 -0700 Created attachment 381059 Patch 1580598 2 simon.fraser 2019-10-16 11:34:00 -0700 What does "in WebKit" mean in the title? 1580604 3 thorton 2019-10-16 11:40:41 -0700 (In reply to Simon Fraser (smfr) from comment #2) > What does "in WebKit" mean in the title? Source/WebKit. Right now if you make a WK2-only patch, you won't get shamed into having tests. Only if you touch WebCore. 1580606 4 thorton 2019-10-16 11:41:33 -0700 (In reply to Tim Horton from comment #3) > (In reply to Simon Fraser (smfr) from comment #2) > > What does "in WebKit" mean in the title? > > Source/WebKit. > > Right now if you make a WK2-only patch, you won't get shamed into having > tests. Only if you touch WebCore. I think I might flip the "higher of" to "deeper of" (so that if you make a WebCore and WebKit change, the message is in WebCore, not WebKit). I started the other way around, but thinking more I think that's wrong. 1580641 5 simon.fraser 2019-10-16 12:52:33 -0700 Better title would be "prepare-ChangeLog should not whine about not having tests for code changes that are WebKit-only" 1580643 6 thorton 2019-10-16 12:53:54 -0700 Well that would be backwards 1580644 7 thorton 2019-10-16 12:54:11 -0700 How's that 1582758 8 thorton 2019-10-23 00:31:48 -0700 I flipped it around so that if you have both a WebCore + WebKit change, it will only complain in WebCore instead of only in WebKit (which was what my original patch did). https://trac.webkit.org/changeset/251476/webkit 1582759 9 webkit-bug-importer 2019-10-23 00:32:16 -0700 <rdar://problem/56530897> 381059 2019-10-16 00:08:26 -0700 2019-10-16 01:06:58 -0700 Patch bug-203027-20191016000825.patch text/plain 2413 thorton SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MTE3OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE5LTEwLTE2ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu Y29tPgorCisgICAgICAgIHByZXBhcmUtQ2hhbmdlTG9nIHNob3VsZCB3aGluZSBhYm91dCBub3Qg aGF2aW5nIHRlc3RzIGluIFdlYktpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjAzMDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorICAgICAgICAoZ2Vu ZXJhdGVOZXdDaGFuZ2VMb2dzKToKKyAgICAgICAgUHV0IHRoZSAiTm8gbmV3IHRlc3RzIiBvciBs aXN0IG9mIG5ld2x5IGFkZGVkIHRlc3RzIGluIHRoZSBoaWdoZXIKKyAgICAgICAgb2YgdGhlIFdl YkNvcmUgb3IgV2ViS2l0IENoYW5nZUxvZ3MsIGRlcGVuZGluZyBvbiB3aGljaCBkaXJlY3Rvcmll cworICAgICAgICB0aGUgcGF0Y2ggdG91Y2hlcy4KKworICAgICAgICBUaGlzIGlzIG1vc3RseSBp bnRlbmRlZCB0byBlbmNvdXJhZ2UgdGVzdHMgZm9yIFdlYktpdC1vbmx5IGNoYW5nZXMuCisKIDIw MTktMTAtMTUgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAg IEltcHJvdmUgc3VtbWFyeSBmb3IgV2ViS2l0UGVybCBUZXN0cyBidWlsZCBzdGVwCkluZGV4OiBU b29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvcHJlcGFyZS1DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MTE3OSkKKysrIFRvb2xzL1NjcmlwdHMv cHJlcGFyZS1DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTY0Miw2ICs2NDIsMTMgQEAgc3Vi IGdlbmVyYXRlTmV3Q2hhbmdlTG9ncygkJCQkJCQkJCQkJCQkJAogewogICAgIG15ICgkcHJlZml4 ZXMsICRmaWxlc0luQ2hhbmdlTG9nLCAkYWRkZWRSZWdyZXNzaW9uVGVzdHMsICRyZXF1aXJlc1Rl c3RzLCAkZnVuY3Rpb25MaXN0cywgJGJ1Z1VSTCwgJGJ1Z0Rlc2NyaXB0aW9uLCAkYnVnUmFkYXJV UkwsICRuYW1lLCAkZW1haWxBZGRyZXNzLCAkZ2l0UmV2aWV3ZXIsICRnaXRDb21taXQsICR3cml0 ZUNoYW5nZUxvZ3MsICRkZWxpbWl0ZXJzKSA9IEBfOwogCisgICAgbXkgJGhhc1dlYktpdENoYW5n ZSA9IDA7CisgICAgZm9yZWFjaCBteSAkcHJlZml4IChAJHByZWZpeGVzKSB7CisgICAgICAgIGlm ICh1bml4UGF0aCgkcHJlZml4KSA9fiBtfC9XZWJLaXQvJHwpIHsKKyAgICAgICAgICAgICRoYXNX ZWJLaXRDaGFuZ2UgPSAxOworICAgICAgICB9CisgICAgfQorCiAgICAgIyBHZW5lcmF0ZSBuZXcg Q2hhbmdlTG9nIGVudHJpZXMgYW5kIChvcHRpb25hbGx5KSB3cml0ZSBvdXQgbmV3IENoYW5nZUxv ZyBmaWxlcy4KICAgICBmb3JlYWNoIG15ICRwcmVmaXggKEAkcHJlZml4ZXMpIHsKICAgICAgICAg bXkgJGVuZGwgPSAiXG4iOwpAQCAtNjg4LDcgKzY5NSwxMSBAQCBzdWIgZ2VuZXJhdGVOZXdDaGFu Z2VMb2dzKCQkJCQkJCQkJCQkJCQkCiAgICAgICAgIHByaW50IENIQU5HRV9MT0cgbm9ybWFsaXpl TGluZUVuZGluZ3MoIiAgICAgICAgUmV2aWV3ZWQgYnkgJHJldmlld2VyLlxuXG4iLCAkZW5kbCk7 CiAgICAgICAgIHByaW50IENIQU5HRV9MT0cgbm9ybWFsaXplTGluZUVuZGluZ3MoJGRlc2NyaXB0 aW9uIC4gIlxuIiwgJGVuZGwpIGlmICRkZXNjcmlwdGlvbjsKIAotICAgICAgICBpZiAodW5peFBh dGgoJHByZWZpeCkgPX4gbXwvV2ViQ29yZS8kfCB8fCBAJHJlcXVpcmVzVGVzdHMpIHsKKyAgICAg ICAgbXkgJHNob3VsZE1lbnRpb25UZXN0cyA9IEAkcmVxdWlyZXNUZXN0czsKKyAgICAgICAgJHNo b3VsZE1lbnRpb25UZXN0cyB8PSB1bml4UGF0aCgkcHJlZml4KSA9fiBtfC9XZWJLaXQvJHw7Cisg ICAgICAgICRzaG91bGRNZW50aW9uVGVzdHMgfD0gISRoYXNXZWJLaXRDaGFuZ2UgJiYgdW5peFBh dGgoJHByZWZpeCkgPX4gbXwvV2ViQ29yZS8kfDsKKworICAgICAgICBpZiAoJHNob3VsZE1lbnRp b25UZXN0cykgewogICAgICAgICAgICAgaWYgKEAkYWRkZWRSZWdyZXNzaW9uVGVzdHMpIHsKICAg ICAgICAgICAgICAgICBwcmludCBDSEFOR0VfTE9HIG5vcm1hbGl6ZUxpbmVFbmRpbmdzKHRlc3RM aXN0Rm9yQ2hhbmdlTG9nKHNvcnQgQCRhZGRlZFJlZ3Jlc3Npb25UZXN0cyksICRlbmRsKTsKICAg ICAgICAgICAgIH0gZWxzZSB7Cg==